summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2017-01-13coverity#1371287 don't need to copy and then overwriteCaolán McNamara
Change-Id: Ica30e4bed463e8e42cbf54f4b81491149a8de8ab
2017-01-13new loplugin: useuniqueptr: editengNoel Grandin
Change-Id: I6df65eab882780d996ee996b5fef8020186b6d98 Reviewed-on: https://gerrit.libreoffice.org/32958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-09New loplugin:externvar: editengStephan Bergmann
Change-Id: I1668a58f478c63b981c57e68795413f2aab87967
2017-01-09tdf#101828 handle rtf/richtext correctlyOliver Specht
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-05editeng: convert more DBG_ASSERT to assertMichael Stahl
Change-Id: I55aa17c9c900f927735d530550d5a660b6c2148a
2017-01-05editeng: convert some DBG_ASSERT to assertMichael Stahl
Change-Id: Iec89de279adf1c1cea3ecf84380d4b8b820714a4
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-26use std::vector instead of naked array in SfxItemPoolNoel Grandin
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4 Reviewed-on: https://gerrit.libreoffice.org/32384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-21convert VclButtonsType to scoped enumNoel Grandin
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-19no need to wrap calls to SAL_INFO in #ifdef DBG_UTILNoel Grandin
Change-Id: Ic373a8f145f3f78c3f109e36a9c1dd9156f0dd75 Reviewed-on: https://gerrit.libreoffice.org/32034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-16loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I24a0e495b64a1db8b7c45f3c68e06ad3301bd9c4
2016-12-16tdf#104488 editeng,svx: throw less Accessible exceptionsMichael Stahl
For some of these functions it doesn't make sense to throw DisposedException as they can return a sensible default value. Particularly AccessibleShape::getAccessibleChildCount() was throwing an exception that was never caught. Change-Id: I000149cf9bb0fd13f69650ad8224a8daf26f7bee
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in avmedia..canvasNoel Grandin
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12tdf#104540: AccessibleEventNotifier AccessibleBase (editeng)Julien Nabet
See https://bugs.documentfoundation.org/attachment.cgi?id=129537 for bt For the remind, it follows a replace of OSL_ENSURE by an assert, see: https://cgit.freedesktop.org/libreoffice/core/commit/?id=8228227168a7eb3ebf14629bec87f01536c23970 Change-Id: Id05eeb6e6669232e9b5cc2ef2989827fef3025d0 Reviewed-on: https://gerrit.libreoffice.org/31918 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-12coverity#1397045 Unchecked return valueCaolán McNamara
and coverity#1397044 Unchecked return value Change-Id: I193bd676e417c35450efa91cb5773c78c998b63f
2016-12-11Drop ComplexDisabled flags that does nothingKhaled Hosny
There is no such thing as simple text layout in this brave new world. Change-Id: I641b7efa5ec8fdd9839c291e7f2fdb736361ef1e Reviewed-on: https://gerrit.libreoffice.org/31824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07Monkey business: Fix typo in comments: et -> ed :)Mike Kaganski
Change-Id: I91440e8582108b9121ac6525c8ac88ad6f218a60 Reviewed-on: https://gerrit.libreoffice.org/31721 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-05use initialization listJochen Nitschke
guess comments in EditSelection ctors were about calling copy-ctor directly instead of default-ctor + copy assign Change-Id: I0f849d7e9af3d3b8c6d8688f549b3539a0c67873 Reviewed-on: https://gerrit.libreoffice.org/31632 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05tdf#96354 correct broken autocorrect INitial CApitalsYossi Zahn
Change-Id: If65ec7814c3aed5e4c17294ae57c34550373469d Reviewed-on: https://gerrit.libreoffice.org/31317 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-05loplugin:unnecessaryoverride (dtors) in editengStephan Bergmann
Change-Id: I7a268a1e991e84304e5435e0f7b633873f6829eb
2016-11-30add a SAL_WARN() for the broken portion continuationEike Rathke
Or should that even be an assert() to force callers to fix things? Change-Id: Ie0f10394376f088a7af9399ee42503fc403ca094
2016-11-30Resolves: tdf#104152 suppress notifications from EditEngine during PasteEike Rathke
Broadcast once at the end instead to notify a11y. Change-Id: I12383b6efbbb2b149f0d73c67d8576fcc050b253
2016-11-30prevent endlessly creating new lines until out of memory, tdf#104152Eike Rathke
Though this just prevents mishappens during reformatting a broken portion that is in a half-ready state because a11y was notified and attempts to obtain a paragraph. Solving the real cause means not being called in such state.. However, not going out of memory and also having matching X-values for the node's text positions that don't make the EditEngine crash later is better than nothing. Change-Id: Ifa8d2c5d1766b0f145b8e89ad26a78528db42056
2016-11-29Use derived classes' methods instead of Pair::A/BMike Kaganski
Change-Id: I7ffd9a23dbd00672630bc8412e95525a920c5065 Reviewed-on: https://gerrit.libreoffice.org/31379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-29Rewrite some (trivial) assignments inside if/while conditions: editengStephan Bergmann
Change-Id: I374fcd08bdeb37ff542447142b1b164886e0e5db
2016-11-24extend markup support (/italic/ and -strikeout-)TiagoSantos
* adds to LibreOffice markup support for /italics/ and -strikeout- * TODO update strings in the Options dialog (they only refer *bold* and _underline_) * TODO update documentation with new feature Change-Id: I6fd7bbd036bf406a9e24500d316e7f28a848faab Reviewed-on: https://gerrit.libreoffice.org/31076 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-23replace CHAR flags with o3tl::typed_flagsNoel Grandin
the usage of which looks a little dodgy, because this is a bitmask, but it's using == everywhere to check them Change-Id: I8e57d4f943a9048cc457a376ffbdfde0cffe22dd
2016-11-23convert DELMODE to scoped enumNoel Grandin
Change-Id: Idd3f45adb43930358420dba464dbdb88fe27b91d
2016-11-23convert GETCRSR constants to o3tl::typed_flagsNoel Grandin
Change-Id: Ia367d9a1b73d6c5b7a7989da45af0f002c43413c
2016-11-23convert ATTRSPECIAL to scoped enumNoel Grandin
Change-Id: I8abf09dc5f17343945b909887c580e9016a79ac5
2016-11-22trivial makefile cleanupsMichael Stahl
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
2016-11-21convert inventorId to scoped enumNoel Grandin
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21make this just every so slightly less awfulCaolán McNamara
Change-Id: Iddc39359d426f345eff0abf9fc9616e19597a0a4
2016-11-18editeng: assert SfxPoolItem::operator==Michael Stahl
Change-Id: Ia6c6f4f5af1e3a803b464ab410558984c3861a65
2016-11-16make the element names in dumpAsXml match the class namesNoel Grandin
Change-Id: I955facfe3e901fcb76798dab342f96a67d5ac63f Reviewed-on: https://gerrit.libreoffice.org/30894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-13drop useless semicolonsDavid Tardon
Change-Id: I039f8ff491b42ea9c3936bf13922df8095434228
2016-11-11coverity#1371263 Missing move assignment operatorCaolán McNamara
Change-Id: Ifb4117afac4aa86893e674a581e1a7bb80925ee3
2016-11-11check for self-assignmentCaolán McNamara
Change-Id: I74eb934d19c0b511870e5a675917ca4baaf768cc
2016-11-11make it more typical copy ctorCaolán McNamara
Change-Id: I0367e24b966a5bcc0d4838022ae12054e097270e
2016-11-11seems dubious to copy the state, but drop the load again bitCaolán McNamara
if the assigned-to item had loaded its original content, but the assigned-from item hadn't, then surely the assigned-to item will never load the new content. if the assigned-to item hadn't loaded its original content, but the assigned-from had, then why load it again Change-Id: I68c2cf2682a517e7e630ab6cbc637b35a2b9c7aa Reviewed-on: https://gerrit.libreoffice.org/30781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11these are going to get overwritten immediatelyCaolán McNamara
Change-Id: I065ae2aa2dead0679d05f080124ed54c27f0d68f
2016-11-11make this operator= a little less crazyCaolán McNamara
if SetGraphicPos was called with GPOS_NONE then xGraphicObject, maStrLink and maStrFilter are in a suitable state to copy to get the same results as explicitly forced here Change-Id: Id072590e92e0c083a3cbc443db0e85d9dbfa73f0 Reviewed-on: https://gerrit.libreoffice.org/30780 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11why have a pimpl with somethings in it and somethings notCaolán McNamara
Change-Id: I6151defcd9dddf4582ecf8d5952f6f8a825c545a
2016-11-11the pStream member makes no sense at allCaolán McNamara
maybe the PurgeMedia call in sw was meant to be a PurgeGraphic call originally (PurgeGraphic since removed by... commit a22ac2c218870033822120bf0b0d6cfde6ce799f Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 14 22:06:29 2011 +0100 callcatcher: remove unused methods) PurgeMedia releasing the stream makes no difference to the only place its used which is SvxBrushItem::GetGraphicObject which makes a new one every time anyway. the SvxBrushItem assignment operator doesn't change the stream member of the pImpl which looks utterly nuts, so its a good thing the stream is not reused Change-Id: Ie0dee22a6640a6916908fcddbc3541ba85034217
2016-11-11this looks like a leak to meCaolán McNamara
Change-Id: Id72d770ec55d6e627a81cc9590cb59f6c84f27b9
generated by cgit (git 2.34.1) at 2025-01-08 16:59:18 +0000