summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
3 daysAvoid slight jumping of TextEdit on activationArmin Le Grand (allotropia)
A PixelSnap was used before using GetOutputDevice() and LogicToPixel/PixelToLogic (what was incorrect, would need to take care of 1/2 pixel in logic for rounding). We do not need that anymore, in fact it leads to the text slightly 'jumping' around by up to 1 pixel (of course). We paint text nowadays using decomposed TextPrimitives with sub-pixel precision and similar (using a shortcut) for text in TextEdit on the Overlay, also using sub-pixel precision. Just remove this to avoid Text being displayed different in TextEdit and EditView paint visualizations and assign given value to OutputArea unchanged. If this should cause problems somewhere (I do not think so, we try to paint text with Sub-Pixel quality now anyways) this can also be done in alternative ways and only for TextEdit on Overlay. Change-Id: If177ceec880a29a6d102ad4f0dddf891d95b69c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182094 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
8 daysuse more concrete UNO types in some local varsNoel Grandin
found by a little plugin I created. Plugin parked into store/ folder because it needs hand-holding when run. Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
13 daystdf#i165354 sw offapi DOCX: implement HyphenationKeepLine – part 1László Németh
ODF 1.0 feature hyphenation-keep, i.e. disabling hyphenation across page etc. was implemented by shifting the full hyphenated line (fixing also the DOCX layout interoperability, when value of the useWord2013TrackBottomHyphenation MSO DOCX compatibility option is true). To shift only the last word, add UNO paragraph property com::sun::star::text::ParagraphHyphenationKeepLine and the associated layout in Writer core, i.e. disabling the hyphenation in the last line, instead of line shifting, if the value of ParagraphHyphenationKeepLine is true. Fix missing DOCX layout interoperability by mapping the unhandled useWord2013TrackBottomHyphenation = false case to the new layout. Note: shifting lines may be better for languages with long words, but only with 1) typesetting with line-level (greedy) line breaking instead of the desirable paragraph-level, 2) and with missing optimized hyphenation at boundaries of compound word constituents, and 3) forgotting the following: Shifting only words or word constituents are better for 1) equal line count on pages and spreads (very basic typographical requirement), 2) disabling hyphenation really (shifting doesn't guarantee this, because shifting is limited in a single line, but the previous line can be hyphenated, too) and 3) more compact typesetting. Both hyphenation-keep algorithms are important for interoperability, but the new HyphenationKeepLine can create state-of-the-art automatic typesetting with the planned improvements. Follow-up to commit 9574a62add8e4901405e12117e75c86c2d2c2f21 "tdf#132599 cui offapi sw xmloff: implement hyphenate-keep". and commit c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463 "tdf160518 DOCX: import hyphenation-keep to fix layout". Change-Id: Iafa352ec91bbd5d1d227b8480337fa2b9acb5993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181954 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2025-02-11tdf#164685 Cleanup SfxItemSetFixed - Part 3rafaelhlima
This is the continuation of the cleanup of class SfxItemSetFixed, as described in the bug ticket. Change-Id: I567f985af181d326a6adb6c3d3af2a9e2fa8df34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180975 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2025-02-08move some fields from OutlinerEditEng to OutlinerNoel Grandin
as the comment indicates, that is where they belong Change-Id: I0078a359253d86d0197a87fade5a2de7579be042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181273 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-01-31tdf#164685 Cleanup SfxItemSetFixed - Part 2rafaelhlima
This is the continuation of the cleanup of class SfxItemSetFixed. This patch contains a few edge cases, more specifically when SfxItemSetFixed is used in header files. Change-Id: I2ed48177ca53311b20b9e2a8aed95d3b1c87f250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180309 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2025-01-29tdf#164900 table text in different columns no longer lined upNoel Grandin
Revert "tdf#161846 use unordered_map in SfxItemPropertyMap" This reverts commit c39978f41dccbeb2e973c919a67d9b1d974f8f3c. Change-Id: I26cadb32b426fd3b48179b67c677213a78b4999c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-22tdf#75280: Convert sal_uIntPtr use to operator >>= Color.Marc Mondesir
Replace casts to sal_uIntPtr, then to other types with operator >>= Color. Change-Id: Ib30370da83f3f653f8c5816e4d88cc5381ae648b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-21tdf#105083 Support status of numbering and bullet listOliver Specht
Shows the status of bullet/numbering in the current text selection in the toolbar buttons ToggleUnorder/OrderedList. Change-Id: I458896293c502da8142ad9cb43b5ea62a9f3b558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180238 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-01-20tdf#164685 Cleanup SfxItemSetFixedrafaelhlima
Cleanup of class SfxItemSetFixed as described in the bug ticket. Change-Id: I0704ab45624217a8d00a942e0e8d6d6276934306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180255 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2025-01-20drop coverity std::optional workaroundCaolán McNamara
Change-Id: Ie1b61fc4a8a8219e9ba3d4c8f77c27b8c725407e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-17undo/redo of comment insertion assumes Par2 content matches TextObjectCaolán McNamara
contents (as much as conversion to plain text makes possible) To make things easier, add an EditTextObject::GetText() like EditEngine::GetText() that serializes multiple paragraphs in an equivalent way so there isn't a need to create an editengine just to do this conversion. Modify and extend DesktopLOKTest::testCommentsCallbacksWriter to use a html payload and add a undo/redo to it. Change-Id: I4d895138e919bab54ebbbcb966f9b9faef574086 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179594 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180377 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-01-11pdf: change StructElement to enum class, move out of PDFWriterTomaž Vajngerl
Moves the StructElement out of PDFWriter and changes it to enum class. This makes it mroe type safe, easier to search and more clear what type we are using. Change-Id: Icf469319a01f58397b131c3517bc75fba4072500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179977 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-10ITEM: Refactor ItemTypeArmin Le Grand (Collabora)
ItemType is useful and faster than RTTI. Until now it was implemented by a 16-bit member in the base class, plus (potentially) all constructors having to hand a value in at item construction type (of type SfxItemType) to get that member set correctly. This works, but there is no reliable way to guarantee coverage, and there have already been cases with missing SfxItemType - these fallback to '0' and thus all Items with ItemType() == 0 are assumed equal and might be static_cast'ed to the wrong classes. Note that I identified *35* Items that had no correct ItemType set/implemented actually. It also uses 16-bit per incarnated Item at runtime. I thought and realized now a more systematic approach to do that with a pure virtual function at the Item itself. That can also be secured by a clang compiler plugin in the future to keep it working. It uses one virtual function per derived class, no longer space in incarnated Items. Also the constructors will get more simple again. But the main aspect is security - we cannot afford Items potentially being held as equal if they are not. Unfortunately C++ does not offer something like a 'strict pure virtual function' that would force to be overloaded in every derivation, but the used methotology and adding a clang test is reasonably safe. Have now done the cleanup of previous method. Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-12-19tdf#163660 sw: Treat strong CJK inside RTL runs as Asian scriptJonathan Clark
Previously, Asian-script characters following an explicit direction mark or inside an RTL embedding would be rendered using the Complex font, rather than the Asian font. This change updates script detection to treat these characters as Asian regardless of text direction. This change also consolidates more duplicated script detection code from Writer and Edit Engine. Change-Id: I3931c3ec0cb447f3c504fdbfb3ee62185fd14422 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178817 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-12-19Related: tdf#164359 editeng RTF export: track unused follow styles recursivelyMiklos Vajna
Similar to commit a7a81b6fbe37af938ce461e790fac517be032317 (tdf#164359 editeng RTF export: track unused parent styles recursively, 2024-12-18), the follows of a style has to be tracked recursively as well, to avoid a crash. The Impress UI doesn't seem to have a way to specify the parent/next name of a style, but you can definitely create such a follow chain from test code and probably this is also possible via macros. Fix this similar to the parent case, except here handle when a style sets itself as a follow: that's what the default Outline N styles do in Impress. Change-Id: If3847add02061fdb9ba1e3fbf7c1fc42e3866209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178786 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-18tdf#164359 editeng RTF export: track unused parent styles recursivelyMiklos Vajna
Start edit mode for the shape in the document, double-click on a word which has a "level 2" bullet associated with it -> crash. This is a regression from c8b607b7c0096c58dc5187262bf0133dee728d50 (tdf#163883 editeng RTF export: fix broken offsets into the para style table, 2024-11-19), the direct cause is that ImpEditEngine::WriteRTF() maps all style pointers to a style ID and once we write the parent property in the style table, we unconditionally dereference our search result, because we know all styles should be in that map. The root of the problem seems to be that once parent styles are marked as used for the "only write used styles for the clipboard" case, those parents themselves can have parents, and we didn't mark those as used. Combined with the unconditional dereference, this leads to a crash. Fix this by walking up the parent chain till we get no parent. This assumes that importers create a valid document model, so there can't be loops while walking the parent chain. If that would be a problem in practice, we could check for that in the future. Change-Id: I4b416e78f26bf455040d95ee8ed220cfe870e33a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178703 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-12-16tdf#66791 sw: Treat weak punctuation as Asian in Asian paragraphsJonathan Clark
This change modifies script detection to treat certain weak punctuation marks, particularly left- and right- quotation marks, as Asian script in paragraphs containing Chinese and Japanese characters, but no Complex characters. This change improves our script detection compatibility with other programs. As part of this change, duplicated script detection code has been extracted from Writer and Edit Engine, and consolidated. Change-Id: Ib2880f2e832aaac4c0093971daa88223c7232d63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178608 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-12-11tdf#163634 Format empty paragraph if they have a bullet/numberingOliver Specht
Some optimization in commit 52abeff6d5836b29dbefe69f284bbd89f6672ae2 ignores paragph attributes if the paragraph is empty. But it is not empty if it has an active list. Change-Id: I8885d0f201fc48279263a3d41ec6d660b534ded2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178311 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-12-09remove some range checksNoel Grandin
which are more likely to hide an underlying bug than they are to help Change-Id: I118b592677df05246912d7fa3d7ab8ca2fe99377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177999 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-07Avoid needless temporary Sequence creationMike Kaganski
Change-Id: Ia0b6df8b329136292917c94ee5d5e69a0931a200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178056 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-07Use std::initializer_list, C-style array instead of more expensive SequenceMike Kaganski
Change-Id: Ibb268268926cc91f595f19026f6cee4b5a74a8bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178038 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-07Simplify a bitMike Kaganski
Change-Id: Ie2b96e099a0507e14ad8e79276abdbe0f21d35f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178040 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-07cid#1636582 Negative loop boundCaolán McNamara
Change-Id: Ib91ee62814837765f89f65a1204021e9d9610e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-04[API CHANGE] a11y: Drop XAccessibleExtendedComponent::getFontMichael Weghorn
This method from the unpublished XAccessibleExtendedComponent interface is not used by any of the a11y platform bridges, and I don't know of any platform a11y API that would need it. In order to report character/font attributes, there is the XAccessibleText interface and its XAccessiText::getCharacterAttributes method instead, which actually gets used by the platform a11y bridges. Therefore, drop this method to simplify code, and also decouple the accessibility module a bit further from the toolkit module without having to reorganize code further. (VCLXFont from the toolkit module currently gets used in various implementations.) Change-Id: I06ea3cc5998a13927b3f869877b28f03ac07c89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177809 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04tdf#88226 sd: fix cutting off the overflow text on the notes print pageTibor Nagy
This fix offers two options to preserve the overflowed text: 1: if the "Original size" option is selected for printing, the overflowed text will be displayed on a new page. 2: if the "Fit to Printable Area" option is selected for printing, notes will be scaled to fit within the available printable space. The "Multiple sheets of paper" and "Tile sheet of paper" options are disabled for notes because these options are intended for slide printing and do not make much sense for printing notes. The orientation for the notes print page has also been fixed. Change-Id: I99e56cf9aed5c32764797469a8ea7f3b25053882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177511 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2024-11-29cid#1606728 Overflowed integer argumentCaolán McNamara
Change-Id: I6fef2b6818018b8a0f82125ef2d8220688d642a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177536 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-24tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroMohamed Ali
Change-Id: I958365b3db058ec809702a5ddde1d153467f21ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177158 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-11-24Let ESelection use EPaM for simplificationMike Kaganski
And drop EPosition, which duplicates EPaM, except for its default ctor (used in a single place). Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I183330f8c2e947d6c8dffbcabc7da6c115e08a8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176963 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I3207e070fba8407fd8475c8d774b3a500cae8e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176965 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Iae168766fdfcbf4c68aa0770b0c42e96a61001c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176964 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-22tdf#163598 editeng: avoid using fake outline depthJustin Luth
Most implementations do not actually do anything meaningful with Get/SetDepth, so don't exception or accept their values. To fix the bug, I could have just checked for dynamic_cast<SvxEditEngineForwarder*> (since it supports EE_PARA_OUTLLEVEL directly) but this way seemed more encompassing. The potential downside is that EE_PARA_OUTLLEVEL will be requested as a real property after GetPropertyValueHelper with some of these dummy providers, and who knows what UNO might do about that... IF this patch causes problems, then I need to implement Get/SetDepth in SvxEditEngineForwarder (or consider the dummy providers as SupportsOutlineDepth). Change-Id: I74bf5e39a13bb1d588c39634347eb0982bda66b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176981 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-20tdf#163967 RTF: Pasting/loading hyperlink imports font color and underlineOliver Specht
Hyperlinks are typically colored and underlined. The RTF import - also used when pasting from clipbard - now evaluates font color and underline in the field result. Change-Id: I725fc3e94746c96d68379c021fb0c12cd3750096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176714 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-11-19consider VndSunStarExpand an exotic protocolCaolán McNamara
and generally don't bother with it when fetching data from urls Change-Id: I51a2601c6fb7d6c32f9e2d1286ee0d3b05b370b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176645 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-19tdf#163883 editeng RTF export: fix broken offsets into the para style tableMiklos Vajna
Regression from commit 70d1bd6ee0eba9d6661cd6280566f77a87f2d068 (tdf#161652 editeng, RTF copy: only write used paragraph styles, 2024-06-20), type a few characters into the title placeholder shape in Impress, switch to the Outline view, select all, copy, paste into Writer: the resulting text nodes won't have paragraph styles, just direct formatting. Inspecting the produced RTF, the problem is that the styles table started to omit unused styles, but the style -> offset mapping table still included them, so the offset didn't match, which results in losing the style on RTF import. Fix the problem by building the mapping table later also also ignoring unused paragraph styles there, to restore consistency between declaring style entries and referring to them. Change-Id: I9156a881543cc710eb12990f110ceefc77a1858b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176747 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-17cid#1607833 Overflowed constantCaolán McNamara
Change-Id: Ie90b759b76fa587cddd3c160fe7845dec01652c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-16cid#1606752 silence Overflowed return valueCaolán McNamara
and cid#1607158 Overflowed return value cid#1607271 Overflowed return value cid#1608107 Overflowed return value cid#1606975 Overflowed return value cid#1608009 Overflowed return value cid#1608353 Overflowed return value cid#1608486 Overflowed return value cid#1607009 Overflowed return value cid#1606780 Overflowed return value its totally unclear what the source of these warnings is Change-Id: If46cac6a329dec397bd784f57d9ffe5e53af9a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176683 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-14tdf#36709 GUI changes for font-relative first-line indentJonathan Clark
This change includes GUI element changes to support viewing and editing first-line indent values with font-relative units in the paragraph style dialog. Change-Id: I72ada2565f51d70475eb17096a1317be9316b770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176595 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-11-14cid#1634809 Null pointer dereferencesJonathan Clark
and cid#1634807 Null pointer dereferences Change-Id: I9a100651a744cb77ff89769e8c98afcfb771f593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176563 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-13tdf#36709 editeng: Layout for font-relative first-line indentJonathan Clark
This change extends layout for font-relative paragraph first-line indentation into Edit Engine. Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-13tdf#36709 sw: Writer layout for font-relative first-line indentJonathan Clark
This change implements layout for font-relative paragraph first-line indentation in Writer. Change-Id: Ie8f386bcc13a43ab92d5c15654c24bfdfc62bd69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176216 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-12tdf#163486: Improve commentsBogdan Buzea
Change-Id: I2a892e1b3dd8cfbc1501b1e4c40977ee6b7239bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176078 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08loplugin:reftotemp in dbaccess..editengNoel Grandin
Change-Id: I51f5e47fb2fca37928ac58952a6a34b7351ca53c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176277 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08cid#1555255 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556766 COPY_INSTEAD_OF_MOVE Change-Id: Ie11d0279ec775034ee8e5a14b0e57eaed110fda6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08cid#1634530 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Iae03c8a982659503d7f73dbabbcece7bdb9c8e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176259 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-07cid#1555009 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555173 COPY_INSTEAD_OF_MOVE cid#1555255 COPY_INSTEAD_OF_MOVE cid#1556619 COPY_INSTEAD_OF_MOVE cid#1556766 COPY_INSTEAD_OF_MOVE cid#1557131 COPY_INSTEAD_OF_MOVE Change-Id: Ia581e7858d8ff4db08308b4118116781db1464a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-07[API CHANGE] a11y: Switch AccessibleRelationType to enumMichael Weghorn
Switch css::accessibility::AccessibleRelationType from integer constants to an enum. This provides more type safety and improves the debugging experience, e.g. GDB now prints com::sun::star::accessibility::AccessibleRelationType::AccessibleRelationType_CONTENT_FLOWS_TO instead of just "2" when printing the value of a corresponding variable, so it's no longer necessary to manually look up what constant has that integer value to know what relation this refers to. offapi/com/sun/star/accessibility/AccessibleRelationType.idl had this comment: > <p>We are using constants instead of a more typesafe enum. The reason > for this is that IDL enums may not be extended. Therefore, in order to > include future extensions to the set of roles we have to use constants > here.</p> However, the a11y UNO API is internal (not published), so that shouldn't be a concern. Change-Id: I44a7d56cb085dc24effb24fcd34bb222b78ef4cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176153 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-03-06 06:25:02 +0000