summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2014-01-28bool improvementsStephan Bergmann
Change-Id: If99daef91a41036a5b8dac1e53ab68e928b0b710
2014-01-28Apparently missing "nPos <"Stephan Bergmann
Change-Id: Id334f044d475de7ef14503e1a45190a0021d58be
2014-01-27cp#1000025: Import casemaps from pptx.Muthu Subramanian
Note: This only imports it and it may not be even possible to export (even to othe formats). Change-Id: I8e104f1bc3a95c42ac932b6ab58365dc113fb2e0
2014-01-26long to sal_Int32Matteo Casalin
Change-Id: I03c3d93c03239ae39bb3078ffabe71276ec37d25 Reviewed-on: https://gerrit.libreoffice.org/7658 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-22remove SvStream::operator<< methodsNoel Grandin
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22convert more SvStream::operator<< callsNoel Grandin
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22bool improvementsStephan Bergmann
Change-Id: I2a0980a603822ffdf74a38ba0b41ba27a6830861
2014-01-22bool improvementsStephan Bergmann
Change-Id: Ia212b8f80da70de7796f0d8ba817c8d3da693080
2014-01-21EDITENG : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: Ifc04e2ec9d27c706868569a3bcb8fbfae0e84c69 Reviewed-on: https://gerrit.libreoffice.org/7524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-20Related: #i56998# use locale rules to format percentageCaolán McNamara
Change-Id: I4b744cf10165383153d2a71c05df0c0ed327c641
2014-01-20Resolves: #i56998# add a space separater between value and unit...Tsutomu Uchino
and remove separator between value and percent to match with ISO 31-0 (cherry picked from commit 0cea884e3f417e4b58d2fdcfc7b0111f3bfc6f30) Conflicts: chart2/source/controller/dialogs/tp_SeriesToAxis.src cui/source/dialogs/colorpicker.cxx cui/source/dialogs/colorpicker.src cui/source/dialogs/grfflt.src cui/source/dialogs/zoom.src cui/source/tabpages/tabline.src editeng/source/items/frmitems.cxx editeng/source/items/textitem.cxx sd/source/ui/animations/CustomAnimationDialog.src sd/source/ui/animations/SlideTransitionPane.src svx/source/dialog/bmpmask.src svx/source/engine3d/float3d.src svx/source/items/algitem.cxx svx/source/sidebar/text/TextCharacterSpacingControl.cxx svx/source/xoutdev/xattr.cxx sw/source/ui/utlui/attrdesc.cxx sw/source/ui/utlui/uiitems.cxx Change-Id: I554309cb72dd8956077c5ca6866a982cdd6529aa
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16low hanging xub_StrLen->sal_Int32 in editengCaolán McNamara
Change-Id: I8d9a504a1e7d320b487ee499b5bc0c04b52632e7
2014-01-15Related: #i17171# big xub_Strlen -> sal_Int32 changesCaolán McNamara
Change-Id: I31bce794c95062abfa1171c13cf565498688b5f3
2014-01-14bool improvementsStephan Bergmann
Change-Id: Ic6488ac278cac2d1d7e240abff545f9ea0b8eafe
2014-01-14This shall likely comp. m_eCurrentConversionDirection to HHC::eHangulToHanjaStephan Bergmann
Change-Id: Ib4eba9f6386214d010c880ad15bcacce7665a3af
2014-01-14comment is wrong now with conversion to OUStringCaolán McNamara
Change-Id: Iff26cd2c966fc747895fbde7229a457a99c62f7a
2014-01-14xub_StrLen->sal_Int32Caolán McNamara
Change-Id: I9c4d9b8d18b36dda6609b1976cae13a481943563
2014-01-14longparas: nPartLen always is USHRT_MAX/STRING_LEN to take full stringCaolán McNamara
Change-Id: I55bb0baa8e83948c470ade2fc6fabccb69dea91d
2014-01-13longparas: convert ValidateKashidas to sal_Int32Caolán McNamara
we can use -1 as the failure return code as return value is always checked and isolated from the rest of the code. Change-Id: I87a743de82d681a7e4eabc61a576c4e50f1279a8
2014-01-10SfxPoolItem::operator ==, != should return boolStephan Bergmann
...and SfxEnumItemInterface::HasBoolValue, too. Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-09Consolidate XServiceInfo for classes derived from SvXMLImportStephan Bergmann
Change-Id: I5a269d8b7e95049c67ae14b06a79b417bc91a474
2014-01-08Consolidate XServiceInfo for classes derived from SvXMLExportStephan Bergmann
Change-Id: Ia3e2b5e682a64844bb6c713912c50c7681393d52
2013-12-28Remove unread variableMatteo Casalin
Change-Id: I6271e8f977d5c112223d14744830c8101099613d
2013-12-28Use OUString constructor for constant ASCIIMatteo Casalin
Change-Id: Ifc80743c748c2542055cfe825ad322b83958d976
2013-12-28Use member initialization list in some constructorsMatteo Casalin
Change-Id: Ie0c9720966ca42373bec7a1697b72c5a17f49644
2013-12-28Do not use Getters as SettersMatteo Casalin
Change-Id: Ie465e768f07f6e0ebf10042ca389b4941ba84a2a
2013-12-28xub_StrLen to sal_Int32 + some constMatteo Casalin
Change-Id: Ieae0940d3d072c3214b4fa2280dd0e01dc328cb7
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-12fix OUString simplifyNoel Grandin
In my commit fb847101519ad74c02183672c04ebf1d700aae83 "simplify - use OUString::startsWith where possible" I incorrectly converted if ( !aURL.isEmpty() && ( aURL[ 0 ] != '#' ) ) to if ( aURL.startsWith("#") ) Change-Id: I7fa3a814e13724dc65821e09c03db898b92626ec
2013-12-12simplify - use OUString::startsWith where possibleNoel Grandin
Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-12Don't hold css::uno::Type instances by pointerStephan Bergmann
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-11Revert "Don't hold css::uno::Type instances by pointer"Stephan Bergmann
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now: Ach, old GCC doesn't like plain string literals to initialize members of OUString type... Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11Don't hold css::uno::Type instances by pointerStephan Bergmann
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-10fdo#70278: editeng: fix Time fields in ImpressMichael Stahl
Apparenty an uninitialized SvxTimeField is created instead of the SvxExtTimeField that is needed to preserve the value and format. (regression from ee5fc5d25fe102c30daf7d181b8181d40b85a4f3) Change-Id: I36b16af0c143e8b5451a1925806756492dc2334e
2013-12-10editeng: fix more 32-bit Time breakageMichael Stahl
SfxDateTimeItem and SvxExtTimeField need to use 64-bit integer to store Time as well. These classes also have binary serialization Load()/Save() methods but they are unlikely to be used in a persistent way, just for the clipboard. The problem is easy to reproduce in Impress: Insert->Field->Time(fixed) (regression from 9830fd36dbdb72c79703b0c61efc027fba793c5a) Change-Id: I5946c5b94dd5a509805b6dc40461bbd910caffc4
2013-12-10Resolves: #i123620# IAccessibleHypertext::hyperlinkIndex returns 0...Steve Yin
when editing a cell/object where there is no link (cherry picked from commit 552e71c2482b5911ac485c9331a4f354ba7150b5) Change-Id: I9be20b045d3472f15c98352928d45a1349cec5c4
2013-12-10Drop duplicate #includeTakeshi Abe
Change-Id: Ib8969d5cd4898b81a5dcd90dc313abd28adfe052
2013-11-27IAccessible2: revert some bounds-checking changes againStephan Bergmann
...that were introduced with c23ab5eaed57cc3fb5860e26c591c73c5b22687b "Integrate branch of IAccessible2" but broke JunitTest_sc_unoapi, which expects calls to getCharacterAttributes and getIndexAtPoint to actually fail for out-of-bounds arguments. The above commit does not make it obvious why those changes were actually made. Change-Id: I3492c3e6a49d68885df1206e9368f4483c0dc4f9
2013-11-26WaE: unreachable codeTor Lillqvist
Change-Id: Iee5fa84eb2335efa7d7f7cb28b8efdecf9366592
2013-11-26rewrite new SvxEditSourceHelper::GetAttributeRun replacement in new styleCaolán McNamara
Change-Id: I906e99afb58dcee3e47a545f575aab71b7edc0e9
2013-11-26Integrate branch of IAccessible2Steve Yin
WaE: Reorder initializations to prevent compiler warnings. (cherry picked from commit c05431aa92fa2c7c7258418a6ecd651b5c26d982) WaE: unname unused variable to prevent compiler warnings. (cherry picked from commit 2259256a390c4b6f83cfb5dbe4a65df5032aee47) Conflicts: editeng/source/accessibility/AccessibleEditableTextPara.cxx ad61537527a74670af266feb9e4d26d2d654daf7 66044902b8d94fc15d4c30270e6cc419fb7d3565 Change-Id: I3ec9798f2c7d854824722c0cf44b62128b4f4cb4
2013-11-22replace OUString::reverseCompareTo("xxx") with operator==Noel Grandin
operator== with OUString and literal internally does a reverse-compare (via OUString::equalsAsciiL) anyway, so no need to keep explicit calls to OUString::reverseCompareTo with literal argument Change-Id: I799d9bcd0d5c308a9547ce7cacb2db6042fdb643
2013-11-22remove unnecessary RTL_CONSTASCII_STRINGPARAMNoel Grandin
A final pass through the code, converting code to use the new OUString and OString methods that can detect string literals. Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-20editeng: warning C4805 unsafe mix of type sal_Bool and type boolMichael Stahl
Change-Id: I88fc77ea6c0b6a7c02d0b7eff64d8fdd3db6020e
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OStringBuffer constructorNoel Grandin
Convert code like: OStringBuffer aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OStringBuffer aKeyName("NDX"); which compiles down to the same code Change-Id: If9c96a290bc18cc8285fb733f27be58c6958b63c
2013-11-20fdo#67742 Avoid autocorr of "--" before "-"Laurent Balland-Poirier
LibO 4.1 now uses '-' as word separator for AutoCorrection Then the sequence "---" is detected as word "--" and autocorrect as "–". This avoids autocorrection of "---", as word or as border This commit detects the sequence "---" and report autocorrection. Change-Id: I1342c2ff83dd42683e683b3bb27280d61179b9a2 Reviewed-on: https://gerrit.libreoffice.org/6727 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-20sal_Bool to bool in ImpEditEngineRodolfo Ribeiro Gomes
Change-Id: I76dc0343fd735104827b4803c5440570afe86174 Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/6693 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-23 14:35:19 +0000