summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)Author
2017-04-10loplugin:inlinefields in SvxAutoCorrectNoel Grandin
Change-Id: I09aa52551dd1ed96bc9a72baec6afe5a4a05c1dd Reviewed-on: https://gerrit.libreoffice.org/36346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-07loplugin:redundantcast find cstyle arithmetic castsNoel Grandin
Change-Id: If7c259f0d12a41182f476ddb558f7cb5f76f9577 Reviewed-on: https://gerrit.libreoffice.org/36253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: editengStephan Bergmann
Change-Id: I64be28eb18822c29e3d540decb465c9204d16894
2017-04-06loplugin:redundantcast check for c-style float castsNoel Grandin
Change-Id: I86b6f58887cb398a80698f8d8564b5bc3f55eabb Reviewed-on: https://gerrit.libreoffice.org/36198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06loplugin:singlevalfieldsNoel Grandin
Change-Id: Ia681765aa1da5c80a3dbe91b7376af841a9c9ec1 Reviewed-on: https://gerrit.libreoffice.org/36145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06unnecessary pre-all-oustring copyCaolán McNamara
Change-Id: Ife45898482b74b1b911001d99d04bb8daeacfb41
2017-04-06Fix typosAndrea Gelmini
Change-Id: I9e7f7fa6a8b89304883a843f9fb0b905f5e8a8a4 Reviewed-on: https://gerrit.libreoffice.org/36100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-05loplugin:redundantcast find c-style bool castsNoel Grandin
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2 Reviewed-on: https://gerrit.libreoffice.org/36137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparam part2Noel Grandin
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in UnoControls/, editeng/, filter/, odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/, tools/, writerfilter/, and xmloff/. Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1 Reviewed-on: https://gerrit.libreoffice.org/35992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03Remove DBG_ASSERT since it's always wrongJulien Nabet
Indeed EditHTMLParser constructor calls HTMLParser constructor, the last one calls "SetSrcEncoding(RTL_TEXTENCODING_UTF8);" Change-Id: If749674c3d4f2b9f9fccbf0b99f1e7d62fd0450d Reviewed-on: https://gerrit.libreoffice.org/36011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-02Add SvxTextRotateItem inherited from SvxCharRotatItemTamás Zolnai
I will be use it later for text rotation inside a table. Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc Reviewed-on: https://gerrit.libreoffice.org/36021 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-04-02coverity#1403662 Mixing enum typesCaolán McNamara
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947 Reviewed-on: https://gerrit.libreoffice.org/36020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-31use actual UNO enums in editengNoel Grandin
Change-Id: I58e794f161f3c4dd103985f575bc25202d4989b3 Reviewed-on: https://gerrit.libreoffice.org/35907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30editeng: tweak commentMichael Stahl
Change-Id: I587fafea157a02d2c903dda4b85448b1fe349c3e
2017-03-30tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in editeng/ Change-Id: I9bd15ca0914b34839d83751f530dd212d91e029e Reviewed-on: https://gerrit.libreoffice.org/35884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-30convert SvxDateType to scoped enumNoel Grandin
Change-Id: I5ce04f252642cb3a6c1b08ee22255f6c7b97f0f8 Reviewed-on: https://gerrit.libreoffice.org/35842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Resolves: tdf#106079 automatic color described as 'white'Caolán McNamara
move RID_SVXSTR_AUTOMATIC from svx to editeng for this Change-Id: Icc3fbb15e627ed54770d11bce7aadf30a0d12aa7
2017-03-29split ImportState enum into RtfImportState and HtmlImportStateNoel Grandin
and convert to scoped enum Change-Id: I23e44e78ce96ed5fc19374e3e069e1cdc2166a35 Reviewed-on: https://gerrit.libreoffice.org/35840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Fix integer type of EditCharAttrib nStart/nEnd membersStephan Bergmann
Looks reasonable to replace assignment to nEndField from USHRT_MAX with -1 in ImpEditEngine::AddPortionIterated (editeng/source/editeng/impedit4.cxx). This apparently needs to just be an arbitrary value that EditPaM::GetIndex() will never have. Looks like 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 "xub_StrLen and tools/string.hxx final straw" missed that (as that commit's message acknowledges). Change-Id: I5840d52d12a71937a5ed2779bfd5de071f702300
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27Make loplugin:loopvartoosmall look past top-level ExprWithCleanupsStephan Bergmann
Note the two "//TODO!" in the fix of the one newly found issue. Change-Id: I181691da4b74cd55611452e002b37bd6798ff1e6
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ic823a46019138b8bbcacd7b52b48d7d7ead2fde2 Reviewed-on: https://gerrit.libreoffice.org/35629 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24Added Test for EditEngine - Copy/Paste with Hyperlinks in TextVarun Dhall
Change-Id: Iabe11ddac346f1c48b355c21797c11de8db54b1f Reviewed-on: https://gerrit.libreoffice.org/35593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24Added Test for EditEngine - Copy/Paste with Tabs in TextVarun Dhall
Change-Id: If40dabc53d35c01e61f8a17799f26e6ef9fd6b08 Reviewed-on: https://gerrit.libreoffice.org/35579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24Added Test for EditEngine - Copy/Paste using Underline TextVarun Dhall
Just because Underline is as important as Bold/Italic we cannot skip a test for it :) Change-Id: I6c240a3232cf97794c8265afe66f58ce6f68fa43 Reviewed-on: https://gerrit.libreoffice.org/35217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23Remove unused #include <ctype.h>Stephan Bergmann
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22loplugin:redundantcast find redundant c-style enum castsNoel Grandin
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349 Reviewed-on: https://gerrit.libreoffice.org/35467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19Fix typosAndrea Gelmini
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085 Reviewed-on: https://gerrit.libreoffice.org/35413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-18Revert "Revert "Implement export and import of author field in fixed format""Rosemary Sebastian
This reverts commit cae16645e17df6a1f87443c00b6abfd26dabd27f. Change-Id: If5b85beb53a0925909d537023879a7d86fa011cf Reviewed-on: https://gerrit.libreoffice.org/35391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com> Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-18remove EE_RESSTR preprocessor abuseBjoern Michaelsen
Change-Id: I83b35c4e2d4275ac76a36bec03807be69a605c58 Reviewed-on: https://gerrit.libreoffice.org/35370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-18get rid of pointless EE_DLL macroBjoern Michaelsen
Change-Id: Ide055b4c1c6d26e4ade1ceed0f3669c4cb7d8392 Reviewed-on: https://gerrit.libreoffice.org/35369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-17convert SvxBorderStyle to scoped enumNoel Grandin
and rename to SvxBorderLineStyle Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc Reviewed-on: https://gerrit.libreoffice.org/35265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16Revert "Implement export and import of author field in fixed format"Rosemary Sebastian
This reverts commit 5de40734af30a8b897c6c5b7f681759e36a25557. Change-Id: Ib09fb1dc54066cadcd9503c92140d78e7482ae6c Reviewed-on: https://gerrit.libreoffice.org/35281 Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com> Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-15remove useless castsJochen Nitschke
Change-Id: I900b72372a56d341d18091b0d4721d31002d147f Reviewed-on: https://gerrit.libreoffice.org/35223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15convert SvxFrameDirection to scoped enumNoel Grandin
Based on the casts in chart2/source/view/main/ChartView.cxx and the similarity of naming of values, I conclude that this enum was intended to abstract over css::text::WritingMode2. Added a comment to that effect. Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57 Reviewed-on: https://gerrit.libreoffice.org/35164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14-Werror,-Wformat (clang-cl)Stephan Bergmann
Change-Id: I7a3f58e5967a31999f45ce15086f048fb39650c7
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14change SvxFrameDirectionItem base to SfxEnumItemJochen Nitschke
Change-Id: I82f01d0e3e4bf15ed6ba435406ae63b7c9110091 Reviewed-on: https://gerrit.libreoffice.org/35160 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13Added Test for EditEngine - Copy/Paste using Bold/Italic TextVarun Dhall
Change-Id: Ifd2fd8088590493377749866f37b1e663f97fa76 Reviewed-on: https://gerrit.libreoffice.org/34983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-12make this a member of SvxBrushItemCaolán McNamara
Change-Id: If1216b03a313885bb284ca5ddcd8a91167a3638b
2017-03-11Fix typosAndrea Gelmini
Change-Id: I19d30a1ef4236dbe0a0053dad67a5ba7b1586fc8 Reviewed-on: https://gerrit.libreoffice.org/35054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Johnny_M <klasse@partyheld.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-10ensure SfxApplication exists for editeng testCaolán McNamara
Change-Id: I73814e38437f83f8aa7b87addc285e82f7357bea
2017-03-10tdf#99352: create editeng::SharedVclRessourcesBjoern Michaelsen
- instead of keeping vcl resources in a rtl::Static - these are shared owned by all EditEngines - they let go of them when disposed - thus, this should prevent VclPtrs to leak beyond dispose() Change-Id: Ic6198c19d0ff9c09ecdea377d07807f08711d6a0 Reviewed-on: https://gerrit.libreoffice.org/34986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-10tdf#99352: dispose EditEngines when SfxApp diesBjoern Michaelsen
In an ideal world, by the time we reach DeInitVCL() there should be neither non-null VclPtr nor EditEngine instances around. This fixes the former for those VclPtrs owned by EditEngines, by disposing them when SfxApplication is dying. The goal is -- for now -- to not have any non-null VclPtrs around by DeInitVCL(), so we can e.g. assert() on that to pick up regressions. Should we one day have all EditEngines accounted for with proper smart pointers that get torn down before DeInitVCL(), the Dispose() introduced here might be removed again. Change-Id: I47b17f7fd31fce2ac5fd6f6b146d356d7d07e677 Reviewed-on: https://gerrit.libreoffice.org/34985 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-10Implement export and import of author field in fixed formatRosemary Sebastian
Change-Id: I1975bfcdc8436f2b05e2fab2a4c9c09838330b30 Reviewed-on: https://gerrit.libreoffice.org/33520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-25 08:03:35 +0000