summaryrefslogtreecommitdiff
path: root/embeddedobj/source
AgeCommit message (Collapse)Author
2014-04-04coverity#706511 Uncaught exceptionCaolán McNamara
Change-Id: I2822c35e60a93b86bdcb56f1e4782aa46e1ce8e0
2014-04-04coverity#706508 Uncaught exceptionCaolán McNamara
and coverity#706509, coverity#706510 Change-Id: Ib160cc65ed50073f9302ac071b2e8970a7316a54
2014-04-04coverity#706512 Uncaught exceptionCaolán McNamara
Change-Id: I6ec80c02ca8ef737297e77ccda2a0b5919fa66cb
2014-04-02Avoid possible resource leaks by boost::scoped_arrayTakeshi Abe
Change-Id: Ibf92b3098c50388d8b6d27f4476e613a1f8918b5
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-29typo: persistance -> persistenceThomas Arnhold
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-10embeddedobj: simplify deprecated XTypeProvider.getImplementationIdStephan Bergmann
Change-Id: I977e4af1cd4a2c960aee0b7d1058041fd31608d5
2014-03-04OLE: Turn an OSL_ENSURE() into a real condition.Jan Holesovsky
This is part of some STAMPIT workaround; no idea what it is, but for sure it causes problems with PowerPoint OLE in Writer - so let's avoid updating if it is not "STAMPIT". Change-Id: I266b419ba3461c547f7ee8e447ef64a47a8511e8
2014-02-27Exclude WNT-specific includes on other platformsStephan Bergmann
Change-Id: I7eeae61275269e09092267f2a6ccb27d7bb91ddb
2014-02-26Remove visual noise from embeddedobjAlexander Wilms
Change-Id: I63ce6896e2f82160ffedb9f6123ca765f49698c5 Reviewed-on: https://gerrit.libreoffice.org/8256 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-17comphelper: sal_Bool -> boolStephan Bergmann
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-03fdo#54938 Convert to cppu::supportsServiceAlexandre Vicenzi
Change-Id: I512c525029ebd63d261560d27e9f38bbe94f7e10 Reviewed-on: https://gerrit.libreoffice.org/7649 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-01-30Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-29bool improvementsStephan Bergmann
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-28Fix apparently broken OSL_ASSERT (that would have never fired)Stephan Bergmann
Change-Id: I0a79282466879f00f47e00aa646f827dfe028712
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-10Use boolStephan Bergmann
Change-Id: I7b7be27bc2e6fe73811b800945d7c6dbd8248034
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-06Default OMultiTypeInferfaceContainerHelperVar equalImpl parameterStephan Bergmann
...and assorted OUStringHash clean up Change-Id: I779904e1275e8df88f567beb388d1d11af9e9671
2013-11-29Catch block smells like leftover debugging codeStephan Bergmann
...especially as it doesn't change hr from S_OK, and compiling with /EHsc (instead of /EHa) reveals that OleRun does not throw any (C++) exceptions (and thus produces an "unreachable code" warning for the catch block). Change-Id: Ic34e83e6ede3a214ccb073e3e54d6fcc493d46ea
2013-11-20Windows: Require at least Windows XP SP2Thomas Arnhold
* Windows XP SP2 is 0x0502, see http://msdn.microsoft.com/en-us/library/aa383745.aspx * If a module changes the Windows SDK version setting, this is done module wide now. So the overall behavior is as before. This seems to be the best compromise for now. * We need at least SP2 because of the bluetooth stuff used in sd/source/ui/remotecontrol. * Now, we require at least Internet Explorer 7.0. IE6 has been outdated for a long time. * Leave StdAfx.h file definitions, as those are Microsoft project specific precompiled header files. * All local definitions of WINVER are removed, because the global WINVER setting makes them obsolete now. To the relation of the three macros: Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION automatically to the same value as _WIN32_WINNT. WINVER and NTDDI_VERSION can be set idenpendently each for itself. Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb Reviewed-on: https://gerrit.libreoffice.org/6496 Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-11remove unnecessary use of OUString constructor in EMBEDDEDOBJ moduleNoel Grandin
Change-Id: I60bbdd2a2592a1e5333abe50711aa227786ce935
2013-10-23clean up some include guardsThomas Arnhold
Conflicts: sw/source/ui/inc/content.hxx Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6 Reviewed-on: https://gerrit.libreoffice.org/6388 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-22fdo#68849 add some header guardsThomas Arnhold
Change-Id: I1cd598fba94e337c2ccad68a4a888743aeb292f0
2013-10-07fdo#54938: Adapt supportsService implementations to cppu::supportsServiceMarcos Paulo de Souza
Change-Id: I683c0d30c3286ed5d725d4eefe8b3977b82ee316 Reviewed-on: https://gerrit.libreoffice.org/6035 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-02-Werror,-Wunused-variableStephan Bergmann
Change-Id: I9d09f8b632f568637f0a2ccb1ff62ce5d3d5afed
2013-09-29don't use SAL_WARN to log callsMarkus Mohrhard
Change-Id: Ia9ac8ff7d187cab9d158ffe97fb2d5faca269638
2013-09-24embeddedobj: if the service is missing, log its nameMiklos Vajna
Related to https://gerrit.libreoffice.org/6019, so we can find out the name of the missing component. Change-Id: I1a006403def0b29f7391449a9b6124df40446851
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21osl_getThreadIdentifier(0) -> osl::Thread::getCurrentIdentifier()Stephan Bergmann
Change-Id: Ida9785c4b9fda0459769957734952e69d7a9de44
2013-07-19remove Application::GetWorkAreaPosSizePixelNoel Grandin
This internal API has always been problematic because we cannot support it under the Linux toolkits, where it has in fact always just returned the size of the screen. Change-Id: I406bcbca8a4161b4261ef46940823bb07c6ad18b Reviewed-on: https://gerrit.libreoffice.org/4976 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-05-31fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFORadu Ioan
- replaced RTL_CONTEXT_ with SAL_INFO - replace OSL_* with SAL_* Change-Id: Id4e90b83a7275bfd30914f7514a609cebbfbf4ac Reviewed-on: https://gerrit.libreoffice.org/4044 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06No need for conditionality has been turned on since 2004Tor Lillqvist
Change-Id: I0e1708f1102dab8e0424d12b50da25f726e8a5f6
2013-05-02Resolves: #i113605# missing :ReleaseStgMedium() call on STGMEDIUM objectJian Fang Zhang
which causes obvious memory leaks Found by: zhangjf Patch by: zhangjf (cherry picked from commit e0d9b7a23ca3e7ba181134cd89f3f18233031ef1) Change-Id: I5f99f8cf02e155e5284df3df89feb49d9a30c2c1
2013-04-15fdo#60724 correct spellingThomas Arnhold
Change-Id: I3d978cb657647b4a4e9709258c6a6a4ac1d339a9
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-05Replace `compareTo(...) == 0` with ==Ashish Banerjee
Proposed patch for the following issue: https://bugs.freedesktop.org/show_bug.cgi?id=62096 Change-Id: Ib83a9051ea12c53642f781e5427a6ca728049a7f Reviewed-on: https://gerrit.libreoffice.org/3198 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-03-19removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarationsThomas Arnhold
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b Reviewed-on: https://gerrit.libreoffice.org/2835 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold
Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-04doubled includesThomas Arnhold
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e