summaryrefslogtreecommitdiff
path: root/embeddedobj
AgeCommit message (Collapse)Author
2015-05-19tdf#67421: Prevent unloading objects due to cache fullMike Kaganski
When an object is added to OLE objects cache, when cache is full, old objects are tried to be unloaded. This triggers notifications that cause all loaded objects to become active, and to be added to cache (moved to front). As the new object already was added to front of the cache, later activity pushes it to back, until it is the last object in cache. The cache in this process is overfilled, so each next refresh tries to unload current last OLE object. So, in the end, this effectively unloads all cached OLE objects. This patch prevents this by first unloading last object, and then adding new object to front of cache. Also, removed needless creation of reference (makes at least 200 function calls for no reason). Change-Id: Ia903f4df101971df1b0b0148320fc8e45ac1e79c Reviewed-on: https://gerrit.libreoffice.org/15772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-05-10Use IMPL_LINK_NOARG[_TYPED] where applicableStephan Bergmann
Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann
Change-Id: Ic91c8126b8e9a5a7eeed4c356b783c8bebccecf3
2015-05-04embeddedobj: allow creating objects lacking a FileFormatVersion=6800 filterMiklos Vajna
dbaccess::ODatabaseDocument::loadFromStorage() is still not implemented, though. Change-Id: I1be11f2a2274f67dd0a11f96a718394d5f72605f
2015-04-30embeddedobj: allow embedding objects lacking a FileFormatVersion=6800 filterMiklos Vajna
The "own" filter of Base has FileFormatVersion=6200. Change-Id: I3bbd28ebcf4d517ea9cefe692b01b688358c51e8
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-13loplugin:staticmethodsNoel Grandin
Change-Id: I33a8ca28b0c3bf1c31758d93238e74927bebde9c
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: I1ee944679d509929e47218f88b6fe4be4905a202
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: Iad5d2858976ed789823aaac3aa7f2937233f1dfc
2015-03-27avoid activating chart objects just to get their mapunit or set visual sizeCaolán McNamara
the motivation is SwWrtShell::CalcAndSetScale and the assert/crash triggered by ooo58458-1.odt ooo84729-2.odt ooo75058-1.odt ooo123605-1.odt ooo102990-1.odt fdo57249-1.odt fdo50880-1.odt fdo70223-5.odt ooo30052-2.odt ooo119280-1.odt ooo79009-1.odt ooo58182-2.odt ooo59992-1.odt ooo123607-1.odt ooo89304-1.odt ooo91578-5.odt ooo89303-1.odt ooo30052-1.odt fdo65664-3.odt ooo119941-1.odt ooo55761-1.odt fdo57249-2.odt ooo83229-3.odt ooo84729-1.odt ooo102990-2.odt ooo37749-1.sxw ooo38798-1.sxw ooo27909-1.sxw getMapUnit activates the object which can cause chart object to load data from the current document and appears to attempt to stop and resume pending layout actions which can't be done if layout is underway, hence the assert from the inner SwLayAction::SwLayAction triggered by the runstate while an SwLayAction::SwLayAction is already active for counting the number of pdf output pages. getMapUnit always returns the same result regardless of anything else and the assumption is that we don't need to be in run state to setVisualSize on it Change-Id: Ie75b159b140de223a56324b39699d703c3b40bb9
2015-03-09V801: Decreased performanceCaolán McNamara
Change-Id: I9e9a00acf9503980f0c6c7cd0a20378e5ca7390d
2015-03-05gbuild: set _WIN32_WINNT globally instead of WINVERMichael Stahl
... and remove the definitions in makefiles, except in fpicker, which defines a different value for the Vista file picker. The WINVER value is derived automatically from _WIN32_WINNT by SDK header sdkddkver.h. Change-Id: I73358a9bf5d070f71821654cae2a29335a754a21
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-14tdf#88624 set DocumentBaseURL when saving reportLionel Elie Mamane
regression from 1d38cb365543924f9c50014e6b2227e77de1d0c9 Change-Id: Ia8cfe47b9d92889b3724f394db5090a59e69dd48
2015-02-02add an explicit virtual keyword here, like the other onesCaolán McNamara
Change-Id: I4c5acf42d5ec33df1dd18dc3a70be7de838c9ff3
2015-02-02OOoEmbeddedObjectFactory does implement optional XLinkFactoryStephan Bergmann
regression from 251f1b0b38be7d1267339898e44e320f05849e22 "fdo#46808, Adapt embed::*EmbeddedObjectCreator UNO services to new style" Change-Id: Id8b49c04183d3bc98f22398a8e43c80909c1ea11
2015-02-02callcatcher: remove some unused methodsCaolán McNamara
Change-Id: Id3ca991e9ede13512a39865496429aabb7e71088
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-20Some more loplugin:cstylecast: embeddedobjStephan Bergmann
Change-Id: Iea3b2ca4f2598c501206ab631f86d9aa44a0407c
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2014-12-22bnc#822341: PPTX export of embedded text documentsZolnai Tamás
-Make embedded text documents exported by analogy with spreadsheet embedded documents. -Convert MS ole objects to LO sepcific objecst to allow exporting those ole objects too. Plus use gb_CppunitTest_use_rdb instead of wasting time on finding out which missing components cause test failing. Especcially when we have platform dependent components (e.g. related to embedded object) Change-Id: Ic76d659b51274777a1669c215344a1169ebcba81
2014-12-18embeddedobj: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I149dd1abf03437bb58829a5f16a8c2aef5eec092
2014-12-15fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I026999d6e995185c42df6770a1a700094540d08a Reviewed-on: https://gerrit.libreoffice.org/13454 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-24typo: unknownAndras Timar
Change-Id: If89443c1668ca01c826c8fc353b20097c7da7bf4
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-11coverity#703952 Unchecked return valueCaolán McNamara
originally return was checked in commit c37f4bb94a119e4031796c097a35c1217e221e6c Date: Tue Nov 4 13:30:21 2003 +0000 #112739# add breakLink method then use of bElExists was removed in commit aec29756d7e058b47dc8dcef79bc93c3e9c61928 Date: Fri Nov 14 14:24:28 2003 +0000 #112923# ole implementation related changes at which point this line should have been removed, but it wasn't later at commit 00b1faf239dbf676178dcaa0d15a1678d1148a0d Author: Jens-Heiner Rechtien <hr@openoffice.org> INTEGRATION: CWS warnings01 (1.19.10); FILE MERGED 2005/11/03 10:31:40 cd 1.19.10.1: #i55991# Warning free code for gcc this still wasn't removed, just bElExists commented out Change-Id: I1af2635558cd4f47da06e148e45489f522e0183f
2014-10-01loplugin: cstylecastNoel Grandin
Change-Id: I9fca98995131358b3b112b11e0b28feb1a3267d1
2014-08-29Add a border to opengl chart to make it easier to handle.Zolnai Tamás
Change-Id: I74bc636dc0a37d70f45fe2eac0b8b60e3f6318bb
2014-08-29Make opengl chart window always activeZolnai Tamás
Fortunately there is a special ole object group with the MS_EMBED_ACTIVATEWHENVISIBLE flag which define this behaviour. Problem is that both Aspect and EmbedMisc are MS specific enums so we can't use them directly for non-MS objects. But we can handle opengl charts the same as this ole object group. Change-Id: I49abeffce319cbb775709a72ba198a1f76b65374
2014-08-27bnc#648251: Avoid crash when attempting to open embedded OLE object as "text"Tor Lillqvist
On non-Windows, when double-clicking an embedded OLE object, our glorious content type detection logic detects it as "Text". As a side-effect, we start to calculate text statistics on it. Which surely could produce interesting numbers (you know what they say about statistics), but sadly causes a crash involving the ICU RuleBasedBreakIterator, SwScanner, sw::DocumentStatisticsManager and whatnot. Avoid this by checking for a detected filter of type "Text" explicitly, and avoiding the fun code paths in that case. This leads to double-clicks being just ignored. Maybe it would be more useful to produce a "General OLE Error" message box? Change-Id: Iae0726b5e9c511a92bdff7229d2978cbf76cb07b
2014-08-19java: no need to instantiate String objects directlyNoel Grandin
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-14java: remove commented out codeNoel Grandin
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-05java: remove commented out codeNoel Grandin
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-11bnc#883684: Better fix for this.Kohei Yoshida
Instead of making all chart objects exempt from unloading, check each OLE object on whether or not it already has its persistent storage created. If not, don't unload it else it would have nothing to load back from once unloaded. Change-Id: I2312e86c9376d3699ef4aa1e0cf2f4c04f706c1e
2014-07-11new loplugin: externalandnotdefinedNoel Grandin
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-06-19fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-05-27remove unnecessary use of Reference constructor in throwNoel Grandin
Convert code like this: throw IOException("xx", Reference< XInterface >(static_cast<OWeakObject*>(this)) ); to this: throw IOException("xx", static_cast<OWeakObject*>(this) ); Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27remove unnecessary use of OUString constructor when throwingNoel Grandin
Change-Id: I4a3f3f911dcfbf88696053215a2fb7a94678244c
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-11 00:11:17 +0000