summaryrefslogtreecommitdiff
path: root/extensions/source/plugin
AgeCommit message (Collapse)Author
2014-07-02coverity#983658 Uncaught exceptionCaolán McNamara
Change-Id: I99cb4f64b093765d0667ddcddf1f696891450a9a
2014-06-24more mac build fixNoel Grandin
Change-Id: I4d0f1c21aed9bbcc97f432b0f1872c508853708c
2014-06-24fix mac buildNoel Grandin
after my commit e2080e7 "new compilerplugin returnbyref" Change-Id: Iec1663507ddda009903c31aa3ceedfe5380c1962
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-05-22Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19Julien Nabet
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-11Fix previous commit (extensions part)Julien Nabet
Change-Id: I942cca3639e4d823415da557262e35432a798d04
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-09postwin.h handles OPTIONAL alreadyThomas Arnhold
Change-Id: Ia04bc545f90a093f70bbd7036b7b9403af15daa1
2014-05-07The opaque PostUserEvent IDs are actually pointersStephan Bergmann
...so declare them as such. This avoids the recurring mistake of storing such IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to potentially not remove the event, it thus firing "too late" and probably causing a crash. While at it, consolidate the trivially unnecessary overloads of both Application::PostUserEvent and Window::PostUserEvent. And in each of them, it looks like deleting the mpLink member was missing from the failure branch. Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-02extensions: sal_Bool->boolNoel Grandin
Change-Id: I1730f99c08690138e9aa7aba54304fd7bc51491d
2014-04-19fixincludeguards.sh: extensionsThomas Arnhold
Change-Id: If652bce4cf7621795b084bcbc0aa4c46dd903878
2014-04-13Clean up function declarations and some unused functionsStephan Bergmann
Change-Id: Ie81d270267b6c3c3620ade62eb393b28d995a654
2014-04-11replace some SvStream seeking with calls to remainingSize()Michael Stahl
Change-Id: I2905e98425b9991d6138ab0adc15083d313ca445
2014-04-09Whatever those odd dummy function definitions were supposed to be good forStephan Bergmann
...introduced in d2237276cb3e32493ff8f9f71e06301937434622 "INTEGRATION: CWS vcl09 (1.6.10): #109426# make rpnp.so work on Linux" without any explanation, but probably a misguided attempt at getting things working in the face of a missing libgcc_s.so or libstdc++.so (though the names used here do not match any there), and seemingly not necessary. Change-Id: Ib092d426f4acfd3ece30adb754c1bb76d4eca381
2014-04-04Fix a memory leak by freeing last pBytesTakeshi Abe
Change-Id: I7d170d704fa8950057698856d12df63992e38381 Reviewed-on: https://gerrit.libreoffice.org/8822 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-02Avoid possible resource leaks by boost::scoped_arrayTakeshi Abe
Change-Id: Ibf92b3098c50388d8b6d27f4476e613a1f8918b5
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-19coverity#984088 Uninitialized pointer fieldCaolán McNamara
Change-Id: I228f7c8f99b0cc3117fbeab78efbeddd74896d54
2014-03-04fdo#54938: Convert some places to use cppu::supportsServiceMarcos Paulo de Souza
The last cases are non obvious, so it's pratically done Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547 Reviewed-on: https://gerrit.libreoffice.org/8445 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-02-27Remove visual noise from extensionsAlexander Wilms
Change-Id: I0397d0d0e5343b7ed192a790664b068ac6955bd3 Reviewed-on: https://gerrit.libreoffice.org/8259 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-24harmonize Tell() Seek() type.Norbert Thiebaud
Change-Id: I2e472aa0279d0763762d3c660207cd74da512626
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-10Be explicit when using bool as integral valueStephan Bergmann
Change-Id: I21e24bd39a0872df3077d45c257251c253957489
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-05Fix fallout from 461e0f9eaf9895ecd0eba67b35a4d2cec8a5e5c5Tor Lillqvist
Change-Id: Ic4dc1c106ebcce7d27844551efca43cabb31c4ae
2013-11-21remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsLNoel Grandin
Convert code like this: if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aStr == "rem") which compiles down to the same code. Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
2013-11-20Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"Noel Grandin
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295. I mistakenly converted OUString::equalsL calls to OUString::startsWith calls.
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL callsNoel Grandin
Convert code like: if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aByteStr.startsWith("rem")) Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OStringBuffer constructorNoel Grandin
Convert code like: OStringBuffer aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OStringBuffer aKeyName("NDX"); which compiles down to the same code Change-Id: If9c96a290bc18cc8285fb733f27be58c6958b63c
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11convert OUString !compareToAscii to equalsAsciiNoel Grandin
Convert code like if( ! aStr.compareToAscii("XXX") ) to if( aStr.equalsAscii("XXX") ) which is both clearer and faster. Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11remove unnecessary use of OUString constructor in EXTENSIONS moduleNoel Grandin
Change-Id: Idf73eb831f52d4d74e6fbb6ea27f59ebbfd13a8c
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-20drop unnecessary tools/string includesCaolán McNamara
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-01convert extensions module from String to OUStringNoel Grandin
Change-Id: Ia0cb9fe1eaebdd295fb1742074fe2c48be61c077
2013-09-19WaE: cast to 'void *' from smaller integer typeTor Lillqvist
Change-Id: I85d4a4c3c7bf708daa85dbe7f3af54311c4d7e2e
2013-08-21osl_getThreadIdentifier(0) -> osl::Thread::getCurrentIdentifier()Stephan Bergmann
Change-Id: Ida9785c4b9fda0459769957734952e69d7a9de44
2013-08-18Use subfolder names from <config_folders.h>Tor Lillqvist
Change all instances of hardcoded "program", "share" etc subfolder names to use those from <config_folders.h> instead. In normal builds, the end result will not change. Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-07-29Remove effectively unused INetURLObject OString overloadsStephan Bergmann
Change-Id: Icbbe27b229d5454d27be646e00e8b362a77359b3
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29Search for char instead of 1 char long string, when possible.Thomas Arnhold
follow-up of a7674482254ee996b1c4fee60f3064778be369aa Change-Id: I25f40c601454c092078307d931333af1bc1447ac
2013-06-18fdo#43460 connectivity,extensions,filter,idl,idlc: use isEmpty()Jelle van der Waa
Change-Id: I78ba286be5aa4d731f734e5eb16adb77c686aad9 Reviewed-on: https://gerrit.libreoffice.org/4325 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-10mingw64: cast to pointer from integer of different size in extensionsFridrich Štrba
Change-Id: Ie2162b71e4e9de9fe24ce54815e5139774bb2ec0
2013-06-06Slowly, but surely going on compiling for mingw64Fridrich Štrba
Change-Id: I590aa6a854a040281bf73d5be768c05d4906a984
2013-06-03re-base on ALv2 code. Includes:Michael Meeks
Patches contributed by Mathias Bauer gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 http://svn.apache.org/viewvc?view=revision&revision=1397337 http://svn.apache.org/viewvc?view=revision&revision=1397315 http://svn.apache.org/viewvc?view=revision&revision=1396797 Patches contributed by Andre Fischer Fixed getcsym.awk to handle #-comments that contain special regexp chars. http://svn.apache.org/viewvc?view=revision&revision=1230971 118778: Added ADDITIONAL_REPOSITORIES environment variable and its automatic setup in configure. http://svn.apache.org/viewvc?view=revision&revision=1232004 118160: Added external CoinMP library. http://svn.apache.org/viewvc?view=revision&revision=1233909 Patches contributed by Herbert Duerr #i119168# use generic LICENSE file for langpacks and sdks http://svn.apache.org/viewvc?view=revision&revision=1310178 macosxotoolhelper: need to quote perl regexp if it may contain regexp metachars http://svn.apache.org/viewvc?view=revision&revision=1183367 allow gbuild with empty sysroot on linux http://svn.apache.org/viewvc?view=revision&revision=1179186 Patches contributed by Ingo Schmidt native373: #164472# improvements for msi database http://svn.apache.org/viewvc?view=revision&revision=1167540 http://svn.apache.org/viewvc?view=revision&revision=1167539 Patches contributed by Jurgen Schmidt adapt setup package scripts to handle special DS_Store file for developer snapshot builds http://svn.apache.org/viewvc?view=revision&revision=1232430 imported patch extensions_i117681.patch http://svn.apache.org/viewvc?view=revision&revision=1172102 Patches contributed by Michael Stahl gbuild: RepositoryFixes.mk should be optional http://svn.apache.org/viewvc?view=revision&revision=1166123 xslt filter: remove the FLA horror wordml import filter: replace FLA usage with plain XSLT http://svn.apache.org/viewvc?view=revision&revision=1363727 Patch contributed by Oliver-Rainer Wittmann i#88652: applied patch, remove unicows deps http://svn.apache.org/viewvc?view=revision&revision=1177585 Remove lots of OS2 conditionals, re-extract Rhino Java, unwind cppunit pieces, cleanup Mac image bits, remove coin-mp and re-package lpsolve, Oxygen & Crystal, fixup qstart bits, expand MPLv2 subset checking. Change-Id: Iad5c8a76399620b892671633c0d8c29996db3564
2013-05-07-Werror=unused-macrosStephan Bergmann
Change-Id: I9fd616930eb0b336ce89e97bc333f19d4cf449ae