summaryrefslogtreecommitdiff
path: root/extensions/source
AgeCommit message (Collapse)Author
2015-04-13Related: tdf#90472 initial load of bibliography doesn't...Caolán McNamara
set bibliography type moving to a new row will set the new type, but initially its not set because the ListStore property was set after the model is connected to the database so at the initial connection time there isn't a available set of values to map the row to. So move that connection code from general.cxx to datman.cxx and put it before the connection is established we can then remove the intermediate aBibTypeArr list and those resources then need to be global bib ones. (cherry picked from commit 3e41b069bcc1482eb4d3fabb6d475db4bf3d4e57) Conflicts: extensions/source/bibliography/general.cxx Change-Id: I12276c3df9955ec399e1b5de6d0836c69ebb1ebb Reviewed-on: https://gerrit.libreoffice.org/15219 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-04-09Resolves: tdf#90473 bibliography doesn't resize after reloadCaolán McNamara
resize *after* setting visibility of controls and not before Change-Id: I9318b8a5bc1f4afc6f4ceb4503af3425d0f6364b (cherry picked from commit 1ad3ed20071c81e031c1ed7f546c37fd280803c0) Reviewed-on: https://gerrit.libreoffice.org/15212 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-01-27Resolves: tdf#88819 printing with ps hangsCaolán McNamara
regression from commit bbf3aa7f92c194c9cc4546c95706e6b28e0c070c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Nov 14 11:06:44 2014 +0000 coverity#705989 silence Insecure temporary file and coverity#705983 Insecure temporary file Change-Id: If580196322e68098adc38a9fdb775827843a9c30 Reviewed-on: https://gerrit.libreoffice.org/14202 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-12-05-Werror,-WuninitializedStephan Bergmann
(in PropertyComposer ctor: base class 'comphelper::OBaseMutex' is uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex') Change-Id: I41ede9ab34e89c8dde23ce2e4fd6393b05c979c6 (cherry picked from commit da9fd02a4d1a36cf9d22d5b36ba36240585284f6)
2014-12-04fdo#65163 reintroduce embedded picture for form componentsLionel Elie Mamane
but not for report components (fdo#53001) Change-Id: Ie07e1c2993304d4deb2124e72baa7a326b587918
2014-12-04Revert "coverity#735424 Logically dead code"Lionel Elie Mamane
This reverts commit 1f22e2f954baeec825190ded03510cb6c8069d93. in preparation for fix for fdo#65163 Conflicts: extensions/source/propctrlr/formcomponenthandler.cxx Change-Id: Ifa252ac66724dd3e4b257e3bb6679d9503f8a9db
2014-11-23capitalize e-mail in list of types in bibliographyStanislav Horacek
Change-Id: I4ea55cf421d9e5c8add2dd0a7197d842c5ac7571 Reviewed-on: https://gerrit.libreoffice.org/13077 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14coverity#705989 silence Insecure temporary fileCaolán McNamara
and coverity#705983 Insecure temporary file Change-Id: I2a501f8114ddf8968381e1880263abaf9d1bdc6f
2014-11-14coverity#1242860 Unused valueCaolán McNamara
Change-Id: Id0bb878464fa6df5ed23d4abf5748ed21cb30506
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11cleanup improper SOLARIS linker libs and optionsRichard PALO
and, most importantly, forget MOTIF! Change-Id: I0230932618b396ec4d5bf7638a13e5a80a4fada0 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04-Werror,-Winconsistent-missing-overrideStephan Bergmann
(loplugin:saloverride does not warn about them because they depend on template args) Change-Id: I41a1dbfd7db24e58154f6f3810781219119418ba
2014-11-01coverity#703954 Unchecked return valueCaolán McNamara
Change-Id: Ifc8a4c2a3f22fc12b620a3bd0dd8ace57a99629c
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-30nothing to see here, move alongCaolán McNamara
brown bag fix for commit cdbfbd0f7c3ed3bd3235f97197d279c41913245b Date: Thu Oct 30 09:21:40 2014 +0000 coverity#735608 Division or modulo by float zero and coverity#735607 Division or modulo by float zero Change-Id: I8e04765cf5354d57a54b166a5e2af71b40b670bb
2014-10-30coverity#735608 Division or modulo by float zeroCaolán McNamara
and coverity#735607 Division or modulo by float zero Change-Id: Iceeab702e183d291d7b1b6ded9113d1a15163c94
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29ref-counting vcl::Window subclassesNoel Grandin
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28fdo#84938: replace TIMEF_ constants with enumNoel Grandin
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: https://gerrit.libreoffice.org/12114 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27coverity#982164 silence Unchecked return value from libraryCaolán McNamara
Change-Id: Ie2479e3dc73a7c7e8d2d0c5c979bde2ea5d05a1e
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-25coverity#982164 silence Unchecked return value from libraryCaolán McNamara
Change-Id: Ibec38a7e7846c463601b0a876778f53003cf0441
2014-10-25coverity#982163 silence Unchecked return value from libraryCaolán McNamara
Change-Id: I6b9a3c6ce75472da551706b1c1555eff4ba1abc8
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02coverity#1242860 Unused valueCaolán McNamara
Change-Id: Ibd6d737cf117af0c2fdda7768da6a173c59bd346
2014-10-01loplugin: cstylecastNoel Grandin
Change-Id: I6ea98852ba775d85ccd54823b67224ea7f587c65
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30extensions: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I2d9d2e145584013d8e94f5aea2ec7732452b240c
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29loplugin: cstylecastNoel Grandin
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26coverity#983665 Uncaught exceptionCaolán McNamara
Change-Id: I3d0cd9a9bde8c3705abd876e832b6b7e56bb7fad
2014-09-25comphelper: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I364d6252f470dcc6d71a191f1249e95ca1f284ce
2014-09-23Leftover XLIB_Window -> WindowStephan Bergmann
Change-Id: I51aa3e3fbf440bbd16d43ab8113cd69937060bf3
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23Use prex.h/postx.hStephan Bergmann
Change-Id: I055ae0426df86a1ea49385bc8c0b176cc4b9d940
2014-09-18Blind fix for WindowsStephan Bergmann
Change-Id: I1b923cba578b0acc2b9ce389c6c7d664fa00b268
2014-09-18Blind fix for WindowsStephan Bergmann
Change-Id: I186024f8a95ada752115750419a54a6231967f57
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>