summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)Author
2016-08-19tdf#89329: use unique_ptr for pImpl in datasourcehandlingArnold Dumas
Change-Id: Ib019d26a72d234245cc1a7322bfbfb11705f29d3 Reviewed-on: https://gerrit.libreoffice.org/28231 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-18cppcheck: passedByValueCaolán McNamara
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
2016-08-15tdf#100782 have XPropertyList hold unique_ptrJochen Nitschke
Change-Id: I928f297e1be76b965898d83cb3dd2e79b23b7974 Reviewed-on: https://gerrit.libreoffice.org/28095 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11tdf#96015 (part) links to Askbot in the Help menuOlivier Hallot
Add the entry "~Get help online" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/forum/?&LOlang=<lang> <lang> is obtained from .getLocale() That in turn will redirect to e.g. askbot (but only few languages are using it at the moment) or other nl-specific resources. (nl-projects can request corresponding targets from infa, without the need to change the code – cf rdm#1983) The link can/should be extended to also include the version of LO and the currently used module to allow finer grained redirects. Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56 Reviewed-on: https://gerrit.libreoffice.org/27028 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-08-09loplugin:sallogareasMichael Stahl
Change-Id: I3443ed8d481d7a0ac72c03c4d0fd0bcf100a09b6
2016-08-08it is possible that Sources is emptyMarkus Mohrhard
See e.g. http://crashreport.libreoffice.org/stats/crash_details/570429b8-21e3-494e-9677-ea95fa8a5293 Change-Id: I8c05efd61fa5a91511c06c660c49a0c470a96c88 Reviewed-on: https://gerrit.libreoffice.org/27947 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-05loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I9bc14b4df6bdda68bae44a1972e6b412fa6adccb
2016-07-07Related: tdf#92478 speculative win64 scanning fixCaolán McNamara
TWAIN-2.3-Spec.pdf says... All TWAIN 2.x Sources must be prepared to work with either TWAINDSM.DLL or TWAIN_32.DLL, which may still be used by older Applications. The TWAIN DSM is a shared library named TWAINDSM.DLL. There is a 32-bit and a 64-bit version of this file. Change-Id: I047d872271573a5b2efc3ee2af4ecfc4e142a2b2 Reviewed-on: https://gerrit.libreoffice.org/26541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-05merge BibTabPage with BibGeneralPageNoel Grandin
Change-Id: I16a80e7e98fdd2be08b5a8ce586b709a3720e694 Reviewed-on: https://gerrit.libreoffice.org/26929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-29Move accessibility relations to .ui files, Part 12: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. As of this commit, all accessible relations have been moved to .ui files other than a few exceptions. Change-Id: Ic9dffdde414d245c13f13ee08543f90884991222 Reviewed-on: https://gerrit.libreoffice.org/26707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-28Simplify some PutProperties callsStephan Bergmann
Change-Id: Idf91592e6cf34b5591f221c3c5bdc937bbe46014
2016-06-24compilerplugins: add OWeakObject::release() override checkMichael Stahl
Change-Id: I767857545d7c91615cf162790c04f0016de9fdf6 Reviewed-on: https://gerrit.libreoffice.org/26555 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22valgrind: use after freeCaolán McNamara
sal/osl/unx/conditn.cxx:90: pthread_cond_destroy failed: Device or resource busy sal/osl/unx/conditn.cxx:92: pthread_mutex_destroy failed: Device or resource busy "Desktop disposed before terminating it" seen under valgrind with CppunitTest_sccomp_lpsolver Change-Id: I643cf114b902c38a6a54487fd78c55d84ed78cfc
2016-06-19coverity#1362777 Explicit null dereferencedCaolán McNamara
Change-Id: I5db9cf469677b8509c19d6489472a4cf0babeca5
2016-06-18Fix simple typo in parameter nameMuhammet Kara
Change-Id: I8c4a5e701c20c70c7df091a34efb38936ee59f9d Reviewed-on: https://gerrit.libreoffice.org/26420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-17Resolves: tdf#96251 address wizard crash when run from start centerCaolán McNamara
Change-Id: I20de1fbdd3ca609a1818dfe8f81ba66b1cb15281
2016-06-13tdf#43157 Clean up DBG_ASSERTkrishna keshav
Change-Id: I2a7d5d507a875e555441a9d30d54e638e5dea026 Reviewed-on: https://gerrit.libreoffice.org/26099 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-13loplugin:sallogareasNoel Grandin
Change-Id: I6ce045db236b81aa8bc7bce2a0e20c4132c5931f
2016-06-12Resolves: tdf#92478 avoid crash on using scanner on windows x64Caolán McNamara
which appears to correspond to backtrace http://crashreport.libreoffice.org/stats/crash_details/ad46ef89-6b98-44f9-b060-ccb25015269d Change-Id: Ic5a4b66028db6ba4aea08baf5bf4a672f71745a0 Reviewed-on: https://gerrit.libreoffice.org/26197 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-06-12convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-10Clean up uses of Any::getValue() in extensionsStephan Bergmann
Change-Id: I67b9127d8aa67a702086ef5bc61372ae54c2142e
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08merge cond. blocks to oneDavid Tardon
Change-Id: Iad5858955244e12a849336f84938a39b6f3219e0
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06remove unused constants in HRC filesNoel Grandin
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02DataAccess.xcs says xs:short not xs:int for this typeCaolán McNamara
noticed when examing tdf#96251 Change-Id: Iec8748ad323bcb59e8e1f6b4135b4a3b313a6e44
2016-06-02Remove SetAccessibleRelationLabeledBy calls tdf#87026Muhammet Kara
And make proper changes in the related .ui files Change-Id: Iea998b6de25831c08950a8afa725713288113bfa Reviewed-on: https://gerrit.libreoffice.org/25807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01extensions: more READMEMichael Stahl
Change-Id: I9cd902ce606c800e67cc142daf698962544b26bc
2016-06-01tdf#99643 OLE automation bridge: fix 64-bit pointer conversionsMichael Stahl
XBridgeSupplier2::createBridge() is always called in-process and should therefore expect and create Anys with native-sized encoded pointers, so use sal_uIntPtr. Change-Id: Ia757ff38568b07de8085a1a9d323d806bcca0f63 Note: Currently all calls in LO code are with source=UNO, target=OLE.
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Some clean up of uses of css::uno::Any::setValueStephan Bergmann
Change-Id: I04e8aef35a6083b61d775c8eb3f96757da2b31bd
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert VclAlign to scoped enumNoel Grandin
Change-Id: I03718cc63ec5c1260ebd599bddb1a787ca8f5788 Reviewed-on: https://gerrit.libreoffice.org/25603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16)Noel Grandin
and put an assert in SfxPoolItem::SetWhich() so nothing new creeps in. Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df Reviewed-on: https://gerrit.libreoffice.org/24324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26loplugin:unusedmethodsNoel Grandin
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-25Fix typosAndrea Gelmini
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Revert "remove some manual ref-counting"Noel Grandin
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-21tdf#97221 restore original message for failed check of updateStanislav Horacek
the message is not specific for server errors Change-Id: If282acfaefa4fc5843757dff730dd84ece528210 Reviewed-on: https://gerrit.libreoffice.org/25217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-04 11:25:21 +0000