summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)Author
2018-10-09tdf#120264 - Access to "Get Involved"heiko tietze
UNO command SID_GETINVOLVED added with access to the website from all main menus under Help Dispensable ellipsis removed from other UNO commands around Help Change-Id: I79536be3de31f55a7b208bcdd5a243e05b3d3668 Reviewed-on: https://gerrit.libreoffice.org/61238 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-09tdf#120318: remove autofilter for the momentJulien Nabet
Before adding it the entry again, please implement it and test it. See comments of the tdf. Change-Id: I64a5729baf589dbd188b6e8fcd5075112e5a7da7 Reviewed-on: https://gerrit.libreoffice.org/61558 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-08tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-07weld ListSelectionDialogCaolán McNamara
Change-Id: Id2aaec88bd864167e0815ddb675c27b10331247f Reviewed-on: https://gerrit.libreoffice.org/61482 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07weld NewDataTypeDialogCaolán McNamara
Change-Id: Ice5146e72baba397e60fbcb8d64d1ddaeb32e45c Reviewed-on: https://gerrit.libreoffice.org/61481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06make OGenericUnoDialog take an awt::XWindowCaolán McNamara
Change-Id: I7c63397d0579306f4ade1947ce5bf9e1866bf876 Reviewed-on: https://gerrit.libreoffice.org/61469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Related: tdf#93372 fix up extensions character dialogCaolán McNamara
Change-Id: I3609f8bd6a23e6f419bba88c17bc7d82a5d3b993 Reviewed-on: https://gerrit.libreoffice.org/61266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24make all the related inheritences formatted the same wayCaolán McNamara
Change-Id: I2e0c060a86cd199a640589a7599fa5f01ef77e3b Reviewed-on: https://gerrit.libreoffice.org/60943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Looks like these functions can be static and not STDAPIStephan Bergmann
...as they appear to only be called from within this .cxx. (And <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> documents that STDAPI expands to a return type of HRESULT, among further decoration.) Change-Id: I4994e6e6f8fe0466f9aa9b4c9cf2c20bd718fa05 Reviewed-on: https://gerrit.libreoffice.org/60925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-18loplugin:external (macOS)Stephan Bergmann
Change-Id: Ib06572a844d2999e9ecd91e26abd98ecec06a0ae Reviewed-on: https://gerrit.libreoffice.org/60665 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-18use nullptr instead of reinterpret_cast<void*>(0)Noel Grandin
Change-Id: I1b424fd2fbf524c36746e9e39300595328979937
2018-09-18weld ControlCharacterDialogCaolán McNamara
Change-Id: Iac11d3ea29cc9529a786db3b91b79a9e7bcbd2cf Reviewed-on: https://gerrit.libreoffice.org/60581 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17New loplugin:externalStephan Bergmann
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-11loplugin:stringbuffer (clang-cl)Stephan Bergmann
Change-Id: Ie49cd58e7363c834c02769dda7c5aa83cca4f587 Reviewed-on: https://gerrit.libreoffice.org/60324 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-09Avoid getTokenCount and use indexed getTokenMatteo Casalin
Change-Id: Iaac598c9e56afa29db88237fecbe54d9cb4d4011
2018-09-08clan-tidy bugprone-throw-keyword-missing in SubmissionPropertyHandlerNoel Grandin
warning: suspicious exception object created but not thrown; did you mean 'throw IllegalArgumentException'? looks like a mistake in commit cd5b956817d0a6585d44f50857d690e9dc58145e Date: Tue Mar 14 10:33:39 2006 +0000 INTEGRATION: CWS pbrwuno (1.3.88); FILE MERGED Change-Id: I828501f32b3caff8c4ca05a8a8c4b063dccecd3b Reviewed-on: https://gerrit.libreoffice.org/60196 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08loplugin:simplifyconstruct in editeng..extensionsNoel Grandin
Change-Id: I646a24382554312d92a4a8746d5267767353a53f Reviewed-on: https://gerrit.libreoffice.org/60169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05clang-tidy performance-inefficient-vector-operationNoel Grandin
Change-Id: Iebcaea7b08c5284946d83b6b6b9ed26b218025d4 Reviewed-on: https://gerrit.libreoffice.org/59992 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-31Address data source wizard: fix most a11y warningsSamuel Thibault
Change-Id: I7992bee3cf88c670d932cd6d6873339ac5f0c104 Reviewed-on: https://gerrit.libreoffice.org/59817 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-29Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24pass DelFormats around using std::vectorNoel Grandin
instead of an array and a separate count Change-Id: Ia12a549da7e35092da2db35f8b2b9fc6a9e9c2be Reviewed-on: https://gerrit.libreoffice.org/59506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-21tdf#117972 - Empty UI stringheiko tietze
Change-Id: I43bdd0533c34d5e44c96fd023d2c7270a65ddb74 Reviewed-on: https://gerrit.libreoffice.org/59380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-20Simplify containers iterations, tdf#96099 follow-upArkadiy Illarionov
Use range-based loop or replace with std::any_of, std::find and std::find_if where applicable. Change-Id: I2f80788c49d56094c29b102eb96a7a7c079567c6 Reviewed-on: https://gerrit.libreoffice.org/59143 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in OPropertyBrowserControllerNoel Grandin
Change-Id: Id5e225dbe5a1c2f27c1032cdaab35a01c78ede81 Reviewed-on: https://gerrit.libreoffice.org/59136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-15loplugin:useuniqueptr in extensions/propctrlrNoel Grandin
Change-Id: I08564e76ed667d158bd885a66b994b421ae9b426 Reviewed-on: https://gerrit.libreoffice.org/59015 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-04Fix typosAndrea Gelmini
Change-Id: Iaaf12d276fb890e5ac860e79c5dc196d7e8680d8 Reviewed-on: https://gerrit.libreoffice.org/58435 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-08-01Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from dbaccess to extensions Change-Id: I4d15aa35e11664ef78c836ffc2937c7e0bb6ea59 Reviewed-on: https://gerrit.libreoffice.org/58165 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-29loplugin:stringloop in variousNoel Grandin
Change-Id: Ic2436c6d94729211cd5bc72fee18af228381e4a3 Reviewed-on: https://gerrit.libreoffice.org/58250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-23Fix typosAndrea Gelmini
Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2 Reviewed-on: https://gerrit.libreoffice.org/57810 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-22Fix typosAndrea Gelmini
Change-Id: I326827c394347cbe9fad242e9da5702cba7a4d95 Reviewed-on: https://gerrit.libreoffice.org/57761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-14tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorUlkem Kasapoglu
Change-Id: I09016a06110772379ddf8b15f14446346b850cd6 Reviewed-on: https://gerrit.libreoffice.org/57339 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-09loplugin:oncevarNoel Grandin
Change-Id: Id295dc0db174a448ef73db9de34f2de07d47f09a Reviewed-on: https://gerrit.libreoffice.org/57108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-26Fix typoAndrea Gelmini
Change-Id: I47cf4db535562e4db505b44981d86d40171e7630 Reviewed-on: https://gerrit.libreoffice.org/56424 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-26tdf#96099 Remove some trivial container iterator typedefsArkadiy Illarionov
Change-Id: Ifec98748d55ff6aca64c425c50c2cf2650f61591 Reviewed-on: https://gerrit.libreoffice.org/56422 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25Add a FIXMETor Lillqvist
Change-Id: I3771d6f4703bbd1f012389f5699928464875290f
2018-06-20move SvColorDialog to welded argumentsCaolán McNamara
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-15menubar sbibliography: finish menubar and fix a bug in the toolbarandreas kainz
Change-Id: I08a6e29aeac8c16bbb987c5513cbf3d0777d4b3a Reviewed-on: https://gerrit.libreoffice.org/55835 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-14menubar: sync file bibliography menubarandreas kainz
Change-Id: I40726ace2cb8c1c5e02d4c68154d920d079bdf93 Reviewed-on: https://gerrit.libreoffice.org/55546 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12Support named arguments in InterfaceOleWrapper::Invoke()Tor Lillqvist
Convert a DISPPARAMS with named arguments into one with just positional ones. If there are gaps, use markers for them (VARIANTs with VT_ERROR:DISP_E_PARAMNOTFOUND). Those are then passed on as empty UNO Anys. Change-Id: Iad1197ba2559567a9c0eca4524e76389c2048fec Reviewed-on: https://gerrit.libreoffice.org/55646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-11Show also args in the SAL_INFO in InterfaceOleWrapper::Invoke()Tor Lillqvist
Change-Id: I8d1d3273fcafe1ce750e66e55712eac607722717 Reviewed-on: https://gerrit.libreoffice.org/55643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-11Fix typoAndrea Gelmini
Change-Id: I22eb441313c2f06ecbbbe86a8b2c4dc602861cff Reviewed-on: https://gerrit.libreoffice.org/55611 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-10Start of work on supporting named argumentsTor Lillqvist
In InterfaceOleWrapper::GetIDsOfNames(), look up also the parameter names, if present (if cNames > 1, rgszNames entries after the first). Return S_OK only if *all* the names were found, i.e. both the first (method or property) name, *and* all the parameter names. Change-Id: Ie04bc0558a7e2044ef527fc18f99230c71985a22 Reviewed-on: https://gerrit.libreoffice.org/55549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-08Fix glitch in SAL_INFO loggingTor Lillqvist
Change-Id: I421d3980c50706f927a0611e48c33a43267dd01b Reviewed-on: https://gerrit.libreoffice.org/55477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-08Log all the names being looked up in GetIDsOfNames()Tor Lillqvist
Change-Id: Ia116021ecc9f20c82622a4bc8ee40e7a9a1508fa Reviewed-on: https://gerrit.libreoffice.org/55479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2024-05-29 18:40:21 +0000