Age | Commit message (Collapse) | Author |
|
Use SolarMutexReleaser, instead.
Change-Id: I276459c42b688813ea168d6fc80466a07a5ecba4
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
of which there are several.
There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
numeric values to the underlying code, but perhaps further fixing is necessary?
Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
|
|
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
|
|
Change-Id: I73d98b1aa08966e2fb169e8d25fbfbe68762a228
|
|
The plugin streams are a bit of a disaster area: there are 2 of them
with a common base class and the PluginInputStream is a UNO service.
The m_pPlugin gets reset in PluginStream::setMode(-1), which is called
by the plugin itself. So those PluginStream/PluginInputStream methods
that are called via UNO (including dtors) need to check that m_pPlugin
isn't null, but they also lock member access with m_pPlugin's mutex.
Try to ensure that that works by ensuring that the plugin is still alive
with a WeakReference, *and* checking that m_pPlugin isn't null.
Change-Id: I925b30dd7cad3d3587fcc6b10f888e30d45fc38a
|
|
Change-Id: I3ab73401b29be79ae5457c9f8905ad35e6f0c5fa
|
|
~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.
Change-Id: Ic675e9cd3be1494c740a4f289be3bdbf0d1a122b
|
|
Rename the virtual function, and add a new non-virtual Commit() to do
that.
Change-Id: I09421df781ba965d6ff638b46cd8214fb3a00022
|
|
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
|
|
introduced in commit d22519f62bcd1325f1e7cc920a115b68fccd1922
"V801: Decreased performance"
Change-Id: Ie8e1e00db91b0d1874abc6a3e6399ff30484f993
|
|
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
|
|
Change-Id: I9e9a00acf9503980f0c6c7cd0a20378e5ca7390d
|
|
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
|
|
Change-Id: Id3852abe9bc7bbe774331a7d691abd2a79ff59b4
|
|
Change-Id: I12290bed7e4f298ab90393b8de6e2b6e7061e53f
|
|
Change-Id: Id4ef36d6c80ad62306bdbaa7094c2cb0b8ff77da
|
|
... and remove the definitions in makefiles, except in fpicker, which
defines a different value for the Vista file picker.
The WINVER value is derived automatically from _WIN32_WINNT by SDK
header sdkddkver.h.
Change-Id: I73358a9bf5d070f71821654cae2a29335a754a21
|
|
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
|
|
.. in favour of just using the underlying constants from
css::util::NumberFormat
Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
|
|
Change-Id: I9bb56396f263c73fbb22a556da32a5da7f94c3fd
|
|
Change-Id: I22b5ad47ba76da9b00e9a69bcfbc00befc369fe6
|
|
Change-Id: I61d6a92e5301e07c9180d94dafec23ef1a06e0ef
|
|
to reduce code clutter like
pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos())
since this is a fairly frequent operation.
Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184
Reviewed-on: https://gerrit.libreoffice.org/14472
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I55b827c4f20c57fcb18f8d6b54e3fdc168baed3f
|
|
Deprecated comphelper/sequenceasvector.hxx.
Rewritten code using it. Using instead the functions containerToSequence and
sequenceToContainer, found in include/comphelper/sequence.hxx.
One class that inherits from it (in framework/inc/stdtypes.h), and
the code using that has been left.
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Conflicts:
writerfilter/source/dmapper/DomainMapper.cxx
writerfilter/source/dmapper/TblStylePrHandler.hxx
writerfilter/source/dmapper/WrapPolygonHandler.hxx
Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
|
|
Change-Id: Ibf4a2ed99024568b2d370b22919e3a25c43c6fbf
|
|
Change-Id: I4a7e8751a5a6a93bd0cb8208a06a7c4fd30ef1b4
|
|
Change-Id: I00a5bc6256d9cbfc69ea6a71f2f2cd21e75cc594
|
|
(cherry picked from commit 2b2128d0665dc390ae90739c84bc387f399ebe87)
Conflicts:
extensions/source/propctrlr/formmetadata.cxx
Change-Id: Ic6d708454009e8023dc2e601043409377fd6cb34
|
|
...in some places where it is obvious that it does not hurt that for an empty
vector the obtained pointer is not necessarily a nullptr.
Change-Id: Id5d66b1559ca8b8955d379bcdbfae6986ef46a51
|
|
regression from
commit bbf3aa7f92c194c9cc4546c95706e6b28e0c070c
Author: Caolán McNamara <caolanm@redhat.com>
Date: Fri Nov 14 11:06:44 2014 +0000
coverity#705989 silence Insecure temporary file
and
coverity#705983 Insecure temporary file
Change-Id: If580196322e68098adc38a9fdb775827843a9c30
|
|
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
Change-Id: Ida4bf3bf03d49856eb16329c4f88b9507f330c6f
Reviewed-on: https://gerrit.libreoffice.org/14150
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ia47c0bc3539ddf8f925cd053a2431c742c46d337
|
|
Change-Id: I3b1a00f12b75e3b115e08289b7f486a6a9c3c863
|
|
left over from "SVStream operator>> to Write method" conversion
Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
|
|
add constructors to Date/DateTime/Time,
that take the css::util counterparts,
to simplify code converting between these type
Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7
Reviewed-on: https://gerrit.libreoffice.org/13855
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
and dump the ones that nothing is listening to
Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
|
|
and drop DATACHANGED_DATETIME because no-one is using it
Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
|
|
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
|
|
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
|
|
Change-Id: I9c67de31f5571b282adc132d973b79bccb35fdc9
|
|
found by CodePro
Change-Id: If1b75e43f81d70984422e437147048a491395b66
|
|
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
|
|
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
|
|
Change-Id: Ief21a59fc58cdd6fb3398bbe5080ed5a53cb374e
|
|
Change-Id: I4f117b3339753af254768724c38167f3595fbe69
|
|
...to use single ASCII character literals "more directly" in the OUString API
(instead of having to go via an intermediary OUString ctor call). Especially
useful for character literals that are defined as const variables or via macros
("direct" uses of character literals in the OUString API can often simply be
replaced with single-character string literals, for improved readability).
(The functions overloaded for OUStringLiteral1 are those that are actually used
by the existing LO code; more could potentially be added. The asymmetry in the
operator ==/!= parameter types is by design, though---writing code like
'x' == s
is an abomination that shall not be abetted.)
Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
|
|
Change-Id: I37a82554de4f77be7e0fb3e42245a70b53beb83c
Reviewed-on: https://gerrit.libreoffice.org/13476
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|