summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)Author
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27improve "unnecessary user-declared destructor" checkNoel Grandin
to look for inline&empty destructors, where we can just let the compiler do it's thing Change-Id: Ibde8800bdfed6b77649c30ebc19921167c33dec3 Reviewed-on: https://gerrit.libreoffice.org/32999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24tdf#105467 new color widget doesn't support XStringListControlCaolán McNamara
so this threw and mangled the dialog. New color dialog doesn't need to be told the name of colors, it figures that out itself. Change-Id: I89382b6b26312fc90c967620c654ea611cbd9616
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23use rtl::Reference in SubmissionPropertyHandlerNoel Grandin
rather than manual acquire/release Change-Id: I3276361153591a3af8c6b00b478365b2700dedf5
2017-01-23use rtl::Reference in bib::OComponentListenerNoel Grandin
rather than manual acquire/release Change-Id: Ib4b52fb4a85223f974e9905bc3d02eb839150030
2017-01-20use rtl::Reference in BibFrameCtrl_ImplNoel Grandin
instead of storing both a raw pointer and a uno::Reference Change-Id: I8caa56eade25561178aa6ffd144b00f452517974
2017-01-20use rtl::Reference in BibliographyLoaderNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Ic46c5cda34c1df818cbe1ffa4b2d44d1519b4d6f
2017-01-20use rtl::Reference in FormControlContainerNoel Grandin
instead of manual acquire/release Change-Id: Ie0fed7db217adea68aaa09cf9de699d488bf84dd
2017-01-19New loplugin:dynexcspec: Add @throws documentation, extensionsStephan Bergmann
Change-Id: Ia44f7b0a162d269bf38133575f986efd62eb6d52
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-16e*, f*: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: I3383e222829042557a8fd9f575049c47aeddeb09
2017-01-16new loplugin: useuniqueptr: extensionsNoel Grandin
Change-Id: Iaafaf0117a339dbb435cec2bbf4dca55629ab8a2 Reviewed-on: https://gerrit.libreoffice.org/33154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14-Werror,-Wunused-lambda-captureStephan Bergmann
Change-Id: I0ceabed1f89b6b641d5282fa1c32719bf3ead19c
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann
Change-Id: I638199f1455bead71f0a03f15e4b6f418a0cd0e2
2017-01-09tdf#105160: word wrap at wizardheiko tietze
Vertical spacing fill now Change-Id: I1463df1a0b345a39c10ef83b2fa0c558bd135cdc Reviewed-on: https://gerrit.libreoffice.org/32829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-01-09New loplugin:externvar: extensionsStephan Bergmann
Change-Id: I596eecab083092cccbe67062ade2279e6e25baab
2017-01-06loplugin:salboolStephan Bergmann
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2017-01-01fold ResourceIndexAccessBase into ResourceStringIndexAccessCaolán McNamara
Change-Id: Icef518dc65d5edf4e7893df460aaae179eecfb45
2017-01-01so ResourceStringListIndexAccess isn't neededCaolán McNamara
Change-Id: Ic25fc6f2f8f3e471a90e10c3f2319f40888520e6
2017-01-01so we can drop StringList access from ResourceIndexAccessCaolán McNamara
Change-Id: Ie855a45f7994e9d58ddecc51b54c25424fc544d6
2016-12-26use std::vector instead of naked array in SfxItemPoolNoel Grandin
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4 Reviewed-on: https://gerrit.libreoffice.org/32384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-24unwind RID_TOOLBAR_IMGLIST and RID_TOOLBAR_BIGIMGLIST ImageListsCaolán McNamara
Change-Id: Iae7ffce940f90e48dfb95b33abab35ca03a6b305
2016-12-22RID_SVXBMP->RID_EXTBMPCaolán McNamara
Change-Id: I19e5c60ea8b42223322da2a1e343b7c4c1c59928
2016-12-21loplugin:staticmethodsStephan Bergmann
Change-Id: I04d3095c657deb72a20fa803964912cf6baf268b
2016-12-21-Werror,-Wmacro-redefinedCaolán McNamara
Change-Id: Ifd246b642979df0d8b1aa20a59f8c73dc9ddc1b2
2016-12-21loplugin:staticmethodsTor Lillqvist
Change-Id: I30456ec3a0440364b8b4c460d198588aed241034
2016-12-21convert VclButtonsType to scoped enumNoel Grandin
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21unwind RID_IL_FORMEXPLORER imagelistCaolán McNamara
Change-Id: I4c86aa99aecf22e842183966721976a921bafe7b
2016-12-20extensions: Drop empty fileTakeshi Abe
Change-Id: I4962d739af889595f026c250b8f10a917b1dfb17 Reviewed-on: https://gerrit.libreoffice.org/32130 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12remove useless Mutex guardsNoel Grandin
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05loplugin:unnecessaryoverride (dtors) in extensionsStephan Bergmann
Change-Id: Ia8250bc33c5d05861794619c5d240fdcb4002c13
2016-11-29extensions,sc,sd,vcl: de-obfuscate assignments in conditions to help GCCMichael Stahl
GCC 6.2.1 with -Og produces spurious -Werror=maybe-uninitialized on variables that are assigned in conditions; perhaps it's better to de-obfuscate the code if even GCC is confused about it. Change-Id: Ia2f8209df893a8e5659ca72f4cde3d7d847574e1 Reviewed-on: https://gerrit.libreoffice.org/31332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-29loplugin:vclwidgetsStephan Bergmann
Change-Id: If88a200fa26bcc6b20ad3c1dbc160e862054318f
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-18loplugin:datamembershadowNoel Grandin
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:expandablemethods in extensionsNoel Grandin
Change-Id: I93a770933de86146de1d25db9d596615916c3e28 Reviewed-on: https://gerrit.libreoffice.org/30689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04extensions leaks out details of Color Selector, patch it upCaolán McNamara
and rebase it on SvxColorListBox Change-Id: I3afef689ab0dc3c34e465810d82bf21797907558
generated by cgit (git 2.34.1) at 2024-07-10 09:31:17 +0000