Age | Commit message (Collapse) | Author |
|
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
|
|
all single tab dialogs are .ui enabled now.
So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog
and ~SfxNoLayoutSingleTabDialogBase together
Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
|
|
.. and convert the last few places still using those methods.
Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
|
|
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
|
|
regression since 64b993e046f23baaacaff1572b7d2a816588b5ef
Change-Id: Ifc907a34430c36a64318fc42342e630e2b84ad13
|
|
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
|
|
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
|
|
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance
service.
Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
|
|
Change-Id: I93309674ef50e8ca7438874378fb01484bb7f9f3
|
|
Change-Id: Icc9def55a814fc1309ce143a84effc140a90a92b
|
|
It's the isCustom field that should be checked to see whether the
customAttribute field has been assigned or not.
Change-Id: I5d2af26b675ab0cbc0e1844eb98ebaf5145eb73d
|
|
Change-Id: Ie65526e66a71561aa64ed3517097d1274ffe7db4
|
|
For one, NPPrint.mode must be either NP_FULL or NP_EMBED, so assigning TRUE is
odd. And for another, the value of printInfo->mode is read again in the next
line, so assigning anything to it here looks like an error anyway.
Change-Id: Icd5a7ceabd07ed8b716e2fc90b214b7da5301451
|
|
Change-Id: I21e24bd39a0872df3077d45c257251c253957489
|
|
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
|
|
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153)
Conflicts:
basic/source/comp/parser.cxx
basic/source/comp/token.cxx
dbaccess/source/ui/dlg/generalpage.cxx
sc/source/ui/unoobj/chart2uno.cxx
vcl/quartz/salbmp.cxx
Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
|
|
Change-Id: I14956a86b8c83b9432c1eda511371beb026fd680
|
|
In the past, NO_LOCALIZE_EXPORT macro must be used to
skip uneeded parsing of src files which has no localizable content.
It is unsued by now and it is more effective to handle
this files on gmake level:
gb_SrsTarget_add_nonlocalizable_files
gb_SrsTarget_add_nonlocalizable_templates
Plus remove some empty src file.
Change-Id: I8fc9b2db0b5fd7a3379d3c5be970c4fc691f4c53
|
|
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
|
|
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
|
|
Change-Id: I9059370e21e753a9578f231fd0c0eb0a1d6a981e
|
|
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up,
of course.
Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
|
|
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
|
|
Convert code like
aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp");
to
aFilename = OUString::number(nFilePostfixCount) + ".bmp";
Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
|
|
Change-Id: I8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06
|
|
Change-Id: I44f6f587dffe047d4aef7e32233bafe54a77cb6d
|
|
Change-Id: I0d9f1eadb6dc863f1e5606ef2d166881e6cf6c0a
|
|
Change-Id: If37ef9f68711da3a0aa9a3ba59b111a8a23421df
|
|
...use cppu::UnoType instead.
Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
|
|
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it. Plus some const clean-up.
Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
|
|
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now:
Ach, old GCC doesn't like plain string literals to initialize members
of OUString type...
Change-Id: I50563a00406259bb5d41831e2a2796762450d097
|
|
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it. Plus some const clean-up.
Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
|
|
Change-Id: Ib8969d5cd4898b81a5dcd90dc313abd28adfe052
|
|
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.
Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
|
|
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
|
|
Change-Id: I099f94922acba0bf9cde22fbbb3eefc230776868
|
|
Change-Id: Ibacf8da00e06a725557e4de1ea3f9c6833b59d74
|
|
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
|
|
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
|
|
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
|
|
Change-Id: Ic4dc1c106ebcce7d27844551efca43cabb31c4ae
|
|
...that would fall into the same trap as
50bd5c11f551f5274be9a4411c5ddcbd32bd9a03 "wsprintf is broken by design and never
writes more than 1024 characters" if the length were not currently bounded by
2 * MAX_PATH + x < 1024 anyway.
Change-Id: I2503ba0a9df960f2fdb51925d5fbbcff5bdb998a
|
|
Change-Id: I8fe982d0c0c0a04e2a10cff0f0ae68d51bed590a
|
|
CoInitialize{Ex] always exist in all supported Win32 versions, so just
call them.
Change-Id: I45f227319aae811b6c94a3ac475467a06146b8e9
|
|
Convert code like this:
if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
if (aStr == "rem")
which compiles down to the same code.
Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
|
|
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.
I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
|
|
* Windows XP SP2 is 0x0502, see
http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
this is done module wide now. So the overall behavior
is as before. This seems to be the best compromise for
now.
* We need at least SP2 because of the bluetooth stuff
used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
project specific precompiled header files.
* All local definitions of WINVER are removed, because
the global WINVER setting makes them obsolete now.
To the relation of the three macros:
Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.
WINVER and NTDDI_VERSION can be set idenpendently each
for itself.
Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
|
|
Convert code like:
if (aValue.matchL(RTL_CONSTASCII_STRINGPARAM("BOOL=")))
to:
if (aValue.startsWith("BOOL="))
Change-Id: I385d10fd486d6a3e5f81f4a28088d913fc2f0d26
|