summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)Author
2021-08-13extensions bibliography: sync the bibliography database window with sw/Miklos Vajna
That one has the browse button and page number widgets removed for URL (keeping them only for local URL), do the same in extensions/ to be consistent. Change-Id: I519b2d82ddbb88d2b63f599094c23783c6d719cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120424 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-13split SvNumberFormatter into it's own headerNoel Grandin
so I can make changes without running into cyclic dependencies between header files Change-Id: I98a91c7cc66002ba745cdb8239e5cc267922a45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13sw bibliography: fix missing identifier + local URL in biblio referenceMiklos Vajna
Regression from commit 5fd2f212a1db9e061fb3a886810b427251e8a6bf (sw bibliography, local copy: handle the bibliography database window, 2021-07-27), the problem was that the newly added LOCAL_URL column affected BibliographyLoader::getPropertyValue(), which was not adapted, done now. Change-Id: Id3bd95bdd5c692048a50ce7ba2e5cdf16e824bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120400 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-11convert some LogicToLogic calls to use o3tl::convert insteadTomaž Vajngerl
If a LogicToLogic uses fixed units, we can use o3tl::convert instead. We can also do the same for all other cases where LogicToLogic is used, but that needs additional investigation to determine if it is safe to do so. Note: MapUnit::Pixel is converted to o3tl::Length::pt because it assumed 72 PPI for a logical pixel, which corresponds with the conversion rate of a point (72 PPI). Today, 96 PPI is standard, which is also used for o3tl::Length:px. Change-Id: I29126df38bfcfda74b5d83d4cb880a378aecd18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120230 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-10use rtl::math::expm1 instead of boost::math::expm1Caolán McNamara
similar to: commit 1a1dbff33db8a6f2f55a5d92483a03670a610f6a Date: Mon Feb 13 18:22:28 2017 +0100 get rid of boost::math::log1p() and use rtl::math::log1p() ... which in turn uses the compiler's std::log1p() Change-Id: I1a09b790345f4da37d86ab7deba09fa20c5f648b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-10can return OInterfaceIteratorHelper2 by value hereNoel Grandin
Change-Id: I32e94473667a734e582dad0a9785c8e9cfbc8cff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-09stray unwanted and unneeded image-position propertiesCaolán McNamara
Change-Id: I094132890dd735c0941d5de87677c0290efe37f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-07create comphelper::OMultiTypeInterfaceContainerHelper2 and use itNoel Grandin
based on OInterfaceContainerHelper2 which is considerably faster than the original OInterfaceContainerHelper Change-Id: I9c8b6d0e5382018824bf7188a26343703abf2d51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-05fix --enable-online-update afterNoel Grandin
commit 14cfff500e93f0d6cbf8412065feea85c01ea81d Pass context and resource string down to boost::locale separately Change-Id: I10336d0081c03090d63f48636ee8283b327304aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120058 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-05drop unneeded forward declareCaolán McNamara
Change-Id: I858d4a43690bd37385eb6f48945c05dd9c2a6182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-05Pass context and resource string down to boost::locale separatelyNoel Grandin
because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-02Fix --enable-online-update buildStephan Bergmann
...after 1597cc5b3e07dd24cb4cb10b35b1e93545e4b929 "convert #defines to OUStringLiteral" (partially reverting that commit), > extensions/source/update/check/updatecheckconfig.cxx:68:17: error: expected '}' > RELEASE_NOTE"1", > ^ > extensions/source/update/check/updatecheckconfig.cxx:62:47: note: to match this '{' > const char * const aUpdateEntryProperties[] = { > ^ etc. Change-Id: I3cebb3dbc74adaeeefc14c11986ee4c8817b31b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-02convert #defines to OUStringLiteralNoel Grandin
mostly by doing $ git grep -l '#define.*\"' -- *.cxx | xargs perl -pi -e 's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 = u\2;/g' Change-Id: Idface893449b0ef2a3c5254865a300585d752fbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119669 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-27sw bibliography, local copy: handle the column mapping dialogMiklos Vajna
This allows mapping the LocalURL database column to the LocalURL property of a bibliography reference field. Change-Id: Ic8793561e0242964c8a8313b230f6e13dda31dcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119558 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-07-27sw bibliography, local copy: handle the bibliography database windowMiklos Vajna
- update generalpage.ui to have the same widgets for both the URL and the local URL - extend BibGeneralPage to map LocalURL to m_xLocalURLED - get the usual browse / page number handling buttons working - introduce a separate GtkAdjustment for the additional spinbutton, which seems to be necessary for gtk3, but not for gen (otherwise increasing the value sets a new value for both spinbuttons) Change-Id: I9ea616102cd6a8a060217a4e404a8eb93a0c2a04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119545 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-07-23do not use "using namespace std" in headersCollabora
It's a bad style, doing that in headers can affect many source files (especially with PCH used). Change-Id: Ic9091a1d018e74606c9fa95df71a55faaa93d4ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119011 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-07-19Move svl::Items to include/svl/whichranges.hxx, and unify its usageMike Kaganski
... in WhichRangesContainer and SfxItemSet ctors. Now it's not needed to explicitly use 'value' in WhichRangesContainer's ctor, or create an instance for use in SfxItemSet ctor (svl::Items is already defined as a template value of corresponding type). Instead of WhichRangesContainer Foo(svl::Items<1, 2>::value); SfxItemSet Bar(rItemPool, svl::Items<1, 2>{}); now use: WhichRangesContainer Foo(svl::Items<1, 2>); SfxItemSet Bar(rItemPool, svl::Items<1, 2>); Change-Id: I4681d952b6442732025e5a26768098878907a238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119157 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-17Related: tdf#143357 set blank label for no dateCaolán McNamara
instead of current system date Change-Id: Ic504b34990a8ea5151ec653de2db860c1cd4b8ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-16Related: tdf#143357 explicitly set the default of focus-on-clickCaolán McNamara
this should already be the default according to https://developer.gnome.org/gtk3/stable/GtkWidget.html but it's apparently False nevertheless, so make it explicit here for these widgets where there is a focus watcher to commit their changes and the absence of this is non-cosmetic. Just these initially for a small backportable change. Change-Id: I96442b4e844ce0446f56276c1b648ca5ce57b740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-16extensions: bibliography database window: add UI to set a page number on a URLMiklos Vajna
Again, to be consistent with the Define Bibliography Entry dialog which already had this. Change-Id: If43506a3c2cb105551df7ec8198a749315458409 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119021 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-07-14extensions: bibliography database window: add browse button for URLsMiklos Vajna
To be consistent with the Define Bibliography Entry dialog which already had this. Change-Id: I1f2eda189ae594dbef9c7fd4f0f1a1d12dc6ad5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118939 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-07-12Fix extended tip after translationOlivier Hallot
Change-Id: I6a999a2c20f0a90be1cde21cd27ec73f75dc4f28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118448 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-12tdf#126665 Remember last used file picker directorySamuel Mehrbrodt
This introduces internal tracking of last used directories. Each caller of the file picker can pass a "context". The selected directory will then be saved & restored when opening the file picker with the same context again. After ffa636ba74b04b3258ec9a696bc4eac33581fa24 , the Windows file picker no longer tracks the last used directory itself. This is a replacement and an improvement at the same time, since there is not one global last used directory, but one per context. Change-Id: I10650cfb9359922690954fa65c89b4e47477e2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118597 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-07-09Make loplugin:stringadd slightly more aggressiveStephan Bergmann
...by assuming that all const member functions are side-effect free. (This presumably means that some of the special cases in StringAdd::isSideEffectFree are obsoleted by this more general case, but any such removal is postponed to later clean-up.) (Came across this when idly wondering why 8b7f948d9d79393bc6c1b11d239706666fd5d7de "sc, VmlFormControlExporter: avoid OStringBuffer style" had not been found by the plugin before.) Change-Id: I6bca10df53885b14a590543aabd61f23b3748572 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118675 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-07-09loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: Iae559ca8bee9650c01167a4d1b918e18cbf03c28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118660 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-07-02stray unwanted image-position for CheckButtonCaolán McNamara
Change-Id: I31ca60b6b7ee953e002e074efeac9a204f2986f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-25Add back computation of excepinfo.bstrDescription lengthStephan Bergmann
...which had been dropped with eebd84b337506c8fff151493f9b51bd127dbc89f "loplugin:stringview (clang-cl)". But as discussed in the comments at <https://gerrit.libreoffice.org/c/core/+/116548/2/extensions/source/ole/oleobjw.cxx#b1432> "loplugin:stringview (clang-cl)", that dropped support for embedded NULs ("not that this should matter here", though). Change-Id: Ifdb327cbe8b20b365c8174802622f83b4510d547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117836 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-25-Werror,-Wunused-but-set-parameter (clang-cl 13 trunk)Stephan Bergmann
...ever since 95117e7fefa9ae82431dcdffd1e58495730f6f54 "initial import" Change-Id: I7088801e9ad1e5190c127d01c640ded0a2b0c9d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117846 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-25-Werror,-Wunused-but-set-variable (clang-cl 13 trunk)Stephan Bergmann
...ever since 95117e7fefa9ae82431dcdffd1e58495730f6f54 "initial import" Change-Id: Id1590c855a604862796549376f2c3f6d76d3cb2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117847 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-19use more TellEnd()Noel Grandin
which has the potential to be more efficient than STREAM_SEEK_TO_END Change-Id: I64d84632bc4751e07309332c9dff7a02bcd507fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-17use string_view in the Translate APINoel Grandin
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-14only one of the radiobuttons in a group should be activeCaolán McNamara
Change-Id: I0475bdd0633b54a644e205628577fac18a3af974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03Revert "Initialize vector directly with the already known count number"Julien Nabet
This reverts commit da9fe0da11687bfc4c0eff2197286da67d6206c2. Reason for revert: wrong result since there'll be first 4 by default initializations then an extra reserve allocation. Change-Id: If480243e81db405d6a984b8450a219e486f1a1ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116465 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-06-02Initialize vector directly with the already known count numberJulien Nabet
instead of initializing an empty vector then reserve a fixed value Change-Id: Iccddda05b3dd98aa9c25a61637ece7af4d42d72f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116624 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-01loplugin:stringview (clang-cl)Stephan Bergmann
Change-Id: Id1f8f24fec638efcdf5a04ca7253e6f401afd2fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116548 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21use toggle instead of click for RadioButtonCaolán McNamara
Change-Id: Ic246c68749f79cc1b25fed08a66fd8a0d57495f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115884 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara
Change-Id: I7196581a8b7c307d531f6995e1c24db746afdb26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19loplugin:noexcept (clang-cl)Stephan Bergmann
Change-Id: Ife669f959358992b547b408ab5d1f6bf1c1d14bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115744 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-15inherit LinkButton and Notebook from Widget instead of ContainerCaolán McNamara
Change-Id: Ie3940d712e2e60a59234aff34daaf6003301fd15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-13Revert "simplify the vcl<->toolkit connection"Noel Grandin
because it introduces a link-time dependency of vcl on toolkit, and toolkit already depends on vcl This reverts commit f7a86c5cdf4323c99d26512bf78de7f7c380667d. Change-Id: Ibdd4f3e8221d70e2abd8fcbda67f85af3ac0396e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-12simplify the vcl<->toolkit connectionNoel Grandin
No need to store two different pointers and hide the underlying class behind an UNO interface Change-Id: I72c55e912caa9eae1cffa6c9d1b1d480e5668d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-08ref-count SfxItemPoolNoel Grandin
so we can remove SfxItemPoolUser, which is a right performance hog when we have large calc spreadsheets Change-Id: I344002f536f6eead5cf98c6647dd1667fd9c8874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115247 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03loplugin:unnecessaryparen small improvementNoel Grandin
when calling a function, and passing only one arg, but the function has defaulted args, we were ignoring this case. Change-Id: I86517f18e30531127664088ddc09ef96dbd8bdf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115033 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-29loplugin:stringadd simplify some *StringBuffer operationsNoel Grandin
pulled from a larger patch which I created with a more permissive variant of this plugin Change-Id: I7abf1f3f09e84703b6e0e52fe9587dff691b2187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27loplugin:stringadd (clang-cl)Stephan Bergmann
Change-Id: Id7c2db4abcf947c4efa0296df29feca2c36d3cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114692 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-21loplugin:stringadd replace OUStringLiteral temporaries with OUString::ConcatNoel Grandin
Change-Id: I656f06a74d9f0180ae460264563d6a935c7d2c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114377 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-20use OUString::Concat here, not OUStringLiteralNoel Grandin
Change-Id: Ia2172bcab60f32c9d9d4f6ca0230484343eef69b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-13 13:02:33 +0000