summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)Author
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ic823a46019138b8bbcacd7b52b48d7d7ead2fde2 Reviewed-on: https://gerrit.libreoffice.org/35629 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23Resolves: tdf#106461 use a row height of max of edit and listbox heightCaolán McNamara
not just take the listbox because edits can be taller and result in overlaps Change-Id: I6067b384484d933727220febda723bc9e8c5e90b
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19TyposJulien Nabet
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c Reviewed-on: https://gerrit.libreoffice.org/35436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18cppcheck: workaround nullpointer false positive with an assertJulien Nabet
Change-Id: Ib94d64ed5076b5603e99fa9632d25e85395b6ff1 Reviewed-on: https://gerrit.libreoffice.org/35395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18cppcheck: nullPointerJulien Nabet
Avoid to forget E_POINTER return value Change-Id: I1887d20c7d73dcd3c6ddc1287b6c1ad6c13dd69f Reviewed-on: https://gerrit.libreoffice.org/35394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-17remove unused defines from HRC files in extensionsNoel Grandin
Change-Id: Idc98097d32c64c095bb735c8cb91b0ab368c8fa9 Reviewed-on: https://gerrit.libreoffice.org/35309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16Fix typosAndrea Gelmini
Change-Id: I1488e2147fa0cd4a821eb5bfe172a58a4e396ace Reviewed-on: https://gerrit.libreoffice.org/35224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-14No need for --disable-activex and --disable-atl any longerTor Lillqvist
Change-Id: I7ac4f32cb01bfcc3a2c06e69280c2150d408ec6b Reviewed-on: https://gerrit.libreoffice.org/35174 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-09oops, forgot to commit thatMichael Stahl
Change-Id: I7b0a08ca47996f80112f68daef3e2ba5e3be221b
2017-03-09extensions: fix MSVC 2017 build of Library_so_activex_x64Michael Stahl
Change-Id: Ia98c2ba085d6b7705b53dafd5368d69f0e0727c5
2017-03-08Clean up uses of integer typesStephan Bergmann
Change-Id: Iaf07f989776c80abd998977e0a2a67f503d0860e Reviewed-on: https://gerrit.libreoffice.org/34975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-08convert SvxCaseMap to scoped enumNoel Grandin
Change-Id: Iea77ddc21e9b2d5a021c08e323da9ccabf9d46bd Reviewed-on: https://gerrit.libreoffice.org/34963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I338dacd3cfe915714a9038e1dea4a60d586e9394 Reviewed-on: https://gerrit.libreoffice.org/34806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove bogus source code commentsdennisroczek
Change-Id: I616ca3483d926c8e4155512ef5138e3f7978ece3 Reviewed-on: https://gerrit.libreoffice.org/34842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-02-28loplugin:unoanyStephan Bergmann
Change-Id: I57f1d614b1dbb945e39b546fec2fdaac40de82b2
2017-02-28loplugin:unoanyStephan Bergmann
Change-Id: I57375d39aa2e84e40f2c2eb13e3e942497a78a3e
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-27Clean up use of integer typesStephan Bergmann
Change-Id: I007b8eca8249da0e3c4aa5a9d274ac4cb497799b
2017-02-17Drop :: prefix from std in [de]*/Tor Lillqvist
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-02-16convert resetType to scoped enumNoel Grandin
Change-Id: Ie127b99949546b5303fd105c662b25c62d409941
2017-02-14Resolves: tdf#79250 add typed list to form control listboxEike Rathke
... so numeric and text data can be distinguished input. Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
2017-02-13Fix typosAndrea Gelmini
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-11Revert "Resolves: tdf#79250 add typed list to form control listbox"Eike Rathke
This reverts commit e387b69967aabc44d5da5aaad8d94191437dc57c. It breaks toolkit.subsequentcheck with propertyChangeListener wasn´t called for ´TypedItemList´ Back to the drawing board for the twisted property logic of forms and toolkit uno control models.
2017-02-10Resolves: tdf#79250 add typed list to form control listboxEike Rathke
... so numeric and text data can be distinguished input. Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
2017-02-10Remove MinGW supportStephan Bergmann
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-09tdf#105447 Move accelerator to first letters in Help menuYousuf Philips
Change-Id: I14088435228a989cb388cb9e205dc7fcd3fbbfa9 Reviewed-on: https://gerrit.libreoffice.org/33646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-08Blind fix for apparently buggy GCC 4.8Stephan Bergmann
cf. <http://ci.libreoffice.org/job/lo_tb_master_linux_dbg/10952/console> Change-Id: If947e338be0ab17f41f74f8e70e6281f46a7f57c
2017-02-08Use OUStringLiteralStephan Bergmann
Change-Id: I15580bd0395145f9554cd3a155c4825ba95005b3
2017-02-08Drop bogus check for escaped $Stephan Bergmann
This apparently wanted to check whether the $ starting a potential pattern occurrence was escaped by a preceding $. However: * The check itself was broken, erratically looking into sPattern instead of _inout_rFileURL for the $. * The check was bogus, as it would have misinterpreted e.g. "$$$(loggername)". * The resulting string is documented (in officecfg/registry/schema/org/openoffice/Office/Logging.xcs) to be passed through css.util.PathSubstitution. However, neither the PathSubstitution service's documentation (in offapi/com/sun/star/util/PathSubstitution.idl) nor its implementation (SubstitutePathVariables::impl_substituteVariable in framework/source/services/substitutepathvars.cxx) appear to support esacping $ with a preceding $. So it looks more reasonable to remove the check completely here. Change-Id: I445493d444904cd54f166adcbf870a918d1f9982
2017-02-08Add missing #includesStephan Bergmann
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-05.uno:ScriptOrganizer should be menu:menuitemMaxim Monastirsky
... so it won't show as an empty submenu in the customization dialog, and allow accidentally overwriting it. Change-Id: I9431e5240485a58f63a2333850a9052e475db63e
2017-02-02unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27improve "unnecessary user-declared destructor" checkNoel Grandin
to look for inline&empty destructors, where we can just let the compiler do it's thing Change-Id: Ibde8800bdfed6b77649c30ebc19921167c33dec3 Reviewed-on: https://gerrit.libreoffice.org/32999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24tdf#105467 new color widget doesn't support XStringListControlCaolán McNamara
so this threw and mangled the dialog. New color dialog doesn't need to be told the name of colors, it figures that out itself. Change-Id: I89382b6b26312fc90c967620c654ea611cbd9616
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23use rtl::Reference in SubmissionPropertyHandlerNoel Grandin
rather than manual acquire/release Change-Id: I3276361153591a3af8c6b00b478365b2700dedf5
2017-01-23use rtl::Reference in bib::OComponentListenerNoel Grandin
rather than manual acquire/release Change-Id: Ib4b52fb4a85223f974e9905bc3d02eb839150030
2017-01-20use rtl::Reference in BibFrameCtrl_ImplNoel Grandin
instead of storing both a raw pointer and a uno::Reference Change-Id: I8caa56eade25561178aa6ffd144b00f452517974
2017-01-20use rtl::Reference in BibliographyLoaderNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Ic46c5cda34c1df818cbe1ffa4b2d44d1519b4d6f
2017-01-20use rtl::Reference in FormControlContainerNoel Grandin
instead of manual acquire/release Change-Id: Ie0fed7db217adea68aaa09cf9de699d488bf84dd
2017-01-19New loplugin:dynexcspec: Add @throws documentation, extensionsStephan Bergmann
Change-Id: Ia44f7b0a162d269bf38133575f986efd62eb6d52