summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)Author
2014-06-17coverity#705999 Unintended sign extensionCaolán McNamara
also coverity#706000 coverity#706001 coverity#706002 Change-Id: Ib970a4956fcf8362b8e3f9ae859c374c5fc8a545
2014-06-17coverity#1223093 Uninitialized scalar fieldCaolán McNamara
Change-Id: I5519b552507ab81e51f81996835467d353277a18
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-14we can't use untranslatable strings hereCaolán McNamara
and drop the now unused helpid Change-Id: I38fb93e50e7715e05f21e08c2e8714a1a52305b8
2014-06-14we can now easily re-orient the ok/cancel/help buttonsCaolán McNamara
Change-Id: Ifc379008f545ba0c44e8c3bb18a43fc2a633dc64
2014-06-14Convert RID_DLG_MAPPING to .uiPalenik Mihály
Change-Id: I92a5778a2f4f69beb73885c2f7c78a43045986c0 Reviewed-on: https://gerrit.libreoffice.org/9779 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: Ib8bbba8d6e3364f7474643ddb60a469497437616
2014-06-13coverity#706514 Uncaught exceptionCaolán McNamara
also coverity#706515 coverity#706516 coverity#706517 coverity#706528 coverity#706529 Change-Id: I5beb753d5cc8ed976b3c11319cc36415adebd1e6
2014-06-12loplugin:unreffunStephan Bergmann
Change-Id: Ia4eda7adc7685809b69a248f664b6a38dc3ea0e6
2014-06-12scn resource file is empty now post ui-ificationCaolán McNamara
Change-Id: Id8a6d6c4faf3101b13d84de180f8db7cab2cb16f
2014-06-12more the png into the .ui so it isn't garbage collectedCaolán McNamara
Change-Id: If0d3829bfc14c602a0167967cbe215782c75f549
2014-06-12extract gamma grid drawing to standalone widgetCaolán McNamara
so the dialog stops scribbling on itself, and instead uses a real widget for that This has to be one of our weirdest dialogs, why expend so much effort to create this dialog for the most obscure of issues. Change-Id: Ia25e6c67fb278528c6c68a1d6db74de59915fd34
2014-06-12don't use raw english stringCaolán McNamara
Change-Id: I5f34889520afb2149ba480f56d59f14d75ee50c0
2014-06-12Convert GRID_DIALOG to .uiPalenik Mihály
Change-Id: I4476559cc2e6a90b65d5bdc8169b256929f07f7e Reviewed-on: https://gerrit.libreoffice.org/9734 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-11Resurrect SaneResId in the place where it is still usedStephan Bergmann
Change-Id: I20f751f6b9fdf683566544aed4ca2ad877abc253
2014-06-11loplugin:unreffunStephan Bergmann
Change-Id: Iffc5a864954e106e1b20a86c8caddf4257ff139e
2014-06-11Reset preview boundaries on a new scannerCaolán McNamara
Change-Id: Id2830727216fa25ca5935406a74f4237276d56db
2014-06-11Changing scanners has no effectCaolán McNamara
I guess no-one ever tested with multiple scanners but it just happens that my laptops webcam is presented as a (non-functional) scanner alongside the real one Change-Id: Ie36651cfc867027ef19e272dbabe46de6c4261ee
2014-06-11extract Scan Preview code into a preview widgetCaolán McNamara
instead of scribbling over the parent dialog directly. Doing is this way allows the .ui-ification to work right. Change-Id: Ia0c33eae4cd5a4c94896436fe5a5afad8d60a577
2014-06-11Convert RID_SANE_DIALOG to .uiPalenik Mihály
Change-Id: I1f08493cdc18f4c0691a8436368432fe4e94dec3 Reviewed-on: https://gerrit.libreoffice.org/9696 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-10Filter out OS not needing -ldlBaptiste Daroussin
Change-Id: I5863de6d8b1f0fe2419ea7419b1ff90087bb513d Reviewed-on: https://gerrit.libreoffice.org/9715 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-06-09extensions: tweak quoting for Win32 makeMichael Stahl
Change-Id: I6e3524ab98ec6ffdea24be808a718b2798e44f95
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-06fixincludeguards: fix include guardsThomas Arnhold
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b Reviewed-on: https://gerrit.libreoffice.org/9629 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-05extensions: remove SAL_THROW macroNoel Grandin
Change-Id: I12b5b46d31d5189adb21804a818ce591f2c19cbf
2014-06-04coverity#705376 Inferred misuse of enumCaolán McNamara
Change-Id: Ie0e44c872d5d99d15508f8abedb51450a0e36ad0
2014-06-04coverity#705375 Mixing enum typesCaolán McNamara
Change-Id: Ic7cb53d8fe427b4c28b890b64fa4437846b5b493
2014-06-04compareToAscii -> equalsAsciiNoel Grandin
convert places using compareToAscii that should be using equalsAscii Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
2014-06-04DeInitVCL at end of testsStephan Bergmann
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-05-29define->endifCaolán McNamara
Change-Id: I3b97d4473b1a1000a1de1fdc96525333948f73d5
2014-05-29fdo#68849: Add header guards to all include filesJens Carl
Added header guards to files in directory extensions/* Change-Id: If6a1642d726732fa05735c721f31b6fc7c405608 Reviewed-on: https://gerrit.libreoffice.org/9537 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-29remove more unnecesary OUString constructor useNoel Grandin
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29remove unnecessary NULL parameter passed to UNO ExceptionNoel Grandin
.. now that we have a default value for that parameter Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-27remove unnecessary use of Reference constructor in throwNoel Grandin
Convert code like this: throw IOException("xx", Reference< XInterface >(static_cast<OWeakObject*>(this)) ); to this: throw IOException("xx", static_cast<OWeakObject*>(this) ); Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-24coverity#983672 Uncaught exceptionCaolán McNamara
Change-Id: I1b2ff484906ba3dc85fa4926dbbf45c91a57c6be
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-22Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19Julien Nabet
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-14Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part12Julien Nabet
Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7
2014-05-13Related fdo#60338: do not call umask(3) in a MT programStephan Bergmann
...and it is unclear what this call was supposed to help for; if a user deliberately sets its umask too strong, then better live with the consequences than to silently "fix" it. Change-Id: I0d84a7d1bd6f007794a65e1f7cc4ea09ebd9d4af
2014-05-12callcatcher: update unused codeCaolán McNamara
Change-Id: If239c30e0e63311a91c757da466bb37d89abcfe4
2014-05-11coverity#738627 Uninitialized scalar fieldCaolán McNamara
Change-Id: I32d0f04a3346aa2ec8df6dbd8709c74f45c66c06
2014-05-11Fix previous commit (extensions part, second)Julien Nabet
Change-Id: Iac6c801478a583346c8358456b788a0085158981
2014-05-11Fix previous commit (extensions part)Julien Nabet
Change-Id: I942cca3639e4d823415da557262e35432a798d04
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-10Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part9Julien Nabet
Change-Id: I82ed4a4868cb22566706ca0f4b1321e0d45016cf
2014-05-10remove globally disabled warnings from source filesThomas Arnhold
Change-Id: Ic7b092a24b4d1e48ca11e53b507da5c2bfdeabe8