summaryrefslogtreecommitdiff
path: root/external/graphite
AgeCommit message (Collapse)Author
2024-05-06makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo)Christian Lohmaier
…by a simple/static $(gb_UnpackedTarball_workdir)/foo see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f Change-Id: I8e6aa55c85534c4446556548910c950ddbe7c6fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167163 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2023-12-11external/graphite: operation between different enumeration typesStephan Bergmann
> workdir/UnpackedTarball/graphite/src/Pass.cpp:197:92: error: invalid arithmetic between different enumeration types ('status_t' and 'graphite2::errors') > 197 | || e.test(m_cPConstraint.status() != Code::loaded, m_cPConstraint.status() + E_CODEFAILURE)) > | ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18 trunk since <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31> "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on Enumerations (#73105)" Change-Id: I34b2743d46b8f46b1f39b2af812f95876e4b9e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160550 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2019-05-24disable warnings in external libsLuboš Luňák
As in, really disable, so that they do not even show. This moreover avoids tons of D9025 warnings from MSVC about overriding -W4 with -w. Change-Id: Ia2e72fd72d883d91bdd89e467ee42f259e2ae033 Reviewed-on: https://gerrit.libreoffice.org/72899 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-04-11graphite: Force optimization on Android.Jan Holesovsky
The Pass.cpp triggers an infinite loop in clang when not optimizing (ie. with the debugging buildls), at least with this version: > ~/Android/Sdk/ndk-bundle/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --version Android (5058415 based on r339409) clang version 8.0.2 (https://android.googlesource.com/toolchain/clang 40173bab62ec746213857d083c0e8b0abb568790) (https://android.googlesource.com/toolchain/llvm 7a6618d69e7e8111e1d49dc9e7813767c5ca756a) (based on LLVM 8.0.2svn) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /local/home/kendy/Android/Sdk/ndk-bundle/toolchains/llvm/prebuilt/linux-x86_64/bin Change-Id: Ib4984f8838fc733be6da4e24eb10915d3efbf79e
2018-12-16Add back still-relevant part of external/graphite/ubsan.patchStephan Bergmann
...which had been removed completely with 6b84708914f9c026776b28a300ac6d278272881f "graphite: update to 1.3.12". See <https://ci.libreoffice.org/job/lo_ubsan/1137/>: > /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16: runtime error: downcast of address 0x60f00008c3b0 which does not point to an object of type 'gr_face' > 0x60f00008c3b0: note: object is of type 'graphite2::Face' > 2a 00 00 61 d0 17 e7 ff 99 2b 00 00 36 00 be be be be be be 88 d8 0e 00 d0 61 00 00 80 38 05 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'graphite2::Face' > #0 0x2b99fdaae105 in gr_make_face_with_ops /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16 > #1 0x2b99fdaaeabe in gr_make_face /workdir/UnpackedTarball/graphite/src/gr_face.cpp:107:12 > #2 0x2b99fdfd6dc7 in _hb_graphite2_shaper_face_data_create /workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:114:18 > #3 0x2b99fdfd62f0 in hb_graphite2_shaper_face_data_ensure /workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:37:1 > #4 0x2b99fddb6a10 in hb_shape_plan_create_cached2 /workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:35:1 > #5 0x2b99fddb1478 in hb_shape_full /workdir/UnpackedTarball/harfbuzz/src/hb-shape.cc:133:33 > #6 0x2b99fc5867df in GenericSalLayout::LayoutText(ImplLayoutArgs&, SalLayoutGlyphs const*) /vcl/source/gdi/CommonSalLayout.cxx:440:23 > #7 0x2b99fb2345e4 in OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:1310:36 > #8 0x2b99fb236220 in OutputDevice::GetTextArray(rtl::OUString const&, long*, int, int, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:960:45 > #9 0x2b99fb235c56 in OutputDevice::GetTextWidth(rtl::OUString const&, int, int, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:881:19 > #10 0x2b99fd105281 in ImplFontMetricData::ImplInitTextLineSize(OutputDevice const*) /vcl/source/font/fontmetric.cxx:325:30 > #11 0x2b99fb1c128c in OutputDevice::ImplNewFont() const /vcl/source/outdev/font.cxx:1062:38 > #12 0x2b99fb1bd46c in OutputDevice::GetFontFeatures(std::__debug::vector<vcl::font::Feature, std::allocator<vcl::font::Feature> >&) const /vcl/source/outdev/font.cxx:171:10 > #13 0x2b9a1a3c8607 in FontFeatureTest::testGetFontFeatures() /vcl/qa/cppunit/FontFeatureTest.cxx:58:5 > #14 0x2b9a1a401f2c in void std::__invoke_impl<void, void (FontFeatureTest::*&)(), FontFeatureTest*&>(std::__invoke_memfun_deref, void (FontFeatureTest::*&)(), FontFeatureTest*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14 > #15 0x2b9a1a401b0f in std::__invoke_result<void (FontFeatureTest::*&)(), FontFeatureTest*&>::type std::__invoke<void (FontFeatureTest::*&)(), FontFeatureTest*&>(void (FontFeatureTest::*&)(), FontFeatureTest*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14 > #16 0x2b9a1a40195c in void std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()>::__call<void, 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:467:11 > #17 0x2b9a1a401533 in void std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()>::operator()<void>() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:549:17 > #18 0x2b9a1a400340 in std::_Function_handler<void (), std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:316:2 > #19 0x2b9a1a40259c in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:706:14 > #20 0x2b9a1a3ff580 in CppUnit::TestCaller<FontFeatureTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7 > #21 0x2b99d930dab8 in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #22 0x2b99f39cf332 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:49:14 > #23 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #24 0x2b99e850d672 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #25 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #26 0x2b99e5130312 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #27 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #28 0x2b99d9273d82 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #29 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #30 0x2b99d92d7f02 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #31 0x2b99d93705e5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28 > #32 0x2b99d930c135 in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #33 0x2b99d930ff12 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #34 0x2b99d930f0ed in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #35 0x2b99d930ff12 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #36 0x2b99d930f0ed in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #37 0x2b99d939eb32 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #38 0x2b99d936f075 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9 > #39 0x2b99d939fa80 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #40 0x543813 in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:316:20 > #41 0x54027d in sal_main() /sal/cppunittester/cppunittester.cxx:466:20 > #42 0x53f26e in main /sal/cppunittester/cppunittester.cxx:373:1 > #43 0x2b99daec8444 in __libc_start_main (/lib64/libc.so.6+0x22444) > #44 0x42f454 in _start (/workdir/LinkTarget/Executable/cppunittester+0x42f454) > > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16 in > > Error: a unit test failed, please do one of: > > make CppunitTest_vcl_fontfeature CPPUNITTRACE="gdb --args" > # for interactive debugging on Linux > make CppunitTest_vcl_fontfeature VALGRIND=memcheck > # for memory checking > make CppunitTest_vcl_fontfeature DEBUGCPPUNIT=TRUE > # for exception catching > > You can limit the execution to just one particular test by: > > make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params... > > /home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/CppunitTest.mk:113: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/CppunitTest/vcl_fontfeature.test' failed Change-Id: Iccb72ec8a4c507478858ceb5af32b75f5ae53a45 Reviewed-on: https://gerrit.libreoffice.org/65226 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-14graphite: update to 1.3.12Miklos Vajna
Martin Hosken thinks all patches are redundant now, so drop them. Change-Id: I062168416a1289b7f4dd42d8ae58b7df56a37712 Reviewed-on: https://gerrit.libreoffice.org/65074 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2017-11-01-I$(dir $(3)) in gb_CObject__command_pattern is no longer neededStephan Bergmann
...at least in com_GCC_class.mk (com_MSC_class.mk will be addressed in a follow- up commit), after the recent loplugin:includeform clean-up. Two static libraries built from external sources needed adjustment, two compilerplugin tests needed adjustment (which wasn't found by loplugin:includeform, by design), and one more adjustment in sal/textenc/generate/. Change-Id: Idad5ae355a02ae130369a9a45b5f5925ab48ffef Reviewed-on: https://gerrit.libreoffice.org/44174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-05external/graphite: Avoid -fsanitize=pointer-overflowStephan Bergmann
...as seen during CppunitTest_sc_subsequent_filters_test: > workdir/UnpackedTarball/graphite/src/TtfUtil.cpp:1250:25: runtime error: unsigned pointer index expression result is 0x7fc5e2857433, preceding its base 0x7fc5e2857434 > #0 0x7fc663188640 in graphite2::TtfUtil::GlyfLookup(void const*, unsigned long, unsigned long) workdir/UnpackedTarball/graphite/src/TtfUtil.cpp:1250:25 > #1 0x7fc663159b1d in graphite2::GlyphCache::Loader::read_glyph(unsigned short, graphite2::GlyphFace&, int*) const workdir/UnpackedTarball/graphite/src/GlyphCache.cpp:360:28 > #2 0x7fc663158e37 in graphite2::GlyphCache::GlyphCache(graphite2::Face const&, unsigned int) workdir/UnpackedTarball/graphite/src/GlyphCache.cpp:142:52 > #3 0x7fc66314eaf9 in graphite2::Face::readGlyphs(unsigned int) workdir/UnpackedTarball/graphite/src/Face.cpp:98:29 > #4 0x7fc66314167e in (anonymous namespace)::load_face(graphite2::Face&, unsigned int) workdir/UnpackedTarball/graphite/src/gr_face.cpp:54:19 > #5 0x7fc6631413eb in gr_make_face_with_ops workdir/UnpackedTarball/graphite/src/gr_face.cpp:89:16 > #6 0x7fc6631419d7 in gr_make_face workdir/UnpackedTarball/graphite/src/gr_face.cpp:99:12 > #7 0x7fc663135362 in _hb_graphite2_shaper_face_data_create workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:113:18 > #8 0x7fc663076a1e in hb_graphite2_shaper_face_data_ensure(hb_face_t*) workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:35:1 > #9 0x7fc663076530 in hb_shape_plan_create_cached workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:35:1 > #10 0x7fc66262932e in CommonSalLayout::LayoutText(ImplLayoutArgs&) vcl/source/gdi/CommonSalLayout.cxx:608:40 > #11 0x7fc661ea3287 in OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*) const vcl/source/outdev/text.cxx:1359:36 > #12 0x7fc661ea5916 in OutputDevice::GetTextArray(rtl::OUString const&, long*, int, int, vcl::TextLayoutCache const*, SalLayout const*) const vcl/source/outdev/text.cxx:1004:22 > #13 0x7fc661ea56ee in OutputDevice::GetTextWidth(rtl::OUString const&, int, int, vcl::TextLayoutCache const*, SalLayout const*) const vcl/source/outdev/text.cxx:924:19 > #14 0x7fc662a49b18 in ImplFontMetricData::ImplInitTextLineSize(OutputDevice const*) vcl/source/font/fontmetric.cxx:338:30 > #15 0x7fc661e69138 in OutputDevice::ImplNewFont() const vcl/source/outdev/font.cxx:1097:42 > #16 0x7fc661e6ce1e in OutputDevice::GetFontCharMap(tools::SvRef<FontCharMap>&) const vcl/source/outdev/font.cxx:235:9 > #17 0x7fc661e7d5a9 in OutputDevice::HasGlyphs(vcl::Font const&, rtl::OUString const&, int, int) const vcl/source/outdev/font.cxx:1506:17 > #18 0x7fc61da7a450 in VCLXFont::hasGlyphs(rtl::OUString const&) toolkit/source/awt/vclxfont.cxx:206:23 > #19 0x7fc605fce1d3 in oox::xls::Font::finalizeImport() sc/source/filter/oox/stylesbuffer.cxx:787:28 > #20 0x7fc606037909 in void std::_Bind<std::_Mem_fn<void (oox::xls::Font::*)()> (std::_Placeholder<1>)>::__call<void, oox::xls::Font&, 0ul>(std::tuple<oox::xls::Font&>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:933:11 > #21 0x7fc606037692 in void std::_Bind<std::_Mem_fn<void (oox::xls::Font::*)()> (std::_Placeholder<1>)>::operator()<oox::xls::Font&, void>(oox::xls::Font&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:991:17 > #22 0x7fc606034c6a in oox::RefVector<oox::xls::Font>::ForEachFunctor<std::_Bind<std::_Mem_fn<void (oox::xls::Font::*)()> (std::_Placeholder<1>)> > std::for_each<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::shared_ptr<oox::xls::Font> const*, std::__cxx1998::vector<std::shared_ptr<oox::xls::Font>, std::allocator<std::shared_ptr<oox::xls::Font> > > >, std::__debug::vector<std::shared_ptr<oox::xls::Font>, std::allocator<std::shared_ptr<oox::xls::Font> > > >, oox::RefVector<oox::xls::Font>::ForEachFunctor<std::_Bind<std::_Mem_fn<void (oox::xls::Font::*)()> (std::_Placeholder<1>)> > >(__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::shared_ptr<oox::xls::Font> const*, std::__cxx1998::vector<std::shared_ptr<oox::xls::Font>, std::allocator<std::shared_ptr<oox::xls::Font> > > >, std::__debug::vector<std::shared_ptr<oox::xls::Font>, std::allocator<std::shared_ptr<oox::xls::Font> > > >, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::shared_ptr<oox::xls::Font> const*, std::__cxx1998::vector<std::shared_ptr<oox::xls::Font>, std::allocator<std::shared_ptr<oox::xls::Font> > > >, std::__debug::vector<std::shared_ptr<oox::xls::Font>, std::allocator<std::shared_ptr<oox::xls::Font> > > >, oox::RefVector<oox::xls::Font>::ForEachFunctor<std::_Bind<std::_Mem_fn<void (oox::xls::Font::*)()> (std::_Placeholder<1>)> >) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/stl_algo.h:3769:2 > #23 0x7fc6060348ad in void oox::RefVector<oox::xls::Font>::forEach<std::_Bind<std::_Mem_fn<void (oox::xls::Font::*)()> (std::_Placeholder<1>)> >(std::_Bind<std::_Mem_fn<void (oox::xls::Font::*)()> (std::_Placeholder<1>)>) const include/oox/helper/refvector.hxx:62:29 > #24 0x7fc606005f5a in void oox::RefVector<oox::xls::Font>::forEachMem<void (oox::xls::Font::*)()>(void (oox::xls::Font::*)()) const include/oox/helper/refvector.hxx:70:29 > #25 0x7fc605ffab14 in oox::xls::StylesBuffer::finalizeImport() sc/source/filter/oox/stylesbuffer.cxx:2769:13 > #26 0x7fc6163aa7e6 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:855:40 > #27 0x7fc641f9ab9c in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) oox/source/core/fastparser.cxx:123:15 > #28 0x7fc641f9b0be in oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&) oox/source/core/fastparser.cxx:131:5 > #29 0x7fc64201cb63 in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) oox/source/core/xmlfilterbase.cxx:354:21 > #30 0x7fc64201c40a in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&) oox/source/core/xmlfilterbase.cxx:296:12 > #31 0x7fc6060c309e in oox::xls::WorkbookFragment::finalizeImport() sc/source/filter/oox/workbookfragment.cxx:360:9 > #32 0x7fc6163aa7e6 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) sax/source/fastparser/fastparser.cxx:855:40 > #33 0x7fc641f9ab9c in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) oox/source/core/fastparser.cxx:123:15 > #34 0x7fc641f9b0be in oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&) oox/source/core/fastparser.cxx:131:5 > #35 0x7fc64201cb63 in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) oox/source/core/xmlfilterbase.cxx:354:21 > #36 0x7fc64201c40a in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&) oox/source/core/xmlfilterbase.cxx:296:12 > #37 0x7fc605bff1da in oox::xls::ExcelFilter::importDocument() sc/source/filter/oox/excelfilter.cxx:100:32 > #38 0x7fc641fa97b1 in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) oox/source/core/filterbase.cxx:488:55 > #39 0x7fc605c005f8 in oox::xls::ExcelFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sc/source/filter/oox/excelfilter.cxx:154:25 > #40 0x7fc62e0ed38d in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sfx2/source/doc/objstor.cxx:2219:34 > #41 0x7fc62e0cdff3 in SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:759:23 > #42 0x7fc6302f087c in ScBootstrapFixture::load(bool, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned long, rtl::OUString const*) sc/qa/unit/helper/qahelper.cxx:585:21 > #43 0x7fc6302f12cb in ScBootstrapFixture::loadDoc(rtl::OUString const&, int, bool) sc/qa/unit/helper/qahelper.cxx:616:12 > #44 0x7fc64b042040 in ScFiltersTest::testColumnStyle2XLSX() sc/qa/unit/subsequent_filters-test.cxx:3729:28 > #45 0x7fc64b0b4c56 in void std::_Bind<std::_Mem_fn<void (ScFiltersTest::*)()> (ScFiltersTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:933:11 > #46 0x7fc64b0b4a1d in void std::_Bind<std::_Mem_fn<void (ScFiltersTest::*)()> (ScFiltersTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:991:17 > #47 0x7fc67f692258 in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #48 0x7fc67f6630d5 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #49 0x7fc67f6630d5 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #50 0x7fc6738fe014 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #51 0x7fc67f6630d5 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #52 0x7fc67f5f932d in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #53 0x7fc67f6630d5 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #54 0x7fc67f65c5fa in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #55 0x7fc67f6f4598 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28 > #56 0x7fc67f690859 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #57 0x7fc67f694624 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #58 0x7fc67f69387c in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #59 0x7fc67f694624 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #60 0x7fc67f69387c in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #61 0x7fc67f722f5c in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #62 0x7fc67f6f304e in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9 > #63 0x7fc67f723e7e in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #64 0x532f3d in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316:20 > #65 0x53101c in sal_main() sal/cppunittester/cppunittester.cxx:466:20 > #66 0x530a36 in main sal/cppunittester/cppunittester.cxx:373:1 > #67 0x7fc67dc44400 in __libc_start_main /usr/src/debug/glibc-2.24-59-g86ac4a7/csu/../csu/libc-start.c:289 > #68 0x4385a9 in _start (workdir/LinkTarget/Executable/cppunittester+0x4385a9) Change-Id: I7289846da81944c53756b842b2ac246ec1aecea7
2017-06-07external/graphite: Avoid -fsanitize=pointer-overflowStephan Bergmann
...that was recently introduced into Clang trunk with <https://reviews.llvm.org/D33305> "[ubsan] Add a check for pointer overflow UB". Here, _code is of type instr*, dist is of type ptrdiff_t, and sizeof(instr) is something like 8. My first impulse was to cast the result of the division (done with arguments promoted to size_t) back to ptrdiff_t, but that wouldn't help: When dist is a relatively small negative number (like -3293184), the division expression will promote it to a large unsigned (size_t) value (like 0xFFFF'FFFF'FFCD'C000), but the result (in our case, 0x1FFF'FFFF'FFF9'B800) would be small enough to fit into ptrdiff_t as a positive value. So assume that sizeof(instr) fits into int and ensure the division is done on signed values. (At least CppunitTest_sc_subsequent_filters_test started to fail with "workdir/UnpackedTarball/graphite/src/inc/Code.h:165:15: runtime error: pointer index expression with base 0x7fb90a3b4df0 overflowed to 0x7fb90a0a0df0".) Change-Id: Ie6698e38d6abec80f2fa817c42ebf20618496109
2017-06-07Remove gb_LinkTarget_add_generated_cxxobjectsStephan Bergmann
...in favor of gb_LinkTarget_add_generated_exception_objects. The former would have needed any flags to be passed in explicitly (but no call sites did), so e.g. StaticLibrary_graphite didn't have any debug information (when building with --enable-debug). I guess there is no downside to having C++ exception support enabled in these places, and using _add_generated_cxxobjects instead was likely an oversight in the first place (at least in the case of external/graphite/StaticLibrary_graphite.mk, it was that way ever since 1ceb47d96da9e7977c96241f49ad291ff0466970 "graphite: convert to gbuild", but for no apparent reason). Change-Id: I9986a6c5ec30a521095dbe5315e5ca649741a790
2016-11-11new release of Graphite lib: 1.3.9Andras Timar
Change-Id: I4e9a7ebf323848a03e02da3e9ed39377d1df6715 Reviewed-on: https://gerrit.libreoffice.org/30771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-04-01Fix up upgrade to graphite 1.3.8Martin Hosken
Change-Id: Idd7945176e1f667c29ff11144dc78870110bf562 Reviewed-on: https://gerrit.libreoffice.org/23716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2016-01-06Refresh graphite2.win64.patch.1 to apply using sle11 patch binary.Tomáš Chvátal
Change-Id: If43ca99631fab5a3a04e7dead9b694cf52944666 Reviewed-on: https://gerrit.libreoffice.org/20882 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-11-12Generalize COM_GCC_IS_CLANG -> COM_IS_CLANGStephan Bergmann
...in anticipation of building with clang-cl.exe on Windows Change-Id: I1d723c9d3b5ca8a2bc6b27ef0189a7b053581398 Reviewed-on: https://gerrit.libreoffice.org/19928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-24Fix graphite sole diacritic renderingMartin Hosken
Change-Id: If44ab2ff8c860fbed2af3b4702fa031675e425f4 Reviewed-on: https://gerrit.libreoffice.org/18757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2015-09-17Fix Graphite windows build staticMartin Hosken
Change-Id: I6feb3805e79f7cae4a8df7efa665fd97c56411c2 Reviewed-on: https://gerrit.libreoffice.org/18654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2015-09-14Refactor graphite integration and update graphiteMartin Hosken
Change-Id: I09db7262c2a6180a078620ba086dd7a4c132bd82 Reviewed-on: https://gerrit.libreoffice.org/18459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2015-06-29external/graphite: work around -fsanitize=nonnull-attribute/vptrStephan Bergmann
Change-Id: Ic0766555dc7a04bbb8c7ad8f9cba3d74d84c59db
2015-03-02remove executable bit from .mk / .patch filesMichael Stahl
Change-Id: Ic8560c9ea13bee56b63e4661446689c7857f789e
2015-02-04Fix graphite on windows 64 bitDavid Ostrovsky
Change-Id: I509fcf9194d3cc0d4454e31a9f7dfbb7f22c421c Reviewed-on: https://gerrit.libreoffice.org/14316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-15Graphite: Add link to main development site and issue trackerDavid Ostrovsky
Change-Id: I8f7777c1234a69e1851b8f4f4e8afc8466cc2e06 Reviewed-on: https://gerrit.libreoffice.org/13918 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2013-12-12Update bundled Graphite to 1.2.4Khaled Hosny
Change-Id: Id8c90b58c40bd449617c58f6c9e7cdea035a1c41 Reviewed-on: https://gerrit.libreoffice.org/7056 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-18Fix building from inside modules moved to externalKhaled Hosny
Change-Id: Id6023dc3751fe70984f489682be17d1ab1855f71
2013-10-18fdo#70393: move graphite to a subdir of externalKhaled Hosny
Change-Id: If0f3c19fd539d2b1323016df032b9f959a0adf66 Reviewed-on: https://gerrit.libreoffice.org/6305 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>