summaryrefslogtreecommitdiff
path: root/external
AgeCommit message (Collapse)Author
2023-05-18tdf#63130 improve the performance in librevengeNoel Grandin
we end up generating a ton of base64 encoded strings when loading a visio file, so reduce some copying here Change-Id: I2d56fda867032b23b03971731b2565f1edc2e1a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151882 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-17tdf#92824 spell checking: limit suggestions only for the best onesLászló Németh
Apply Hunspell fix to keep only the best suggestions, if they exist to avoid of overgenerating worse suggestions especially for short bad words. See Hunspell commit b88f9ea57bdb9b219f3c1d2c67f4f882f1f23194 "Keep only REP, ph: or 2-word dictionary phrase suggestions These are the best suggestions, no need to search other ones to avoid annoying redundant and long list. For example to suggest only "a lot" to the bad form "alot", add the 2-word phrase "a lot" to the dic file. Or for a very typical spelling mistake, enough to specify the bad form with a ph: in the dictionary file to remove the other suggestions." Change-Id: I0272bb9ed2dd493aa372feb68d1937e359910e0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151868 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-17ofz#57493 reduce num_edges required to triggerCaolán McNamara
Change-Id: Idb6127d8943dbf62d8cacb7f2f5382a1e8619aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-11ofz#57493 Timeout in _cairo_bo_event_queue_sort with > 200000 edgesCaolán McNamara
Change-Id: Id925da604647973977c25bbbfa57b1a69382e063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09Reinstate external/libwpg/rpath.patchStephan Bergmann
...which 0c0c9a0dd8a7b102315ab1075f78a0f1f3397b67 "tdf#155057: Wrong colors in some WPG2 (well rendered in WPG1)" had dropped for no apparent reason, causing > [CHK] CustomTarget/postprocess/check_dynamic_objects/check.done > ~/lo/core/instdir/program/libwpg-0.3-lo.so.3 has unexpected RPATH 0x000000000000001d (RUNPATH) Library runpath: [~/lo/core/workdir/UnpackedTarball/libwpd/src/lib/.libs:~/lo/core/workdir/UnpackedTarball/librevenge/src/lib/.libs:/usr/local/lib:$ORIGIN] to fail (in Linux builds that execute that test) Change-Id: Id9f87b14f571b328b98496625351bc1f87bf8c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151555 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-04external/libjpeg-turbo: Missing include (for FILE)Stephan Bergmann
Change-Id: Ifb80f4824ab7a89177171f7dc91a2c6bb6f954f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151369 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-02tdf#155057: Wrong colors in some WPG2 (well rendered in WPG1)Julien Nabet
Thank you Fridrich Strba for the quick fix in libwpg! Change-Id: Icb2a48cdd7846ac9f2b32ca65a479381d8c8bfed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151217 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26Revert "workaround compile failures in libxml, with clang-17"Noel Grandin
This reverts commit 4a828dde104551c1c3d935ed8b43ebc546fa77c3. Reason for revert: Caolan merged a better fix with aa87fe2562e7a55a18a1c757a49babfe74377bcd Change-Id: I3ae713555fc62782675dbc48ad51a36ff41bfcf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-25add --disable-pedantic to avoid warnings as error for xmlsecCaolán McNamara
like... symkeys.c:621:30: error: no newline at end of file [-Werror,-Wnewline-eof] #endif /* XMLSEC_NO_PBKDF2 */ ^ 1 error generated. make[5]: *** [Makefile:765: libxmlsec1_openssl_la-symkeys.lo] Error 1 Change-Id: I1dcd0cb6b350f412c30fb5a8d3aa4976cd0afde5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150980 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25workaround compile failures in libxml, with clang-17Noel Grandin
ever since commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b Author: Miklos Vajna <vmiklos@collabora.com> Date: Mon Apr 24 14:27:47 2023 +0200 Update libxmlsec to 1.3.0 failures reported to https://github.com/lsh123/xmlsec/discussions/623 Change-Id: I2952f0eda036f6ff69710b8a103bbfc846ed87d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150966 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-17Upgrade external/boost to latest Boost 1.82.0Stephan Bergmann
<https://dev-www.libreoffice.org/src/boost_1_82_0.tar.xz> has been generated (on Fedora 38) with > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.82.0/source/boost_1_82_0.tar.bz2 > $ printf 'a6e1ab9b0860e6a2881dd7b21fe9f737a095e5f33a3a874afc6a345228597ee6 boost_1_82_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_82_0.html> > boost_1_82_0.tar.bz2: OK > $ external/boost/repack_tarball.sh boost_1_82_0.tar.bz2 > Unpacking boost_1_82_0.tar.bz2 ... > Removing unnecessary files ... > Creating boost_1_82_0.tar.xz ... > Cleaning up ... > e48ab6953fbd68ba47234bea5173e62427e9f6a7894e152305142895cfe955de boost_1_82_0.tar.xz > Done. * Updating StaticLibrary_boost_locale.mk is needed to avoid > workdir/UnpackedTarball/boost/libs/locale/src/boost/locale/util/locale_data.cpp:137: error: undefined reference to 'boost::locale::util::normalize_encoding(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' Change-Id: Iff3f5249df0fcf75f5a50e7eb35ef64373af8184 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150516 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-06poppler: upgrade to release 23.03.0Taichi Haradaguchi
* Upgrade poppler-data to 0.4.12 * Update poppler-config.patch.1 Change-Id: Ic2a3e8d4f801d52d1568210d0df064cacb51290f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148842 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-31fix poppler buildTaichi Haradaguchi
* Update POPPLER_VERSION in poppler-config.patch.1 Change-Id: Iba770e6a3036a091925997025d4528f1d855da5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-29libjpeg-turbo: upgrade to release 2.1.5.1Taichi Haradaguchi
Fixes a serious regression that 2.1.5 had.[1] [1] "Release 2.1.5.1 · libjpeg-turbo/libjpeg-turbo" <https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.1.5.1> Change-Id: I0586d735e17789482e0e8e667aafd2b5613a1232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-23Upgrade Harfbuzz to 7.1.0Taichi Haradaguchi
* Fixes CVE-2023-25193. * if Harfbuzz >= 7.0.0, uses hb_font_draw_glyph() instead of hb_font_get_glyph_shape(). * Update URL in README. Change-Id: Id234c2b459c40ddac340731b44889b104e03a1e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148743 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-03-13Update pdfium to 5636Miklos Vajna
Some changes in the bundled libtiff, but it seems that would be for XFA which we disable, so it doesn't affect us. Change-Id: Ibadeecf20daec342fbfef6d1e89bd17f5f0095e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148652 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-06external/fontconfig: Silence UBSan nullptr-with-offsetStephan Bergmann
...during CppunitTest_cppcanvas_test, > fcserialize.c:166:54: runtime error: applying zero offset to null pointer > #0 in FcSerializeResize at workdir/UnpackedTarball/fontconfig/src/fcserialize.c:166:54 > #1 in FcSerializeSet at workdir/UnpackedTarball/fontconfig/src/fcserialize.c:204:7 > #2 in FcSerializeAlloc at workdir/UnpackedTarball/fontconfig/src/fcserialize.c:228:10 > #3 in FcStrSerializeAlloc at workdir/UnpackedTarball/fontconfig/src/fcserialize.c:274:12 > #4 in FcDirCacheBuild at workdir/UnpackedTarball/fontconfig/src/fccache.c:1255:10 > #5 in FcDirCacheScan at workdir/UnpackedTarball/fontconfig/src/fcdir.c:360:13 > #6 in FcDirCacheRead at workdir/UnpackedTarball/fontconfig/src/fcdir.c:462:10 > #7 in FcConfigAddDirList at workdir/UnpackedTarball/fontconfig/src/fccfg.c:516:10 > #8 in FcConfigAppFontAddDir at workdir/UnpackedTarball/fontconfig/src/fccfg.c:2891:10 > #9 in psp::PrintFontManager::addFontconfigDir(rtl::OString const&) at vcl/unx/generic/fontmanager/fontconfig.cxx:745:20 > #10 in psp::PrintFontManager::initialize() at vcl/unx/generic/fontmanager/fontmanager.cxx:683:17 > #11 in GenericUnixSalData::InitPrintFontManager() at vcl/unx/generic/app/gendata.cxx:65:26 > #12 in GenericUnixSalData::GetPrintFontManager() at vcl/inc/unx/gendata.hxx:100:13 > #13 in psp::PrintFontManager::get() at vcl/unx/generic/fontmanager/fontmanager.cxx:105:23 > #14 in GenPspGraphics::GetDevFontListHelper(vcl::font::PhysicalFontCollection*) at vcl/unx/generic/print/genpspgraphics.cxx:248:35 > #15 in FreeTypeTextRenderImpl::GetDevFontList(vcl::font::PhysicalFontCollection*) at vcl/unx/generic/gdi/freetypetextrender.cxx:110:5 > #16 in SvpSalGraphics::GetDevFontList(vcl::font::PhysicalFontCollection*) at vcl/headless/svptext.cxx:51:23 > #17 in OutputDevice::ImplInitFontList() const at vcl/source/outdev/font.cxx:643:17 > #18 in OutputDevice::ImplNewFont() const at vcl/source/outdev/font.cxx:700:5 > #19 in OutputDevice::InitFont() const at vcl/source/outdev/font.cxx:660:10 > #20 in OutputDevice::GetTextHeight() const at vcl/source/outdev/text.cxx:899:10 > #21 in vcl::Window::GetTextHeight() const at vcl/source/window/window3.cxx:65:65 > #22 in vcl::Window::ImplInitAppFontData(vcl::Window const*) at vcl/source/window/window.cxx:1188:40 > #23 in vcl::Window::ImplInit(vcl::Window*, long, SystemParentData*) at vcl/source/window/window.cxx:1182:9 > #24 in ImplBorderWindow::ImplInit(vcl::Window*, long, BorderWindowStyle, SystemParentData*) at vcl/source/window/brdwin.cxx:1557:13 > #25 in ImplBorderWindow::ImplBorderWindow(vcl::Window*, SystemParentData*, long, BorderWindowStyle) at vcl/source/window/brdwin.cxx:1586:5 > #26 in VclPtrInstance<ImplBorderWindow>::VclPtrInstance<vcl::Window*&, SystemParentData*&, long&, BorderWindowStyle&>(vcl::Window*&, SystemParentData*&, long&, BorderWindowStyle&) at include/vcl/vclptr.hxx:280:39 > #27 in WorkWindow::ImplInit(vcl::Window*, long, SystemParentData*) at vcl/source/window/wrkwin.cxx:51:38 > #28 in WorkWindow::WorkWindow(vcl::Window*, long) at vcl/source/window/wrkwin.cxx:95:5 > #29 in ScopedVclPtrInstance<WorkWindow>::ScopedVclPtrInstance<std::nullptr_t, long const&>(std::nullptr_t&&, long const&) at include/vcl/vclptr.hxx:412:45 > #30 in CanvasTest::testComposite() at cppcanvas/qa/unit/test.cxx:38:38 Change-Id: I90c86931ae5d4dfb32a1a95a5eb660484b54f09a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148287 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-01fontconfig: upgrade to release 2.14.2Taichi Haradaguchi
Change-Id: I5347580318c752517c9ef7a37d4175a2c6db36bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-01curl: upgrade to release 7.88.1Taichi Haradaguchi
Fixes CVE-2023-23916, 2 CVEs that probably don't affect LO. Reference: https://curl.se/docs/security.html Change-Id: If9b3fc7c5ce66bfe1027caff39ea2c1cf55df7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147673 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-01postgresql: upgrade to release 13.10Taichi Haradaguchi
Fixes CVE-2022-41862 Reference: https://www.postgresql.org/support/security/CVE-2022-41862/ Change-Id: I6075838972fec1c091f3150b19c5da4dc80ad6d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147674 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-28upgrade to libjpeg-turbo 2.1.5Caolán McNamara
Change-Id: Ia6355beaf19765e6255f9388d60e2179206ddc5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-27It seems to work to compile also the MMX code for WASMTor Lillqvist
Change-Id: I27b56297a07e248102cae1bee4074b7be422ce23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147875 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-26zxing: fix build after upgrade to v.2.0Mike Kaganski
Change-Id: If1b85a1f9f1b562aed8f357fd34434c8fe97e2f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147737 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-24upgrade zxing-cpp to 2.0.0Caolán McNamara
Change-Id: I3dc00f34359ec56a22cf7d8ba8e565ccb755c755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-24freetype: upgrade to release 2.13.0Taichi Haradaguchi
As the issue has been fixed upstream[1], removed some codes from "external/freetype/ubsan.patch". [1]"[truetype] Fix undefined pointer arithmetic." <https://gitlab.freedesktop.org/freetype/freetype/-/commit/905270925dd0492ba557e58938e5513f062e6fc5> Change-Id: I66c11e414cd9ecdad8678487d0c3f645a352ad92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147464 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2023-02-22vcl: Avoid the need to patch HarfBuzzKhaled Hosny
Reverts parts of d552b4a549d614a03aa9328e017dec27bd3ff41e and 97e2e73e87479a742b798f362eda4baafb89497c. Instead of patching HarfBuzz, lets make use of the already mmap’ed file we use with FreeType. Change-Id: Ia81222118162a30cadb8c988bc477ad3ce36166d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147410 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-21Mark recently added external/cppunit/*.patch.0 as upstreamedStephan Bergmann
Change-Id: I62c62ee6fbd8ec6bf1846cea305ab97d4e567ae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147385 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-20external/cppunit: Don't mis-apply GCC < 4.6 workaround for ClangStephan Bergmann
...which happens to define __GNUC__=4, __GNUC_MINOR__=2 Change-Id: I128547d0bd375ffec9deb6abd744eeb2667ba666 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147257 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-20external/cppunit: Use snprintf instead of sprintfStephan Bergmann
...to avoid > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:115:8: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] > sprintf(buffer, "%.*g", precision, x); > ^ > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here > __deprecated_msg("This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.") > ^ > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg' > #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg))) > ^ on macOS after the upcoming <https://gerrit.libreoffice.org/c/core/+/147257> "Don't mis-apply GCC < 4.6 workaround for Clang" Change-Id: I213de1d112cb56fba220006842e611c56ccc7331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147333 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-16android: Use actual Android API level for minSdkVersion, nssMichael Weghorn
When an Android API level is explicitly set with the `--with-android-api-level` switch introduced in commit 4c0bccbb21ba022fd9d630eb1d9ae34673b4dc11 Date: Thu Jul 4 09:06:49 2019 +0200 android: Allow specification of the API level. , use that for the minSdkVersion for the Android Viewer app and the API level for the NSS build, rather than leaving that hard-coded at API level 16. Building with a newer API level means that the app won't run on devices with older API levels. With this in place, this will be recognized at install time (installation will fail: INSTALL_FAILED_OLDER_SDK) rather than crashing at run time. Change-Id: Id6047b768d265b965696f3a3161d7828e5f3696e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146127 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-02-16android: Switch from GNU binutils to support NDK 23.x, require 21.xMichael Weghorn
Relevant announcement from revision history for NDK 23 [1]: > * GNU binutils, excluding the GNU Assembler (GAS), has been removed. GAS > will be removed in the next release. If you are building with > -fno-integrated-as, file bugs if anything is preventing you from > removing that flag. Therefore, switch from uses of GNU binutils to the corresponding LLVM tools instead. NDK 20.x doesn't provide `llvm-ranlib` yet, so bump the minimum version to 21.x. Also drop the previous uses of `ANDROID_BINUTILS_PREBUILT_ROOT`, which appear to no longer be relevant by now. commit 4082a18406c18af7b4fcef7bd501c3679c3be56b Date: Wed Nov 22 23:08:06 2017 +0100 android: use unified headers and llvm-c++ STL (x86) with NDK 16 gnustl (and others) are to be removed in future versions of the ndk also bump gradle and build-tools to current versions along with it arm unfortunately crashes with llvm-c++, so keep with gnustl for now/fix that later that introduced one of those uses mentions issues on ARM, but building and running the app at least on my 32-bit ARM device (Samsung Galaxy S4 I9505, LineageOS 17.1/Android 10) didn't show any issues in a quick test with this change in place. Update the Jenkins config to switch from the now no longer supported NDK 20.1.5948944 to 23.2.8568313 for which building and running the app has been tested on devices for all of the four supported architectures with upcoming change Change-Id I9ea714255faf29d50bb5f8e206f13495637da867 "android: Require NDK 23 and use default linker lld" in place on top, s. that one's commit message for more details. Note however that the NDK version will be further updated to use NDK 25 in upcoming change Change-Id Ib8e65f433ee89ff1bc12432722570bf8f9f7ed85 ("android: Support NDK 24.x and 25.x, use NDK 25 for Jenkins"). [1] https://developer.android.com/ndk/downloads/revision_history [2] https://lists.freedesktop.org/archives/libreoffice/2023-January/089878.html Change-Id: I7645f8025d42f0fa384b5bceb31bb4b1c0a44cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146118 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2023-02-15use upstream suggested fixCaolán McNamara
Change-Id: Ibe61144ea45211aa1b68e51d267ce5b7e1764839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147026 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-14disable script dumpCaolán McNamara
Change-Id: I04d740cc0fcf87daa192a0a6af34138278043a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146905 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-13ofz#55872 fix oss-fuzz build wrt fontconfig not getting built staticCaolán McNamara
change from static to dynamic was hidden away in commit: commit d552b4a549d614a03aa9328e017dec27bd3ff41e Date: Tue Sep 20 16:07:14 2022 +0300 Enable opening of downloaded fonts only in ForKit in Online Change-Id: Ia6e636fdbdac31f6cf746fc70c892d71462a9619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-13Only package the external/cairo library that is named the same as the SONAMEStephan Bergmann
Change-Id: Id97fe380c3e3976e56a6962eaebfbd696bab7332 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146908 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-13fix openssl build on aarch64 - _umul128 is not available on non x64Christian Lohmaier
adding upstream patch that uses __umulh as a fallback Change-Id: Ib95de30d3f7208c38421df0c63eb1ceafccd9354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146839 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-02-11Update liborcus to 0.18.1Kohei Yoshida
Change-Id: I0439640789e59e4dd6e92d7f2975538de2f42f53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146826 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-02-10Avoid implicit function declaration warningsTor Lillqvist
Noticed when compiling with Emscripten for WASM, but might well happen in other cases, too. Change-Id: I37ae326af21204d81a6a3267831d7a0198d1d501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146744 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-09Use SIMD in pixman for WASMTor Lillqvist
Emscripten and WASM do have some support for SSSE3, so let's try to use it, with -msimd128. See https://emscripten.org/docs/porting/simd.html. WASM is not x86, though, so avoid use of inline x86 assembly, like the CPUID instruction. Emscripten does not have <mmintrin.h> but does have <xmmintrin.h>, <emmintrin.h>, and <tmmintrin.h>. Change-Id: Ic3a47291f6c6dee6843e93ccecc92a643b269cb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146691 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-09Enable opening of downloaded fonts only in ForKit in OnlineTor Lillqvist
We want that only the ForKit process needs to have access to new font files added to a Collabora Online instance dynamically by downloading from a server. There are however many locations in the Kit process, in core and in external libraries like harfbuzz, where the code wants to open a font file. Handle this so that the ForKit process opens such a downloaded font file and doesn't close it. The file descriptor is thus inherited by Kit processes. The font file pathname passed on to other code is a fake on in the format "/:FD:/%d" where the %d is the file descriptor of the opened font file. Add checks in all places where font files are opened, look for this special pathname format, and modify the code to just dup() the already open file descriptor in that case. All this is relevant for Linux only, as Collabora Online runs on Linux. Do the above for harfbuzz, cairo, fontconfig, and freetype. In addition make sure that these libraries (except harfbuzz which needs to be a static library and freetype) when bundled, on Linux, are built as shared libraries, and won't be confused with the corresponding system libraries by making sure their sonames are different. Change-Id: Ib059cb27e1637d07bb709249abd0d984f948caa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140714 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146341 Tested-by: Jenkins
2023-02-09fix internal python build on powerpc64le-unknown-linux-gnuAndras Timar
Change-Id: I49c1368542a1af5dbbf377dbd8cb0cad8c6e2a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135174 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146689 Tested-by: Jenkins
2023-02-08openssl: upgrade to release 3.0.8Michael Stahl
Fixes CVE-2023-0401 CVE-2023-0286 CVE-2023-0217 CVE-2023-0216 CVE-2023-0215 CVE-2022-4450 CVE-2022-4304 CVE-2022-4203 CVE-2022-3996 Remove the patch that fixed CVE-2022-3996. Change-Id: I8587d780ea7dc07637278643dc1c49b577e3ae56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146657 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-30external/skia: Still missing includeStephan Bergmann
9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update skia to m111" had removed the whole external/skia/missing-include.patch.0, including the part added by 5877c6b118c99c9ec807a111471bfd67720a5086 "external/skia: Missing include" (for snprintf in workdir/UnpackedTarball/skia/third_party/vulkanmemoryallocator/include/vk_mem_alloc.h), even though at least my GCC 13 trunk build still requires that. However, the comment at <https://gerrit.libreoffice.org/c/core/+/145552/2#message-7fad3bfd39568500aa66b1c03dfd1670dad636f2> "external/skia: Missing include" pointed out that this "landed upstream at https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/commit/29d492b60c84ca784ea0943efc7d2e6e0f3bdaac", so switch to using a git-format-patch of that (slightly hand-edited to fix up the path of that project's vk_mem_alloc.h as included in the Skia tarball, and to cater for that file's usage of CRLF line endings). Change-Id: I31192b6e0aaf355d5cfee96badc59903ab592aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146365 Reviewed-by: Sam James <sam@gentoo.org> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-30external/skia: Another constexpr template point of instantiation issueStephan Bergmann
...with --with-latest-c++ after 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update skia to m111", > In file included from workdir/UnpackedTarball/skia/src/core/SkBitmapDevice.cpp:8: > In file included from workdir/UnpackedTarball/skia/src/core/SkBitmapDevice.h:11: > In file included from workdir/UnpackedTarball/skia/include/core/SkBitmap.h:12: > In file included from workdir/UnpackedTarball/skia/include/core/SkImageInfo.h:14: > In file included from workdir/UnpackedTarball/skia/include/core/SkRect.h:19: > In file included from /Users/stephan/llvm/inst/bin/../include/c++/v1/algorithm:1747: > In file included from /Users/stephan/llvm/inst/bin/../include/c++/v1/__algorithm/inplace_merge.h:28: > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'SkStrikePinner' > static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type"); > ^~~~~~~~~~~ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:297:7: note: in instantiation of member function 'std::default_delete<SkStrikePinner>::operator()' requested here > __ptr_.second()(__tmp); > ^ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:263:75: note: in instantiation of member function 'std::unique_ptr<SkStrikePinner>::reset' requested here > _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); } > ^ > workdir/UnpackedTarball/skia/src/core/SkStrikeCache.h:46:47: note: in instantiation of member function 'std::unique_ptr<SkStrikePinner>::~unique_ptr' requested here > std::unique_ptr<SkStrikePinner> = nullptr) SK_EXCLUDES(fLock); > ^ > workdir/UnpackedTarball/skia/src/core/SkStrikeCache.h:20:7: note: forward declaration of 'SkStrikePinner' > class SkStrikePinner; > ^ Change-Id: I367323706d047da18fd8d4230a47a78fbb32b677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146349 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-30Update skia to m111Noel Grandin
(*) Remove patches already upstream (*) Remove the skia_sk_cpu_sse_level_0_by_default.patch.1 patch and rather set that define via -D parameter, because that is how the skia BUILD.gn seems to do it. (*) I hand edited the PCH file, because running the update_pch script failed for me. Change-Id: I1fd175b9f63f8d2792a1876e4ece03fe92fb5374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146251 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-28Related: tdf#145988 Reset layer's pixel format to MTLPixelFormatBGRA8UnormPL
Skia initally sets the layer's pixel format to be BGRA8888 but macOS may change the layer's pixel format when a window has moved to a screen with 30-bit color depth so reset it back to BGRA8888. Change-Id: I1ad47a31e41aaa197e3052146243882e0b4ef673 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146301 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-01-28Fix 'Architecture' string on ppc64le platform, Debian uses 'ppc64el'Andras Timar
Change-Id: Idb678ac2669914575d3ddb813d35212df26e3d17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146297 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-27Remove support for AIXStephan Bergmann
As discussed in the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2023-January/089808.html> "Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)", the bridge implementation at bridges/source/cpp_uno/gcc3_aix_powerpc is apparently dead and should thus be removed. However, that was the only bridge implementation for AIX, which implies that support for the AIX platform as a whole is dead and should thus be removed. Change-Id: I96de3f7f97d4fd770ff78256f0ea435383688be9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146057 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26tdf#147342 Notify Skia that the window's backing properties changedPatrick Luby
Change-Id: I4185a240a2ca6df1c92e86ff9950f86234d4ace8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146142 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-01-26Just use std::variant and std::getKohei Yoshida
Change-Id: If467225fae07a9d33e324cac9ff32300d6c56534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146151 Tested-by: Kohei Yoshida <kohei@libreoffice.org> Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>