Age | Commit message (Collapse) | Author |
|
This change adds the --enable-skia-vulkan-validation build option. When
this option is set, Skia will be built with Vulkan validation layers
enabled. Vulkan validation layers must also be installed on the
development machine (e.g. via the Windows Vulkan SDK, or the Ubuntu
vulkan-validationlayers package).
Vulkan validation layers are an important debugging tool for Vulkan
application development. Validation layers externally verify that Vulkan
API calls are correct and comply with the standard. This is particularly
important as Vulkan does not require drivers to reject invalid uses;
some hardware or drivers may tolerate certain developer mistakes, while
other drivers reject them. Without using validation layers to confirm,
this may create a false impression that certain hardware/drivers are
faulty, when it is our own code at fault.
Change-Id: If39a09e3d1043d37b465dd3cc5fcd8e5c364a1a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178736
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia38a81cbcd14776b7fa1398856bd3f8997a869ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178741
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
Change-Id: Ifc24cb42df76c50f0ca40e3c793f36c355e483d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178730
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...where "will be needed" is approximated by "install location is under
C:\Program Files" (i.e., where admin privileges will be necessary to do an
update)
Change-Id: I00c93df8c0c2c5132fffa4056b88af098cb4a644
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178679
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
|
|
For some (still unknown) reason the upgrade from boost 1.86 to 1.87
caused the 32-bit ARM Android builds to fail
with errors like
<inline asm>:1:41: error: expected '%<type>' or "<type>"
.pushsection ".debug_gdb_scripts", "MS",@progbits,1
^
<inline asm>:318:12: error: .popsection without corresponding .pushsection
.popsection
^
2 errors generated.
make[1]: *** [/home/tdf/lode/jenkins/workspace/android_arm/solenv/gbuild/LinkTarget.mk:339: /home/tdf/lode/jenkins/workspace/android_arm/workdir/CxxObject/configmgr/source/groupnode.o] Error 1
make[1]: *** Waiting for unfinished jobs....
[build CXX] configmgr/source/node.cxx
<inline asm>:1:41: error: expected '%<type>' or "<type>"
.pushsection ".debug_gdb_scripts", "MS",@progbits,1
^
, see e.g. [1] and the list of all Android ARM 32 bit builds [2].
A local bisect points to this commit, and reverting it
fixes the build.
Do this for now to work around the build failure and give
time for finding a better solution.
This reverts commit 25e7e1677b13db818b5458cd0c3fd3d9dfc88557.
[1] https://ci.libreoffice.org/job/gerrit_android_arm/43354/console
[2] https://ci.libreoffice.org/job/gerrit_android_arm/
Change-Id: Ifad1412b691adce74bb16805975e3439898e3b74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178697
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
* external/boost/0001-Add-a-comma-before-ellipsis-in-constexpr_swap.patch.2
has been fixed upstream
<https://dev-www.libreoffice.org/src/boost_1_87_0.tar.xz> has been generated (on
Debian 12) with
> $ wget https://boostorg.jfrog.io/artifactory/main/release/1.87.0/source/boost_1_87_0.tar.bz2
> $ printf 'af57be25cb4c4f4b413ed692fe378affb4352ea50fbe294a11ef548f4d527d89 boost_1_87_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_87_0.html>
> boost_1_87_0.tar.bz2: OK
> $ external/boost/repack_tarball.sh boost_1_87_0.tar.bz2
> Unpacking boost_1_87_0.tar.bz2 ...
> Removing unnecessary files ...
> Creating boost_1_87_0.tar.xz ...
> Cleaning up ...
> efd6d4ce7e8571ba87f77a30bee2d3dd8dccd306721351464fc6998dd00b0c8c boost_1_87_0.tar.xz
> Done.
Change-Id: I9aaa9fc435b5b1890f9038ccfbfa26707a57a8da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178574
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
CPWL_Dash-switch-to-universal-init.patch.1 is upstreamed, remove it.
Change-Id: I4ff68f15d58b853896626b0458d3817f64fbc32f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178297
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
So it'll be easier to drop it the next time pdfium is updated.
Change-Id: Iebeb892f62ee8002460142adf28f75666c92c2e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178237
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I161f3cfc334d6be0263536800cb028b8e7310823
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178080
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Idb458e3e65bc22d148cc68e496aa0dda32fec2a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178079
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
There is no simple "Windows is 10 or newer" check in MSI, with the
Microsoft policy of "you don't need to know real Windows version".
See also https://developercommunity.visualstudio.com/t/detect-a-windows-version-from-msi/412198
The values that MSI sees (e.g. on my Win11) are:
Property(C): VersionNT = 603
Property(C): VersionNT64 = 603
Property(C): WindowsBuild = 9600
So those can't be used for the check. I use the WINMAJORVER that is
read from registry (Software\Microsoft\Windows NT\CurrentVersion).
There is no more need to check and install UCRT; it was dropped.
Change-Id: Ic02d6aeb965e9684bafd4357f969980f77000e73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178049
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
When live resizing a window, replacing the CAMetalLayer with each
resize event repaints the window's background which causes a
noticeable flicker. So reuse any existing CAMetalLayer already
assigned to the native view.
Change-Id: I03bda5f0d40b84606b6602961e5f0d3b0dfcc6ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177921
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
|
|
* external/gpgmepp/gettid.patch issue fixed upstream
Downloaded from https://gnupg.org/ftp/gcrypt/gpgme/gpgme-1.24.1.tar.bz2
Change-Id: Id2d984f5e68b8681bf5e635a1afe5d90605711ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177821
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
jom (https://wiki.qt.io/Jom) is a parallel version of nmake that
especially helps with building openssl since everything is compiled
individually/the compiler cannot use parallelism either.
Also in a LibreOffice build there's not much else that can be done in
parallel/other stuff requires openssl to be built to continue.
Change-Id: Ib16b0f947991a1d3255aeae7dc5d9bdee0b157a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177743
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
|
|
...new with GCC 15 trunk -std=c++26 since
<https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cc67d95dc100706ea665e8cce581d59466aba62e>
"c++: Implement C++26 P3176R1 - The Oxford variadic comma",
> In file included from workdir/UnpackedTarball/boost/boost/rational.hpp:82,
> from source/external/boost/include/boost/rational.hpp:30,
> from source/tools/source/generic/fract.cxx:32:
> workdir/UnpackedTarball/boost/boost/integer/common_factor_rt.hpp:66:56: error: omission of ‘,’ before varargs ‘...’ is deprecated in C++26 [-Werror=deprecated-variadic-comma-omission]
> 66 | inline constexpr void constexpr_swap(T&a, U& b...) BOOST_GCD_NOEXCEPT(T)
> | ^~~
> | ,
and
> In file included from workdir/UnpackedTarball/boost/boost/move/unique_ptr.hpp:24,
> from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core/non_terminal/impl/grammar.ipp:18,
> from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core/non_terminal/grammar.hpp:21,
> from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core.hpp:42,
> from workdir/UnpackedTarball/boost/boost/spirit/home/classic.hpp:24,
> from workdir/UnpackedTarball/boost/boost/spirit/include/classic.hpp:11,
> from source/external/boost/include/boost/spirit/include/classic.hpp:30,
> from sdext/source/pdfimport/pdfparse/pdfparse.cxx:23:
> workdir/UnpackedTarball/boost/boost/move/detail/unique_ptr_meta_utils.hpp:500:39: error: omission of ‘,’ before varargs ‘...’ is deprecated in C++26 [-Werror=deprecated-variadic-comma-omission]
> 500 | struct is_unary_function_impl<R (*)(T0...)>
> | ^~~
> | ,
Change-Id: I56856e274a7c577c53d96343992bb79d4c3d602e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177730
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
|
|
For some unkown reason (maybe due to the macOS two-level namespace?)
including the $(ICU_LIBS) link flags causes a crash on startup in
the macOS dynamic library loader on some versions of macOS running
on Intel machines. LibreOffice 24.8.3 and earlier did not have this
bug since libraptor2-lo was not linked against libicuuc. So, revert
back to the LibreOffice 24.8.3 macOS build behavior.
On macOS, libraptor2-lo still links successfully even without
libicuuc and the bundled JavaScript HelloWorld macro still runs. So
it appears that libraptor2-lo does not need any symbols in libicuuc
or, if it does, libicuuc has already been loaded by the time
libraptor2-lo is loaded.
Change-Id: I2e09ce57b5f7aea631a522f5d33f3a4b1ebfd419
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177594
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
|
|
Because the mutex has already been freed because raptor calls
xmlCleanupParser
I have logged a feature request against raptor for a flag to turn off
this behaviour, but until that lands, this will have to do.
-----
make CppunitTest_filter_pdf results in
WARNING: ThreadSanitizer: use of an invalid mutex (e.g. uninitialized or
destroyed) (pid=330602)
0 pthread_mutex_lock
/home/noel/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:1371
(discriminator 8) (cppunittester+0x7e1be)
1 xmlDictFree ??:? (libxml2.so.2+0x3404b) (BuildId:
14c9410dbe8278dfa121dabc48c9ae25eac169d1)
2 lt_xml_unref
/home/noel/libo-tsan/workdir/UnpackedTarball/liblangtag/liblangtag/lt-xml.c:351
(liblangtag-lo.so.1+0x1fc6a)
3 lt_db_finalize
/home/noel/libo-tsan/workdir/UnpackedTarball/liblangtag/liblangtag/lt-database.c:144
(liblangtag-lo.so.1+0xac22)
4 (anonymous namespace)::LiblangtagDataRef::teardown()
/home/noel/libo-tsan/i18nlangtag/source/languagetag/languagetag.cxx:219
(libi18nlangtag.so+0x20951)
5 (anonymous namespace)::LiblangtagDataRef::~LiblangtagDataRef()
/home/noel/libo-tsan/i18nlangtag/source/languagetag/languagetag.cxx:204
(libi18nlangtag.so+0x20951)
6 cxa_at_exit_callback_installed_at(void*)
/home/noel/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:445
(cppunittester+0x6e3af)
7 LanguageTagImpl::canonicalize()
/home/noel/libo-tsan/i18nlangtag/source/languagetag/languagetag.cxx:190
(libi18nlangtag.so+0xe370)
8 main /home/noel/libo-tsan/sal/cppunittester/cppunittester.cxx:482
(cppunittester+0x10cf6c)
Change-Id: I5d9ff1c5667f8e19e5858cd5a408e8f95d2a98e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177320
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Generated with:
./autogen.sh
./configure
make dist-xz
Change-Id: I46b921f3c2ef41ab52e272df5afd82a1d9331f42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177332
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
Since
commit 05aedcba6672979d317b540bbfa74f5c9b409402
Author: Stephan Bergmann <sbergman@redhat.com>
Date: Thu Jan 21 23:19:20 2021 +0100
Fix use of -fvisibility=hidden with Clang in external/libcdr, external/libqxp
Change-Id: Idb97eaea30f5a2b15379b18981455532de0308b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177330
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Generated with:
./autogen.sh
./configure
make dist-xz
Change-Id: I74ac661c5f8db9abf7644212d98b29c3ec5b422f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176036
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...by backporting upstream
<https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=bc5a4dfcf7390145dc3ba3c1c18c5ce561b778cd>
"Assume that <stdbool.h> conforms to the C standard." to our REL_14_15 version.
GCC 15 trunk defaults to C23 now, so started to fail with
> In file included from fls.c:49:
> ../../src/include/c.h:419:23: error: two or more data types in declaration specifiers
> 419 | typedef unsigned char bool;
> | ^~~~
> ../../src/include/c.h:419:1: warning: useless type name in empty declaration
> 419 | typedef unsigned char bool;
> | ^~~~~~~
> make: *** [<builtin>: fls.o] Error 1
> make: Leaving directory 'workdir/UnpackedTarball/postgresql/src/port'
(Removing HAVE__BOOL and HAVE_STDBOOL_H also from src/tools/msvc/Solution.pm is
necessary to avoid failures like
> "C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/openssl\apps\openssl.exe" version 2>&1unused defines: HAVE_STDBOOL_H HAVE__BOOL at /home/tdf/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/postgresql/src/tools/msvc/Mkvcbuild.pm line 870.
> make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/external/postgresql/ExternalProject_postgresql.mk:27: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/ExternalProject/postgresql/build] Error 1
in MSVC builds.)
Change-Id: I1f6bd0d613ae4d6ce70feaaf67aaf95496eeff87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177280
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
|
|
...so the existing C code started to fail with
> In file included from workdir/UnpackedTarball/mariadb-connector-c/libmariadb/ma_alloc.c:20:
> workdir/UnpackedTarball/mariadb-connector-c/include/ma_global.h:687:25: error: two or more data types in declaration specifiers
> 687 | typedef char bool; /* Ordinary boolean values 0 1 */
> | ^~~~
(And the !defined(HAVE_BOOL) there, always being true, apparently started to get
in the way now and thus needed to be removed, whatever its original purpose.)
Change-Id: I781458d643e01a7199e19a178da3a32520d16b34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177260
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
|
|
This reverts commit 32eb29377c5bbf6a965357756d2813add2789053.
Reason for revert: Original commit did not fix tdf#163945
Change-Id: Ie66edde40ed44f89bb28043db074fab7e6e06a49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177025
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
|
|
It seems that -[MTLCommandBuffer presentDrawable:] doesn't
immediately replace the previous drawable on screen so I
assume that there is some default minimum display time for
drawables.
LibreOffice only invokes this method in a timer so let
LibreOffice control the rate of window updates by presenting
the drawable right now.
Change-Id: Ibd8d72bd6ea0303f9582264791cc4356bda62c13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176879
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
|
|
* external/libgpg-error/w32-build-fixes-6.patch fixes
libgpg-error.lib(libgpg_error_la-spawn-w32.obj) : error LNK2019: unresolved external symbol __imp__AllowSetForegroundWindow@4 referenced in function __gpgrt_process_spawn
Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.51.tar.bz2
Change-Id: I6001d1932d1226c0daa037408523f98a9e719f2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176446
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* external/gpgmepp/gettid.patch fixes
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: ./.libs/libgpgme.so: undefined reference to `gettid'
* external/gpgmepp/strcasecmp.patch fixes
libgpgme.lib(key.obj) : error LNK2019: unresolved external symbol _strcasecmp referenced in function __gpgme_key_append_name
Downloaded from https://www.gnupg.org/ftp/gcrypt/gpgme/gpgme-1.24.0.tar.bz2
Change-Id: I2f2587f5157db7610d6ffaa84b49f9677ba1cc4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176160
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ia84be07223cf8c7427aa899baf97b63ed8fc8794
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176144
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
|
|
Change-Id: I731eb3039f9f43ac05d3b60d5387ff44c5986a71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176049
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
|
|
Generated with:
./autogen.sh
./configure
make dist-xz
Change-Id: I6ff112ab2669d8ca7903f685486b5cd0f0348fd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175442
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
|
|
Change-Id: I0dfe44f8e8f20c137a12eafb4fa108d266f89370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174875
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
New fast_float header-only inner dependency.
CppunitTest_vcl_pdfexport's testTdf154549 and
CppunitTest_vcl_pdfexport2's testTdf71956 started to fail after this.
Assuming that the code covered by these tests still works (since this
commit doesn't change vcl/ or sw/ code), just update those tests to
match the new PDFium API call results for now.
Change-Id: I07b2f97fbbc9bd609e2f94593474393adcb5a839
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174814
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ibfa3d8f5a86dd7474f5cc288c89eb33a8aa472cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174848
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: Iea920a34b11695aba32f15921018cf53f418d09a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174846
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and add a patch to deal with a horrible windows COM header
preprocessor thing, which resulted in:
$ make skia
cd C:/libreoffice/libo-core/external/skia && C:/cygwin64/opt/lo/bin/make -j 8 -rs
[build DEP] LNK:Library/skialo.dll.d
[build CXX] workdir/UnpackedTarball/skia/tools/window/VulkanWindowContext.cpp
[build LOC] top level modules: skia
In file included from C:/libreoffice/libo-core/workdir/UnpackedTarball/skia/tools/window/VulkanWindowContext.cpp:26:
C:/libreoffice/libo-core/workdir/UnpackedTarball/skia\src/gpu/vk/vulkanmemoryallocator/VulkanAMDMemoryAllocator.h(33,69): error:
invalid parameter name: 'struct' is a keyword
33 | const VulkanInterface* interface,
| ^
C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\combaseapi.h(168,19): note: expanded from macro
'interface'
168 | #define interface __STRUCT__
| ^
C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\combaseapi.h(167,20): note: expanded from macro
'__STRUCT__'
167 | #define __STRUCT__ struct
| ^
1 error generated.
make[1]: *** [C:/libreoffice/libo-core/solenv/gbuild/LinkTarget.mk:403: C:/libreoffice/libo-core/workdir/GenCxxObject/UnpackedTarball/skia/tools/window/VulkanWindowContext.o] Error 1
make: *** [Makefile:125: skia] Error 2
Change-Id: I48975bd503098a2c38d794307c7c55f60668232a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174760
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Regression since commit 4e9a21bb0e4981e834de22c1d666f7a83a2771c5
(Update to skia m116, 2024-10-07) - actually it was about m117.
The dropped line initialized fImageCount; and without it, that
uninitialized variable held whatever garbage was there. E.g., I
saw a value of 3452816845, meaning that it allocated 3.5 billion
of VkImage, clearing the memory took about 10 seconds per each
window initialization (main window creation, menu popup, dialog
and so on), and crashes.
Change-Id: I1d5fc9c6f29e302c46aa0380e528cac64f58c85b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174803
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Idffde7d5efc26a39dd119b657b7284527c013eb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174759
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id5f93ad07171228cf0701bd330be1ccf51c32e51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174739
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I92e2132f79ba9f3d2ec6cb6438e8040eb6cd0e81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174738
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I9bb712bdde8d2f2af792af5b439f4789e59f1595
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174720
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic7687add0fce85b17bf77b003137649bc7be9042
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174703
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifdc602fa7007a9352cdd1a654555204955c89317
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174702
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic3ab29795af11470d4b41a73d02eac1cd56cadb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174692
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The following patch appears to be upstreamed now
incomplete.patch.0
Change-Id: I36a4c62928c050ed4f8103a580899cdb3cf237cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174654
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
the SkImageGenerator patch seems to have been upstreamed
Change-Id: Ic2af62b9479c36394c6c0cf19d1c6f61edfff6b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174653
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The following patch appears to be upstreamed now
0001-AvoidCombiningExtrememelyLargeMeshes.patch.1
Add a patch to deal with a clang issue that only shows
up when building for 32-bit Windows.
The issue is reported upstream, but there is only
a workaround so far, no fix.
Change-Id: I1c50019a2afe39d245c6b02243789752e84445a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174585
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The sort comparison patch seems to have been upstreamed.
Lots of patches needed to be redone.
Followed the skia release notes in replacing calls
to SkCanvas::flush and SkSurface::flushAndSubmit.
Change-Id: I13179565b95cc0720b4548cd4baecc5adacc7133
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174554
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
so it more closely corresponds to the GN buildfiles that it is derived
from, in order to make updating to newer versions of skia easier
Change-Id: Iffd934d0bb05f4abe2b97838eb18baccac4a5096
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174474
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
With Skia/Raster or Skia disabled, converting the image's
colorspace to match the window's colorspace causes more than
an expected amount of color saturation so let the window's
underlying CGContext handle any necessary colorspace conversion
in CGContextDrawImage().
With Skia/Metal, this bug is caused by the CAMetalLayer being
set to the same colorspace as its matching window. So set the
CAMetalLayer's colorspace to sRGB so that, like with Skia/Raster
and Skia disabled, any colorspace conversion is handled when the
CAMetalLayer is drawn to the window.
Change-Id: Ifa2abe46d34bfcf5acd478fffd346603f869157b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173962
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
|
|
Fixes CVE-2023-52356 CVE-2024-7006
ofz65182.patch was apparently merged upstream and then reverted;
Caolán suggested to drop the patch and see if ofz still finds a problem
there.
Change-Id: I0967708f19a7151b020372eca3c906b30f693db9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173602
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
* 0001-ofz-70675-XML_ERR_FATAL-not-ending-parse.patch.0
is no longer needed. fixed upstream
Downloaded from https://download-fallback.gnome.org/sources/libxml2/2.13/libxml2-2.13.4.tar.xz
Change-Id: I7d39940ad5b197b302c57110e147aef7d2b911d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173621
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|