summaryrefslogtreecommitdiff
path: root/filter/qa
AgeCommit message (Collapse)Author
2020-10-31tdf#123476 filter: try to detect 0-byte files based on extensionMiklos Vajna
A 0-byte ("empty") pptx file is obviously junk input, so it's not surprising if the catch-all generic_Text filter is chosen to open it in Writer at the end. But we can do better: if we really get an empty file URL with an extension we can recognize, that we can fake the filter type / filter name, so the empty "presentation" opens in Impress, and also a re-save works as expected. This builds on top of commit 8a201be240b6d408d15166be7ffc576b9e123634 (fdo#68903 Import .tsv and .xls plain text files in Calc by default, 2013-10-27), just the new way works for all supported file extensions and also with filters which would not handle empty input (e.g. pptx refuses the import if the ZIP storage is broken). Change-Id: Ie01650a5eb6ca42c35e090133965467b621bb526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104939 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105039 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-09-08SVG export: fix failure on trying to read graphic of a 3D shapeMiklos Vajna
Regression from commit 8fc1b60f62c213a0476f3acc9f89cd5eccbf335d (sw SVG export: try to reuse original bitmap data for JPG and PNG bitmaps, 2020-02-27), which generalized the code that tries to get the original bitmap of shapes for performance reasons. Originally this worked with SdrGrafObj, but now we try every XShape which has a Graphic property. Add the missing check, so shapes without a graphic property just miss the fast path, but doesn't fail the entire SVG export. (cherry picked from commit fbcdbfef8664430e15b9429187b58dede992accf) Conflicts: filter/qa/unit/svg.cxx filter/source/svg/svgexport.cxx Change-Id: I6b20083110f3269337b9df6a23bd193cc6f7d13b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102223 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-19Fix warning on macOS: unused function 'dispatchCommand'Tor Lillqvist
Change-Id: Idfc39195e20ba7c2da23eb06bb21e8bb190e0138 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94533 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-02-26sw SVG export: try to reuse original bitmap data for JPG and PNG bitmapsMiklos Vajna
Writer shapes are implemented using SwXShape, Impress shapes use SdrGrafObj. So switch to working with the XShape interface, which is supported by both. Also, don't work with the transformed graphic if it has the same checksum as the original graphic: the transformed graphic is not linked to the original JPG/PNG data. Now selecting an image in Writer Online has the same speedup that Impress Online already had. Change-Id: Iab2791c5f5c7a2754e3de0ebb2d6ea664f6c77e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89542 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-08Fix typosAndrea Gelmini
Change-Id: Ifd1affb7c3945de84a210dfbda894b60014f6cd6 Reviewed-on: https://gerrit.libreoffice.org/63020 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17loplugin:staticvar in editeng..frameworkNoel Grandin
Change-Id: I8e555a98f74f61e6e40122564b7ad19ca07a8a91 Reviewed-on: https://gerrit.libreoffice.org/61866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from filter to jvmfwk Change-Id: I2a73d63f2aaef5f26d7d08957daaa8a30b412ac5 Reviewed-on: https://gerrit.libreoffice.org/58204 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-24Fix typosAndrea Gelmini
Change-Id: I07cf04cd2acc5b50d64224edb9f2c2de2c61e356 Reviewed-on: https://gerrit.libreoffice.org/57884 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-05-09Fix some IWYU warningsMiklos Vajna
Change-Id: Iab61e0a7cac2dc89e6b04875a62894b181aa0ff4 Reviewed-on: https://gerrit.libreoffice.org/54016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-27Fix typosAndrea Gelmini
Change-Id: Id1a19f2c8b44131773d4d5270a607c1907b16597 Reviewed-on: https://gerrit.libreoffice.org/48684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-16Fix typosAndrea Gelmini
Change-Id: Id3d1a07922d4ca05e3bbf61d4b5797a30fc5b23a Reviewed-on: https://gerrit.libreoffice.org/47872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16Fix typosAndrea Gelmini
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-13tdf#114428 filter: recognize XHTML with XML declaration as HTMLMiklos Vajna
The problem was the additional <?xml version="1.0" encoding="utf-8"?> XML declaration before the usual <!DOCTYPE html ... line, just ignore it. Change-Id: I294aae5504b40b42f76da00fef645d0d89009da9 Reviewed-on: https://gerrit.libreoffice.org/46324 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-11Fix typos and grammarIlmari Lauhakangas
Change-Id: I4143da3c5a809118d57849664f6ab1d2e775837f Reviewed-on: https://gerrit.libreoffice.org/46253 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-08Make Color a forward declarationChris Sherlock
Change-Id: Ib28833555661b119de8e967b05e3c8691fca826a Reviewed-on: https://gerrit.libreoffice.org/43227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-11Fix data races during CppunitTest_filter_xsltStephan Bergmann
Change-Id: I140ac8a24326959ba341adddbbf505ff16616283
2017-07-10add CVE-2017-10688 testcaseCaolán McNamara
Change-Id: Icf24df4a3655775d9ce26ca1f72e130eead49c10 Reviewed-on: https://gerrit.libreoffice.org/39760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-10add CVE-2017-9936 testcaseCaolán McNamara
Change-Id: I0c791ef1f51c8af9f752742b8a3a3de6d626191b Reviewed-on: https://gerrit.libreoffice.org/39759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-10add CVE-2017-9147 testcaseCaolán McNamara
Change-Id: I82f5d4e75c888f4f988c8d6188b77550631fe258 Reviewed-on: https://gerrit.libreoffice.org/39758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-20Translate German comments and debug strings (leftovers in f... dirs)Johnny_M
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "f". Additionally: - Fixed translation in formula/source/ui/dlg/funcutl.cxx (translated in https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=5e04331fc0a6434c61d3d18843cb4f80a44e5989 ), because clearing an event is quite the opposite of its triggering. Change-Id: I0fd62193a29883796cd05e5a80ce8a2900636b6c Reviewed-on: https://gerrit.libreoffice.org/37839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-30ofz#967 optimize tiff import if line is the same as previous lineCaolán McNamara
Change-Id: Ided61679a579a73481320f85c05b03e3ce3d762a
2017-03-18fix typo: amd --> anddennisroczek
Change-Id: I2905e8bbc659ab8a6344b172980d20455a67e87e Reviewed-on: https://gerrit.libreoffice.org/35319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16fix typo: chenged --> changeddennisroczek
Change-Id: I64e33601615f13d2227c24ba1d732817f42d412d Reviewed-on: https://gerrit.libreoffice.org/35235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I338dacd3cfe915714a9038e1dea4a60d586e9394 Reviewed-on: https://gerrit.libreoffice.org/34806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28ofz: timeout on clamping big double to 0..360Caolán McNamara
Change-Id: Ica2aedc5275e5f523302f5793e3f3816b3ff65b4
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-13guard against self-recursive GetBoundingBoxCaolán McNamara
Change-Id: If33f0e5e326604bf731d6ad50644e3a0b24ccf51
2017-01-13avoid infinite loops in dxf renderingCaolán McNamara
Change-Id: Id2eb5540241f0792cde35c444fc2c0c5b7778353
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-09-16filter: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Ibb80377a581d70501dbd243307e883057508e67f
2016-09-10Typo: (un)kown->(un)knownJulien Nabet
Change-Id: I7455c928293cd8d2d2ff16aa85fe02c9a54959d2 Reviewed-on: https://gerrit.libreoffice.org/28801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for filterArmin Le Grand
All *.ui files create a screenshot, but not all look useful Change-Id: Idd684f1fee55eebb58b4b56a2681cd4058be2880
2016-04-21Fix typosAndrea Gelmini
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07improve defaultparams lopluginNoel Grandin
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05RC4 encrypt some WMF and TIFF test filesMichael Stahl
Reportedly some virus scanners warn about some of these files. Use a new "RC4" name prefix since the files don't come from external sources. http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/69200 Change-Id: I6d4cff2fdd5c0134bf2c77558ea09b3196b39be9
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I61e494952df8cc40fff3ccad0936adf06035dbeb
2015-11-06merged graphic import/export into a single libraryOliver Specht
instead of egi, eme, epb, epg, epp, eps, ept, era, eti, exp, icd, idx, ime, ipb, ipd, ips, ipt, ipx, ira, itg, iti, there is now one graphic import export lib (gie) Change-Id: I20c0dd94e5857bb6e2e8cc8ac175ff500c6bbdfc Reviewed-on: https://gerrit.libreoffice.org/19756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-16spellingNoel Grandin
Change-Id: Ibd062310a3ae597cbab98729b394b26838e71d67
2015-10-16convert "continue" flag to an enumNoel Grandin
Change-Id: I160de1152978f301c514d9107c9e9082bab3cf05
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-03Fix typosAndrea Gelmini
Change-Id: Icde566ef79dc4ed8cb67a89c743f0a6c1b3c8f14
generated by cgit (git 2.34.1) at 2024-07-19 06:59:12 +0000