summaryrefslogtreecommitdiff
path: root/filter/source/svg
AgeCommit message (Collapse)Author
2019-09-04loplugin:constmethod in filterNoel Grandin
Change-Id: Ib337c45c0ee7de881313b000bf2f8d816fd17884 Reviewed-on: https://gerrit.libreoffice.org/78565 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23Mark move ctors/assignments noexceptMike Kaganski
This should enable using move semantics where possible e.g. in standard containers. According to https://en.cppreference.com/w/cpp/language/move_constructor: To make strong exception guarantee possible, user-defined move constructors should not throw exceptions. For example, std::vector relies on std::move_if_noexcept to choose between move and copy when the elements need to be relocated. Change-Id: I6e1e1cdd5cd430b139ffa2fa7031fb0bb625decb Reviewed-on: https://gerrit.libreoffice.org/77957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-20loplugin:constvars in drawinglayer..frameworkNoel Grandin
Change-Id: I6e62229fdc38f49f766a306f5264afafe9acefa5 Reviewed-on: https://gerrit.libreoffice.org/77774 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): filterStephan Bergmann
Change-Id: I469205ac250bb78c626c8d237b6eea9445617f04 Reviewed-on: https://gerrit.libreoffice.org/76677 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-19loplugin:referencecasting in filterNoel Grandin
Change-Id: Ia437fa8f18052afa2b70dfedc1b4badcfd165d6a Reviewed-on: https://gerrit.libreoffice.org/75956 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-23Fix typoAndrea Gelmini
Change-Id: If1f6d73088e87db6e91916ba338725054f63b5ac Reviewed-on: https://gerrit.libreoffice.org/73231 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-18tdf#42949 Fix IWYU warnings in include/svx/[t-v]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I345b8c54890b5bc27f51addd2e6e73ba68b6b327 Reviewed-on: https://gerrit.libreoffice.org/73977 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-16loplugin:logexceptionnicely in filter..frameworkNoel Grandin
Change-Id: I8cf70ee278c641767e3fcfcfd151d99d791b3468 Reviewed-on: https://gerrit.libreoffice.org/74098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-11tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b Reviewed-on: https://gerrit.libreoffice.org/73476 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-31Fix typoAndrea Gelmini
Change-Id: Ic53f1f1aacff2b91c987c18258d904ea24114216 Reviewed-on: https://gerrit.libreoffice.org/73232 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-20lok: writer: svg export transformed imagesMarco Cecchetti
Change-Id: I908a6e01573c35c0641519f4995730af0b033c33 Reviewed-on: https://gerrit.libreoffice.org/70565 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-10tdf#62699 Drop pass-through header file include/svx/svdattr.hxxGabor Kelemen
Change-Id: I04289589196ac69b31f75989d9252c79d03c890f Reviewed-on: https://gerrit.libreoffice.org/71633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-30implement std::hash for css::uno::Reference and rtl::ReferenceNoel Grandin
The declaration in BarChart.cxx is particularly suspicious, because it was using a < for the KeyEqual template parameter. Been there since: commit b2c3233e5f267b5d244d722a94424a3b224b3314 Date: Thu Dec 21 20:08:33 2017 +0900 chart2: suspend/resume setting rects dirty for 3D shapes comphelper::OInterfaceCompare is no longer necessary Change-Id: I8278c4a3d9113a18570ca237cd05d553ec8f3975 Reviewed-on: https://gerrit.libreoffice.org/71537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#124197 Improve "Unexpected error" user-visible error message wordingDarkByt31
Change-Id: I11c2ac4855a5fec2d26255ec3ab14ffe50e0fbbe Reviewed-on: https://gerrit.libreoffice.org/71066 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-13loplugin:sequentialassign in filter..fpickerNoel Grandin
Change-Id: I4ba0e1e982897bd570612f6cda8ba1e6a9fa5dbd Reviewed-on: https://gerrit.libreoffice.org/70700 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-14Avoid using index for single getToken() callMatteo Casalin
Change-Id: I155996a0504e39b11afd1b2e0f2472f6c1830a1e Reviewed-on: https://gerrit.libreoffice.org/69245 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-14Avoid using index for single getToken() callMatteo Casalin
Change-Id: Ice39b95ed5bb77a4989c838b51992c80ef37756f Reviewed-on: https://gerrit.libreoffice.org/69244 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-05Check svg URLs before exportingSamuel Mehrbrodt
Change-Id: I3b86b6b82318b0d201c3d7db516664520eb47bed Reviewed-on: https://gerrit.libreoffice.org/68668 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-01tdf#123780: Fix SVG export of Writer imagesTamás Zolnai
Used for LO online to generate preview. Change-Id: I25107bedecc5a60e6a3ac094b7defd5dcb822138 Reviewed-on: https://gerrit.libreoffice.org/68543 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-28tdf#115549 Check xPropset is exist.Gülşah Köse
Checks xPropset is exist for chart handling on LibreOffice Online. Change-Id: I57947fd23e089ace4df011873613c2f886770b30 Reviewed-on: https://gerrit.libreoffice.org/68493 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-24tdf#122582: Add touch gestures to iOS app slideshow, also for exiting itTor Lillqvist
Left swipt shows the next slide, right swipe shows the previoius slide. Up or down swipe exit the slideshow. Use the same hammer.js as Online does for touch gestures in dialogs. With one addition that was necessary to avoid a runtime error: look for a comment starting with '// tml:'. No idea why this is not needed in Online. Change-Id: I7a22b16dfbc069dcdc1be344005ab7503dcd1ba7
2019-02-22tdf#122582: Add ways to exit the slideshow in the iOS appTor Lillqvist
Either going past the end, or pressing the 'q' key on a hardware keyboard will exit the slideshow by posting an 'EXITSLIDESHOW' message to the app. (The app will have to handle that, of course, will commit in a moment.) Change-Id: I075e5e3fa86cc632cb3071d6546721b010ff77a2
2019-02-22Handle arrow keys (from a hardware keyboard) on iOSTor Lillqvist
Change-Id: Ia5946a77215eba565c3ff8c4dfbc08b95af493c0
2019-02-19More loplugin:simplifyboolStephan Bergmann
...found with GCC 9, where the standard library iterator implementations are apparently sufficiently different to older versions of GCC to find more cases of !(... == ...) vs. ... != ... Change-Id: Ibe7c5140049a69d2c5318b4b2371f2e66bd05028 Reviewed-on: https://gerrit.libreoffice.org/68012 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-09loplugin:indentation in filterNoel Grandin
Change-Id: If0574f34effb82bf718958692a44fd422b71abd4 Reviewed-on: https://gerrit.libreoffice.org/67555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-31tdf#115549 Enable handling background object.Gülşah Köse
Change-Id: Ibb9c01d83572259b812981aa6229e9aa9b7c60f3 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/67215 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21svg.js: the SVG Path polyfill doesn't work with Firefox 59 and laterMarco Cecchetti
We use a drop-in replacement for the SVGPathSeg and SVGPathSegList APIs that were removed from SVG2. Unfortunately the embedded version of this polyfill doesn't work anymore with Firefox 59 and later. It has been needed to adapt a new version of the same polyfill. (See https://github.com/progers/pathseg) Change-Id: Ib5208d67022e585b7a5fb24e37cc446f50e57ee3 (cherry picked from commit 1b2aedb7b9f81bb6b43b64559cab00956c189f82) Reviewed-on: https://gerrit.libreoffice.org/65548 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-12-21use unique_ptr in SVGFilterNoel Grandin
Change-Id: I58d352f5f9d689b268ab499f811be54020fcb458 Reviewed-on: https://gerrit.libreoffice.org/65521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21loplugin:unusedfieldsNoel Grandin
Change-Id: Ib41c168817c30ce11baf99c3f43005313fe484ff Reviewed-on: https://gerrit.libreoffice.org/65496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19Removed duplicated includeAndrea Gelmini
Change-Id: Ibefbb2cc191061c8ae08c7cdf446a2ee78b43e06 Reviewed-on: https://gerrit.libreoffice.org/65301 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-15lok: Implement SVG export of selected Writer imageTamás Zolnai
A Writer image does not behave similar to other shapes, so we need to generate a shape to get the export code working. Change-Id: Icfb25ceb40f73f1018d379863b836d8303e539f3 Reviewed-on: https://gerrit.libreoffice.org/65176 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-15lok: Implement SVG export for Calc (SelectionOnly mode)Tamás Zolnai
Change-Id: Ic305e5305890fd1efa3a3130e5216f9c672870e5 Reviewed-on: https://gerrit.libreoffice.org/65175 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-14lok: Implement SVG export for Writer (SelectionOnly mode)Tamás Zolnai
Separate generic code from Impress / Draw specific code and implement shape selection handling in case of Writer. This is an internal filter, so it can be called only from the code. Change-Id: I807e04a0949530d6029037bb964c10c80197ff33 Reviewed-on: https://gerrit.libreoffice.org/65174 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-08Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-08Remove misguided FALLTHROUGH commentsStephan Bergmann
...between adjacent switch labels without any intervening statements Change-Id: Ieb8a0d9f71ea4382b5f7d005cdf7111d06aeb5d0 Reviewed-on: https://gerrit.libreoffice.org/64789 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07Avoid writing out unneeded data to SVG file in SelectionOnly modeTamás Zolnai
Change-Id: I6d0ce089be051667e965aff45a63f6b1a8342952
2018-12-07Remove noise from the SVG file exported in SelectionOnly modeTamás Zolnai
Change-Id: Ia09f6ab40c20c17230e8b544987a5d11b7359f2f
2018-12-07Introduce client-server message for requesting the selected shape as SVGTamás Zolnai
It works for Impress only now. Change-Id: I95e3e37ae7df49b567108f6d6467038b715e886d
2018-11-19tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-16loplugin:buriedassign in dbaccess..ooxNoel Grandin
Change-Id: Ic0ca695a1d9d05418213475a68e233953136cc8e Reviewed-on: https://gerrit.libreoffice.org/63468 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23clang-tidy performance-unnecessary-copy-init in editeng..i18npoolNoel Grandin
Change-Id: I2ee2c8d15d8700cfaa1697363da4557c741a5f36 Reviewed-on: https://gerrit.libreoffice.org/62216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski
V668 There is no sense in testing the 'aNewSdrGrafObj' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I78159c7bd19bacea7120abc8015b866e6179c719 Reviewed-on: https://gerrit.libreoffice.org/62128 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-19clang-tidy readability-container-size-emptyNoel Grandin
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15add SvStream::TellEndNoel Grandin
and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>