summaryrefslogtreecommitdiff
path: root/filter/source
AgeCommit message (Collapse)Author
2018-04-24tdf#116990 Unwanted line breaks if ODS export to XHTMLAndreas Brandner
Change-Id: I86cc48d74f0572a7ba18beabbaf307bcaa069d38 Reviewed-on: https://gerrit.libreoffice.org/53087 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/53409
2017-12-13fix build: incompatible exception specsJuergen Funk
For gcc 4x and 5.2, we need to have matching, or more narrow, exception specs for overridden virtual methods. Change-Id: I2f2da8b8a9ac5639a3d885cd6851e1d0125651b1
2017-12-07set new document window as parent for dialogs during loadCaolán McNamara
and exit typedetection early and completely if application quits while detecting During typedetection, before loading proper, we have the hidden window as parent so warnings are not modal to existing windows and they are cancelled on exit. Once we do have a window, then reinit interaction handler to have that window as the parent for any further dialogs. Change-Id: I5c6711557266bf7d1eb9291f1c454cbfaf766886 Reviewed-on: https://gerrit.libreoffice.org/45148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-01tdf#113696 XHTML Export: Prefer fallback graphicSamuel Mehrbrodt
Which is usually png and browsers can read that, but they can't read our internal metafile format (svm) Change-Id: Idfd82da630ead69f508b74285081e32315030825 Reviewed-on: https://gerrit.libreoffice.org/45590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01tdf#109202 Add mimetype to image elementSamuel Mehrbrodt
Browsers don't recognize base64 svg if the mimetype is missing. So we add the image mimetype to our flat odf export, which the xhtml export uses and transforms it into an xhtml document. Change-Id: I21aafdb97b4104e14e2d40abda73a526bb37041a Reviewed-on: https://gerrit.libreoffice.org/40371 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-13ofz: check bounds on readCaolán McNamara
Change-Id: I07779bec876b90e36f20a81d6dbf06ae727edf85 (cherry picked from commit fb05611064e12c8eda09bc32c42544cde8c2ab49) Reviewed-on: https://gerrit.libreoffice.org/36019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-13valgrind: use of uninitialized valuesCaolán McNamara
Change-Id: I5b8c6d4d4576fd88dbffdfc710cbd9b2e9429942 (cherry picked from commit b7152aff51665bc802af66e6e599a89e0344c92f) Reviewed-on: https://gerrit.libreoffice.org/35808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-21ofz#875 limit depth to max legal depthCaolán McNamara
Change-Id: Icbe9339148dc4aeb31c160e976385e3bcaef75b6 (cherry picked from commit 30e2b7203963af215c9aaaec12383e0d5e1f6a7f) Reviewed-on: https://gerrit.libreoffice.org/35260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-21ofz#829 ensure palette can fulfil largest index usedCaolán McNamara
Change-Id: I95aa4796875ee71e8b06a2bb8985845f270b8817 Reviewed-on: https://gerrit.libreoffice.org/35105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-21ofz#876 avoid accessing empty rowsCaolán McNamara
(cherry picked from commit b9892037c303e645ee1a987d80734361700d91ac) Change-Id: Iba539fb03611bbe5627cc7976c1146d08a2ab5fd Reviewed-on: https://gerrit.libreoffice.org/35257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-21ofz: use after freeCaolán McNamara
Change-Id: I6d3f9108b02149165b020fc9c6677880456a1ef4 Reviewed-on: https://gerrit.libreoffice.org/35300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-03ofz: init varsCaolán McNamara
Change-Id: Ie35617997845de25af9e528668bce4c332ac408a (cherry picked from commit 1c29456c9c9007b788297aebea58a1a765f77c84) Reviewed-on: https://gerrit.libreoffice.org/34786 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-02ofz#668: check nTargetBits sizeCaolán McNamara
Change-Id: I5cc7499cfdee58ffa480bb31dfc262d5b781180d (cherry picked from commit 99c361be16eb3a21aa679a103db2d07ecd0f5d3c) Reviewed-on: https://gerrit.libreoffice.org/34724 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-23ofz: don't read data that isn't thereCaolán McNamara
Change-Id: I7fdcb78bde8f650c1a57d34177d8993a6d8a0a2f (cherry picked from commit ee619fb344c7e8f491e09bd256df7f8567af9bef) improve scoping Change-Id: Ic79d46da4e322a0f52981c3a3df65f7f0294fdd8 (cherry picked from commit 840ad0a88045021c58644404a099a3678a371020) make this a little clearer no logic change intended Change-Id: Ibfc46d0aba9e220be54270734e0cdfbc123be9a5 (cherry picked from commit 46b1b5dd2a5368663fd56434160fa126f1a54d84) Reviewed-on: https://gerrit.libreoffice.org/34573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-23Resolves: ofz#668 check for massive row lengths before trying to allocate themCaolán McNamara
Change-Id: I7b3f1abf5dcf457e8ff7d04a7cf48ffee70817a2 Reviewed-on: https://gerrit.libreoffice.org/34575 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-23ofz: don't read data that isn't thereCaolán McNamara
Change-Id: I9f730c321755cde169d940b49fc93bbe057ead57 (cherry picked from commit c5b1a01ddfa54156b4fa8e542d6936908257ca93)
2017-02-01Resolves: ofz#488 check remaining size while parsingCaolán McNamara
Change-Id: Ibb2b6c59a159f9fafa6a065be438b59a6d2d3f21 Reviewed-on: https://gerrit.libreoffice.org/33666 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-02-01ofz: tidy up eps preview importCaolán McNamara
a) check that the remaining stream length is >= the 14 bytes that are unconditionally skipped b) make the initial security count the min of the arbitrary 100 and the remaining stream len less that 14 bytes c) tweak ImplGetNumber not to reduce nSecurityCount if its already 0 (cherry picked from commit 94ffb720b889c51665ebb789d84aee3b3bacb456) ofz: check eps seeks are sane and succeeded (cherry picked from commit f85fb724d52a0fff9c64365cd202ae8975492c05) ofz: check if the stream is able to meet the eps len claim before reading (cherry picked from commit e17a34e957c21a8cd2977b1b0e1c9a427c244aed) ofz: check if the stream is able to meet the eps len claim before reading (cherry picked from commit d1f31681623696e99b0bd9e98570cb1ebac518cc) make this a little more readable (cherry picked from commit cf06348d9d4be8b8460d202cebf0d995fd4f6abf) move deref inside (laughable) nSecurityCount check (cherry picked from commit 521723b1180a32c02a88ed47137d4242c06eaca7) Change-Id: Ifffa6d02d492affd578fb48007704457ad635b39 0eb45e1c1ffd91682ed0ce6a6a74eab54666d715 65407bffb67449e203b8ead23554a4e88387d214 440c7f38d6588c570a411f2a97c0164e5d7d646f 83b6b0bd636b639ce0892f22f216410ce79dee03 df9a83ffa80137967d8c77d7a9b5133529fc2858 Reviewed-on: https://gerrit.libreoffice.org/33635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-18ofz#414 crash in DXFHatchEntity::EvaluateGroupCaolán McNamara
(cherry picked from commit 5434d51d12611eb2726ce1394eb01921d008fa89) ofz#415 crash in DXFVector::DXFVector (cherry picked from commit 2a9b4363ca190f1d783d540e95a031357f852858) Change-Id: I15c8cb7aeb8c45f32357afd0ea2f550ffe11dbf7 Reviewed-on: https://gerrit.libreoffice.org/33235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-17ofz: ensure nOldSize is > 0Caolán McNamara
Change-Id: Iaf385c9cd4fd37d56879908c00c7483762d66a0b (cherry picked from commit dd70861fd7123c826feefa86f8af1da1f4877c97) Reviewed-on: https://gerrit.libreoffice.org/33178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-16guard against self-recursive GetBoundingBoxCaolán McNamara
(cherry picked from commit 7420e350906558556881afc213f942d45d3e0b60) Change-Id: If33f0e5e326604bf731d6ad50644e3a0b24ccf51 Reviewed-on: https://gerrit.libreoffice.org/33051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-13avoid infinite loops in dxf renderingCaolán McNamara
Change-Id: Id2eb5540241f0792cde35c444fc2c0c5b7778353 (cherry picked from commit 57779b5f3a49fedd952aed70ddcce22f48b98ea5) Reviewed-on: https://gerrit.libreoffice.org/33043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-28tdf#104144: Missing dashed border, "break" should be "fallthrough" after allStephan Bergmann
...5ffd2c1595d1f67f5e4b14e48188a1f37f1956b5 "Presumably missing break in switch" apparently decided wrongly in favor of "break" over "fallthrough". Change-Id: I90372faac84a26514f5dc936e0e393a1ca12effa (cherry picked from commit 787d31a94510ca3de9ce582d7b7402dfca584b23) Reviewed-on: https://gerrit.libreoffice.org/31314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-01tdf#103552: Decrease SpreadsheetML import time to prevent "General ↵Шиповський Роман
input/output error" Change-Id: I39ed8fff7ba88042c74a11ddc58eec014c0bc6bd Reviewed-on: https://gerrit.libreoffice.org/30361 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 458a9fd8065737af212bb6bbba285ecb9aad1bb8) Reviewed-on: https://gerrit.libreoffice.org/30458 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-10-26implement CryptoAPI RC4+SHA1 encryption scheme for xls importCaolán McNamara
there might be other variants out there in practice, but this works for default encrypted xls of excel 2013 (cherry picked from commit 1473ce030314027c01c98f513407ed0897328585) contains... be more c++y Change-Id: I673b00e111a734bc626ba3d3f6ecf9692f1ce7db (cherry picked from commit fcf7f503b64b2cf7dbef019fb43dde033e3538e8) hash len is 20 for xls cryptoapi configuration Change-Id: I6e06b8578959b8147043179db57e875b1d98d57d (cherry picked from commit 491884350ce74f36044b3348bd66356ad1c234af) clarify hash lengths a bit more Change-Id: I66cea4b9efb82d29e6c052ac11a6f2eaca823ce0 (cherry picked from commit 8db1b13e721683d0263925c8e0300dd86a022814) hash len isn't going to change depending on who implements it Change-Id: Iee585cba4acad74c11d083085153e2af96c8894f (cherry picked from commit fcc846e8f29839eaace7e1d28746abea8f4b598a) move some useful header information to mscodec for reuse Change-Id: Ic7adf3ed3c8279cc93a06975d6fb337210d1af87 (cherry picked from commit fc514cbf30be1613fdf4d4b7c12cbd55ca08b9b0) rework things in light of now available documentation Change-Id: If5f75e27191017a8c6a3929e2a70d21840f157c6 (cherry picked from commit 3fabbd0a22219464545f933fc28c869a6fa89546) split MSCodec_Std97 into a baseclass MSCodec97 (cherry picked from commit 06916c839b16866b47235306d2db50850df0ad7c) Change-Id: Ia3c41a048169c78684800def94e53fc9f3201e30 Change-Id: I91c0e1d1d95fbd1c68966650e7ac7d23276bcbe3 Reviewed-on: https://gerrit.libreoffice.org/30128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-20Resolves: tdf#99273 can't save specific docxCaolán McNamara
crashtesting: assert on export of tdf99571-1.docx to docx (cherry picked from commit fb045517532aababc06fb4b1112def53b03d9144) Change-Id: I2c8d82ac21451a2d2cc748dc28ac210c8e5ddf5f Reviewed-on: https://gerrit.libreoffice.org/29015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-07filter: "tga" import: fix some endian issues in ImplReadPaletteMichael Stahl
Change-Id: Ia8ec7b7e19cf9b6b19497cbd77ae5a4e2fdccee7 (cherry picked from commit da4f7d5d76e054627b61521657d40141b9728e15) Reviewed-on: https://gerrit.libreoffice.org/25993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-07filter: PPT import: PptPlaceholder is 1 byte largeMichael Stahl
The array of 8 bytes corresponds to 8 enum values and is read directly in ReadPptSlideLayoutAto(); this was wrongly converted to enum. (regression from e5a03da8eb02c333502d6b427625e7bf554ff203) Change-Id: I5757e06459467b3c84c4a404493fa3be23e4e9a0 (cherry picked from commit 6325cdb735effc5c9ff85819b20aec4271158519) Reviewed-on: https://gerrit.libreoffice.org/25990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-30Resolves: tdf#100057 force libxslt to give up when we cancel a transformationCaolán McNamara
we're already using libxslt internals, so using XSLT_STATE_STOPPED isn't an additional exposure This probably isn't all that useful to the original reporter in terms of importing useful data, but it does turn a hopeless situation into something that can be cancelled. Change-Id: I08e9a1dcd9ee78e1804faec500bbcca36a546988 (cherry picked from commit 2805adb0d3cf68d7def01a93bf07fb2e8121ec10)
2016-05-25filter: generate that with the python script, not BOOST_PPMichael Stahl
Change-Id: I9ab4cf721dd135aaae021fa05b8b6df54389a9b7
2016-05-25Convert BMP_FORMAT to scoped enumNoel Grandin
Change-Id: I751ab762b6e6f961e9e73a8a2ca92a3f5a5eb1c8 Reviewed-on: https://gerrit.libreoffice.org/25189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Convert Disposal to scoped enumNoel Grandin
and drop unused FULL value Change-Id: I3b9c26cb164785ef86f1a8d57cce962b015c85d6 Reviewed-on: https://gerrit.libreoffice.org/25432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23Convert SbxClassType to scoped enumNoel Grandin
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23convert tnode to scoped enumNoel Grandin
Change-Id: I66b343db2c6e61e2316773f8995f78bbb1890eef Reviewed-on: https://gerrit.libreoffice.org/25210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-21coverity#1362017 Uninitialized scalar fieldCaolán McNamara
Change-Id: I7b13104ff579f9dd40dbc05245146440e55e7e18
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19Revert "tdf#35208 Allow choosing encoding for old Excel files"Maxim Monastirsky
This reverts commit 4f1ce46b8d65360436e09750242101b566e6186c. Change-Id: I4b93ef8233f172935e72401ec51abd3d4c8a9fac Reviewed-on: https://gerrit.libreoffice.org/25152 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19tdf#35208 Allow choosing encoding for old Excel filesMaxim Monastirsky
Lots of BIFF2-BIFF5 files out there don't have CODEPAGE record at all, or have one with a wrong value, and/or FONT records with wrong charset value. To solve that, this patch adds a new "Choose Encoding" entry to the file picker, so that users could specify the encoding to use for a given file, instead of relying on the information that might be present (or not) inside the file. It can be also used in headless mode, e.g. --infilter="MS Excel (encoded)":61 This doesn't affect BIFF8 import, nor the default behavior when not explicitly using the "Choose Encoding" entry. Change-Id: I89d850d7679b81bd399044478fac7a02e8b7680e
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16 tdf#64748: added placeholder option to pdf export dialog in WriterOliver Specht
This patch introduces a setting 'Export placeholders' to File/Export as PDF. It works like the related printer setting. Change-Id: I3a11a4601b1244b57e55c9b73b58116d355e105c Reviewed-on: https://gerrit.libreoffice.org/24976 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-15coverity#1361575 Logically dead codeCaolán McNamara
commit 6312dfdc16f7da09f48628f51bb20b09dc5b7001 Date: Wed May 11 20:11:18 2016 +0200 convert TSS_TYPE to scoped enum changed - if ( ( nInstance < PPT_STYLESHEETENTRYS ) && to + if ( ( nInstance < TSS_Type::LAST ) && but PPT_STYLESHEETENTRYS is 9 and TSS_Type::LAST is 8 Change-Id: I08fb0ad04332cd17e1bdc724799f2927a77359a7
2016-05-13filter: convert boost::bindMichael Stahl
Change-Id: Ib17cfa114b7a218c31690c780cf14e128a7992c2 Reviewed-on: https://gerrit.libreoffice.org/24981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13convert TSS_TYPE to scoped enumNoel Grandin
Change-Id: Ic76d7bfcfe4015c6a02dc5989f8300e5ddde706e Reviewed-on: https://gerrit.libreoffice.org/24896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Include cppumaker-generated .hpp, not .hdlStephan Bergmann
Change-Id: Ib0451f26edbfbcdfdca78caa97bd09bc65ec2782
2016-05-10Fix typosAndrea Gelmini
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Presumably missing break in switchStephan Bergmann
Was like that at least since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter", but as clarified on IRC: <vmiklos> sberg: doesn't look intended, i think ESCHER_Prop_lineDashing and ESCHER_Prop_fNoLineDrawDash are supposed to be mutually exclusive. Change-Id: I5ea92e6bdc9800c4511ca041c0572d1f9ffca49c