summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)Author
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26ofz#3483 Floating-point-exceptionCaolán McNamara
Change-Id: I3c8dc5e4ec9ce342d2da39459c49eeb0459f76d8
2017-09-25tighten up the pict filter a tadCaolán McNamara
Change-Id: Ib09a33a97a79fdeb5b61d486af4f11b5cc4035ec
2017-09-25ofz: divide-by-zeroCaolán McNamara
Change-Id: Ie9a21a1432a98af3dca9a397057b7887ff30375f
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-24ofz#3476 oom in tiff readerCaolán McNamara
Change-Id: Id103488ea0774b55521571f8b51059d06d4a0993 Reviewed-on: https://gerrit.libreoffice.org/42707 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24move sanity checks before allocationCaolán McNamara
Change-Id: I7374b3cc4cb7f2be9cec71a385899051288234c9 Reviewed-on: https://gerrit.libreoffice.org/42706 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23new loplugin unnecessarycatchthrowNoel Grandin
Change-Id: Iabab71ee076227bc38447ec109afaea1e53a86a6 Reviewed-on: https://gerrit.libreoffice.org/42643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22Use const reference instead of copyEike Rathke
Change-Id: Idf5239e2037dcfa808e016a726f5a980d862ede6 Reviewed-on: https://gerrit.libreoffice.org/42669 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22GraphicExportFilter: adding FilterData defaults is unnecessaryEike Rathke
... now that we use the proper dialog that sets the proper filter properties. Change-Id: Iabc3e4b2c13b60bccc0b596a851109df32fe535c Reviewed-on: https://gerrit.libreoffice.org/42668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22Apply replaceFirst() only onceEike Rathke
It's unnecessary to call if a replacement was already done and might even harm, though unlikely. (e.g. file extension "web") Change-Id: I6615c9a31178770429b523e0ee878661f1b2b6e8 Reviewed-on: https://gerrit.libreoffice.org/42667 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Group member variables and functions and fix naming nitpicksEike Rathke
Change-Id: Ie0b13c0ed4657200b6c92ae66ea25093e35a6c8f Reviewed-on: https://gerrit.libreoffice.org/42666 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22No using namespace in header fileEike Rathke
And using namespace css is sufficient, it's actually good to see some namespace.. Change-Id: I8cd3418e04769bb2fd1c632d6d671b368aae06b3 Reviewed-on: https://gerrit.libreoffice.org/42665 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Export to PNG: selected shapes via drawing::GraphicExportFilter, tdf#108317Eike Rathke
Change-Id: Id09d9b21b2e6c018dd199a1911a9125c118abec2 Reviewed-on: https://gerrit.libreoffice.org/42658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22Move implementation to filterRenderDocument()Eike Rathke
Change-Id: I632a26c5f149fabbe3a4a1186bfbe822fff0ea24 Reviewed-on: https://gerrit.libreoffice.org/42656 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Remember XComponentContextEike Rathke
Change-Id: I52847249b3e17a31f6c6bf76af7bfe91a414d072 Reviewed-on: https://gerrit.libreoffice.org/42657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22ofz#2902 eps timeoutCaolán McNamara
Change-Id: I8001df3ac89b81bffab871404efc90b6606e3eb3 Reviewed-on: https://gerrit.libreoffice.org/42637 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22Ditch now unused GraphicExportDialog, GraphicExportOptionsDialogEike Rathke
That was a dead end anyway, trying to partly reimplement SvFilterOptionsDialog ExportDialog, instead of implementing the necessary bits to use that one which has everything. Change-Id: Icde7422f2c2d7e26c07dfe921a4abda41e222b09 Reviewed-on: https://gerrit.libreoffice.org/42503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22loplugin:flatten in filter..i18npoolNoel Grandin
Change-Id: I9024b8b614a4de83a4d927e1918f6d4904a7fccb Reviewed-on: https://gerrit.libreoffice.org/42592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21restore zero init of mpGroupLevel membersCaolán McNamara
since... commit 19b34f615c04555f27978e2823ba735a9c9f882e Date: Fri Jul 7 15:58:40 2017 +0200 loplugin:useuniqueptr in filter originally - mpGroupLevel = new sal_uInt32[CGM_OUTACT_MAX_GROUP_LEVEL] (); and turn this into a tidy member init list Change-Id: Ic3f012b348cfa4f4f30da678fd6bfc172d22e693 Reviewed-on: https://gerrit.libreoffice.org/42465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20improve scoping, etcCaolán McNamara
Change-Id: I3a4902b2954d500900062394d03a15aae5826e60 Reviewed-on: https://gerrit.libreoffice.org/42557 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20ofz#2298 don't reuse previous frame alpha is this frame has no alphaCaolán McNamara
Change-Id: Ie5a50e8aafdafdbeaa66f07e1f99bb7785e7ee64 Reviewed-on: https://gerrit.libreoffice.org/42550 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20xAcc always exists at this pointCaolán McNamara
Change-Id: Idea4b63bc8556ddd23c81385a050155b0e0012b3 Reviewed-on: https://gerrit.libreoffice.org/42549 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20convert to a vectorCaolán McNamara
Change-Id: Ie8223d426a5a5411afb0cb55845e3086d234511c Reviewed-on: https://gerrit.libreoffice.org/42548 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20Get the comments rightEike Rathke
Change-Id: I936b22af55b4dae3c9352f4e1238a6351a03cb3d Reviewed-on: https://gerrit.libreoffice.org/42553 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-20fix another memory leakCaolán McNamara
Change-Id: I3cb34e3efc1c071e556b7c30c1b97e4956e998af Reviewed-on: https://gerrit.libreoffice.org/42544 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20repeat for StripOffsetsCaolán McNamara
Change-Id: I87810b2ee99dc5fce12062e5ebdc97e294d38542 Reviewed-on: https://gerrit.libreoffice.org/42543 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20use aStripOffsets.size instead of nNumStripOffsetsCaolán McNamara
Change-Id: I5d4f65beb7162aabe51fb932c3aec6a4f9b55684 Reviewed-on: https://gerrit.libreoffice.org/42542 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20valgrind: leak of pStripOffsetsCaolán McNamara
convert to std::vector, don't need pOldSO anymore then because the original values are retained in aStripOffsets on resize Change-Id: I9f82b0ca85eb174ba5f1f5a9e63be8eb32da5394 Reviewed-on: https://gerrit.libreoffice.org/42541 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20ofz#3439: Direct-leakCaolán McNamara
Change-Id: I6949e9dc12738fdfc5b4099cf0680e606cada27b Reviewed-on: https://gerrit.libreoffice.org/42537 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20Clean up xsl filesSamuel Mehrbrodt
* Remove trailing spaces * Use 4 spaces for indentation everywhere See discussion at https://lists.freedesktop.org/archives/libreoffice/2017-September/078433.html Change-Id: I0bb9a0b9b0502cdf0870529cea37ee9c4d1ffdf4 Reviewed-on: https://gerrit.libreoffice.org/41009 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-20improve scopingCaolán McNamara
Change-Id: I82e68bc00780ef37399b30f5374df4ef792546e9 Reviewed-on: https://gerrit.libreoffice.org/42540 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20filter,sc: try to prevent potential SeekToEndOfRecord infinite loopsMichael Stahl
SeekToEndOfRecord() now doesn't seek to EOF if the offset is too large; break out of loops in the obvious cases where this could be problematic. But don't use SAL_WARN_UNUSED_RESULT because unfortunately GCC doesn't allow to explicitly suppress that with a (void) cast. Change-Id: Ie0211075bf0f4ef271bb26bdfead5fb070875a2b
2017-09-20unused maFilterService in filter_info_implNoel Grandin
since it was added in commit d0d152d4e3e99c41dd71187eca917470c4d64adf Date: Fri Apr 4 15:34:02 2003 +0000 INTEGRATION: CWS xmlfilter01 (1.1.2); FILE ADDED Change-Id: I69bf6cad4e3d637c065d967a2b5915312cc23e93
2017-09-19Writer Web export to PNG,JPG: switch to proper SvFilterOptionsDialogEike Rathke
Change-Id: I6388ad03d4b94556f5a955d06c1f4e0d8c7188b1 Reviewed-on: https://gerrit.libreoffice.org/42501 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Writer does not support selection, so don't claim it wouldEike Rathke
Though it doesn't change anything UI wise. See also commit cb9d99dbb5a7249ca7437bd5c30c6c9374089a16 Change-Id: Ic5e0e411325945f91a00b58da5341eeecd7b6623 Reviewed-on: https://gerrit.libreoffice.org/42500 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Writer export to PNG,JPG: switch to proper SvFilterOptionsDialogEike Rathke
With all bells and whistles, instead of the crude size/dpi JPG dialog even for PNG. Change-Id: I695a78643e07900822ec9253ac818efd52339cc0 Reviewed-on: https://gerrit.libreoffice.org/42498 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Rename getCurrentPageWriter() to getCurrentPage()Eike Rathke
... and let getCurrentPageWriter() be a private implementation detail. Change-Id: Iaa14d8eab81e5750fbaf45adc6aab66eee9018eb Reviewed-on: https://gerrit.libreoffice.org/42488 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19'a'CurrentPage gets on my nervesEike Rathke
Change-Id: Ifb6137048d7206c1f3a718331ed8b42f746052bb Reviewed-on: https://gerrit.libreoffice.org/42487 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19ofz#2538 avoid oomCaolán McNamara
Change-Id: Ief86805a1d8c010826351d7b701678ee2945770d Reviewed-on: https://gerrit.libreoffice.org/42466 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18Calc: support export to JPEG, just because we can.. tdf#108317 relatedEike Rathke
Change-Id: I7b78fe3efe97267eca7bf2f085d8375ba7b483ca
2017-09-18Export to PNG: use proper dialog and filter options, tdf#108317Eike Rathke
... and not the crude JPG ones. The com.sun.star.svtools.SvFilterOptionsDialog service has all we need, so teach it to cope with non-Graphics source documents and let ExportDialog handle that as well, just the actual rendering needs to go via GraphicExportFilter (and effectively DocumentToGraphicRenderer), so don't let that overwrite the properties set by the filter dialog. Switching to the dialog then is just a matter of changing the UIComponent in filter/source/config/fragments/filters/calc_png_Export The same mechanism probably could be used by Writer as well by adjusting filter/source/config/fragments/filters/writer_png_Export.xcu and maybe filter/source/config/fragments/filters/writer_jpg_Export.xcu in which case the GraphicExportOptionsDialog likely would be moot then. Also, it looks like a filter/source/config/fragments/filters/calc_jpg_Export.xcu (which doesn't exist yet) could be possible using the same mechanism. Change-Id: I1fb9b33a6490dc39d7591b2b5913be182bb820e5 Reviewed-on: https://gerrit.libreoffice.org/42421 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-18convert SvxDateFormat to scoped enumNoel Grandin
And simplify the code in sd/headerfooterdlg, no need for the complex encoding of date and time when we can just index into a static array. Change-Id: I677400bf1f956c81eba665b71dbda9183b63f55c Reviewed-on: https://gerrit.libreoffice.org/42346 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeFormat to scoped enumNoel Grandin
and make the numerators look more like our internal formatting codes Change-Id: I3b3d448cec913e72c7ffb6cc3e7754241af36d93 Reviewed-on: https://gerrit.libreoffice.org/42345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeType to scoped enumNoel Grandin
Change-Id: Ic5ca8c50ccd74837cd0521a13e1f5eaa8e326ff3 Reviewed-on: https://gerrit.libreoffice.org/42344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxURLFormat to scoped enumNoel Grandin
Change-Id: Ie2199cf0bcfb6d649f8aa33325ab645b18e7c000 Reviewed-on: https://gerrit.libreoffice.org/42343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Fraction: make conversion operators and constructor explicitNoel Grandin
and simplify some of the calculations that needed to be changed. Which resulted in one unit test needing to change by one pixel, let's hope not an indication of a real problem. Change-Id: Ie56434f35f4e58d21ee6f671392e93dc7542fca3 Reviewed-on: https://gerrit.libreoffice.org/42240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-12EPUB export: initial UI componentMiklos Vajna
EPUBExportUIComponent::execute() still needs to launch an actual dialog, but otherwise it has enough functionality that only tweaking maFilterData is necessary in the UNO component to pass custom filter options to the exporter. Change-Id: I95af024f5babd66a5aa0b446550f4f0fec45ef43 Reviewed-on: https://gerrit.libreoffice.org/42204 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>