summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)Author
2015-08-14remove default value from DffPropSet::GetPropertyValueNoel Grandin
more useful to make it explicit Change-Id: Ic76fcc5ffa245b3eb3c99f3a5e4d0656b56c511e
2015-08-11tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, for filter. Change-Id: I30dcd7cfb3e484034f6cceceb1ff7cd9d3f4b7a6 Reviewed-on: https://gerrit.libreoffice.org/17585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-11gbuild/config stop using VERBOSE, use only verbose=tNorbert Thiebaud
configure.ac was setting VERBOSE=YES/NO when really we use verbose=t or verbose= Change-Id: I47aee8d177cb2d788a62ecdbbb9cc3695c2bb299 Reviewed-on: https://gerrit.libreoffice.org/17634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-05remove unused SfxFilterFlags valuesNoel Grandin
from both the code and the XCU files Change-Id: I47f1f33c3ad4a37e346e3b8020dd9d3e284ccb77 Reviewed-on: https://gerrit.libreoffice.org/17522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04filter,desktop,dbaccess: inline some use-once typedefsNoel Grandin
Change-Id: I35f256a11b211c3cb977ae76b5b561efbfd13b9d
2015-08-03coverity#1157790 Division or modulo by float zeroCaolán McNamara
Change-Id: I98ada1d4ccae0b804a6a083cdd0ab185c556ad71
2015-08-03new loplugin: refcountingNoel Grandin
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-31filter: valgrind uninitialized warning in filter_met_testMichael Stahl
Change-Id: Iaa6a6ed0ef1b9ca3b3f72706ec3934c6c4a93322
2015-07-31filter: valgrind uninitialized nDataLen warning in filter_tiff_testMichael Stahl
Change-Id: I70e38970394ca291de2de184b80bb5bb7c2cccac
2015-07-31fix crash in writer, thanks to my new assert in typed_flags_setNoel Grandin
and clean up the duplication of constants between filter/ and comphelper/ in the process Change-Id: I0d1525b559c63a3d39deae51accff5dcdbb0aa82 Reviewed-on: https://gerrit.libreoffice.org/17446 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-07-29Remove the unnecessary type definition: HPBYTEDaniel Robertson
HPBYTE is a duplicate defintion of Scanline as seen below. include/vcl/salbtype.hxx: 34: typedef sal_uInt8* HPBYTE; 35: typedef HPBYTE Scanline; Remove the definition of HPBYTE and inline the definition of Scanline. Replace all instances with sal_uInt8*. Change-Id: I8a79a9d6c45af57fbabf8d3e6a04a1b5eba15a7b Reviewed-on: https://gerrit.libreoffice.org/17175 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-28remove unused ALLCHART constantsNoel Grandin
Change-Id: I8fbc3ff0b8427c3aa18527f8da2a339b82407309
2015-07-27inline a bunch of use-once macrosNoel Grandin
no point in having a macro unless it's actually going to reduce the number of lines of code Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-24filter: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I9aa0543edf3f0aef3a0a376aa0f82f51c6d93313
2015-07-24filter: convert boost::ptr_vector to std::vectorMichael Stahl
... and move it out of the header since it's only used in that class. Change-Id: Icd5cc86428c97bdaaa07d56e17393846629721e5
2015-07-24filter: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl
Change-Id: I171fdb41bef4a7f3ef6418d81a1d99f123c0652c
2015-07-24filter: that cast is sillyMichael Stahl
Change-Id: Id3766ccc992934633c77d8e035abd8390ef088cb
2015-07-24filter: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I87f903c6a81b271847f072fa0608fae4669ac307
2015-07-24filter: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I2659fea1fb18c5b0a4ff5339643c7c28c0f5f458
2015-07-24filter: convert boost::ptr_vector to std::vector<std::unique_ptr>Michael Stahl
Change-Id: I548f15466c695e4cbf5e505771d7c0baf8812198
2015-07-22remove some unused constantsNoel Grandin
Change-Id: I8742db77a0cfd99257584d830162c1c7126da263 Reviewed-on: https://gerrit.libreoffice.org/17283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21Miscellaneous typosAdolfo Jayme Barrientos
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
2015-07-21reject invalid tiff dimensionsCaolán McNamara
Change-Id: I64e77f12cb016a7f4a9d21c732aaeaae7959da76
2015-07-20bail if offsets are past eofCaolán McNamara
Change-Id: I4a8e78231befff498894ec92a1f38af206e13129
2015-07-20fail on short readCaolán McNamara
Change-Id: I7215cf8d8b1e4a4156c87507018de3c2b7ed08d8
2015-07-20translate from germanDavid Tardon
Change-Id: Ia3682f2d002e10c2984e99264d0ec98bc3477f1c
2015-07-20don't hang on a bad ReadCodeAndDecodeCaolán McNamara
Change-Id: I999012d428fa84e21fe9e9f851a016eacc96a686
2015-07-20ensure loop ends eventuallyCaolán McNamara
Change-Id: I318385286fcc27ffb2d938237d83e793564d2525
2015-07-20final check np boundsCaolán McNamara
Change-Id: I9213bb2cc059e05e286598edac03bd72c84db876
2015-07-20test that nNumStripByteCounts value is within bounds of fileCaolán McNamara
Change-Id: If119628d7f510a7db30ed2180111063781cde887
2015-07-20check np bounds yet againCaolán McNamara
Change-Id: Id3f6fdc0ebed9711acec5d71f404e7a6072b765c
2015-07-20reduce scope, etc, don't loop endlesslyCaolán McNamara
Change-Id: I86e4e94392527b5faf5d9cdb4251853f35813f4e
2015-07-20add a test imageDavid Tardon
Change-Id: Ibd30ddc9c4a0e1ca440d0b62635cfab3f3ab8235
2015-07-20tdf92789 fix reading of some PICT imagesosnola
Change-Id: I24498bc6f316e5522e716184fb8b2e17bcd76226
2015-07-19check np bounds againCaolán McNamara
Change-Id: I0fb61954b2eaf0c015d7bdefe9f03bd459b31501
2015-07-19check np boundsCaolán McNamara
Change-Id: Id16ae9325f3c67792941b9c88d83435aa98282ca
2015-07-19in reality we are limited to max sal_Int32 hereCaolán McNamara
so accept that and test if the values were accepted or limited Change-Id: I599cf8065a6f8786d380fdba03135857766770f3
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-17in remainingSize consider that its is possible to seek past the endCaolán McNamara
Change-Id: I1652244d5515629f1cd8f15f4c5b15f139dba0aa
2015-07-17don't loop forever if pcx has short readCaolán McNamara
Change-Id: I638792417924bcb8e48995f4e789f84a2cbf4757
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17rename test caseCaolán McNamara
Change-Id: I76d35955a1d024d05a94ffdfdcf8e4076de24975
2015-07-17detect another loop in tif formatCaolán McNamara
Change-Id: I950f751277d9080b4fc00c38f63453cce81bcc32
2015-07-17test that nNumStripOffsets value is within bounds of fileCaolán McNamara
Change-Id: I1483ea3671420be53496888892374641e10b344d
2015-07-17detect loop in tif formatCaolán McNamara
Change-Id: I27645566cd9fc0ac8cf753f0217ae6cf0fa9929e
2015-07-17loplugin:unusedmethods filterNoel Grandin
Change-Id: Ie33a5ebda9337cf123b39ae18a8d7b4ef12b6991 Reviewed-on: https://gerrit.libreoffice.org/17131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16Resolves: tdf#92772 missing shape bg colorCaolán McNamara
regression from dcad3ac445980740b6a39761cdd1f1bd0b3e6e34 coverity#1242624 Untrusted loop bound Change-Id: Idf52c09828c2bab767e9ff0d07b61befd6bfc64b The original code read 8 bytes on the nElemSizeVert == 8 branch and always 4 otherwise. I assumed that nElemSizeVert had to be read as 4 on that branch, but apparently not. So if its not 4, set it to 4 and we get the same behaviour as originally and continue to ensure we bounds check the loop Change-Id: Ica8ab7cc3bbebee93216766a2e1279a579494840
2015-07-16min size of eps for a preview is 32Caolán McNamara
Change-Id: Icb82d9dd0a3918f2bdc4cb768c566774cd0d8ac4
2015-07-16exception on div by 0Caolán McNamara
Change-Id: Id33d6a5e3df5812babd28ebfc65b95ce97219ad3
2015-07-15don't hang if at end of streamCaolán McNamara
Change-Id: I497a30041ec667237c2aa64963dcefb67753e87c