summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)Author
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08Retire the --disable-export optionTor Lillqvist
It was never fully implemented, and its usefulness is unclear. Change-Id: I86dee8ee6326bdfaa178260c76188261aef2fb4c
2016-12-07convert PolyFlags to scoped enumNoel Grandin
and remove the XPolyFlags enum, which has the same values and was being converted to PolyFlags anyhow Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41 Reviewed-on: https://gerrit.libreoffice.org/31627 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07crashtesting: "use" loop in moz325427-1.svgCaolán McNamara
Change-Id: I6ea2aaa5ca857d89342b9d18bd4cbedbeeea2b2f
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06Change Read/Write access to Scoped Read/Write accessMark Page
Change-Id: Idbe8e393b64f2a151e20c1851d7c14fa161acf97 Reviewed-on: https://gerrit.libreoffice.org/31635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06convert PolyStyle to scoped enumNoel Grandin
Change-Id: Ia35fdbb5e40888db9558988ac069741b31721f0e Reviewed-on: https://gerrit.libreoffice.org/31633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05add separate MS PowerPoint 3 filter (libmwaw)David Tardon
Change-Id: I9f07e6d363387fc47f187f6635f489f8f8237f77
2016-12-05silence some BAD_SHIFTsCaolán McNamara
Change-Id: I2a669aff0a8a63eb4b16600344cea9f601d5e68a Reviewed-on: https://gerrit.libreoffice.org/31601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-05convert E_GRAPH_PROV constants to typed_flagsNoel Grandin
and drop the never checked E_GRAPH_PROV_DO_NOT_ROTATE_METAFILES constant Change-Id: Idd2598c209b34bfa4a58a84ce5ee14a7340d59d4 Reviewed-on: https://gerrit.libreoffice.org/31553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-29Rewrite some (trivial) assignments inside if/while conditions: filterStephan Bergmann
Change-Id: I8985f24972d0efd8450de930102ce82cd383b459
2016-11-28loplugin:unnecessaryoverride (dtors) in filterStephan Bergmann
Change-Id: I0f859829a02721dd78b4bd0cc99bad6b864855d8
2016-11-28tdf#104144: Missing dashed border, "break" should be "fallthrough" after allStephan Bergmann
...5ffd2c1595d1f67f5e4b14e48188a1f37f1956b5 "Presumably missing break in switch" apparently decided wrongly in favor of "break" over "fallthrough". Change-Id: I90372faac84a26514f5dc936e0e393a1ca12effa
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-22trivial makefile cleanupsMichael Stahl
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
2016-11-21convert inventorId to scoped enumNoel Grandin
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21correct UIName of legacy StarOffice Text Documentosnola
Change-Id: I2f4a67ce439d913648c17d4770b94c5b4e7968f9
2016-11-21rename makefile to match the module nameDavid Tardon
Change-Id: I21685599e42c961407fa3de40e69e6e54dfe7c79
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-16new loplugin finalprotectedNoel Grandin
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-14Avoid -fsanitize=nullStephan Bergmann
...during CppunitTest_filter_dialogs_test: > filter/source/xsltdialog/xmlfiltersettingsdialog.cxx:1398:20: runtime error: reference binding to null pointer of type 'ResMgr' > #0 0x7f144bf5ab10 in XMLFilterListBox::XMLFilterListBox(vcl::Window*, SvxPathControl*) filter/source/xsltdialog/xmlfiltersettingsdialog.cxx:1398:20 > #1 0x7f144bf7abb8 in VclPtr<XMLFilterListBox> VclPtr<XMLFilterListBox>::Create<VclPtr<VclVBox>&, SvxPathControl*>(VclPtr<VclVBox>&, SvxPathControl*&&) include/vcl/vclptr.hxx:138:46 > #2 0x7f144bf50df8 in SvxPathControl::SvxPathControl(vcl::Window*) filter/source/xsltdialog/xmlfiltersettingsdialog.cxx:1312:20 > #3 0x7f144bf7d487 in VclPtr<SvxPathControl> VclPtr<SvxPathControl>::Create<VclPtr<vcl::Window>&>(VclPtr<vcl::Window>&) include/vcl/vclptr.hxx:138:46 > #4 0x7f144bf56a2f in makeSvxPathControl filter/source/xsltdialog/xmlfiltersettingsdialog.cxx:1378:1 > #5 0x7f14d2060a04 in VclBuilder::makeObject(vcl::Window*, rtl::OString const&, rtl::OString const&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&) vcl/source/window/builder.cxx:1793:17 > #6 0x7f14d2078ddb in VclBuilder::insertObject(vcl::Window*, rtl::OString const&, rtl::OString const&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&) vcl/source/window/builder.cxx:1887:25 > #7 0x7f14d208790a in VclBuilder::handleObject(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2856:37 > #8 0x7f14d20215bc in VclBuilder::handleChild(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2114:33 > #9 0x7f14d2087bea in VclBuilder::handleObject(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2859:17 > #10 0x7f14d20215bc in VclBuilder::handleChild(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2114:33 > #11 0x7f14d2087bea in VclBuilder::handleObject(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2859:17 > #12 0x7f14d20215bc in VclBuilder::handleChild(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2114:33 > #13 0x7f14d200c59a in VclBuilder::VclBuilder(vcl::Window*, rtl::OUString const&, rtl::OUString const&, rtl::OString const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) vcl/source/window/builder.cxx:206:9 > #14 0x7f1492275862 in ScreenshotTest::dumpDialogToPath(rtl::OString const&) test/source/screenshot_test.cxx:177:24 The existing code apparently depended on any calls to getXSLTDialogResMgr in xmlfiltersettingsdialog.cxx only happening after pXSLTResMgr had been set up in the outer XMLFilterDialogComponent::execute in xmlfilterdialogcomponent.cxx. That is not true when each dialog is opened independently in the screenshot test, so instead just call CreateResMgr on demand wherever needed. Change-Id: I9f6dc7c66d4999137352a8d91665b954f4088085
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04loplugin:oncevar in desktop..filterNoel Grandin
Change-Id: I21c47cacbcd68f06eea7ccbbfa6d04fc65e2b7ee Reviewed-on: https://gerrit.libreoffice.org/30564 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02check only Column elements when computing column indexDavid Tardon
Change-Id: I4856227c05e97daefbae7e98c0e9d70f84e1a2b4
2016-11-02check only Row elements when computing row indexDavid Tardon
Change-Id: I3bd1b0749f8889cbd1d92a0edfa84d754e888f03
2016-11-02rhbz#1390776 check only Row elements when computing row indexDavid Tardon
Change-Id: Ic5ef3971829597170acfdc0606b3c0f16c42be04
2016-11-01Decrease SpreadsheetML import time to prevent "General input/output error"Шиповський Роман
Change-Id: I39ed8fff7ba88042c74a11ddc58eec014c0bc6bd Reviewed-on: https://gerrit.libreoffice.org/30361 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-10-27filter: use comphelper::containerToSequence() in ImpPDFTabDialogMiklos Vajna
Change-Id: I9c6523d96e06901751d392bd76e7aa8717784697 Reviewed-on: https://gerrit.libreoffice.org/30307 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-26Revert "clang plugin for push_back after using sized constructor"Stephan Bergmann
This reverts commit e2fa592c770222344fccb0e39db3d500fc7690b5, sould no longer be necessary after 3be8c4c2bb919d69a2812c76edbaeaa41d149edb "The badvectorinit plug-in probably can be retired". Change-Id: I26fadaf002e8e21144a7e888a80bb40eb017a64b Reviewed-on: https://gerrit.libreoffice.org/30296 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-26try and silence coverity#1374267 Out-of-bounds accessCaolán McNamara
Change-Id: Ib7a8866dc4acdc243e7bfa975e760afde3bb43a6
2016-10-26The default std::less<sal_uInt16> is fineTakeshi Abe
Change-Id: I29cd62ef0b687613ed9bda5170511dcae2fc6e7e Reviewed-on: https://gerrit.libreoffice.org/30282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-24Simplify code furtherStephan Bergmann
...after 9ad0e56be46df46b021109acfd6ece9d17ce84f8 "fixes for >>= with rhs Any" Change-Id: Idf7b7033bd0ef5501e2884841ba897f8691a5f77
2016-10-24fixes for >>= with rhs AnyJochen Nitschke
this changes behaviour because >>= always returned true Change-Id: Ia7bbce1696e5c23f6e1e6f1a7e60b3c462cf0086 Reviewed-on: https://gerrit.libreoffice.org/30141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21clang plugin for push_back after using sized constructorCaolán McNamara
the warning is bogus for this ctor, but the clang plugin is still active in gerrit at the moment. Change-Id: Ia55260491988a12a48e49dc4962733261d13e2a1
2016-10-21loplugin:expandablemethodds in include/filterNoel Grandin
Change-Id: I92f0e19845e921701eb139e19493effa47908b39
2016-10-21implement CryptoAPI RC4+SHA1 encryption scheme for xls importCaolán McNamara
there might be other variants out there in practice, but this works for default encrypted xls of excel 2013 Change-Id: I91c0e1d1d95fbd1c68966650e7ac7d23276bcbe3
2016-10-21split MSCodec_Std97 into a baseclass MSCodec97Caolán McNamara
Change-Id: Ia3c41a048169c78684800def94e53fc9f3201e30
2016-10-21move some useful header information to mscodec for reuseCaolán McNamara
Change-Id: Ic7adf3ed3c8279cc93a06975d6fb337210d1af87
2016-10-20be more c++yCaolán McNamara
Change-Id: I673b00e111a734bc626ba3d3f6ecf9692f1ce7db
2016-10-20Any can't be nested ...Jochen Nitschke
... don't check for it Change-Id: I0400ef365fdfcd8e1f516958225ae99289798f21 Reviewed-on: https://gerrit.libreoffice.org/30049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>