summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)Author
2020-08-19Fix typosAndrea Gelmini
Change-Id: I58c510121a9f535b2a31854f10b5f6535554d379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100988 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-17inline some use-once typedefsNoel Grandin
Change-Id: I683175c1e788a2a4cfec9504dc8dc3ebfee7c5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-15remove constructor with plain Bitmap from Graphic, use BitmapExTomaž Vajngerl
Change-Id: Ie429a10a8f54c6779d437ee4bc75a5ea0c427848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100727 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-14loplugin:simplifybool moreNoel Grandin
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14rename xmlnmspe -> xmlnamespaceNoel Grandin
Change-Id: I8fdf9833dede6f4c9ba4bbb76b9ab9b6b419f155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14rename nmspmap.hxx -> namespacemap.hxxNoel Grandin
we're not in DOS anymore, Dorothy Change-Id: I79926e0d694163940ba7ebf20419724dd0a486f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13loplugin:stringstatic also look for local staticsNoel Grandin
Add some API to O*StringLiteral, to make it easier to use in some places that were using O*String Change-Id: I1fb93bd47ac2065c9220d509aad3f4320326d99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-07filter: MSO export: convert TextWrap property to Escher_Wrap*Michael Stahl
There's a paucity of working wrapping modes in Escher unfortunately. Change-Id: Ibaf99c3249a6492dc129f9c9b5707778038f9a4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100331 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-04loplugin:referencecasting (clang-cl)Stephan Bergmann
("the source reference is already a subtype of the destination reference") Change-Id: I1183eaa2015bd9d6567001bb14f7809dffcae7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100088 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04tdf#135427 Make pstoedit delegate letter placement to usSamuel Thibault
As pstoedit documents itself, its wmf/emf driver uses a very approximate interletter spacing, making the text look really awful. But it provides a -nfw option that delegates the letter placement to the emf reader, and we happen to be doing a proper job, thus getting a proper vectorized output. This is not a concern on Windows (and the option is ignored there). The option is available since version 3.40 (~2005). So we can just always pass it on. Change-Id: I8ffd3fbf046b5a80e8011651eeaf060a8f5107e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100035 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-25filter/xsltdialog: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. I have changed this from single-instance to multi-instance to avoid loplugin:staticvar and because I can't see a good reason for a dialog to be single-instance Change-Id: Ic7c917fd4923dce11466069e9531bf44989a1ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99421 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25don't need prefix here anymoreNoel Grandin
Change-Id: Ie3b6681cb4ae8c1138766db7b19cc473367bfbd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99422 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25filter/config: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I4423d3acd0a3c77bb7e553511e296f682f87b3e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-17SVG export: fix lost semi-transparent text on shapesMiklos Vajna
Extend SVGTextWriter::setTextPosition(), so when it looks for a text action in a metafile, it recurses into transparency groups, so the text is not lost. Extract part of SVGActionWriter::ImplWriteMask() into a new StartMask(), so we can detect the case when the transparency group has a constant alpha, i.e. no complex mask is needed, just an opacity value. When looking for text, remember if we saw a request for text opacity and make the transparency group writing in SVGActionWriter::ImplWriteMask() conditional to avoid duplication. This is needed because once we're inside <text>, we don't want to write an invalid transparency group via <g>, rather we want a fill-opacity on the existing <tspan>. With this, the SVG export is on par with PDF export for semi-transparent shape text. Change-Id: If43b0ab3446015299acc4b37590358867c5fac5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98937 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-16compact namespace: editeng-filterNoel Grandin
Change-Id: I240bff8de9489d3c0c9c9be6b31ce7e15661bff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-15comphelper: don't hardcode hash sizes in Hash::getLength()Miklos Vajna
Instead move the constants from filter to comphelper and reuse them. Change-Id: Ib7061e9028ccf6067b4e86f50145c1472c2b01d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98785 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-13svgexport: add TEXTLANGUAGE to not supported meta actionsTomaž Vajngerl
This adds TEXTLANGUAGE to "unsupported" actions, so that it is not logged as a warning, when we get a metafile with such action. Change-Id: I1afb3ce48e4526d7c9e623fe4571b8953f9a8ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98629 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-13Prepare test for SVG export of semi-transparent text, not enabledTomaž Vajngerl
This prepares the test for semi-transparent text, but the assert is not yet enabled until the bug gets fixed. Change-Id: I31a241910fd7bdf27579f291a497b76292eac775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98628 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-13tdf#134667 filter: EPS export: fix integer unsigned->signed SNAFUMichael Stahl
In PSWriter::ImplWriteF(), (nCount + 1) - nLen used to be unsigned long but now it's unsigned 32-bit int so on 64-bit platform values > 2^31 no longer init nStSize to negative values. (regression from cf82475c785c47327cdc9d591d63d7a82dd1ac53) Change-Id: Ib17537cf67c80883f10cf2a3b7e38d6a8f8dfcb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98654 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-13Fix typoAndrea Gelmini
Change-Id: I0b94689af645249f4142422d6bd2ec772f3bd373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98659 Reviewed-by: Michael Warner <michael.warner.ut+libreoffice@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-13filter/config: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I4de7d1b5822422bd7f85f09114c1e6ceb98551d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-13filter/graphic: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I28b6c5a532f55c88bad46573c123f92766b5af91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-13filter/msfilter: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I7bc7e89699173966406272138301a4ca2422281d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12filter/pdf: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ieb73f2a75804013383195130e16472cc671a4ac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98598 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12filter/svg: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I6a049364726327d1be10f72174aced5bade271a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12filter/storagefd: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I7329893b62a9fb511535f6caadcdb6e007aadfd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12filter/t602: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Icf7829977f4225ec40a63f5f2b8cf23ab360e883 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12filter/xmlfilteradaptor: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I44392add5b0ed6d3184e4ecdd2e8da729a78169c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11filter/xmlfilterdetect: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ie16b3a2a11c4b5fee579c05d041d287d753ab2a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11filter/xslt: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I7aae8e370a31a69f84dcbb4372077e5b8e0781fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-10replace usage of blacklist with excludelist for IWYUThorsten Behrens
Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 Change-Id: I2f22d455d2a936a85750eaab1fda215ebb6d9d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98182 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-10replace usage of blacklist with denylistThorsten Behrens
.. and a few cases of instead doing blacklist->excludelist where that made more sense. Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Canvas::DeviceBlacklist -> DeviceDenylist [API CHANGE] officecfg::Office::Canvas::BlacklistCurrentDevice -> DenylistCurrentDevice [API CHANGE] officecfg::Office::Common::Misc::OpenCLBlackList -> OpenCLDenyList Change-Id: Ia35e25496bf0cc0692d5de4cb66bfc232d3a869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98180 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-08Fixing top border style by fixing three XSLT issues triggered by...Svante Schubert
... new properties in ODF 1.3 * check for fo:border='none' * missing @ in @fo:background-color * without default case (xsl:otherwise), end delimiter for "page" missing in CSS Change-Id: Ie5d0c3e8a32de0403534c5a4fa33a5f20393ce69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98365 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-04reduce number of framework librariesNoel Grandin
Change-Id: I18bfdba3d26593f796d8b0bda87720e31066d5e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04reduce number of framework librariesNoel Grandin
Change-Id: If2bf85301eb1523a636d031f6e5a9f78cb1ee06b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97871 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01reorder parameters of SvXMLExport::SvXMLExportNoel Grandin
so they all have similar order Change-Id: Id8baef058d52f6cce9d9be41b0341eec8ad648b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: filterStephan Bergmann
Change-Id: I345f4677b0ac32f8373fb13c6db07041247e3982 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97561 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30ofz#23783 Invalid-enum-valueCaolán McNamara
Change-Id: Ifd641a24dc8db9cb19bb41480c19ed1e3f29c43a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97455 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-24ofz#23684 Invalid-enum-valueCaolán McNamara
Change-Id: Ie92b336adcf3734352c02742cf0eb249cfec774b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97023 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-05Related: tdf#113278 PDF export: improve selection of signing certificateMiklos Vajna
The action should be "select", not "sign", since we just select the certificate in the dialog. Signing will only happen later after the pdf export is almost done. Ignore gpg certificates which are not handled during pdf export. This does not implement the request in the bug, but at least hides certificates which don't work. Change-Id: Ib12f2e38bf864b08838e5970cebdba9ff20603bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95573 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-04Upcoming loplugin:elidestringvar: filterStephan Bergmann
Change-Id: Ic88f3ca8dffa416966734370ef01f8814eacdd05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95433 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-30ofz#22813 Invalid-enum-valueCaolán McNamara
Change-Id: Ia9b0a674bc9e7cd00498ec46962826e7ed08a721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-29loplugin:simplifybool in dbaccess..frameworkNoel Grandin
Change-Id: I0d73bb7d8d3fde426edc0a10c0750758b68aceb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-27ofz#22588 Invalid-enum-valueCaolán McNamara
Change-Id: Id632537856086490c3231879a81692e80edad4c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27Remove some unused includesMiklos Vajna
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26tdf#106181 XLSX export: output form controlsSerge Krot
Prepared general algorithm to ouput form controls into XLSX. For now only CHECKBOX is supported with a possibility to link withem to any worksheet/cell. Change-Id: Ide8739d81ffb755aeae074c4ebecf24251383e34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94161 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-24inline some use-once typedefsNoel Grandin
Change-Id: Idddba2f3fd05265b08dbc88edb6152d34a166052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21use for-range on Sequence in f*Noel Grandin
Change-Id: I820255001c1b96d1f4b76a203f3c0f76fa09fe66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>