summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)Author
2015-01-04cppcheck: Possible inefficient checking for <var> emptinessJulien Nabet
Change-Id: I6ca0e477a4429e762c48c721951b9876db3a5c6c
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-27coverity#735429 Logically dead codeCaolán McNamara
Change-Id: I2f2bd16d04b8058ba0d253eb3d5455fabbad54cd
2014-12-25fix new[]/delete mismatchMarkus Mohrhard
Found by asan. E.g. ooo45229-2.cgm
2014-12-20TyposJulien Nabet
Change-Id: I3475be796cf2655d9b619b86c9686aeef4b97b82
2014-12-19java: static fields that should not be staticNoel Grandin
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-18filter: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I9b8be418e8ac43eab27ef1f8a80ca09d66524810
2014-12-18comphelper: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Id1d5c3cf2f76dbb33606cec1c0f17d4a1f282247
2014-12-15document coverity#735433 Logically dead codeCaolán McNamara
Change-Id: I4a6917c78b527245ff1ae78c180aaf3a4a198045
2014-12-15filter: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I4b1c365bb2ff80b30748630d2c6296bf4ed6fd53
2014-12-15fdo#84938 replace PPT_PLACEHOLDER_ constants->enumTobias Madl
Change-Id: I4110fab17f42a747ec55b27445f28bdef873ef86 Reviewed-on: https://gerrit.libreoffice.org/13447 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-14fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. in addition: simplified some simple bool checks: "if (!bVar)" instead of "if(bVar == false)" Change-Id: I609b4a3ee7d43bbeeb91ba141af2c90511d0c8d7 Reviewed-on: https://gerrit.libreoffice.org/13455 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-14fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I09fa7d6f87a73a2ecee9b84e792d5df82ca5b420 Reviewed-on: https://gerrit.libreoffice.org/13457 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12fdo#84938 replace PPT_LAYOUT_ constants with enumTobias Madl
Change-Id: I3c77e7e551bd4b657cb58fdfeead73d50441e890 Reviewed-on: https://gerrit.libreoffice.org/13437 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11fdo#85486 - Clean up unnecessary enumerations from xenum.hxxRadu Ioan
Removed XGradientStyle Reviewed on: https://gerrit.libreoffice.org/13320 Change-Id: Iff662c05105c3a939104f658f2d0be7d8cb57995
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-08Related: rhbz#1164614 better default size for no xslt entries caseCaolán McNamara
Change-Id: I75dd1210b4e8e5e7cb2c2ce1e83e085a9c480b91
2014-12-05loplugin:cstylecast, involving pointer to incomplete typeStephan Bergmann
Change-Id: If8d2be68a75e69226f2a5a1d2936a257fa032c23
2014-12-05java: remove some unused local variablesNoel Grandin
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05fdo#84938: removed unused definesJennifer Liebel
Change-Id: Iaccc5ab6804c290b26e641c724051e497d00e32e Reviewed-on: https://gerrit.libreoffice.org/13308 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2014-12-04We want PDF signing to be non-experimental nowTor Lillqvist
Change-Id: Ic02d1f5169197edd8f9793befd45adf5db145a3b
2014-12-03fdo#83939: Add new error code for failed PDF signing, and handle itTor Lillqvist
Change-Id: Ide6dc06d33faea795272d9d32fc028ac8d023c5a
2014-12-03fdo#83939: Check return value from pPDFWriter->Emit()Tor Lillqvist
Change-Id: Id492b1b6b9d534276c155b1e46953d098ce8b969
2014-12-03Fix "result of 32-bit shift implicitly converted to 64 bits" on WNT x64David Ostrovsky
On Windows x64 long is only 32-bit (while on other x64 platforms it is typically 64-bit), but sal_uLong is not a typedef for unsigned long, but rather for sal_uIntPtr, which in turn is large enough to take recast pointer values (i.e., always 64-bit on 64-bit platforms). sal_uLong was introduced as a "temporary helper type" to ease transition from the old tools/solar.h types ("ULONG" etc.), but in the long run it should be remove from the code base, and places that now use sal_uLong analysed to use more appropriate types. As short term solution, cast to sal_uLong fixes it. Change-Id: I2169b7858517313616007a8fb2acc5c7d0487719 Reviewed-on: https://gerrit.libreoffice.org/13232 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-12-02add fallback encodings for Thai and VietnameseCaolán McNamara
Change-Id: Ie9fbf8d25e7954ae3a60ea7224881a0ad58280ad
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-30fdo#85486 - Clean up unnecessary enumerations from xenum.hxxRadu Ioan
Removed XDashStyle Change-Id: Id14802a007a90508ee033e1dc964c57d3d5ef582 Reviewed-on: https://gerrit.libreoffice.org/13213 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-11-282007/2010/2013->2007-2013Caolán McNamara
Change-Id: Ide300badd03e52394212eaa2ac457d6d5c1ee90f
2014-11-2897/2000/XP/2003->97-2003Caolán McNamara
Change-Id: I8ceaed177af64cb79bc6429ecad817f49cadeea2
2014-11-27unused function Calc_nBLIPPosAndras Timar
Change-Id: Iaa4073e2f1c0ccea7a5d63d24e34ac5647a0e7b0
2014-11-27fdo#84686 prevent std::bad_alloc exception by stricter input checkAndras Timar
The bugdoc has invalid length (rh.recLen) in header of blipStore's OfficeArtFBSE record. Therefore LibreOffice read junk for the next BLIP, and tried to seek to an invalid stream position, which caused bad allocation exception on 32-bit systems. Change-Id: I72fae4c2b00216b57736f4409a32c62a40f25785
2014-11-25java: remove some comment noiseNoel Grandin
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-24coverity#1242658 Untrusted loop boundCaolán McNamara
Change-Id: Ie22cb785065342582ca59f871a7b4da7e7bc77e5
2014-11-24typo: unknownAndras Timar
Change-Id: If89443c1668ca01c826c8fc353b20097c7da7bf4
2014-11-23fdo#85486 - Clean up unnecessary enumerations from xenum.hxxRadu Ioan
Removed XLineStyle Reviewed on: https://gerrit.libreoffice.org/13029 Change-Id: I583575a04988ccf932374e411672ba14a3f3cb2f
2014-11-21coverity#1242658 Untrusted loop boundCaolán McNamara
Change-Id: Ib3bb7f28b051c2886b470a77bdc6daf683a03f84
2014-11-19Related: coverity#1242658 Untrusted loop boundCaolán McNamara
Change-Id: Ic785b333c1ad31036da20483dc7310fcc5338d80
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17don't reuse old var remnantsCaolán McNamara
Change-Id: I1074d0431695ec21e22cdef334dbe419763e7ba2
2014-11-17afl: divide-by-zeroCaolán McNamara
Change-Id: Ided311873f654c0f40dae57c8876a6412ee97d3e
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17Simplify input parameters to just take the sequenceMatúš Kukan
Change-Id: Ic2538ca8b0f7261064e1dfbf3884dd452003c797
2014-11-17fdo#77268 SVG Import: fix null pointer dereferenceVort
Change-Id: I47c591f3d8b61d60f1258db3515c6805bf42304c Reviewed-on: https://gerrit.libreoffice.org/12472 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17More HIG fixes in filter, svxAdolfo Jayme Barrientos
Change-Id: I74df6b8221b4bb18791ec81af266dd58571c4c8c Reviewed-on: https://gerrit.libreoffice.org/12489 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-14coverity#1209889 Untrusted loop boundCaolán McNamara
Change-Id: I63039ca0de1dc54b5aa9d048e5110c31bf930bdc
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11callcatcher: dropping SwChapterNumRules binary Load/Store has knock-on effectCaolán McNamara
Change-Id: I2567026af23dd5fc42812b90bd6098c4c74a4f92