summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)Author
2020-02-10tdf#130262 ignore negative wrap distance values in doc prop importPatrick Jaap
Change-Id: I2c06b12c958dfde09adcc2ae4c59532ffde6b6fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88127 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-08Add minimum support for PDF/A3Arnaud Versini
Change-Id: I6ce3a3dbe71df1d3f56279879e3f91bd7c82f784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84687 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06ofz#20523 timeout, don't generate undo data during importCaolán McNamara
Change-Id: Id56901a6bf4da7bc8fbdcbcc811f6afb2121fe07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-05Fix typoAndrea Gelmini
Change-Id: Id16c1fe3fef0149a881f0ea684141e4e198892ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87999 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-04rename Set/GetTextFirstLineOfst->Set/GetTextFirstLineOffsetNoel Grandin
Change-Id: Iaeb3c17fe157dec82cd70991122c08ee1e215752 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03tdf#96505: Get rid of cargo cult long integer literalsDesmin Alpaslan
Change-Id: Id64855e3879d21106930a4dc9c36b246deb3c6e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85818 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29cid#1458020 Untrusted loop boundCaolán McNamara
cid#1458018 Untrusted loop bound cid#1242844 Untrusted loop bound Change-Id: I9062240290708f4b51b0ce42a30897b50d1a2677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87702 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ofz#20366 OOMCaolán McNamara
Change-Id: If658720502739e6ad88c3cf73ac6674e0313a48b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87648 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28tdf#96505: Get rid of cargo cult long integer literalsOnur Yilmaz
I checked return values. Long variables didn't affect the calculation. Change-Id: Ia3713eedf275de71b1096d1fe7e22da012a7f94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87493 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28New loplugin:unsignedcompareStephan Bergmann
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28remove some unused local varsNoel Grandin
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-27tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorSarper Akdemir
Change-Id: I37a8b72895e75bf1f0e7e1b1574353b3317ca031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87500 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27Use properly typed variable for iterationStephan Bergmann
Change-Id: I5fa9a889922f41be3f124ae0f66afac35130f41a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87490 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26remove some unused local varsNoel Grandin
found by a more aggressive variant of loplugin:unusedvariables. This is my first pass, committing the simplest and most obviously unnecessary vars Change-Id: I9676a6e39a101937097788548764506c93811c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87414 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-26rename some local variablesNoel Grandin
mostly to make the job of my very aggressive unused local vars plugin easier Change-Id: Ifc21a920841f8589f8b7e10de39dba6622a5d501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-24Revert "lok: ui: more files to increase the 'step-increment'"Miklos Vajna
This reverts commit 0a64b33617299ece871a947828855b16e2482706. Let's revert this till it's clear how to fix UITest_writer_tests2 to not hang with these changes. Change-Id: I9b40b101ecdad0ccac9a0b52b6a2ef19bd47a38c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87333 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>
2020-01-24loplugin:makeshared in drawinglayer..fpickerNoel Grandin
Change-Id: Ib20fec3a7b6bfe2f94c6f5f2f9fa0be6f7c21e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23lok: ui: more files to increase the 'step-increment'Henry Castro
property to 5. In mobile view, touch spin button should increment by 5 Change-Id: Ib3c8966443d053ab0588fa0c124f0daae31b7ed8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86844 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86854 Tested-by: Henry Castro <hcastro@collabora.com>
2020-01-21PDF export: don't ignore FilterData specified by UNO clientsMiklos Vajna
The data was given to the PDF filter, but then we stopped iterating right after finding our output stream. Seems this was always like this, ever since commit 4111b430a0a7954416ff95794a8ffb8fbc4472e3 (#101570#: added pdf filter, 2002-08-13). Change-Id: If26661935c22a7b7959fda5f92b4d50b15f13a35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87152 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-16ofz#20160 Integer-overflowCaolán McNamara
since... commit cf82475c785c47327cdc9d591d63d7a82dd1ac53 Date: Sun Dec 8 19:46:45 2019 +0530 tdf#114441 Changing sal_uLong to appropriate integer type in filters module Change-Id: I1f29e764c6405bb05dfd27da06bdc08cf8ae13cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86947 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16ofz#20150 unknown readCaolán McNamara
since... commit cf82475c785c47327cdc9d591d63d7a82dd1ac53 Date: Sun Dec 8 19:46:45 2019 +0530 tdf#114441 Changing sal_uLong to appropriate integer type in filters module Change-Id: I22b56d9a0084e7d55a2299143eae3d806f976d5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15tdf#114441 Changing sal_uLong to appropriate integer type in filters moduleshashikdm
changed sal_uLong to one of {size_t, sal_uInt64, sal_uInt32, sal_uInt16, sal_uInt8} in flash/impswfdialog.cxx and graphicsfilter changed PS_* in file filter/source/eps/eps.cxx to enum and overloaded bitwise or (|) made types of nSize, nParseThis, nComp and nBytesRead to sal_uInt32 as Michael Stahl suggested changes suggested by Michael Stahl changed x, y, j to sal_uInt32 in filter/source/graphicfilter/etiff/etiff.cxx changed nMinPercent, nMaxPercent, nLastPercent, nMainEntitiesCount to sal_uInt16 in filter/source/graphicfilter/idxf/dxf2mtf.hxx removed nGcount variable from filter/source/graphicfilter/idxf/dxfgrprd.hxx and filter/source/graphicfilter/idxf/dxfgrprd.cxx removed static_cast in filter/source/graphicfilter/idxf/dxf2mtf.cxx changed nComp in filter/source/graphicfilter/ieps/ieps.cxx to size_t changed mnCol to sal_uInt16 in filter/source/graphicfilter/ipbm/ipbm.cxx revised a number of datatypes as suggested by michael stahl in his reviews removed redundant static casts which caused test to fail Change-Id: Id892ee7e9c1ef3cf75c9d768b790ced9c2ce3f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84726 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-15tweak GetBitmap methods in BitmapExNoel Grandin
so we return a const& for the normal case, just like other methods, which reduces copying. This revealed that CreateDisplayBitmap in Bitmap can be const. Change-Id: I9f9b9ff0c52d7e95eaae62af152218be8847dd63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-14ofz#20087 Invalid-enum-valueCaolán McNamara
Change-Id: I32966a6b3973a0db9e186260225ded216607efbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14pdf export dialog update general tab alignment updateandreas kainz
Change-Id: I78dd99e3ca79322553b7bf1788f628a3e0aba305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86720 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-13ofz#20051 if duplicate exists then m_ObjToRecMap points to deleted elementCaolán McNamara
Change-Id: I854410ba1d5c0a622b5ba9c6816a24a3477e5089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86681 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-12tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorYusuf Keten
Change-Id: I9b285a80e0d52f412e2738995d66aa65cf93d16a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86606 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-12ofz#20031 AbrtCaolán McNamara
Change-Id: I54451cdda29b9683fc8adf8374cb611bbebf0097 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-11ofz#20025 Invalid-enum-valueCaolán McNamara
Change-Id: Ia1972a283b7d1d27a60ac763498eb175530b0c4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-11tdf#129417 Rename "Full-sheet previews" to "Whole sheet export"Roman Kuznetsov
in PDF option dialog Change-Id: Ib772599a68366be29f208e27f830b79015dbdc13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86593 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2020-01-10use more std::make_sharedNoel Grandin
found using 'git grep', I tried using clang-tidy, but it only successfully found a tiny fraction of these Change-Id: I61c7d85105ff7a911722750e759d6641d578da33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-09Introduce o3tl::make_unsigned to cast from signed to unsigned typeStephan Bergmann
...without having to spell out a specific type to cast to (and also making it more obvious what the intend of such a cast is) Change-Id: Id9c68b856a4ee52e5a40d15dc9d83e95d1c231cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86502 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-09Improve loplugin:redundantcast for sal_Int... vs. ::sal_Int...Stephan Bergmann
Change-Id: I1548a76fdc03afee68f1e5c01bc665e616f2edf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86501 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-09tdf#45636 trigger accessibility check when exporting as PDF/UATomaž Vajngerl
This triggers the accessibility check, when we want to export the PDF with PDF/UA functionallity. If issues are found, it will show the issues. OK will continue with export despite the issues and cancel will cancel the whole PDF export. Change-Id: I2fde97381e08e9c2c79473888caa36e8dd828979 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86387 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-09use for jpeg quality everywhere 80andreas kainz
Change-Id: I1744cb5e281b5d36dc9a29c85c7685730e3fbb32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86438 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-08tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer typesYusuf Keten
Change-Id: Idf73b768671c0daa0d815b75ce71740fc0e5f5c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86310 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08ofz#19901 Invalid-enum-valueCaolán McNamara
Change-Id: I14273dfc695c504bd00f23f614b041207a8f2b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-06ofz#19803 check for negative valuesCaolán McNamara
Change-Id: I30036a16cf1651a7e27c7aefa086b3725d58933a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86250 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-06Removed redundant semicolonsAndrea Gelmini
Change-Id: Ife14b8c3f7d121deb390deb5f405dd42d3016acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86156 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-04pdf: set the UniversalAccessibilityCompliance from the dialogTomaž Vajngerl
Change-Id: I380b760a39bcdbef271c948690b1c9a95c769b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86213 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-04ofz#19790 Invalid-enum-valueCaolán McNamara
Change-Id: Ifca6b26b39d873f67d6161d19354be4bd6462953 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30Fix typoAndrea Gelmini
Change-Id: I08e3c3351a6838ca199a1b6415e2f699c79748ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85975 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-29pdf: Add option for PDF/UA to the PDF export dialogTomaž Vajngerl
This is adding PDF/UA option to the PDF export dialog. When PDF/UA support is enabled, it automatically enables PDFTag support as it is required for PDF/UA. Change-Id: Ib3dece964523d4ed9884c98a6022a91120c6065f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85921 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-20ofz#19594 Invalid-enum-valueCaolán McNamara
Change-Id: Iffd708aa30d8dde2badc4748d2adb53b64c376aa Reviewed-on: https://gerrit.libreoffice.org/85534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-19Fix typoAndrea Gelmini
Change-Id: I90432c3d81878a43f7562e3798a9f5d8133f92ee Reviewed-on: https://gerrit.libreoffice.org/85489 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-19sal_Char->char in filterNoel Grandin
Change-Id: I0cec9d1f552e3350e2a2748861447a8f0afa64e8 Reviewed-on: https://gerrit.libreoffice.org/85474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-17tdf#42949 Fix IWYU warnings in filter/Gabor Kelemen
Also drop inc/gfxtypes.hxx and source/svg/spirit_supplements.hxx which are unused since commit 3ca7be09834a26fbd1c371deabd7a58111092676 "Replace SVGFilter using SVGIO" Drop now unneeded pass-through header source/graphicfilter/icgm/main.hxx too. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8abaf294370c98256815a226168085dd01123f3e Reviewed-on: https://gerrit.libreoffice.org/84734 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-17loplugin:expandablemethodsNoel Grandin
Change-Id: Ifc269d9996928085a3ab78033788465b4f029368 Reviewed-on: https://gerrit.libreoffice.org/85255 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-18 17:12:27 +0000