summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)Author
2014-10-16java: no need to call toString() on a String objectNoel Grandin
Change-Id: I05fa4bf198b3d77b1217eb65b5a1c79915016522
2014-10-15one of the oddest things I've seenCaolán McNamara
Change-Id: Ia0240d212a39401ea119588f4a0731b2b99d1d1f
2014-10-15Blind Win fix attemptStephan Bergmann
Change-Id: I39df464321685ebef29f44221bab9005295d0c3f
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15avoid double-deleteDavid Tardon
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e. Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
2014-10-15Make ImportCGM signature match ImportCGMPointer (in sdcgmfilter.cxx)Stephan Bergmann
Change-Id: I363777ff59b1756a15615d3daaa0c95542632361
2014-10-14fix tinderboxen with the right sort of brackets.Michael Meeks
Change-Id: I13869771890ce5702d64053e7823dd5cedc82a40
2014-10-14valgrind: init GroupLevelsCaolán McNamara
Change-Id: Idccebc826ade29a507e115108d20fd461b7bb4ec
2014-10-14stray ;s all other the placeCaolán McNamara
Change-Id: If67bf3361e082c1321f42ae7717cc941dc96e74b
2014-10-14valgrind: multiple errorsCaolán McNamara
Change-Id: Ic0ee492710650165004ad05f523424ba1b094473
2014-10-14check for short readsCaolán McNamara
Change-Id: I98a7d77cabe0207ff2b0190ccef47b87d1552930
2014-10-14sal_True->trueCaolán McNamara
Change-Id: Idbbc50afbb229dca1b62a7a0d1b2eeec9b0418d5
2014-10-14valgrind: Source and destination overlap in memcpyCaolán McNamara
Change-Id: I0b83a1955b6752c1253cfd7992a50b932aac078d
2014-10-14valgrind: Mismatched free() / delete / delete []Caolán McNamara
Change-Id: I78a9e08fb3535f9fe6c61a6e192c7aff4ef0c527
2014-10-14valgrind: Mismatched free() / delete / delete []Caolán McNamara
Change-Id: I293229dabb9a04f2e76b556e9da66921328ebe23
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-12coverity#1130166 Unchecked return valueCaolán McNamara
Change-Id: I0730a099463ac77afce4bb999f3f00ad7bb097c7
2014-10-11filter: stop leaking temp files in xsltfilter testMichael Stahl
Change-Id: Icefec168910ba0b059f4b1887ec67cce8505ffd6
2014-10-10fdo#65864: dont't traverse defs-nodes when in shape writing modeChr. Rossmanith
Relevant for opening svg images via File->Open: Children of the <defs> element should be interpreted only during the style collecting step. Collecting <path> elements from clip paths during the shape writing step leads to unwanted black polygons. Change-Id: I73598134c9be2877e975a7e756541ec3026fe768 Reviewed-on: https://gerrit.libreoffice.org/11793 Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2014-10-10typo: follwing -> followingAndras Timar
Change-Id: Ia201473c84dc0923e8f4bee6329ad926cd6addd6
2014-10-10coverity#1242472 gold, Identical code for different branchesCaolán McNamara
Change-Id: Ibdba24ef03ee4732e216b32b3f9e665706e96e4a
2014-10-10cid#1244954 Uncaught exceptionNoel Grandin
Change-Id: Ica5e88ed8294c4256da2798093cd4a191b7c5313
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08fdo#75757: remove inheritance to std::vectorTakeshi Abe
from SvxMSDffShapeOrders. Change-Id: Idf551f1fbde907759d6a296141e2837264dbbb10 Reviewed-on: https://gerrit.libreoffice.org/11840 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-06fdo#75757: remove inheritance to std::vectorTakeshi Abe
from PptSlidePersistList. This also puts in assertions that every entry in a PptSlidePersistList is non-null. Cf. 9536a28ede89e8c29940e8ba225215a45667062c Change-Id: Iea35532ed668e58a3f02d3f3433a66c2d4e1fe2a Reviewed-on: https://gerrit.libreoffice.org/11807 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06loplugin: cstylecastNoel Grandin
Change-Id: I88a106081b7413bff6313d1e07f53e39d8350002
2014-10-03coverity#1242529 silence Arguments in wrong orderCaolán McNamara
Change-Id: I662c89e6e3e0917b51e8084bc50a9ea38d6c0838
2014-10-02coverity#1202776 'Constant' variable guards dead codeCaolán McNamara
Change-Id: Ib1d5dcc8b09e11a8ef2399e3ef1a5ae1769de90f
2014-10-01coverity#1242472 Identical code for different branchesCaolán McNamara
Change-Id: I32a74aa1ad42b975bca4b13403d261fd31deb8dd
2014-10-01We require OS X SDK 10.8 or newer nowTor Lillqvist
Change-Id: I68eee76c8710c89af8e3c1e1006345f908923ece
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-28border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos
Second pass. Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d Reviewed-on: https://gerrit.libreoffice.org/11669 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-26remove unnecessary casts in misc calls to SvStream.Write*Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26remove unnecessary casts'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-26remove unnecessary static_cast'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods e Please enter the commit message for your changes. Lines starting Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-26cleanup GUID/ClsId/CLSID typesNoel Grandin
- rename GUID to SvGUID so we don't need an #ifdef WIN32 - drop ClsId struct, since it is used interchangeably with GUID and has the same structure Change-Id: Idf5c14c82a6861ef585fb57896a9b12cfe40374c
2014-09-26filter: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: Id1d0392e1dbd33de326aa2bd8cbcf8cc03bf7c90
2014-09-25fdo#63483: support for modify passwd in Impress and DrawKatarina Behrens
iow, allow opening Impress and Draw ODF documents read-only Change-Id: I379b9f92b9bfb20e99998177d9a5fae80069d98f Reviewed-on: https://gerrit.libreoffice.org/11495 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-18.ui tweaks to PDF export tab pagesAdolfo Jayme Barrientos
Added missing colons, use sentence case for check boxes [1], allow descriptive security labels to wrap, add 6 px padding for the Sign page. Change-Id: Iafc0788e367ab74aa0ec740b06892926b0b00390 Reviewed-on: https://gerrit.libreoffice.org/11408 Reviewed-by: Katarina Behrens <bubli@bubli.org> Tested-by: Katarina Behrens <bubli@bubli.org>
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18cid#736037 Missing break in switchNoel Grandin
Change-Id: I4a982ebfd3864b5953bce4ddf90008706e0e49b9