summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)Author
2021-09-14ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5906dc1f9f0295d406c01871e5fed1da0025682f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-12clang:optin.performance.PaddingNoel Grandin
Excessive padding in 'struct chart::TickInfo' (11 padding bytes, where 3 is optimal). Excessive padding in 'class EscherBlibEntry' (10 padding bytes, where 2 is optimal). Excessive padding in 'struct oox::drawingml::ConditionAttr' (8 padding bytes, where 0 is optimal). Excessive padding in 'struct oox::drawingml::Constraint' (12 padding bytes, where 4 is optimal). Excessive padding in 'struct (anonymous namespace)::Number' (10 padding bytes, where 2 is optimal). Change-Id: If7573afa8a794497c9a2bf1c7c15e8f11ff11407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121993 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08simplify static_cast after dynamic_castNoel Grandin
Change-Id: I53ae7f18519fdd878730d1d0316ebc408271c66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08Drop unused rUsedDetectors argumentMike Kaganski
... ever since commit e4003b67062e575f9b77772488f9b9691fa9fc38 Author: Kohei Yoshida Date: Thu Mar 7 01:35:09 2013 -0500 Make check passes. Remove deep-only detection for real. Now the type detection process is a lot more simpler. Change-Id: Ib0c08e28edf85a3642e187798a08ed2e143bf56c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121765 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-06ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I6db44a3a56f3eca02970bdce393355715564299e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121701 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-04dynamic_cast -> static_cast (tdf#130795)Noel Grandin
the dynamic_cast is hot here, and none of these dynamic_casts are necessary, we already assert that they must succeed, so just use static_cast Change-Id: I88ade90431c4da4792c778b5cdab22332ed1c428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04use std::vector for fetching DX array dataNoel Grandin
because I'm trying to track down a related heap corruption, and that is much easier if the access to the array is checked by the std::vector debug runtime Change-Id: Ia665f5cebb7f14d88942e88b4b400ad3c28ef5d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03cgm bounding box was originally Point and SizeCaolán McNamara
so keep it like that Change-Id: I0392f283b79174c831d29b1895817cf6ee35ba3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03check stream stateCaolán McNamara
Change-Id: Id096abd3dee2584a3afa01d7ce005ed74a224a94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03no need to allocat PptFontEntityAtom separately hereNoel Grandin
Change-Id: Id0b8c919bc35bb427a88c229d024a118437785f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-02do the same check on the same code pattern as was done earlierCaolán McNamara
in this same function Change-Id: I03a112e3e57549ec776e99a460544b575476528d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ie666d56816b5af96590d482e2af204e0f6486bc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121494 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02rename UpdateMode -> UpdateLayout in editeng classNoel Grandin
... because "update" is such a generic term I keep forgetting what we are turning on and off Also return the previous value from SetUpdateLayout to make the save/restore code more compact. Change-Id: Iae1764c837a92e58c9b17521f130e8fc80311d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121479 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-01ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I394b84d9d83d09096932c94fb09e6d964a5aecfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121398 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31clang-tidy:readability-redundant-member-initNoel Grandin
Change-Id: Icaef0cca9ca7bce76a7eb7ecd54c492f9ffcaad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-30ofz#37831 avoid Integer-overflowCaolán McNamara
Change-Id: I95acce44623c6c5e48686a79314ffaf6ab402292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I50411f90940c1225b6164d4eadcb9dbd14e9e2b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ie994deb224ef403a42108656c7ad142ad9447d5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121239 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9f467529458e303af371a653ef6412413db2f8a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-28avoid unnecessary OString to OUString conversionNoel Grandin
speeds up loading some writer files Change-Id: Ia6dddf3a9e8990b8cd3f600c86c758573c7ea2ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-27ofz: Integer-overflowCaolán McNamara
Change-Id: I4142f48db0f756872ea75e1c39cda6195bdddf43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26tdf#143526 Korean numbering import/export supportDaeHyun Sung
add support for the new NUMBER_LEGAL_KO(korean-legal) numbering format to various import and export filters. fix support for the HANGUL_SYLLABLE_KO(korean-counting) numbering format. Change-Id: I7b7dafe7305da910784ae537e307f9bfd05319a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120509 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-25tdf#113240 Fill imissing pdfgeneralpage.ui extended tipsOlivier Hallot
Address "Export pçaceholders". Change-Id: I8cfea3ea8daea948c7b4bd269d976e223ff9222d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120960 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-25Bump Glade release for pdfgeneralpage.uiOlivier Hallot
no changes in contents Change-Id: I0adb61facad506ebfa7e0ab0bff81948d84007e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120959 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-24ofz: cgm Integer-overflowCaolán McNamara
Change-Id: I1cb1d5612f2b0b8999fed0d6c203ab24eedd4fe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-23loplugin:referencecasting look through more clang TypesNoel Grandin
Note that because of where the fix resides, loplugin:redundantcast also notices a few more things. Change-Id: I0b66047fadfff2c5ceafcbd3eab085de00d861a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120865 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-22don't store vcl::Font with unique_ptrNoel Grandin
it is already a COW object, so just use std::optional Change-Id: I5ced54dbf3dc222316d9bcf3581b36e0f6e6e270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-22no need to use unique_ptr for PolygonNoel Grandin
it is already a COW type Change-Id: I74ffb129aa63cd9c56794997d72e32002f8b45fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120822 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20New loplugin:unusedcapturedefaultStephan Bergmann
In sc/qa/unit/ucalc_formula.cxx, dropping the capture-default from the lExpectedinF lambda revealed that MSVC in C++17 mode (i.e., when building without --with-latest-c++) requires ROW_RANGE (a local const int variable from the enclosing TestFormula::testTdf97369) to be captured, even though all uses of that variable within the lambda body are constant expressions. That is still true at least for the latest Visual Studio 2019 version 16.11.1. (This is not an issue for the lExpectedinH and lExpectedinI lambdas a few lines further down, as they, in addition to using that ROW_RANGE, also use the local const double variables SHIFT1 and SHIFT2, whose uses are not constant expressions, so they are implicitly captured and loplugin:unusedcapturedefault does not suggest dropping those lambdas' capture-defaults in the first place.) Change-Id: Iee7efb485187cbe8eba6a2d470afca4993eb1816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120693 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-19Drop GetSdrObjectFromXShape and use SdrObject::getSdrObjectFromXShapeMike Kaganski
Change-Id: I0d233878ee49fcdc1338ec3bd700e5482d558163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120694 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18undo changes to TextAlignCaolán McNamara
revert commit 8689bd5490b473a7ffb149bbe5f7f0683f679c72 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 29 20:49:29 2021 +0100 convert TextAlign to scoped enum lets leave this as it always was Change-Id: Id4d2a5644974cdd2b0ed6d361d5c52629674d057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120626 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17Move GDIMetaFile::GetChecksum to SvmWriter::GetChecksumpanoskorovesis
Move the method and update all the method calls from GDIMetaFile::GetChecksum -> SvmWriter::GetChecksum Remove the method from gdimtf Change-Id: I68e2b3cf99178947ac4f1474810dd5568f07e122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120414 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-16pass OutlinerParaObject around by valueNoel Grandin
since it uses o3tl::cow_wrapper, so it is really just a wrapper around a pointer, no point in allocating it on the heap Remove assert in SdrText::SetOutlinerParaObject, which was bogus anyhow, because it was comparing pointers, not deep equality. And since we are now being more efficient and avoiding copying of the internal data in OutlinerParaObject, we hit this assert. Change-Id: I6dbfaab5ee2ca05b2001baf63110041e469df9c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120510 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13rtl::Static -> thread-safe static localNoel Grandin
Change-Id: If5b7181fb1bb3f3f21ec3742680e5a3e12b21b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13tdf#105575 Slow rendering when using a Logo commandNoel Grandin
Remove dynamic_cast'ing to Primitive2D, expensive and unnecessary <quikee[m]> noelgrandin: nobody is using XPrimtive that is not derived from BasePrimitive2D in an extension ... mainly as it is not even possible Change-Id: I68224021f0fbc35fe2a973198ba78d2b41ea172d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13split SvNumberFormatter into it's own headerNoel Grandin
so I can make changes without running into cyclic dependencies between header files Change-Id: I98a91c7cc66002ba745cdb8239e5cc267922a45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13Replace ReadGDIMetaFile with SvmReader::Readpanoskorovesis
Use the new Read functionality Change-Id: Ied997377fda8793422b1c8877ece705e4a9b6dbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120376 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-10add some --disable-scripting fixesCaolán McNamara
Change-Id: I45f08bce8e067ead82f4c73c8150b7027c083172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-10Missing includeStephan Bergmann
(for std::unique_ptr, with recent libstdc++ 12 trunk) Change-Id: I61b7823dd740ea7cdfe0d7403a50ac73b24d1c4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-07create comphelper::OMultiTypeInterfaceContainerHelper2 and use itNoel Grandin
based on OInterfaceContainerHelper2 which is considerably faster than the original OInterfaceContainerHelper Change-Id: I9c8b6d0e5382018824bf7188a26343703abf2d51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-06Replace GDIMetaFile::Read with SvmReader::Read in svgexport.cxxpanoskorovesis
Use the new read functionality in filter/source/svg/svgexport.cxx Change-Id: I798bd35df9f7f15c5f802b8a6b2f5af2136ce0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119963 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-05drop unneeded forward declareCaolán McNamara
Change-Id: I858d4a43690bd37385eb6f48945c05dd9c2a6182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-05Pass context and resource string down to boost::locale separatelyNoel Grandin
because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-02convert #defines to OUStringLiteralNoel Grandin
mostly by doing $ git grep -l '#define.*\"' -- *.cxx | xargs perl -pi -e 's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 = u\2;/g' Change-Id: Idface893449b0ef2a3c5254865a300585d752fbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119669 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-30convert TextAlign to scoped enumCaolán McNamara
Change-Id: Id2c466eacb44f0ea6adba75a0ac0be8be8e7ed4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-28Related: ofz#36348 ubsan runtime error: value outside representable rangeCaolán McNamara
Change-Id: I0dbbba2c4020d7fc7e6f12aba4bfcb003fa13893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119611 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-07-27ofz#36348 Integer-overflowCaolán McNamara
Change-Id: I7c6020e94c9ec9d002e66d0ad83426c062ebd5c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-26tdf#143543 Fix extended tip for pdflinkspage.uiOlivier Hallot
Note: E.T. borrowed from Help page. Change-Id: Ia4da746aa25c72a3ef1a77a52fea5034fb3a0ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119507 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-26Bump Glade version to 3.38 for pdflinkspage.uiOlivier Hallot
No change in dialog contents Change-Id: I648ef9bda3d20782d6912e765fa4a28a68a663b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119506 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-21IsVertical->IsEffectivelyVertical, GetDirectVertical->GetVerticalMike Kaganski
Before commit 653b53287ca09a9ffe3f5ce0242919e719c1086c, editengine objects had a pair IsVertical/SetVertical, which queried and set a boolean flag (and SetVertical also had a second argument to set another flag). The mentioned commit had introduced an inconsistency, changing SetVertical to only set a single flag, but at the same time making IsVertical to return a synthesized result from two values: vertical and rotation. Additionally, GetDirectVertical was introduced to complement SetVertical. In many places, the use of synthetic IsVertical looks suspicious, especially where it is used in combinations with SetVertical. But here I don't change existing logic, and only rename the methods, so that in case someone sees an actual problem, it would be easier to spot the method mismatch. The end result is that now we have a proper getter/setter pair GetVertical/SetVertical, and also IsEffectivelyVertical, named to reflect that it calculates its return value. Change-Id: I38e2b7c5bd7af0787dd7a1c48e1385138dac80b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119315 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-08 09:02:41 +0000