summaryrefslogtreecommitdiff
path: root/forms/source
AgeCommit message (Collapse)Author
2016-10-26coverity#1374279 Uncaught exceptionCaolán McNamara
Change-Id: I5818bb0a2fe64fd808de5ca7f6d8393f92ab55e2
2016-10-26coverity#1374278 Uncaught exceptionCaolán McNamara
Change-Id: Ide557d1a3237c36067107d357ac2df6186994e10
2016-10-26coverity#1374277 Uncaught exceptionCaolán McNamara
Change-Id: I2475056682252111af78a7594c04d15a93fda47f
2016-10-26coverity#1374276 Uncaught exceptionCaolán McNamara
Change-Id: I0572e4365831cf0be2b73c5255812aaf4516ccb0
2016-10-26coverity#1374275 Uncaught exceptionCaolán McNamara
Change-Id: I6fcc5d75d8a4b131dc4e3b2e294761b152763a1b
2016-10-26coverity#1374274 Uncaught exceptionCaolán McNamara
Change-Id: I9e3cee79dfdc06c751d1e5b3d0806c49a7e30da7
2016-10-26coverity#1374273 Uncaught exceptionCaolán McNamara
Change-Id: Ia2738aeb9d1092dd0738801022c5a729b9081f26
2016-10-26coverity#1374272 Uncaught exceptionCaolán McNamara
Change-Id: Iea7cb5d35e78b89398e8aca7bbdbd17015cb7120
2016-10-26coverity#1374271 Uncaught exceptionCaolán McNamara
Change-Id: I043cd76ae0da65cac09130f0e761266fd8730be6
2016-10-26coverity#1374270 Uncaught exceptionCaolán McNamara
Change-Id: Ia29b644748f00aa7dc31af9ccc510976d8646241
2016-10-26coverity#1374269 Uncaught exceptionCaolán McNamara
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19loplugin:expandablemethodds in filter..formsNoel Grandin
Change-Id: Ic1f64f804acc10b1a48d82de9fc6a2b39af465a0 Reviewed-on: https://gerrit.libreoffice.org/30014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-12Don't allow O[U]StringBuffer in string concatenationStephan Bergmann
...as OStringBuffer b("foo"); b = "bar" + b; doesn't work as one might expect (see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html> "concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And of the affected places, MethodDescriptor::getSignature (codemaker/source/javamaker/javatype.cxx) was the only one that would actually have benefitted. Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
2016-10-05loplugin:unnecessaryoverride in forms/frameworkNoel Grandin
Change-Id: Ia2aabec5af5559903be09e1ef81d156a7538ab3f
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03Fix typosAndrea Gelmini
Change-Id: I6730c6c5eab9157533822e5045e9f86109062580 Reviewed-on: https://gerrit.libreoffice.org/29433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16Drop redundant castTakeshi Abe
Change-Id: Ief00bc6e82cd4e54602e069c0bafd1dfc7bdd2ff
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12loplugin:constantparam in extensions..lotuswordproNoel Grandin
Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01coverity#1372386 Uncaught exceptionCaolán McNamara
Change-Id: Ic1fd5486e6b26718086d2f062459f11c00f244d2
2016-08-30default dtors are fine hereCaolán McNamara
Change-Id: I503f954a2729aa2737d783ed8c72f62d8a68da4c
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (forms)Stephan Bergmann
Change-Id: I25323e586bb80b833d1b2dace5498de853aa039e
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu
Change-Id: I3099818283a9801976288d0efa67a8711106f376 Reviewed-on: https://gerrit.libreoffice.org/28360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-21tdf#89329: use unique_ptr for pImpl in richtextvclcontrolArnold Dumas
Change-Id: Icaa9b8bed2ae6efc8d87b44b5f104c4a4b272f70 Reviewed-on: https://gerrit.libreoffice.org/28263 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-17convert SvxEscapement to scoped enumNoel Grandin
and fix a potential bug with footnotes and superscripts in writer in ndtxt.cxx, where it was passing bad args to the SvxEscapementItem constructor Change-Id: I0d2de34c056e7824f3b456a86d502e10ac93a1c1
2016-08-17convert SvxLineSpace to scoped enumNoel Grandin
and rename to be more explicit Change-Id: Id06e6b68ef30e1d0d0daf19c37a390060e8bcb01
2016-08-17convert SvxInterLineSpaceRule to scoped enumNoel Grandin
and rename it to be more explicit Change-Id: I3f8bd7928495dba1e94b785cdda06d9819ee66bf
2016-08-12loplugin:unusedenumconstants in forms..sotNoel Grandin
Change-Id: Ic445e1bdd012c32ef7d84aec9df908467c3296a7 Reviewed-on: https://gerrit.libreoffice.org/28055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19improve unnecessaryoverride pluginNoel Grandin
to ignore ImplicitCastExpr when calling superclass method Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1 Reviewed-on: https://gerrit.libreoffice.org/27279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15Improve loplugin:unnecessaryoverrideStephan Bergmann
<sberg> thorsten, remember what that "TODO" in SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly, in a909acb7009acadffa53e74ea05ddb88803490f1 ? <thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review me' <sberg> thorsten, OK, thanks (that override will eventually go away with loplugin:unnecessaryoverride, and the TODO comment be lost) Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac Reviewed-on: https://gerrit.libreoffice.org/27232 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I21cd93811f8491172ae7d3841b1abc55d401c1ae
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04Localize error message in ODataTypeRepositoryMuhammet Kara
Change-Id: I92b5a69daf405d71bf8f72685696c647a64cc9d1 Reviewed-on: https://gerrit.libreoffice.org/26807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-29move #includes to top of fileNoel Grandin
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29Further clean-upStephan Bergmann
Change-Id: I16b8bfe2c4a337acf188ec8ffa2ed084ca437faa
2016-06-29Remove unused template parameterStephan Bergmann
Change-Id: I3b1f54f88351512cbe2e555f9ca9c1c0dcc2c098
2016-06-28loplugin:singlevalfields in variousNoel Grandin
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-20Remove unused includesStephan Bergmann
Change-Id: I25bb67449c8c572075d354e62b1c731e95655b4f
2016-06-19loplugin:salbool: Implicit conversions from non-Boolean fundamental typesStephan Bergmann
Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
2016-06-10Clean up uses of Any::getValue() in formsStephan Bergmann
Change-Id: I335aabc92ecb5de107dad3ecdfa6e025ec0d1b0f
2016-06-08remove some manual ref-counting in formsNoel Grandin
Change-Id: I6334dca6e98bfd4531033bec203518ca27f64bc0 Reviewed-on: https://gerrit.libreoffice.org/26049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08split AddRemoveListener into two methodsNoel Grandin
Change-Id: I247dc8a9033b39d5e49dc06e725f638644fcd02d
generated by cgit (git 2.34.1) at 2024-07-20 23:54:58 +0000