summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)Author
2014-02-26Remove visual noise from formsAlexander Wilms
Conflicts: forms/source/component/DatabaseForm.cxx Change-Id: I4005fe65e89794bd92191c37221c252a3e964917 Reviewed-on: https://gerrit.libreoffice.org/8262 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-25Typo: apropriate -> appropriateJulien Nabet
Change-Id: I05e23039dc3ae0b6595c87fe550f4228ad93d5d6
2014-02-24implicitboolconversion: warn about implicit conversion of call args to boolStephan Bergmann
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f "sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it" earlier when converting occurrences of sal_Bool to bool. Restricting this check to function call arguments avoids too much noise while hopefully still catching all the relevant problems. (This check partially overlaps the pointertobool check, so implicit conversions from pointers to bool call arguments will now generate two loplugin warnings, but that's harmless.) Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24Replace exisiting TriState, AutoState with more generic TriStateStephan Bergmann
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24toolkit: sal_Bool -> boolStephan Bergmann
Change-Id: I5153c4413004d1b50cc503b3e70657bc831a5793
2014-02-24Remove unnecessary bool2anyStephan Bergmann
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24Remove unnecessary extractInterfaceStephan Bergmann
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-23coverity#704644 Dereference after null checkCaolán McNamara
Change-Id: I9b2aad39c54497b5b53a86cf11a754f89c012d0e
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23coverity#441137 Dereference after null checkCaolán McNamara
Change-Id: I877abe904885f28560cf43ee70001ac97fadbe04
2014-02-21coverity#738652 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ie191910d49ee9f622bc407a768e79671698d2ac3
2014-02-21coverity#738654 Uninitialized scalar fieldCaolán McNamara
Change-Id: I92909b606e06f3d86fc3b66aef1ac52e5d706967
2014-02-21coverity#738656 Uninitialized scalar fieldCaolán McNamara
Change-Id: I49e3f47e318ae342738dd1de90673e2aee2bb62b
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21editeng: sal_Bool->boolNoel Grandin
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
2014-02-21editeng: sal_Bool->boolNoel Grandin
Change-Id: I36cb765d87ddef1fba3447a3ea90e5285cbcd678
2014-02-21Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-18Drop unnecessary #includeTakeshi Abe
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
2014-02-17comphelper: sal_Bool -> boolStephan Bergmann
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17ucbhelper: sal_Bool -> boolStephan Bergmann
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-02-13coverity#737157 Uncaught exceptionCaolán McNamara
Change-Id: I062dbdf7c29489111f7ba6dc37a191d835fa7824
2014-02-13coverity#737151 Uncaught exceptionCaolán McNamara
Change-Id: I133012cf88020e38eb0fc0932979347b996943fe
2014-02-13coverity#737149 Uncaught exceptionCaolán McNamara
Change-Id: I34b31a3574e5a21a506c49b4f69f3b8c8fbdcdbd
2014-02-12cid#705175 missing break in switchNoel Grandin
Change-Id: I4565f3eab411a706eddc665b5b35f3b940b4a52c
2014-02-12cid#705174 missing break in switchNoel Grandin
Change-Id: Id3563f949a210ea4af59a96bbbbbb615368b06c2
2014-02-06typo fixes in commentsAndras Timar
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-05fdo#69652 Default(Date|Time) is a UNO struct nowLionel Elie Mamane
Changed to UNO struct from integer by fdo#67235 adapt form control code to time nanosecond API change Change-Id: I5817d44438d70a0da534c03afd22d74a311252f5
2014-02-03fdo#54938 Convert to cppu::supportsServiceAlexandre Vicenzi
Change-Id: I512c525029ebd63d261560d27e9f38bbe94f7e10 Reviewed-on: https://gerrit.libreoffice.org/7649 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-01-30"stati" considered both pretentious and incorrect LatinMichael Stahl
As one knows, the Latin plural of the noun status is statūs. Change-Id: I6b19c57aa2aedcc1337736becc93d8802fe03f2e
2014-01-30fdo#63154 Removed unused solar.h ref. in basic, cui, forms and writerfilter.Alexandre Vicenzi
Change-Id: I09cca73d8d77af259965e74e1b29a88aa5c315ab Reviewed-on: https://gerrit.libreoffice.org/7731 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-28bool improvementsStephan Bergmann
Change-Id: I78099f87510355a43ba9b01ca9d545d44ce11a50
2014-01-28Introduce com.sun.star.frame.theUICommandDescription singleton.Matúš Kukan
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28coverity#705814 Dereference before null checkCaolán McNamara
Change-Id: Ib5eb5a7058098f7222b1597e60ddc84786403805
2014-01-23Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-21FORMS : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db Reviewed-on: https://gerrit.libreoffice.org/7534 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-15remove last xub_StrLen in formsCaolán McNamara
Change-Id: If6c711cf9c317411c72260b4029521782f8a282c
2014-01-14bool improvementsStephan Bergmann
Change-Id: Iba5bf2d2207f80098cb43ff8ce290eef741d21c9
2014-01-08Lock SolarMutex in RichtTextEngine::CreateStephan Bergmann
...as always, the question is where exactly to place the mutex guard, but without it querying for XServiceInfo of a freshly instantiated "stardiv.one.form.component.Edit" (i.e., OFormattedFieldWrapper) would lead to failing > DbgTestSolarMutex () at include/tools/debug.hxx:295 > OutputDevice::ImplGetGraphics (this=0x2b81dc11e680) at vcl/source/gdi/outdev.cxx:560 > OutputDevice::DrawRect (this=0x2b81dc11e680, rRect=Rectangle = {...}) at vcl/source/gdi/outdev.cxx:1649 > OutputDevice::ImplDrawColorWallpaper (this=0x2b81dc11e680, nX=0, nY=0, nWidth=1, nHeight=1, rWallpaper=...) at vcl/source/gdi/outdev6.cxx:778 > OutputDevice::ImplDrawWallpaper (this=0x2b81dc11e680, nX=0, nY=0, nWidth=1, nHeight=1, rWallpaper=...) at vcl/source/gdi/outdev6.cxx:1083 > OutputDevice::Erase (this=0x2b81dc11e680) at vcl/source/gdi/outdev6.cxx:1144 > VirtualDevice::ImplInitVirDev (this=0x2b81dc11e680, pOutDev=0x28dc0a0, nDX=1, nDY=1, nBitCount=0, pData=0x0) at vcl/source/gdi/virdev.cxx:114 > VirtualDevice::VirtualDevice (this=0x2b81dc11e680, nBitCount=0) at vcl/source/gdi/virdev.cxx:136 > ImpEditEngine::SetRefDevice (this=0x2b81dc045f10, pRef=0x0) at editeng/source/editeng/impedit2.cxx:195 > ImpEditEngine::ImpEditEngine (this=0x2b81dc045f10, pEE=0x2b81dc0c8a00, pItemPool=0x2b81dc0a0960) at editeng/source/editeng/impedit2.cxx:156 > EditEngine::EditEngine (this=0x2b81dc0c8a00, pItemPool=0x2b81dc0a0960) at editeng/source/editeng/editeng.cxx:104 > frm::RichTextEngine::RichTextEngine (this=0x2b81dc0c8a00, _pPool=0x2b81dc0a0960) at forms/source/richtext/richtextengine.cxx:103 > frm::RichTextEngine::Create () at forms/source/richtext/richtextengine.cxx:52 > frm::ORichTextModel::ORichTextModel (this=0x2b81d866ff30, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at forms/source/richtext/richtextmodel.cxx:66 > frm::ORichTextModel::Create (_rxFactory=uno::Reference to (cppuhelper::ServiceManager *) 0x2b813a25a260) at forms/source/richtext/richtextmodel.cxx:243 > cppu::OSingleFactoryHelper::createInstanceEveryTime (this=0x2b819d66a6a0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:171 > cppu::OSingleFactoryHelper::createInstanceWithContext (this=0x2b819d66a6a0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:203 > cppu::OFactoryComponentHelper::createInstanceWithContext (this=0x2b819d66a638, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:432 > non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:433 > cppuhelper::ServiceManager::createInstanceWithContext (this=0x2b813a25a208, aServiceSpecifier="com.sun.star.form.component.RichTextControl", Context=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/servicemanager.cxx:979 > non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/servicemanager.cxx:987 > frm::OControlModel::OControlModel (this=0x2b81d8679408, _rxContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, _rUnoControlModelTypeName="com.sun.star.form.component.RichTextControl", rDefault="com.sun.star.form.control.TextField", _bSetDelegator=0 '\000') at forms/source/component/FormComponent.cxx:593 > frm::OBoundControlModel::OBoundControlModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, _rUnoControlModelTypeName="com.sun.star.form.component.RichTextControl", _rDefault="com.sun.star.form.control.TextField", _bCommitable=1 '\001', _bSupportExternalBinding=1 '\001', _bSupportsValidation=1 '\001') at forms/source/component/FormComponent.cxx:1273 > frm::OEditBaseModel::OEditBaseModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, rUnoControlModelName="com.sun.star.form.component.RichTextControl", rDefault="com.sun.star.form.control.TextField", _bSupportExternalBinding=1 '\001', _bSupportsValidation=1 '\001') at forms/source/component/EditBase.cxx:57 > frm::OEditModel::OEditModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at forms/source/component/Edit.cxx:296 > frm::OEditModel_CreateInstance (_rxFactory=uno::Reference to (cppuhelper::ServiceManager *) 0x2b813a25a260) at forms/source/component/Edit.cxx:280 > cppu::OSingleFactoryHelper::createInstanceEveryTime (this=0x2b819d66a5c0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:171 > cppu::OSingleFactoryHelper::createInstanceWithContext (this=0x2b819d66a5c0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:203 > cppu::OFactoryComponentHelper::createInstanceWithContext (this=0x2b819d66a558, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:432 > non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:433 > cppuhelper::ServiceManager::createInstanceWithContext (this=0x2b813a25a208, aServiceSpecifier="com.sun.star.form.component.TextField", Context=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/servicemanager.cxx:979 > non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/servicemanager.cxx:987 > frm::OFormattedFieldWrapper::ensureAggregate (this=0x2b81d8879818) at forms/source/component/FormattedFieldWrapper.cxx:342 > frm::OFormattedFieldWrapper::queryAggregation (this=0x2b81d8879818, _rType=invalid uno::Type) at forms/source/component/FormattedFieldWrapper.cxx:164 > cppu::OWeakAggObject::queryInterface (this=0x2b81d8879818, rType=invalid uno::Type) at cppuhelper/source/weak.cxx:281 > frm::OFormattedFieldWrapper::queryInterface (this=0x2b81d8879818, _rType=invalid uno::Type) at forms/source/component/FormattedFieldWrapper.hxx:68 > com::sun::star::uno::BaseReference::iquery (pInterface=0x2b81d8879818, rType=invalid uno::Type) at include/com/sun/star/uno/Reference.hxx:43 > com::sun::star::uno::Reference<com::sun::star::lang::XServiceInfo>::iquery (pInterface=0x2b81d8879818) at include/com/sun/star/uno/Reference.hxx:58 > com::sun::star::uno::Reference<com::sun::star::lang::XServiceInfo>::Reference (this=0x2b81d8663a98, rRef=...) at include/com/sun/star/uno/Reference.hxx:158 Change-Id: I16ebbb2caf4f0fe943c9e43bddde03b5a2627e35
2014-01-08This can be privateStephan Bergmann
Change-Id: Ida54a46580fb3d1ec49ea5daeb55c0235d2bf85a
2013-12-22Fix other typosJulien Nabet
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
2013-12-20Spelling correction: s/retrive/retrieve/Tor Lillqvist
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-17No need for implbase1.hxx to include XComponentContext.hppStephan Bergmann
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up, of course. Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866