summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)Author
2019-10-21loplugin:virtualdead unused params in formsNoel Grandin
Change-Id: Iac26ba57443060474f4f33c4f449a69eca8c1063 Reviewed-on: https://gerrit.libreoffice.org/81236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-18make bin/update_pch.s always include code in trivial #if'sLuboš Luňák
E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds with our PCHs. Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5 Reviewed-on: https://gerrit.libreoffice.org/80961 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-15new loplugin:bufferaddNoel Grandin
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26loplugin:constmethod in forms..fpickerNoel Grandin
Change-Id: I1673e00be0a6c9d34ce02437bf68d929c56952f7 Reviewed-on: https://gerrit.libreoffice.org/79540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-17move GetStandardText to stdtext.hxxCaolán McNamara
Change-Id: Iaf9b5107cf88390f62d5ca94bf985c77bcb8b7ad Reviewed-on: https://gerrit.libreoffice.org/79048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-06return unique_ptr from :svt::GraphicAccess::getImageStreamNoel Grandin
Change-Id: Ie63259ce826101e553c1cb03a85e7c0ba5f0f9f5 Reviewed-on: https://gerrit.libreoffice.org/78719 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06tdf#39593 use isUnoTunnelIdArkadiy Illarionov
Adapt getUnoTunnelId methods where required: rename or make public. Change-Id: I0fd2120bf9f0ff1aa690329a65ff64a154c89315 Reviewed-on: https://gerrit.libreoffice.org/78680 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-06TyposAndrea Gelmini
Mainly fixing '....' and '..' Change-Id: Ic928701b319868671b826d757dd94c296fd5e942 Reviewed-on: https://gerrit.libreoffice.org/78668 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-24loplugin:returnconstval in desktop..formsNoel Grandin
Change-Id: I268e352e4e3054d1c1a8e61e52d91fd99794b359 Reviewed-on: https://gerrit.libreoffice.org/78057 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20Fix typosAndrea Gelmini
Change-Id: Iab3756a0e27af8a87e4012decdf706d19d0f3e82 Reviewed-on: https://gerrit.libreoffice.org/77757 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-17tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorJulien Nabet
in forms and fpicker Change-Id: Ifa931bed6de434a2ee183c78e8e1be852ca06a56 Reviewed-on: https://gerrit.libreoffice.org/77637 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-17tdf#125340 transport preferred dialog parent down the migration dialogCaolán McNamara
Change-Id: Icb7bab35eac3ae08fb82d73f559ef161dd1820c3 Reviewed-on: https://gerrit.libreoffice.org/77606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in forms..ooxNoel Grandin
Change-Id: Id742001211e916e7709918e7112902a0c35bac95 Reviewed-on: https://gerrit.libreoffice.org/77501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I151508c5d0b5d010f55d2324d36659ab5715a70c Reviewed-on: https://gerrit.libreoffice.org/77274 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
"its" Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6 Reviewed-on: https://gerrit.libreoffice.org/77255 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): formsStephan Bergmann
Change-Id: I105fc954a983280ec07759a7f9d21e726a970a80 Reviewed-on: https://gerrit.libreoffice.org/76676 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-19loplugin:referencecasting in forms..fpickerNoel Grandin
Change-Id: I0aa040b6d3264d2efde5797f79994d3d65ceaddf Reviewed-on: https://gerrit.libreoffice.org/75957 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-18cid#1448381 Unchecked return valueCaolán McNamara
Change-Id: I4f0b48df10bf8557e39e0769a61a36bacac8f02a Reviewed-on: https://gerrit.libreoffice.org/75884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23Fix typosAndrea Gelmini
Change-Id: If81c6224abbd0028bcc446159cf12436e89325d8 Reviewed-on: https://gerrit.libreoffice.org/73421 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-21tdf#39593 Remove frm::OGridControlModel::getColumnImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I3b662136778340a95216ac08035f7c25d5882349 Reviewed-on: https://gerrit.libreoffice.org/74472 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-20tdf#39593 Remove static xforms::Binding::getModelImplArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I001293ca25387a34cff9872c6db2ab72c6c4d617 Reviewed-on: https://gerrit.libreoffice.org/74385 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-20tdf#39593 Remove xforms::Model::getModelArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I52f780059be7626a03bf79044cfc580bb33f3fd3 Reviewed-on: https://gerrit.libreoffice.org/74383 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-20tdf#39593 Remove xforms::Binding::getBindingArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: Ic569783ae01f731f54b54775b8e0eba162cc4b78 Reviewed-on: https://gerrit.libreoffice.org/74381 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-20tdf#39593 Remove xforms::Submission::getSubmissionArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I8dcd0bf1cfbaa02fbb7c128421506f1c30d87773 Reviewed-on: https://gerrit.libreoffice.org/74387 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-16loplugin:logexceptionnicely in filter..frameworkNoel Grandin
Change-Id: I8cf70ee278c641767e3fcfcfd151d99d791b3468 Reviewed-on: https://gerrit.libreoffice.org/74098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07Fix typoAndrea Gelmini
Change-Id: Ie9174d46b3936ee19a7d1e70f85af6fed2c0c6d4 Reviewed-on: https://gerrit.libreoffice.org/73637 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: I577cecc9b5c73a999b0e38478adf71c527210619 Reviewed-on: https://gerrit.libreoffice.org/73635 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: I1ed7280266fc2612ca1286c129a614c51aba3571 Reviewed-on: https://gerrit.libreoffice.org/73636 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini
Change-Id: I3883dedde0ad3ca6c4d6190d711af9c1e6411a50 Reviewed-on: https://gerrit.libreoffice.org/73573 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini
Change-Id: I351a41c7b6964bdf60d9231640c18461fca81ff2 Reviewed-on: https://gerrit.libreoffice.org/73575 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini
Change-Id: Iedf4ec187812fd152d19f70405d2f4554211bf6b Reviewed-on: https://gerrit.libreoffice.org/73576 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-05Fix typoAndrea Gelmini
Change-Id: I2d361544b571144e7f0f2c4190ec3e578427ec7c Reviewed-on: https://gerrit.libreoffice.org/73475 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-05Fix typoAndrea Gelmini
Change-Id: Ib92c1a4b60e46019b4c6f89f88b9e99e5b2d497a Reviewed-on: https://gerrit.libreoffice.org/73473 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-05Fix typoAndrea Gelmini
Change-Id: Ie8b8aeb1ebcb78cca73c6c2bc0512b2f30d245ae Reviewed-on: https://gerrit.libreoffice.org/73474 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-04Fix typoAndrea Gelmini
Change-Id: I1a657bd08ff7a6108a20d57d5ebe9f104fcbe3fd Reviewed-on: https://gerrit.libreoffice.org/73420 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-04Fix typoAndrea Gelmini
Change-Id: Ib72667f1360e190b15eac187b46fc563b9f65524 Reviewed-on: https://gerrit.libreoffice.org/73419 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-03Fix typoAndrea Gelmini
Change-Id: I86e2040fb54bb13f26a458b7ad96353b7bf7065d Reviewed-on: https://gerrit.libreoffice.org/73353 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini
Change-Id: I588837ea6eeeb271a821edcd4e9bc14bb78bf933 Reviewed-on: https://gerrit.libreoffice.org/73351 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Use hasElements to check Sequence emptiness in [e-i]*Arkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: I79e31919db8f4132216f09a7868d18835eeb154b Reviewed-on: https://gerrit.libreoffice.org/71795 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-23Re-enable JunitTest_forms_unoapi_2 forms.ODateModelStephan Bergmann
f9905401d8cf2d73576231ebd84cfa5f4f73bcac "tdf#125170 Deliver mouse events also when clicking into document content" had disabled it because its gerrit_linux_clang_dbgutil Jenkins build had failed it successively like > LOG> Execute: Date > LOG> try to set: > LOG> old = com.sun.star.util.Date@271053e1{1, 1, 1800} > LOG> new = com.sun.star.util.Date@589838eb{2, 0, 0} > warn:tools.datetime:303:1063:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar. > LOG> Property Date is void > LOG> Value for 'Date' hasn't changed as expected > LOG> result = com.sun.star.util.Date@42dafa95{1, 1, 1800} > Method Date finished with state FAILED > LOG> Date: COMPLETED.FAILED (<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/32715/>). But it is unclear how that commit would have affected that test, and at least a recent local build of mine succeeds with > LOG> Execute: Date > LOG> try to set: > LOG> old = com.sun.star.util.Date@dc24521{0, 0, 0} > LOG> new = com.sun.star.util.Date@10bdf5e5{1, 0, 0} > warn:tools.datetime:10048:10220:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar. > LOG> Property Date is void > LOG> Property 'Date' OK > LOG> result = com.sun.star.util.Date@6e1ec318{1, 0, 0} > Method Date finished with state OK > LOG> Date: COMPLETED.OK (note the difference of initial date, {1, 1, 1800} vs. {0, 0, 0}, whether or not that is relevant), so lets re-enable the test for now and see... Change-Id: I53b462954650e32de85c795c94f9b8038dc01918 Reviewed-on: https://gerrit.libreoffice.org/72863 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22New loplugin:dataStephan Bergmann
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16tdf#125170 Deliver mouse events also when clicking into document contentSamuel Mehrbrodt
Event listeners are added once VCLXWindow::SetWindow is called. This never happened for the document content window. So we need to call Window::GetComponentInterface which will create an XWindowPeer and then call UnoWrapper::SetWindowInterface which calls VCLXWindow::SetWindow. After that, event listeners are registered so that we can deliver events. Change-Id: I2ed01f1ab20d87fedc4803bdbd96f5ef14d40043 Reviewed-on: https://gerrit.libreoffice.org/71948 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-10an uno -> a unoCaolán McNamara
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-03-15 04:14:30 +0000