summaryrefslogtreecommitdiff
path: root/formula/source
AgeCommit message (Collapse)Author
2015-09-09clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since 2cb4c646a81c92d7582c0db6eedeb09128ace1c5 "CWS-TOOLING: integrate CWS frmdlg" Change-Id: I5ba64a9e8005efc5e918669d0ef3119c18c32594
2015-09-08convert Link<> to typedNoel Grandin
Change-Id: I365a81a0a960f5da736c9a97aa056da16c99452f
2015-09-04loplugin:cstylecastStephan Bergmann
Change-Id: I2c0f37376455db1c131327c9a7a6b7b35765d556
2015-09-04convert Link<> to typedNoel Grandin
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4 Reviewed-on: https://gerrit.libreoffice.org/18306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-01TableRef: activate structured references export to OOXMLEike Rathke
Change-Id: I737b0c28a9b337af62e1a33bbce15049a0d854a4
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I324dd37d063ea01fd15152caf2f7565ac4b6fb4e
2015-08-28make PostUserEvent Link<> typedNoel Grandin
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-26Convert vcl Button Link<> click handler to typed Link<Button*,void>Noel Grandin
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-20the original author not only didn't like spaces but also not newlines..Eike Rathke
Change-Id: I26b1d6c3a3d4249a1f9c657d1e043e9eb5ec2dd2
2015-08-20let the edit selection not jump back to 0,0 for every keystrokeEike Rathke
... which instead of an input of 123 resulted in 321. This Edit::SetText() has a side-effect that it sets a new Selection(0,0) effectively invalidating the previous selection. We reach RefEdit::SetRefString() also through notification of edit events that already handled the key input in Edit::ImplInsertText() and adapted the selection, the dialog then attempts to update all sort of argument fields, including the one that was just edited. Setting the identical text again confuses the selection and positions the cursor at the beginning of the string instead of the end when typing. Additionally all kind of invalidations and recalculations happen that were just correct.. This somehow worked before (what change?), maybe just by accident, Edit::SetText() always set that new selection. However, calculating all the rat tail for an identical text is unnecessary and hopefully nothing relies on it. If something did, we'd need to remember and set the original selection here after setting the text, or adapt the believer.. Change-Id: Ibe086f3620db921dc852280e73789218d81f5c39
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: I4080aece6fec2778a2a8646ddedd280337303591
2015-08-03coverity#1309048 Unchecked return valueCaolán McNamara
Change-Id: If005f622bc76445f3a6becb26280abe40ee77e26
2015-07-30fix indentationMarkus Mohrhard
Change-Id: I9dddec04d1a929fa406973d3157e309a9511f29c
2015-07-27tdf#92548, limit number of characters shown in formula wizardBenjamin Ni
Change-Id: I5c322140d40e1ec31e8664a6f731e57b9b3defdb
2015-07-27tdf#92546 show results for sub-expressions in formula wizardBenjamin Ni
Change-Id: I1d5ba707d8dce69abc15ec1de7bec4728bd93adb
2015-07-21loplugin:unusedmethods formulaNoel Grandin
Change-Id: I62ff278679638dda7e10c86c49b1966641418e8b Reviewed-on: https://gerrit.libreoffice.org/17223 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10add a SAL_RAND_REPEATABLE for repeatable random numsCaolán McNamara
merge the formula and comphelper ones together Change-Id: I2e7e2cdb176afc6982e384fa1e007da5b914e6f0
2015-07-02coverity#1309048 Unchecked return valueCaolán McNamara
Change-Id: Ia01a78ff8ec2f4fba49d184e05b5785e59677e9e
2015-06-29Subformula evaluation in formula wizard treeBenjamin Ni
Change-Id: If4f6a608f261621e2e1ba40b36d71d39a137a453
2015-06-29Subformula check in formula wizardBenjamin Ni
Change-Id: I843b6886925f389ee1f351d73c6692ff3ceb3b9f
2015-06-23in OOXML save references of named expressions with col,row=0,0 base positionEike Rathke
Saving relative references of named expressions to OOXML never worked, upon reload they pointed to a different position offset by the value of the original base position. This at least saves positive relative references correctly, while generating #REF! for negative offsets which is slightly better than having them point to a wrong location and silently calculate different values.. Also, this is a prerequisite for TableRef ThisRow references in named expressions to be saved correctly in A1 notation, which results in a relative row 0 value. Change-Id: I3734f910794ceab4b9224b214ad11c64d1d18e67
2015-06-21TableRef: include ocTableRef in FormulaToken::IsRef() for HasReferences()Eike Rathke
let FormulaTokenArray::HasReferences() also check RPN Change-Id: Ic97332265c50485691f76b81d8396705d7728ab0
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-15prepare ReplaceToken() to replace also in RPNEike Rathke
Change-Id: I98fbcb9849f2c2b1f26109a54ecbf5347cdd8b4e
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-11Resolves: tdf#89643 report builder function wizard segfaultsCaolán McNamara
regression from commit 3d6521280929ecacc53b7c358d29d0b5d31b3462 CommitDate: Thu Jul 31 22:14:25 2014 +0200 fix memory leak around function descriptions Found by Lsan. There are two implementations of getCategory, one (sc) returns a new one each time (hence the leak fix) and the other (reportdesign) returns a pointer to one that belongs to the manger (hence the crash). The code in formula really looks to me to expect that the getCategory return a pointer that "someone else" needs to look after, i.e. the reportdesign variant is the more correct so revert 3d6521280929ecacc53b7c358d29d0b5d31b3462 and to fix the leak make the sc own the ScFunctionCategories and just cache them like the reportdesign one does Change-Id: Ifd986301a54b4d20449e864697655cd973e0c4df
2015-06-11tdf#69552 [part 2] support all ODFF1.2 and Excel2013 variationsWinfried Donkers
of CEILING and FLOOR Change-Id: I9537d9bd8dbca2eac769e74e9d3d5b298b76f594 Reviewed-on: https://gerrit.libreoffice.org/16016 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I035d84d2de99c4cf790aab6202559e2b35117b64
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: Iaefaeebcccade616329e4d8e29f3c4f53cb739c1
2015-06-01loplugin:loopvartoosmallNoel Grandin
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-05-25Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks
Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-18Remove include stdio (part2)Julien Nabet
Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd Reviewed-on: https://gerrit.libreoffice.org/15775 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-14tdf#91273: Crash when closing formula wizard (cancel or ok)Julien Nabet
warn:legacy.osl:3927:1:vcl/source/window/window.cxx:271: Window ( 7VclVBox ()) with live children destroyed: N7formula7ParaWinE () I took example from http://cgit.freedesktop.org/libreoffice/core/commit/?id=da49275807c8cf1dd7362a531f321f9f756e82d1 + test existence of m_pImpl for FormulaDlg::PreNotify Change-Id: I580aa7be79e1743fc528fd414a0ae581c0cb0c87 Reviewed-on: https://gerrit.libreoffice.org/15726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-12Switch VclBuilder constructors to use VclPtr.Michael Meeks
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
2015-05-11Revert "Switch VclBuilder constructors to use VclPtr."Michael Meeks
Behaves oddly; not ready yet. This reverts commit 9f016bd69422bdfb4cf7c4f5e57356eb98db2d8c. Change-Id: I30d746eac29d1dbe78d3072b10d2e22c051e3f4e
2015-05-11Switch VclBuilder constructors to use VclPtr.Michael Meeks
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
2015-05-09WaE: unused parameter.Michael Meeks
Change-Id: I64024440a0674b7daed27ba8d104d347f8090bd7
2015-05-09tdf#91052 - more macros for 'make' constructors.Michael Meeks
Change-Id: Id05266810760f73db2daba10d1efa14aa9f88dd9
2015-05-07loplugin:vclwidgets ("OutputDevice subclass should have ..."Stephan Bergmann
Change-Id: Id2f6bbfa549fd71258b1d875fef44f1833781a3a
2015-05-07tdf#90935 - function wizard crash fix.Michael Meeks
Change-Id: I1344e194f8fd5d2c0ffff4e8b075564df32706a8
2015-05-05fdo#77985 make calc function NETWORKDAYS comply with ODFF1.2Winfried Donkers
Change-Id: I523b0c71bc0fed501a4d5fffd75c5a4704f6dd13 Reviewed-on: https://gerrit.libreoffice.org/9827 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-05-05Use typed Idle::SetIdleHdl LinkStephan Bergmann
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05loplugin:staticmethodsNoel Grandin
Change-Id: I384a5e60f4b7b2f479c89ef97630519059ab720f
2015-04-30coverity#1296214 Dereference null return valueCaolán McNamara
Change-Id: Ifc82f42ff8d82cfe094701ace57ff7cadabc59d9
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29fdo#69552 [part 1] make calc functions CEILING comply with ODF1.2Winfried Donkers
Also, add support for CEILING.MATH and fix small deficiencies with CEILING functions, as most are interwoven. Change-Id: I0d9a46fb17e982ccf1e9d9e403b58926172c1a7a Reviewed-on: https://gerrit.libreoffice.org/7088 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-04-29string access out of boundsEike Rathke
This convoluted logic may pass FUNC_NOTFOUND -1 as position around if there was no initial function. Change-Id: I217fc745d8e0b8e532642d0f69110371d183610d
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-27More loplugin:simplifyboolStephan Bergmann
Change-Id: I40650e3f9f0aea60b5b536e2bf40735583e4358b
2015-04-24TableRef: centralized FormulaCompiler::NeedsTableRefTransformation()Eike Rathke
... and include OOXML until we actually write Table. Change-Id: I95fa65bd593c72af409728cea1ec599481beaaab