summaryrefslogtreecommitdiff
path: root/formula
AgeCommit message (Collapse)Author
2024-07-19tdf#161296 Convert functions list in FD & FW into collapsible sectionsAhmedHamed
Change-Id: I9211c0cf02be8d21e343d57f53d14e50d7b5fd0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169639 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-07-12tdf#161534 Add a Help button in FD & FW to open respective Help documentationAhmedHamed
Change-Id: I35f5965401e970e02fa196f767bbd08d00de424f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170181 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-06-11tdf#161502: change Structure label of Function Wizard dialogBayram Çiçek
- label "Structure:" changed to "Content:" - this change also removes the duplicated "Structure" text from the dialog which makes the UX better Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I6d70e019b80d4ef0d7207b62e1d0aa6d1f0a3b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168161 Tested-by: Pedro Silva <pedro.silva@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pedro Silva <pedro.silva@collabora.com> (cherry picked from commit dc3e624b52e43bb197417b5d9339890afe7c5379) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168612 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2024-06-09Related: tdf#137543 - fix LET function jump count numberBalazs Varga
Clean-up and fix wrong jump count. Change-Id: Ie64ff95f63c17d2726b3a522af981bcaea2a9a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168590 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-06tdf#137543 - Add new LET function to CalcBalazs Varga
Add new LET function to Calc which assigns names to calculation results. TODO: oasis proposal Change-Id: Ia0d56a30751a44a72e364a28b64fd8f617e997dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168349 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-05-26Resolves: tdf#160371 Relax significant whitespace intersection pre-checkEike Rathke
Change-Id: I3bef7c70571ee6ce8c98d60e6f6f017f3760530f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168070 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2024-05-21Fix typo in codeAndrea Gelmini
Change-Id: Ic416b58498274cbd49cbb0a5fea934bfbe356722 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167901 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-05-21lok: translate formula bar functions to each localeJaume Pujantell
On calc the native formula symbols were loaded once on start-up and assumed to not change. This adds a map language to symbols when LOK is active and chooses the correct set of symbols on each call. Change-Id: I821fb3ad4a06d764399e3fdf4a2ec628909312db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167870 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> (cherry picked from commit 421ef056cf5e991ae3072cd1acb5ef23aa7c780a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167825 Tested-by: Jenkins
2024-05-15tdf#126573 Add Excel2021 array function UNIQUE to CalcBalazs Varga
Add new function called UNIQUE to the function list. (TODO: dynamic array in separate patch, oasis proposal) Change-Id: Ie138aee545995d4af1e66be5a4cf4e99e6e2f581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167484 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-05-08tdf#126573 Add Excel2021 array function RANDARRAY to CalcBalazs Varga
Add new function called RANDARRAY to the function list. (TODO: dynamic array in separate patch, oasis proposal) Change-Id: I34bad3b7e8d631d649a0350d7c1170b26161331d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167003 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-05-08loplugin:ostr in formulaNoel Grandin
Change-Id: Iac66906636e64c0547122ac413bee494631c7c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167304 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-04-26tdf#126573 Add Excel2021 array function SEQUENCE to CalcBalazs Varga
Add new function called SEQUENCE to the function list. (TODO: dynamic array in separate patch, oasis proposal) Change-Id: I9fa6f2c83536536987542cc00a9eec5c196ada8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166245 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-04-13Related: tdf#160056 rename/rework GetDoubleAsReference to SetDoubleCaolán McNamara
Change-Id: I7e79e8d422fe7f426bb7c7360b11f836a5484574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166053 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-13Related: tdf#160056 elide ref counting for initial tokensCaolán McNamara
The initial tokens provided to interpreting will be restored to their original ref count when interpreting is complete. So we could elide expensive ref counting for them for the duration of the the threaded group calculation. Possibly "temp" tokens that are created just during interpreting could additionally use thread-unsafe ref counts presuming they only appear in a thread specific context. Change-Id: I1f5b0198e83027781be15812680079f28b6a4e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165259 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-26tdf#126573 Add Excel2021 array function SORTBY to CalcBalazs Varga
TODO/WIP: oasis proposal More information about how this new function works: https://support.microsoft.com/en-au/office/sortby-function-cd2d7a62-1b93-435c-b561-d6a35134f28f https://exceljet.net/functions/sortby-function Change-Id: I4538a32f7f75056d3055369fc5f4483d24fd1089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165069 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-03-25tdf#126573 Add Excel2021 array function SORT to CalcBalazs Varga
TODO/WIP: oasis proposal More information about how this new function works: https://support.microsoft.com/en-au/office/sort-function-22f63bd0-ccc8-492f-953d-c20e8e44b86c https://exceljet.net/functions/sort-function Note: Move ScSortInfoArray class to sortparam.hxx, which is a more logical place. Change-Id: I70e720e93ba0414d54cb3437de0bfa066508fe30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164778 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-03-15Related: tdf#126573 Add Excel2021 array function FILTER to CalcBalazs Varga
Add ocFilter to matrix (array) functions. Some follow-up cosmetic clean. Follow up commit of b0791dd9216224bdb266fd0d8c87df253b6d0583 Change-Id: I4c3c786fe14ab870be8c43211ca6a76c5ff6ac6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164847 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-03-01tdf#126573 Add Excel2021 array function FILTER to CalcBalazs Varga
https://issues.oasis-open.org/browse/OFFICE-4156 TODO: add dynamic arrays would be useful: Older array formulas, known as legacy array formulas, always return a fixed-size result - they always spill into the same number of cells. The spilling behavior described in this topic does not apply to legacy array formulas. More info about it: https://support.microsoft.com/en-gb/office/dynamic-array-formulas-and-spilled-array-behavior-205c6b06-03ba-4151-89a1-87a7eb36e531 Related Bug: https://bugs.documentfoundation.org/show_bug.cgi?id=127808 Change-Id: I1c3769ef33fa0207f55e1c96083717c2d90402e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163955 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-02-18tdf#128425 Add Excel2021 function XMATCH to CalcBalazs Varga
https://issues.oasis-open.org/browse/OFFICE-4155 Change-Id: I7791ab873cf62ce882feba75dc0d722bc5990f9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163260 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-01-31tdf#127293 Add Excel2021 function XLOOKUP to CalcWinfried Donkers
https://issues.oasis-open.org/browse/OFFICE-4154 What is working already: xlookup with normal forward, backward search in columns/rows. Binary search in rows with real binary search algorithm, in columns only works with linear search yet. Linear forward backward wildcard/regex search in columns/rows. Looking for the first smaller or greater value with linear and binary search ALso all the combination of all these options. Except XLOOKUP not supperted wildcard/regex search with binary search. TODO in next patches: - add the binary search option for searching in columns. - Evaluate Formula calculation not working in general. Co-authored-by: Balazs Varga <balazs.varga.extern@allotropia.de> Change-Id: I15fd4479b63ec13b093d269760d1bbb5957553e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131905 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-27Use emplace_back instead of push_back (Formula)Julien Nabet
Change-Id: I6596e9d002016e5b501900fe9da26b5910cf7653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-23Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]StringStephan Bergmann
...in include files. This is a mix of automatic rewriting in include files and manual fixups (mostly addressing loplugin:redundantfcast) in source files that include those. Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-12Make NC_ constexpr-friendlyStephan Bergmann
...by moving the char8_t -> char reinterpret_cast out of any potential constexpr paths into a new TranslateId::getId. And demonstrate constexpr'ability by making the aCategories var in OApplicationIconControl::Fill (dbaccess/source/ui/app/AppIconControl.cxx) constexpr. (And there might be more such cases that could now be made constexpr.) Change-Id: I0b4e3292faf8f6b901f9b9e934e1aa6bf0f583ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-09-04tdf#147021 use std::size instead of SAL_N_ELEMENTSAdam Seskunas
Change-Id: Ibc6c83f950890ac9b7a754cc49973736fa81dcb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156364 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-09tdf#104487 - Function wizard: remember last used function categoryAndreas Heinisch
Change-Id: I978dd63553e3528e7b9b853dbb438304f1f680cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151565 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-05-03Formula W.: tdf#78826 colons tdf#150045 sec. labelsAdolfo Jayme Barrientos
Change-Id: Ied39588884eed9d1602bac7e1bca9cf2dc7ac0c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151319 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-05-03Resolves tdf#101876 - Resizing function wizard contentHeiko Tietze
GtkPane added Function entries expand now Change-Id: I3f900540fadb530a8c154ec1bdf3771daecb7acb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151258 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-18formula: fix crash in FormulaDlg_Impl::UpdateSelectionXisco Fauli
m_pFuncDesc can be nullptr See https://crashreport.libreoffice.org/stats/signature/formula::FormulaDlg_Impl::UpdateSelection() Change-Id: If8a95bef8b0a8a03ffe63041409ee7c1cf322b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-23jsdialog: enable function wizardSzymon Kłos
Change-Id: I534556e87cda3239bff51f1e7d83355922f8af7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148245 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149327 Tested-by: Jenkins
2023-03-07no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: I86611e14a32dda3ae2226bbfa775ad0234513888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-27can use a reference instead of a pointerCaolán McNamara
Change-Id: I770983c2a46c2181db80243efa7c926e356d5e6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-26no need to hold SvtSysLocale by std::unique_ptrNoel Grandin
allocate it inline, it is only one pointer in size Change-Id: I736f3322784897054993fbddd423f36357f817c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147741 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-17Obtain actual 0-parameter count for OR(), AND() and 1-parameter functionsEike Rathke
OR and AND for legacy infix notation are classified as binary operators but in fact are functions with parameter count. In case no argument is supplied, GetByte() returns 0 and for that case the implicit binary operator 2 parameters were wrongly assumed. Similar for functions expecting 1 parameter, without argument 1 was assumed. For "real" unary and binary operators the compiler already checks parameters. Omit OR and AND and 1-parameter functions from this implicit assumption and return the actual 0 count. Change-Id: Ie05398c112a98021ac2875cf7b6de994aee9d882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147173 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-02-14osl::Mutex->std::mutex in OpCodeMapDataNoel Grandin
Change-Id: I0b92e2a94060549c39df7d08a6409518252fc757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-01Resolves: tdf#151886 Use default locale with English function names againEike Rathke
Automatically switching to en-US locale when using English function names caused too much confusion. There also might be the possibility that the '.' dot decimal separator clashes with the inline array column separator in some locales. A proper solution would make this user-specified and if set also adjust the separators to the common English ones. For now keep the default locale again as it previously was the case. Change-Id: Ic4712c6609c14f35cf0d1d842ac7443806a6e115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144924 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-12-20tdf#146781 sc: update extended tip for function description searchStéphane Guillou
Change-Id: Ifa8f5c2be8e848e6fe2f9cf863d4a5a66787d2d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144153 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-15crashtesting: assert seen on loading forum-mso-en4-573860.xlsxEike Rathke
While resolving named expression Pinnacle3 IF(AND(Pinnacle1+Pinnacle2<>11,Pinnacle1+Pinnacle2<>22,Pinnacle1+Pinnacle2>9),SUM(MID(Pinnacle1+Pinnacle2,1,1),MID(Pinnacle1+Pinnacle2,2,1)),Pinnacle1+Pinnacle2) where resolving and inserting named expressions Pinnacle1 IF(AND(SUM($Sheet1.$D$3:$E$3)<>11;SUM($Sheet1.$D$3:$E$3)<>22;SUM($Sheet1.$D$3:$E$3)>9);SUM(MID(SUM($Sheet1.$D$3:$E$3);1;1);MID(SUM($Sheet1.$D$3:$E$3);2;1));SUM($Sheet1.$D$3:$E$3)) and Pinnacle2 IF(AND(Logic1<>11;Logic1<>22;Logic1>9);SUM(MID(Logic1;1;1);MID(Logic1;2;1));Logic1) with Logic1 IF($Sheet1.$E$3+NilaiTahun>10;SUM(MID($Sheet1.$E$3+NilaiTahun;1;1);MID($Sheet1.$E$3+NilaiTahun;2;1));$Sheet1.$E$3+NilaiTahun) with NilaiTahun IF(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1))<10;SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));SUM(MID(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));1;1);SUM(MID(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));2;1)))) overall exceeds FORMULA_MAXTOKENS (8192) in the generated RPN code, hence an ocStop is encountered as factor token. (this cries for generating subroutine call token arrays where each named expression could have their own RPN code and interim results could be remembered for each while interpreting within one formula cell; just dreaming..). Change-Id: I744c4915a00849b107c7c25d7029aa19d976aa86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144048 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-12-14upgrade tag names with new version of gladeStéphane Guillou
Change-Id: Idcbf12c72eea8f7c8b4c7e787eeb2719f29cc69a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144152 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-28use more string_view in formulaNoel Grandin
Change-Id: I3d9feafb0e2010f284a1700becbe9b701edc9849 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19small opt in FormulaTokenIteratorNoel Grandin
cheaper to init the stack with the first element, rather than calling Push Change-Id: Ia34f88b6534a663fae2ed08d0499d04d2f458847 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-06A ColRowName (label) is a QuotedLabel is a SingleQuotedEike Rathke
Hence a ' is not escaped by \' but by '' doubling it. See also ODFF 5.10 Quoted Label https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part4-formula/OpenDocument-v1.3-os-part4-formula.html#__RefHeading__1017950_715980110 Apparently this was always wrong and even stored in files and never correctly read/compiled back. Change-Id: I94bdb7d1fdffe9bbd77cf443883dd76637be981b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139491 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-01Resolves: tdf#142293 Implement the temporariness of GetOpCodeMap()Eike Rathke
Change-Id: I7c587a68dbdeab9a8c8ed324ecae2eb5dd75b9df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139201 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-01Related: tdf#142293 Introduce a protected FormulaCompiler::GetFinalOpCodeMap()Eike Rathke
... to prepare having GetOpCodeMap() return a temporary if a final doesn't exist yet. Currently just an alias. Change-Id: I6fc100ae6223010e149e4af01fc7c17630930de7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139162 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-08-24tools: rename Rectangle::Justify() to Rectangle::Normalize()Chris Sherlock
Jusify() normalizes the rectangle so both the Width and Height are positive, without changing the location of the rectangle. It ensures that the x and y coordinates will be moved to the top left of the rectangle. The name is strange, so renaming Justify() to Normalize(). Change-Id: Idbf163e65e52a798e38f785b8961b8042cf0cf2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137379 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22cid#1509296 silence Use after freeCaolán McNamara
Change-Id: I6c1d8c0365cb59f3c63537c08e27a34bac111aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-06Related: tdf#135993 Use ScCompiler to create English OpCodeMap with AddInsEike Rathke
... instead of formula::FormulaCompiler base class that doesn't know anything about AddIns, and copy AddIns along to new resulting native map. Change-Id: I9e4ece2f7450a561ac502ca1dbddaa5a697fa2fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137882 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-08-06Related: tdf#135993 Destroy temporary OpCodeMap when reading configEike Rathke
Initialized at FormulaCompiler base class instance it lacks AddIn mapping and a still existing OpCodeMap prevents necessary reinitialization from derived ScCompiler instance later. Change-Id: I0c2db41dd45829abfb8460730264f097ab76ab2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137881 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-08-04Add known but not in AddInMap English names for GRAM_API, tdf#150253 follow-upEike Rathke
Change-Id: I1edc2a979946078e4548c0933f9b64b7a08a7e6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137773 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-26 20:47:53 +0000