summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)Author
2015-07-16Hopefully get the right dispose orderMaxim Monastirsky
warn:legacy.osl:9070:1:vcl/source/window/window.cxx:281: Window ( 17FileViewContainer()) with live children destroyed: 11SvtFileView() 8Splitter() 10FolderTree() Change-Id: I6be256337123fc1c3ff2651bcd9f695c8918bb8e
2015-07-16Move remotefilesdialog.ui to where it belongsMaxim Monastirsky
Change-Id: I9afa6c8f7c9de8ed133f714a4726d3f2d01be1db
2015-07-16loplugin:stringconstantStephan Bergmann
Change-Id: I59da081fc90ffb96c438ed755266f5a69fbd199d
2015-07-16loplugin:vclwidgetsStephan Bergmann
Change-Id: I8671f8540da2e86eedb4cdc7a248ebb1d6caa376
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: Id079a6cc2841f42b0dc10ed2be596cc8f7db4e25
2015-07-16loplugin:passstuffbyrefStephan Bergmann
Change-Id: I37c254bd1fdb3cfb05d513f87fa4f4a468466bb0
2015-07-16-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: I5f7ab4c7eb106fc7bc0d93abc78ab9168c6867a6
2015-07-16question about overwriting the file only in the save modeSzymon Kłos
Change-Id: Iabb3bc12a8efae65a1c3d221a31c2214de8f6c90
2015-07-16FilePickerLastService as a string, not string-list 2Szymon Kłos
Change-Id: If100617ef968fde94178528327135e15f64c1542
2015-07-16RemoteFilesDialog: remember last used serviceSzymon Kłos
Change-Id: I494b1d43d28d8e6c37ce9d391b37580be6a9be31
2015-07-16removed commentSzymon Kłos
Change-Id: Ia74226be5f7d0776d60f04945c23a5b94cdc11b6
2015-07-16RemoteFilesDialog moved to fpickerSzymon Kłos
Change-Id: I8e978d40ee022d15f482aec4567c3171b75b9720
2015-07-16SvtFileDialog_Base in new fileSzymon Kłos
Change-Id: I42189e9ca1c645104f8f5da381cbbb2098c8a0c2
2015-07-16FilePicker interface for RemoteFilesDialogSzymon Kłos
Change-Id: I797d3fcf62bb858713d1e8af10e82f9c095bcf2b
2015-07-15loplugin:unusedmethods accessibility,fpicker,uuiNoel Grandin
Change-Id: I106a0be06c4b9fe1313bbd8d4c62472c4b0a4b4f Reviewed-on: https://gerrit.libreoffice.org/17045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13getFiles: truncate to 1 file onlyJulien Nabet
See http://nabble.documentfoundation.org/Multiselection-needs-work-td4153207.html for details Change-Id: I7f855a067349381e2567bd15a8daa56aad412774 Reviewed-on: https://gerrit.libreoffice.org/16959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-08Fix typosAndrea Gelmini
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-03Fix typosAndrea Gelmini
Change-Id: Id884946cae0687d0b71c967e236e58df17567884 Reviewed-on: https://gerrit.libreoffice.org/16707 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-02tdf#92460: fpicker: fix VistaFilePicker using SolarMutexReleaserMichael Stahl
... on a thread that doesn't ever lock SolarMutex. Assume that Request::wait(), eventually called by UNO methods via AsyncRequests::triggerRequestThreadAware(), is called by the UI thread with the SolarMutex held. Change-Id: Ie3e6f32ed68e48f8c67d80cd9d2ce2f79e4578d8
2015-06-24Simplify uses of comphelper::string::equals with constant argumentStephan Bergmann
Change-Id: I7b12dd04f6811f71b776ee9168703434217b59c8
2015-06-23Drop duplicate #includesTakeshi Abe
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-02loplugin:loopvartoosmallStephan Bergmann
Change-Id: Icdaba21efeb8a910617642b7cb4e082f03f7a0ef
2015-05-21fpicker: simplify code by std::any_ofTakeshi Abe
Change-Id: I0f5a8b5d7f8f88a821793004c1574fcb6a7a4882 Reviewed-on: https://gerrit.libreoffice.org/15836 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-05-10-Werror=shadowStephan Bergmann
Change-Id: I27493171620e93c8ca35345c3320fb8f6da5d2ab
2015-05-10Use IMPL_LINK_NOARG[_TYPED] where applicableStephan Bergmann
Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
2015-05-10No more need for EMPTYARG in C++11Stephan Bergmann
Change-Id: I8a6abc563fa80a801d1907100d0b1138d260c36e
2015-05-10Use IMPL_[STATIC_]LINK_NOARG where applicableStephan Bergmann
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
2015-05-10Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann
Change-Id: If19b613973527e1a70186dfe97e4f6d28b4a17f9
2015-05-09loplugin:staticmethodsStephan Bergmann
Change-Id: I37053f37f074c49b8bc6fcaa82f66a2e52064cb1
2015-05-07convert PUSHBUTTON_DROPDOWN constants to scoped enumNoel Grandin
Change-Id: Iae363b8478ef2d560ae661af06ba989f27adc093 Reviewed-on: https://gerrit.libreoffice.org/15650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-05loplugin:staticmethodsNoel Grandin
Change-Id: I384a5e60f4b7b2f479c89ef97630519059ab720f
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-28loplugin:simplifyboolStephan Bergmann
Change-Id: Ia83a01c8c134729b5ccf978e7cd46e8e694958a0
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28DBG_PRINT_ENTRY expects a 4th arg of type intStephan Bergmann
Change-Id: Id89f3436d9f9e142d8845381b483bdf8697dd1da
2015-04-28Dialog::EndDialog nResult param is of type long/VclResponseTypeStephan Bergmann
Change-Id: I31f1941daf158676518fcf259ef8a9e84863473e
2015-04-27More loplugin:simplifyboolStephan Bergmann
Change-Id: Id3b0791cf5443eaccb6beea0e913be5b9080d812
2015-04-22convert HIB_ constants to scoped enumNoel Grandin
Change-Id: I6fa3ecde4a1c5f9c7e6e1dcd22250cba065933e3
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-16drawinglayer, editeng, forms, fpicker: convert new to ::Create.Michael Meeks
Change-Id: I5144ac74a09a3ac5679abca89e7d87386f2484fd
2015-04-13loplugin:redundantcast: redundant const_cast followed by implicit upcastStephan Bergmann
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
2015-04-10Automated conversion of VclPtr construction to use Instance template.Michael Meeks
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10re-insert erroneously converted delete calls.Michael Meeks
Change-Id: Iebdf2af3866d884289f6913646106fe3f2d4dde5
2015-04-10vclwidget: fixup locally allocated vcl::Window objectsNoel Grandin
They need to be wrapped in ScopedVclPtr in order to be disposed properly. Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e