summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)Author
2021-11-25tdf#145842 canceling remote file delete makes file disappear from treeviewCaolán McNamara
we remove the selected entries from the treeview, so the user cancel's the deletion of an entry we should unselect it from the candidates to remove. and... Related: tdf#145842 fix a crash after deleting an entry delete an entry in remote files dialog and go one level up and crash, ownership of the SvtContentEntry is not with the entry, but belongs to mpImpl->maEntries Change-Id: Ieb2258960fc647ad15d8f315a18454a0dae8a420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125793 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-10-19Related: tdf#145169 make double-click call same handler as ok buttonCaolán McNamara
so that the user is asked to confirm an overwrite of a file Change-Id: I1340fb33559b68c28fc91e272f05e122f8c519ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123780 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-10-19tdf#145216 remote open/save dialog: icon view shows nothingCaolán McNamara
since... commit b004a1bd7bf3885613d52aba70dea79766eae639 Date: Sat Nov 23 19:14:45 2019 +0000 Resolves: tdf#128940 use a normal MenuButton Change-Id: I7ba6424a2a4892e2d6bc5552105a3b1e37d21a41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123777 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-10-19Resolves: tdf#145169 only position treeview cursor at the first entryCaolán McNamara
when the view is filled, don't actually select the entry. With these single selection trees the default is to select when the cursor is positioned, so move the unselect to after the cursor positioning to achieve this. Now nothing is considered "selected" in the view unless the user explicitly does that so the contents of the entry are used by default on save/load because nothing is selected in the treeview unless the user does that. Change-Id: I2a740616205bab35614f85f62e8240cd11df90ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123772 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-19Related: tdf#145169 change to selected dir on remote "save"Caolán McNamara
if a dir is selected then try to change to that dir when save is clicked instead of saving using that as basename, which is consistent with standard fpicker. don't change the contents of the Entry, leave it alone. Change-Id: Id19fbf0f3ef2b8220059a1fa166b7783feb8d57d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123773 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-19Related: tdf#145169 unwanted dialogs on sftp save to remote to a new documentCaolán McNamara
which is similar to: commit f12e483589888f87843026ceff5ae3c1e615ca02 Date: Mon Feb 1 16:04:49 2016 +0100 Fix tdf#97500 Reinstate missing file error dialog on WebDAV this all looks a bit dubious, but make a safely backportable change first Change-Id: Ia6dbaacf7024d05083c336135a80b5acf607dfc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123642 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-19tdf#145169 have one button per responseCaolán McNamara
not two sharing the same response, so the other buttons response handler is not a candidate to be called on pressing return which is the circumstance which causes the dialog to return even after cancel was selected in its child dialog warning about overwrite Change-Id: I09eb0ea5e94c89ce0860be362e1c7632887e7a4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123771 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-11Simplify Sequence/vector initializationsJulien Nabet
Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-10-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
...ever since the code block's introduction in 14bc62ad0d9e0179f4178d2913ebba7abf99755e "INTEGRATION: CWS aquafilepicker02_DEV300" Change-Id: Id4cda7ed087b350361b0207034fc31819d65efad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116992 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-08Simplify Sequences initializations (desktop/e*/filter/forms/formula/fpicker)Julien Nabet
includes removing of unused TOKEN_SEP Change-Id: Ic72d9d94bd8d07232699ee4d948f3b203d524491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116833 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-02no need to allocate these on the heapNoel Grandin
Change-Id: Ie11353c8711e970cc20059227d8283c79e4b126d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara
Change-Id: I7196581a8b7c307d531f6995e1c24db746afdb26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-27loplugin:moveoptNoel Grandin
An attempt that did not find anything convincing enough to finish it up and make it permanently active. So just leave it in /store for now. Change-Id: I1750e177655a4a510da100f880ba81bf762be277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27use string_view in INetURLObject::decodeNoel Grandin
Change-Id: I10e04970ceac33c9c3fbfd0182dd2140e06cb80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27loplugin:staticmethods (clang-cl)Stephan Bergmann
Change-Id: Ib096abfeea6cefb5df562cf75448ef38e432344c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114695 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27-Werror,-Wnon-virtual-dtor (clang-cl)Stephan Bergmann
(1c1226709c6be39c5462f5e6e1262ca630b30b34 "tdf#106282 Change Windows File Dialog to run on the main thread" had changed it to non-virtual, but for no apparent reason) Change-Id: I12dc3a46c5d9aad5e43471b97c9ab45ff9f309ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114693 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: Idd1b0282efd1aac524067504a956f0fccdbce6d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114694 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-22tdf#106282 Change Windows File Dialog to run on the main threadMatt K
Windows crashes when an IFileDialog object is used on a non-main thread when cancelling a long search operation, when COM is initialized as single-threaded apartment for that thread. Trying to use a non-main thread with COM initialized to multi-threaded apartment hangs the dialog UI. The only solution that works is to run all File Dialogs on the main thread. This has a performance penalty on the application while a File Dialog is open or if multiple dialogs are searching and then cancelled, but it's better than crashing. Other applications like Firefox use only the main thread for File Dialogs, but have additional processes to avoid the performance penalty. Change-Id: Icf8a8179dbea19bd3d749a1c2fe8e67dbfc726c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114482 Reviewed-by: Matt K <mattkse@gmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-04-09loplugin:redundantstatic (clang-cl)Stephan Bergmann
Change-Id: If21e0991c483836c2eb9a03396f077111dbec1fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113872 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-25const OUString -> const OUStringLiteralMike Kaganski
Mostly automated rewrite Change-Id: Ie020a083f898bc126b8fb039d4ecb2e687172da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112965 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-23tdf#124176 Use pragma once in f*Vincent LE GARREC
filter, forms, fpicker, framework Change-Id: I55a25ad2dc3749e63465e638e8eeea3c322eabbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112047 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-03-14check for quit when calling Yield in loopNoel Grandin
so we don't get stuck threads when the main application quits Change-Id: Id36e99267ceb4154873b6ef8ef494622fff6c19a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112409 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-03-09-Werror,-Wshadow (clang-cl)Stephan Bergmann
Change-Id: I8b39e510266404a28acb380f449862366c647b87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112173 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-09-Werror,-Wnon-virtual-dtor (clang-cl)Stephan Bergmann
Change-Id: I1f02e154e090ad89ca2e664467d7514f1cbdcb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112174 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-08loplugin:makeshared (clang-cl)Stephan Bergmann
Change-Id: I902c4438adb89970db749ca06a13bfc484925851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112177 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-08loplugin:external (clang-cl)Stephan Bergmann
Change-Id: I543e7970e824c9d2ca504bbf3e4dd75a1ee2b4ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112175 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-28Convert some const OUString to OUStringLiteralMike Kaganski
Change-Id: I7cb56da6b58325781446d6c001c49638d1ec1769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111698 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-27Drop ComPtr and use sal::systools::COMReferenceMike Kaganski
Change-Id: I9eb6d99d883b44943ad69c2c28d4e55716dc34f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111673 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-26Simplify VistaFilePickerImplMike Kaganski
Change-Id: I13ac92f8f28a1d912681239fee1780093f8be444 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111561 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-24Possible race between retrieving and using parent windowSamuel Mehrbrodt
Filepicker was called from extension, parent window was initialized in constructor with current top level window (extension dialog). Extension dialog got closed before file picker was shown in some cases, causing Show() method to fail Change-Id: Ie41585e6b05511ba2dff265374348b6041e9fa87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111378 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-02-23Add mutex guard when assigning memberSamuel Mehrbrodt
Change-Id: I173824eaccea35d9f5e47b4248939050fceb939c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111393 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-02-23loplugin:refcounting in fpickerNoel
Change-Id: Ia14d2a874d559c4438a33c8a46ec6076802cd637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111285 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16loplugin:referencecasting in editeng..frameworkNoel
Change-Id: Ia3375011ecd0a65afed0f131f477fc1542603fde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-30tdf#140013 change icon for list view in Template Manager & Remote Files dialogRizal Muttaqin
Change-Id: I37b04d39efa7b328cff0df54a5b187876db8ba5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110171 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-21remove deprecated [x|y]align property for CheckBoxes and RadioButtonsCaolán McNamara
the gtk default is left aligned, change the vcl one to match and drop the deprecated and unnecessary [x|y]align Unfortunately on load glade's inline preview shows centered alignment, though its "true" preview tool shows left alignment and unsetting and resetting draw-indicator will update the preview to show the alignment which will be used: https://gitlab.gnome.org/GNOME/glade/-/issues/502 See https://gitlab.gnome.org/GNOME/glade/-/merge_requests/110 for my stab at making glade do the right thing. Change-Id: If454e9ce8462e6b271d2423fe7e8a55788e01fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15replace stock button imagesCaolán McNamara
Change-Id: I9be83856c0dd15552a042f009464c279bf239848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15replace stock button labelsCaolán McNamara
Change-Id: I726ba7846322863d9f38314b6c6ccc7f71124a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-13loplugin:stringliteralvar (clang-cl)Stephan Bergmann
Change-Id: I79949789634242eb95cc722bab83e0348775f274 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109174 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-08replace deprecated gtk-go-up, gtk-go-down, gtk-save and gtk-open labelsCaolán McNamara
Change-Id: Iaced32a6810b1a510dc300458a8860b7994226f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07replace deprecated stock labels used <= twiceCaolán McNamara
replace single use of deprecated gtk-paste replace single use of deprecated gtk-play replace single use of deprecated gtk-stop replace only two uses of deprecated gtk-clear replace only two uses of deprecated gtk-find replace only two uses of deprecated gtk-media-next replace only two uses of deprecated gtk-media-previous Change-Id: Ia749c03ad5887f7919b1d0dc2facf8ae7e5fb7a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for fpicker Change-Id: I47ac66f7b823aa6cf8faa184f561cffb259eb2f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-05Fix crash or hang on macOS on arm64 when opening a file pickerTor Lillqvist
There is no reason to not mention the NSOpenSavePanelDelegate protocol that AquaFilePickerDelegate implements. The way we used objc_msgSend() caused a crash or hang. (I saw both, depending on whether the code was built for debugging or not). For some reason we used to cast it to a function with variadic parameters like: reinterpret_cast<id (*)(id, SEL, ...)>(objc_msgSend)( m_pDialog, @selector(setDelegate:), m_pDelegate); This does not work in arm64 code on macOS. (See https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code?language=objc , the "Don't Redeclare a Function to Have Variable Parameters" section.) We could have replaced the ellipsis with the actual type of the first real parameter in this call, or just "id" would have worked fine. But it is much simpler to just do what we mean directly: [m_pDialog setDelegate:m_pDelegate]; I need to look through the code for other places where we have used objc_msgSend() in a similar fashion. Change-Id: Ia93b2007ed8f263eaf99d604a3c88e857efbb421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107257 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2024-04-30 12:29:28 +0000