summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)Author
2016-04-18Avoid reserved identifierStephan Bergmann
Change-Id: I8b85f65e5d3e66aa93e161ce1895547d7d863ca1
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-13tdf#98395 : Remote File dialog showing wrong details in columnsSzymon Kłos
Before patch: - File type in the Size column (only first launch) After patch: - File type is not visible Change-Id: Ia2e3775f49dd9bfcc77a985812e040f70201f45c Reviewed-on: https://gerrit.libreoffice.org/22921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I65681e938c809467f9497568149d25f5f68ed5bf
2016-04-12WNT: check result of PostMessage()Michael Stahl
... so the next time something overflows the main thread's message queue it's easier to debug. Change-Id: I90a35e46f3b2cab190c7da5e53024ec549159ac6
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I8bcd7e8a492ee4dbfa5141416c7c038a1391cf20 Reviewed-on: https://gerrit.libreoffice.org/23673 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-23-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I77a73caf56878060ba3688c87e9b6d5dd3ae28b1
2016-03-23loplugin:constantparam in fpickerNoel Grandin
Change-Id: I7225c996030eed494e3ca8a9dabc501fc505e101
2016-03-23remove unused AUTOSELECT_USERFILTER codeNoel Grandin
added in commit 90fcf5718668f0f9f41ac141a7fc4306633e693a Author: Oliver Bolte <obo@openoffice.org> Date: Wed Apr 13 07:54:11 2005 +0000 and untouched since then Change-Id: I995c094edbd3d85a6f637f7cb3e7aa4a0326c8bb
2016-03-15tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 and added SAL_INFO statements intead of OSL_TRACE Change-Id: Id3fda00e64eacc952e9317d854b179ac8f26d6ed Reviewed-on: https://gerrit.libreoffice.org/23229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09icon view for RemoteFilesDialogSzymon Kłos
New view type can be accessed in: Start Center > Remote Files > Icon View Cloud service for testing purposes: 1. Start Center > Remote Files > Add service 2. Set type to: Alfresco 4 3. Set host to: http://cmis.alfresco.com/cmisatom 4. Click refresh icon and enter login:admin pass:admin 5. Click OK and open this service Change-Id: I3d4674bb84d1df1b678111adffe2f835d2bb2356 Reviewed-on: https://gerrit.libreoffice.org/22437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09loplugin:constantparam in svtoolsNoel Grandin
Change-Id: Ica82c2758030729ee0d1480c16720cf6c8fed487
2016-03-07Bin overly verbose OSL_TRACEs of questionable usefulnessTor Lillqvist
Change-Id: Ic535aef31c2a8d73f9c496ffdc535494c15d3c12
2016-03-07Bin overly verbose function entry/exit debug print macrosTor Lillqvist
Change-Id: Icdbb9344a669e5f78d5db85dc555e91a56ded34c
2016-03-04-Werror,-Wnon-virtual-dtorStephan Bergmann
This looks like a real bug, causing leaks in the derived VistaFilePickerImpl (but harmless for the derived AsyncPickerEvents). Change-Id: Ic0de3f56574b89fb45eccb09fb27b78427f712d4
2016-03-04-Werror,-Wnon-virtual-dtorStephan Bergmann
Why was CCustomControlFactory a class with virtual functions in the first place? Change-Id: I4449a6f69f45a5b294b1906d0ce8a1a8a52c1d7f
2016-03-04Silence -Werror,-Wnon-virtual-dtorStephan Bergmann
Change-Id: I643c7e8ad12f255822c51a8f295e95f8799ef36a
2016-03-04-Werror,-Wunused-macrosStephan Bergmann
Change-Id: Ia8ea71174361b1f685a1a9c038c7ee809e54e0ef
2016-02-17Typo: namesapce(s)->namespace(s)Julien Nabet
Change-Id: Ic7c14c2e39a5ade1f5622a8350f9197d84cf9cc8
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Fix tdf#97500 Reinstate missing file error dialog on WebDAVGiuseppe Castagno
Bug introduced with my fix to tdf#96669 in commit 5fc2910fc872bbd1184aaab7c842dff593d2449b. Reverted previous fix and write a new version in fpicker instead. On WebDAV better check if the stream opens first, then check IsDocument property, because it may be a folder name. Change-Id: I72ce728329e4194080db6fa4cc4d98fecf7672e9 Reviewed-on: https://gerrit.libreoffice.org/22214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04tdf#43157 Cleanup DBG_ASSERT for fpicker and frameworkBerk Gureken
Change-Id: I1b79a39a9d709184cc72a905647f73dbf85eef27 Signed-off-by: Berk Gureken <berkgureken@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/21991 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-26-Werror,-Wsign-compare (clang-cl)Stephan Bergmann
According to MSDN: "If [StretchDIBits] fails, or no scan lines are copied, the return value is 0." Change-Id: I882b97b55f92618f0163f8829bf779a35b5a1452
2016-01-25more Windows build fixesNoel Grandin
after my OInterfaceContainerHelper2 change Change-Id: Id63fd81643b030e0570f00d6e0506cb8ea5d3742
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08Related tdf#96833: display WebDAV path in remote files dialogGiuseppe Castagno
Folder WebDAV paths have the '/' at the end, this needs to be removed in RemoteDialog logic while filling the treeview. Change-Id: I8336de3e08ff030b27b1e48594448ff66106cff6 Reviewed-on: https://gerrit.libreoffice.org/21041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-01-07cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ifdcb1cc12645d6cdba81d16f94f0268696187cde Reviewed-on: https://gerrit.libreoffice.org/21201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-23loplugin:unusedfields in fpickerNoel Grandin
Change-Id: Ia5d9211a668c25c9891ed69902fe1a4fbb2d8483
2015-12-07Undef RGB where it was defined, not where it gets usedStephan Bergmann
Change-Id: I1e122bb7c32850dfdd74de029c8d92a328207a95 Reviewed-on: https://gerrit.libreoffice.org/20430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-02-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Icf15313f5bcacbe9c7efa0b4161929dbb3e39c1e
2015-11-28-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I4331396f5bbc37306c09f0e9a1c6b2969922f66f
2015-11-28-Werror,-WreorderStephan Bergmann
Change-Id: I0988cf701dea563e3990b4179879fbcd3778662d
2015-11-28-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: Ie539b4f3e4295a8dcb1126371e5f2c75e9d723ab
2015-11-28-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: Ib725e544d058c735e485db1586743746a5236488
2015-11-28Avoid ambiguity which OUStringBuffer ctor to selectStephan Bergmann
...for size_t (i.e., unsigned long long on Windows 64-bit), chosing among the int, unsigned int, long, unsigned long overloads. MSVC apparently happily picks one of them, but clang-cl rightly complains. Change-Id: Ib245925bdf9e4a34add6ca435a95559f4f07c4d7
2015-11-28-Werror,-Wunused-functionStephan Bergmann
Change-Id: Id53c00a90f4f2d87e469ae4fe4121a5678dff5a4
2015-11-20loplugin:unusedfields forms,formula,fpicker,frameworkNoel Grandin
Change-Id: Ic7af56ac801c1e5b3fcf3c4e8413656e96220279
2015-11-18remove unused typedefs and inline use-once typedefsNoel Grandin
and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-13 16:05:20 +0000