summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)Author
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-31Strange OUString null checkStephan Bergmann
...ever since 035d20bd248b4f958c185001752688ef88318af6 "INTEGRATION: CWS aquafilepicker01". Unclear whether this was written under the assumption that m_aCurrentFilter is a pointer (which would explain the OSL_TRACE message talking about "null"), or whether it really wanted to check for an empty string (which the code acutally happened to do). So lets keep the empty-string check in, given it was in there ever since the code's introduction in 2007. Change-Id: I9e48b6ceccaf069c6a6a88d3918ba88379a72497
2016-10-28loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Ib75f2c8c06c6219aa0f2a8b2b29d19fb95e09527
2016-10-28tdf#89329: use unique_ptr for pImpl in fpicker/Rohan Kumar
Change-Id: I4a5db5ceafe509bffc32a8800ab3d678f41244f7 Reviewed-on: https://gerrit.libreoffice.org/30309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28only draw menubutton separator when two sides do something differentCaolán McNamara
Change-Id: If6e3b72eacef2325f9f30770bbed32c627bc035c
2016-10-28rename and explain the MENUBUTTON_MENUMODE_TIMED stuffCaolán McNamara
Change-Id: Ifc6ddfb0cc249e537c01f28bab84b42c6b1577d9
2016-10-21Adapt Windows-only code to deletion of the "Any-to-Any" specializatiosStephan Bergmann
...upcoming with <https://gerrit.libreoffice.org/#/c/30022/> "Delete the 'Any- to-Any' template specializations for LIBO_INTERNAL_ONLY" Change-Id: If070825d88ffa7bb49e645b3bfeae9dfa387f000
2016-10-19loplugin:expandablemethodds in formula..frameworkNoel Grandin
Change-Id: I6c8b1bb3b664faa92b2dc05955c30bfd35f6dfaa Reviewed-on: https://gerrit.libreoffice.org/30015 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-16clang-cl loplugin: fpickerStephan Bergmann
Change-Id: Ib19175affd48610fc164a996d609b369256d4f72 Reviewed-on: https://gerrit.libreoffice.org/29865 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14ReleaseSolarMutexOnMainThreadContext is unusedStephan Bergmann
...ever since its introduction in 29da2639353762a64673d6ae5b32a36045caa7d3 "CWS-TOOLING: integrate CWS filepicker01" Change-Id: I2bd989e7e950bf58a8f26708f79eeed223c4fb4a Reviewed-on: https://gerrit.libreoffice.org/29799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14_OPENFILENAME_SIZE_VERISON_400 is unusedStephan Bergmann
...since b30f91c58419e90a789f79a1391b13f2064997ab "Drop Win9x stuff" Change-Id: I4ef6b13865165c84288a77c83daf0758f5083810 Reviewed-on: https://gerrit.libreoffice.org/29793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-06ImageList just reads and discards the MaskColor, so drop itCaolán McNamara
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03Fix typosAndrea Gelmini
Change-Id: I6730c6c5eab9157533822e5045e9f86109062580 Reviewed-on: https://gerrit.libreoffice.org/29433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-28tdf#101549: Remove tooltip_markup from glade .ui filesMuhammet Kara
where there is also an identical tooltip_text. And convert the remaining tooltip_markup properties to tooltip_text. Change-Id: Id9995217468fb7046a2822dcef9a99072a7269ee Reviewed-on: https://gerrit.libreoffice.org/29367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-09-14loplugin:overrideStephan Bergmann
Change-Id: I1971301f2b07a6d0608d13d1ab60c6339a079468
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12Bin some noise comments and superfluous vertical whitespaceTor Lillqvist
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-09-12loplugin:constantparam in extensions..lotuswordproNoel Grandin
Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29tdf#101766: Fix new folder creation in 'Save Remote Server' dialog.Giuseppe Castagno
Change-Id: I5297918ff6acf0631b8be370de3ac96bed474a47 Reviewed-on: https://gerrit.libreoffice.org/28458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-27Resolves: #i96720# FilePicker: setDefaultName...Damjan Jovanovic
setDefaultDirectory "broken" Display the proposed filename even when the URL specified for the file picker directory is invalid. As the Win32 file picker sadly allows both paths and URLs for directories, users try paths on other more restrictive platforms, and since the file picker there shows neither the directory nor the file, they wrongly conclude both are broken. Patch by: me (cherry picked from commit 42d181e761c9903bfe5dd71334cadacebd1d0dc8) Change-Id: I3f99937b667d7fe5198f6445ccd4d0e22d48c7c7 Reviewed-on: https://gerrit.libreoffice.org/28426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-18screenshots: add new global make targetArmin Le Grand
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for fpickerArmin Le Grand
Change-Id: I6c94ff393e823552ea9c2332bd05abf5b2fafd54
2016-08-05loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01Add new open dialog type: Play and linkSamuel Mehrbrodt
This is needed e.g. for the "Slide transition sound" files where we want to play files and also give the choice whether to link or not Change-Id: I5aaef7152be8e5c0a0f88c4d7234926f233c5d92 Reviewed-on: https://gerrit.libreoffice.org/26846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30Add new open dialog type: Preview only (without link)Samuel Mehrbrodt
This is needed e.g. for the "Insert Photo Album" dialog where we don't want the "Insert Link" option in the file open dialog (tdf#65356) Change-Id: I01aecaaf8194a8123931b0482b4a37155654dfc2 Reviewed-on: https://gerrit.libreoffice.org/26796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-27Move accessibility relations to .ui files, Part 11: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. As of this commit, all accessible relations of type "SetAccessibleName" have been moved to .ui files other than a few exceptions. Change-Id: I5972211f58de70889066dec3c74341b405f82c85 Reviewed-on: https://gerrit.libreoffice.org/26520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22Work towards tdf#72606 EasyHack _tstring/TCHAR eliminationskswales
fpicker module TCHAR elimination and A/W clarity NB fpicker was already being compiled as UNICODE Use SendMessageW() as appropriate for clarity Use SAL_N_ELEMENTS for buffer capacity (number of WCHAR) when retrieving class name Change-Id: Ie6d0b1df1b9a2fb18f4cdfc51e5d4c3c55c9ca17 Reviewed-on: https://gerrit.libreoffice.org/26526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30valgrind: Invalid read of size 8Caolán McNamara
saw this in passing checking something else ==12972== at 0x6DEF40B0: rtl::Reference<PlacesListBox>::get() const (ref.hxx:169) ==12972== by 0x6DEEF221: VclPtr<PlacesListBox>::operator bool() const (vclptr.hxx:189) ==12972== by 0x6DEED3DA: CustomContainer::GetFocus() (iodlg.cxx:429) ==12972== by 0xD9EC83B: vcl::Window::CompatGetFocus() (window.cxx:3734) ==12972== by 0xD93A604: vcl::Window::ImplGrabFocus(GetFocusFlags) (mouse.cxx:383) ... ==12972== Address 0x2e4b4690 is 288 bytes inside a block of size 424 free'd ==12972== at 0x4C2D22A: operator delete(void*) (vg_replace_malloc.c:576) ==12972== by 0x6DED9F14: SvtFileDialog::dispose() (iodlg.cxx:518) ==12972== by 0xDB04B1F: OutputDevice::disposeOnce() (outdev.cxx:161) ==12972== by 0x6DED1954: VclPtr<SvtFileDialog_Base>::disposeAndClear() (vclptr.hxx:208) Change-Id: I702eab8dbcf07885e4a3415ace6706c25854174e
2016-05-26Resolves: tdf#98436 crash trying To create remote folder before connectedCaolán McNamara
Change-Id: I953167c9b78f9c9eba560390ecef7ccd8e5f1f68
2016-05-23in unlikely case >>= failsCaolán McNamara
Change-Id: I368456acb085905736f1e221eeb3c79df375c7f0
2016-05-13convert FilePicker flags to scoped enumNoel Grandin
and merged into the other flags variable. Change-Id: I23ed21936b9de1537a06168de04530b9fb6bcff1 Reviewed-on: https://gerrit.libreoffice.org/24889 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-12Convert SFX_EXTRA to scoped enumNoel Grandin
Change-Id: I57fa684d91d10a132c718152ca646edd1c7bd189 Reviewed-on: https://gerrit.libreoffice.org/24882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11set parent window of windows system file picker on save(as)Oliver Specht
If no parent is provided the Windows system file picker uses either the current foreground window or the desktop. The decision depends on the thread id of the foreground window. To make sure the document window is used as parent this is now also sent to the system file picker as it was already done for the internal file picker. Change-Id: Id589cbc1f91db30e065175aaea42ef1512ffb1b9 Reviewed-on: https://gerrit.libreoffice.org/24635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-11remove unused FILEDLG_STATE constants and fieldsNoel Grandin
Change-Id: I2d7460e575b0935e5001b2c78d0ffb0dd33f3c39 Reviewed-on: https://gerrit.libreoffice.org/24880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-28RemoteFilesDialog: icons for view mode buttonsSzymon Kłos
Start Center > Remote files Deleted text and icons inserted into view mode buttons. Change-Id: I0f3caad792d2b87993c08014f38d4f68599132ae Reviewed-on: https://gerrit.libreoffice.org/23249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-27clang-tidy modernize-loop-convert in f*Noel Grandin
Change-Id: Id866aa244378758e3bdb9e99d02cdd2ae6104e16
2016-04-22loplugin:passstuffbyrefStephan Bergmann
Change-Id: I45cc7c949dd8288bcc39f23c224370764c5cf0ec
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I58d7c95c77e67f315b33d1f83ac80148f93af450
2016-04-18loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ib4c63e4942acec1b02bac1a5bc387e1931eaae12
generated by cgit (git 2.34.1) at 2024-12-25 22:45:23 +0000