summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)Author
2015-04-22convert HIB_ constants to scoped enumNoel Grandin
Change-Id: I6fa3ecde4a1c5f9c7e6e1dcd22250cba065933e3
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-13loplugin:redundantcast: redundant const_cast followed by implicit upcastStephan Bergmann
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
2015-04-09loplugin:staticmethodsNoel Grandin
Change-Id: I715374b531da2850434b2436633b6042ecb9ebe0
2015-04-02loplugin:redundantcastStephan Bergmann
Change-Id: I6081fb76b0b6fc6fbce9c1f37a5a8103e70c9ef9
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02loplugin:staticmethodsNoel Grandin
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: Ibe0017f69442b345f66d0cde9445dc5aed9e6542
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: I5ae403a247253d3883ef1559439c571c2a5abefa
2015-03-25TyposJulien Nabet
Change-Id: I434be0034b26ac4719590238817538ecd90b8923
2015-03-24loplugin:constantfunction: variousNoel Grandin
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-24tdf#88230: Remove bogus AcquireSolarMutex fpicker wrapperPranav Kant
Change-Id: I5514c2db57b48d99f7daf410eda11f5ee882438e Reviewed-on: https://gerrit.libreoffice.org/14972 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-20tdf#88230: cleanup solar mutex yieldingPranav Kant
Use SolarMutexReleaser, instead. Change-Id: I276459c42b688813ea168d6fc80466a07a5ecba4 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-03-14tdf#43157: Fix format string violations in OSL_TRACE etc. (Mac OS X)Stephan Bergmann
Change-Id: Iab8c97560a9c46638d3943c2e129ddcf2e9db603
2015-03-10loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ic45e42d5ce7e0509cd2afc8be018f78cd6083aae
2015-03-05fpicker: remove checks for obsolete _WIN32_WINNT versionsMichael Stahl
Change-Id: Ie354e0237b97c872936bd0c87ad014ffc2ba56da
2015-02-26tdf#89700 Move “File type” upAdolfo Jayme Barrientos
Change-Id: Icb57186d823a5fa458b5f6516e04bb06b0a848d9
2015-02-16add GetSelectEntryData to ListBox and ComboBoxNoel Grandin
to reduce code clutter like pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos()) since this is a fairly frequent operation. Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184 Reviewed-on: https://gerrit.libreoffice.org/14472 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-07loplugin:deletedspecial (Mac OS X)Stephan Bergmann
Change-Id: Ia09e2e7b3e40bd04da64b52fe29258017b90b156
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I314402f7256a4b47c1a14255c39165702e21c226
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-06fix windows buildCaolán McNamara
Change-Id: I62a038d99107b30da302acee7b68e802fe5d9622
2015-02-06shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara
and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-23Win SDK 8.1: apparently VersionHelpers.h needs to be included explicitlyMichael Stahl
http://ci.libreoffice.org/job/lo_gerrit_master/495/Gerrit=Gerrit,Platform=Windows/console Change-Id: I0104d448906bd17857b3716856c544e632c1662c
2015-01-20Some more loplugin:cstylecast: fpickerStephan Bergmann
Change-Id: I39e741c395a05f6f83e2e5db91a76cea87d06836
2015-01-19try to fix GetVersionEx deprecation warnings from Windows SDK 8.1Michael Stahl
Apparently GetVersionEx() is deprecated now, but the replacement header "versionhelpers.h" does not exist in older SDKs (at least not in 8.0), so try to determine the used SDK version by checking if the Windows 8.1 version constant _WIN32_WINNT_WINBLUE (0x0602) exists. http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972%28v=vs.85%29.aspx Change-Id: Ia9224a8c76823ada7cb294a600046c6a0fc843ad Reviewed-on: https://gerrit.libreoffice.org/14020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05fdo#83371 : cannot navigate to list Files in LibreOffice dialogsSzymon Kłos
Change-Id: Ice5315136e25ece6a65c6136f0703825c426cf20 Reviewed-on: https://gerrit.libreoffice.org/13704 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-29fdo#85182 : default focus on folder rather than filenameSzymon Kłos
Change-Id: I84a2b6dd3f7045f1e95e6d45226797c33231552b Reviewed-on: https://gerrit.libreoffice.org/13685 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2014-12-26single \n should be non-translatable in UIAndras Timar
Change-Id: I7264ace75346689e9f18f6a797718b7ad3aaeba6
2014-12-18fpicker: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I9be920ec3d9da211daeabe872b02361a0500054a
2014-12-17fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I1d037e87c69b1a7de019f1abf1f729bf7e28d762 Reviewed-on: https://gerrit.libreoffice.org/13494 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15fpicker: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Icbb91dbfcce1f16f77e8238cbb86ff9eba2d5784
2014-12-12fdo#37814: SHCreateItemFromParsingName doesn't like LO's file URLsStephan Bergmann
...but apparently wants pathnames instead, cf. the other use of it in WinSalInstance::AddToRecentDocumentList (vcl/win/source/app/salinst.cxx). Change-Id: Iaa64ff82915f7cbfee55b4389387b226f7adc919
2014-12-09loplugin:cstylecastStephan Bergmann
Change-Id: If35fa5d97cec6c167bb0841da1e6819e5a4caf13
2014-12-04Older Mac apparently need a reinterpret_cast hereStephan Bergmann
Change-Id: I58ff0ae2e2410ff50f0faffabab5cdc0e4471433
2014-12-04fpicker (Mac): loplugin:cstylecastStephan Bergmann
Change-Id: I52687481a3d1203e72224c172edefd4a0a280688
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-26Silence Mac OS X 10.9/10.10 deprecations for nowStephan Bergmann
Change-Id: Ie63ed8f6f66a7641ad872f93d76efb962333cec9
2014-11-25fdo#85347 Make file picker modal againAdolfo Jayme Barrientos
Change-Id: I0e26b9e13e69ed49e7bbbc7f2ac0b04941ee1da7 Reviewed-on: https://gerrit.libreoffice.org/12974 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>