summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)Author
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01Add new open dialog type: Play and linkSamuel Mehrbrodt
This is needed e.g. for the "Slide transition sound" files where we want to play files and also give the choice whether to link or not Change-Id: I5aaef7152be8e5c0a0f88c4d7234926f233c5d92 Reviewed-on: https://gerrit.libreoffice.org/26846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30Add new open dialog type: Preview only (without link)Samuel Mehrbrodt
This is needed e.g. for the "Insert Photo Album" dialog where we don't want the "Insert Link" option in the file open dialog (tdf#65356) Change-Id: I01aecaaf8194a8123931b0482b4a37155654dfc2 Reviewed-on: https://gerrit.libreoffice.org/26796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-27Move accessibility relations to .ui files, Part 11: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. As of this commit, all accessible relations of type "SetAccessibleName" have been moved to .ui files other than a few exceptions. Change-Id: I5972211f58de70889066dec3c74341b405f82c85 Reviewed-on: https://gerrit.libreoffice.org/26520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22Work towards tdf#72606 EasyHack _tstring/TCHAR eliminationskswales
fpicker module TCHAR elimination and A/W clarity NB fpicker was already being compiled as UNICODE Use SendMessageW() as appropriate for clarity Use SAL_N_ELEMENTS for buffer capacity (number of WCHAR) when retrieving class name Change-Id: Ie6d0b1df1b9a2fb18f4cdfc51e5d4c3c55c9ca17 Reviewed-on: https://gerrit.libreoffice.org/26526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30valgrind: Invalid read of size 8Caolán McNamara
saw this in passing checking something else ==12972== at 0x6DEF40B0: rtl::Reference<PlacesListBox>::get() const (ref.hxx:169) ==12972== by 0x6DEEF221: VclPtr<PlacesListBox>::operator bool() const (vclptr.hxx:189) ==12972== by 0x6DEED3DA: CustomContainer::GetFocus() (iodlg.cxx:429) ==12972== by 0xD9EC83B: vcl::Window::CompatGetFocus() (window.cxx:3734) ==12972== by 0xD93A604: vcl::Window::ImplGrabFocus(GetFocusFlags) (mouse.cxx:383) ... ==12972== Address 0x2e4b4690 is 288 bytes inside a block of size 424 free'd ==12972== at 0x4C2D22A: operator delete(void*) (vg_replace_malloc.c:576) ==12972== by 0x6DED9F14: SvtFileDialog::dispose() (iodlg.cxx:518) ==12972== by 0xDB04B1F: OutputDevice::disposeOnce() (outdev.cxx:161) ==12972== by 0x6DED1954: VclPtr<SvtFileDialog_Base>::disposeAndClear() (vclptr.hxx:208) Change-Id: I702eab8dbcf07885e4a3415ace6706c25854174e
2016-05-26Resolves: tdf#98436 crash trying To create remote folder before connectedCaolán McNamara
Change-Id: I953167c9b78f9c9eba560390ecef7ccd8e5f1f68
2016-05-23in unlikely case >>= failsCaolán McNamara
Change-Id: I368456acb085905736f1e221eeb3c79df375c7f0
2016-05-13convert FilePicker flags to scoped enumNoel Grandin
and merged into the other flags variable. Change-Id: I23ed21936b9de1537a06168de04530b9fb6bcff1 Reviewed-on: https://gerrit.libreoffice.org/24889 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-12Convert SFX_EXTRA to scoped enumNoel Grandin
Change-Id: I57fa684d91d10a132c718152ca646edd1c7bd189 Reviewed-on: https://gerrit.libreoffice.org/24882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11set parent window of windows system file picker on save(as)Oliver Specht
If no parent is provided the Windows system file picker uses either the current foreground window or the desktop. The decision depends on the thread id of the foreground window. To make sure the document window is used as parent this is now also sent to the system file picker as it was already done for the internal file picker. Change-Id: Id589cbc1f91db30e065175aaea42ef1512ffb1b9 Reviewed-on: https://gerrit.libreoffice.org/24635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-11remove unused FILEDLG_STATE constants and fieldsNoel Grandin
Change-Id: I2d7460e575b0935e5001b2c78d0ffb0dd33f3c39 Reviewed-on: https://gerrit.libreoffice.org/24880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-28RemoteFilesDialog: icons for view mode buttonsSzymon Kłos
Start Center > Remote files Deleted text and icons inserted into view mode buttons. Change-Id: I0f3caad792d2b87993c08014f38d4f68599132ae Reviewed-on: https://gerrit.libreoffice.org/23249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-27clang-tidy modernize-loop-convert in f*Noel Grandin
Change-Id: Id866aa244378758e3bdb9e99d02cdd2ae6104e16
2016-04-22loplugin:passstuffbyrefStephan Bergmann
Change-Id: I45cc7c949dd8288bcc39f23c224370764c5cf0ec
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I58d7c95c77e67f315b33d1f83ac80148f93af450
2016-04-18loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ib4c63e4942acec1b02bac1a5bc387e1931eaae12
2016-04-18Avoid reserved identifierStephan Bergmann
Change-Id: I8b85f65e5d3e66aa93e161ce1895547d7d863ca1
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-13tdf#98395 : Remote File dialog showing wrong details in columnsSzymon Kłos
Before patch: - File type in the Size column (only first launch) After patch: - File type is not visible Change-Id: Ia2e3775f49dd9bfcc77a985812e040f70201f45c Reviewed-on: https://gerrit.libreoffice.org/22921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I65681e938c809467f9497568149d25f5f68ed5bf
2016-04-12WNT: check result of PostMessage()Michael Stahl
... so the next time something overflows the main thread's message queue it's easier to debug. Change-Id: I90a35e46f3b2cab190c7da5e53024ec549159ac6
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I8bcd7e8a492ee4dbfa5141416c7c038a1391cf20 Reviewed-on: https://gerrit.libreoffice.org/23673 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-23-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I77a73caf56878060ba3688c87e9b6d5dd3ae28b1
2016-03-23loplugin:constantparam in fpickerNoel Grandin
Change-Id: I7225c996030eed494e3ca8a9dabc501fc505e101
2016-03-23remove unused AUTOSELECT_USERFILTER codeNoel Grandin
added in commit 90fcf5718668f0f9f41ac141a7fc4306633e693a Author: Oliver Bolte <obo@openoffice.org> Date: Wed Apr 13 07:54:11 2005 +0000 and untouched since then Change-Id: I995c094edbd3d85a6f637f7cb3e7aa4a0326c8bb
2016-03-15tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 and added SAL_INFO statements intead of OSL_TRACE Change-Id: Id3fda00e64eacc952e9317d854b179ac8f26d6ed Reviewed-on: https://gerrit.libreoffice.org/23229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09icon view for RemoteFilesDialogSzymon Kłos
New view type can be accessed in: Start Center > Remote Files > Icon View Cloud service for testing purposes: 1. Start Center > Remote Files > Add service 2. Set type to: Alfresco 4 3. Set host to: http://cmis.alfresco.com/cmisatom 4. Click refresh icon and enter login:admin pass:admin 5. Click OK and open this service Change-Id: I3d4674bb84d1df1b678111adffe2f835d2bb2356 Reviewed-on: https://gerrit.libreoffice.org/22437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09loplugin:constantparam in svtoolsNoel Grandin
Change-Id: Ica82c2758030729ee0d1480c16720cf6c8fed487
2016-03-07Bin overly verbose OSL_TRACEs of questionable usefulnessTor Lillqvist
Change-Id: Ic535aef31c2a8d73f9c496ffdc535494c15d3c12
2016-03-07Bin overly verbose function entry/exit debug print macrosTor Lillqvist
Change-Id: Icdbb9344a669e5f78d5db85dc555e91a56ded34c
2016-03-04-Werror,-Wnon-virtual-dtorStephan Bergmann
This looks like a real bug, causing leaks in the derived VistaFilePickerImpl (but harmless for the derived AsyncPickerEvents). Change-Id: Ic0de3f56574b89fb45eccb09fb27b78427f712d4
2016-03-04-Werror,-Wnon-virtual-dtorStephan Bergmann
Why was CCustomControlFactory a class with virtual functions in the first place? Change-Id: I4449a6f69f45a5b294b1906d0ce8a1a8a52c1d7f
2016-03-04Silence -Werror,-Wnon-virtual-dtorStephan Bergmann
Change-Id: I643c7e8ad12f255822c51a8f295e95f8799ef36a
2016-03-04-Werror,-Wunused-macrosStephan Bergmann
Change-Id: Ia8ea71174361b1f685a1a9c038c7ee809e54e0ef
2016-02-17Typo: namesapce(s)->namespace(s)Julien Nabet
Change-Id: Ic7c14c2e39a5ade1f5622a8350f9197d84cf9cc8
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
generated by cgit (git 2.34.1) at 2025-01-08 19:07:58 +0000