summaryrefslogtreecommitdiff
path: root/framework/qa
AgeCommit message (Collapse)Author
2020-10-14tdf#137356 framework: fix opening the same document twice for long loadsMiklos Vajna
If the document loading is long enough that the statusbar is updated, then we can have this situation that we start loading the document, then spin the main loop during load and do a second load of the same document as part of the main loop spinning: #0 SwDoc::SwDoc() (this=0x1c6a180) at sw/source/core/doc/docnew.cxx:194 ... #6 0x00007ffff359a6dd in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x1c5c260, seqArguments=uno::Sequence of length 15 = {...}) ... #33 0x00007fffeeb81ecd in Application::Reschedule(bool) (i_bAllEvents=true) at vcl/source/app/svapp.cxx:460 ... #36 0x00007ffff4265251 in framework::StatusIndicator::start(rtl::OUString const&, int) (this=0x1aace80, sText="Loading document...", nRange=1000000) at framework/source/helper/statusindicator.cxx:51 #37 0x00007fffd026dfd3 in XMLReader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) (this=0x1bb7d20, rDoc=..., rBaseURL="file:///.../test.odt", rPaM=SwPaM = {...}, rName="") at sw/source/filter/xml/swxml.cxx:630 ... #42 0x00007ffff359a6dd in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x1bce4d0, seqArguments=uno::Sequence of length 15 = {...}) at sfx2/source/doc/sfxbasemodel.cxx:1883 The reason for this is is that by the time LoadEnv::impl_searchAlreadyLoaded() searches for frames which already have this doc open, the first load is still in progress, and we assiciate the frame with its controller (which has the URL) only once the load finishes. Fix the problem by setting the URL on the frame directly for the duration of the load: this way an in-progress load also counts as a duplicate and we'll have just one document open at the end. Regression from commit 74ac65c49cc1d53b1aa93c2b7c720255867aace2 (#i114963# Enable IPC before OpenClients to allow client connections when printing., 2016-09-06), we just didn't process incoming requests on the socket before, so the problem was less visible. Change-Id: Ib138c4c264e2508c20104ab268501bcca31e2790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104310 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-24framework: lock the solar mutex in loadComponentFromURL() with OnMainThreadMiklos Vajna
Regression from commit 2dc3a6c273cb82506842864481d78df7294debbf (framework: allow loading a component on the main thread, 2018-12-19), which was a forward-port from a 5.4-based vendor branch, where this was (it turns out) just working by accident, but never on master. It can happen that loadComponentFromURL() is invoked on a thread, which does not own the solar mutex. Then once vcl::SolarThreadExecutor::execute() is called, it'll try to release the solar mutex. But SolarMutexReleaser is unsafe: it'll release the mutex even if it is owned by an other thread. To make this a bit more safer, it'll abort in comphelper::SolarMutex::doRelease(), in case the current thread doesn't have the mutex already. Fix the problem by taking the solar mutex in loadComponentFromURL(): this is meant to cause no performance problems, since the actual importers typically start with taking the solar mutex anyway. Taking it earlier would be problematic, since this can be invoked by UNO clients directly. Taking it later in vcl/ would be also unusual: typically vcl just asserts that the solar mutex is locked, doesn't take it itself. Change-Id: I752006a91f16a02254d1b5ac6301100ab282630b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103264 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-19Fix typosAndrea Gelmini
Change-Id: I58c510121a9f535b2a31854f10b5f6535554d379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100988 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-24TODo -> TODOCaolán McNamara
Change-Id: Ie62909f7cffb8fdf178b0588e4f7dd3fc4b8ced3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-18comphelper, drawinglayer, framework, starmath: clang-format these filesMiklos Vajna
I added these files more or less recently and they have long lines. Use clang-format to break at a sane column limit. Change-Id: Id608fffbbc0673c9bc350dd696cb0a31906840d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94423 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-22Fix typosAndrea Gelmini
Change-Id: I49d7dc8a2cbcba5413d05d97559321e672ed413a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92655 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-07test: move component context from subclasses to BootstrapFixtureMiklos Vajna
To avoid duplication. Change-Id: I0ee7c26d5d55bd868ead04c77e7f4ef2582f90e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88138 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-28Fix typoAndrea Gelmini
Change-Id: Iebf4da702da03d9888bad314eb401cff6a26bd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85903 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-10Typo meesages->messages (framework)Julien Nabet
Change-Id: I9e43e516482292ce8f0506e260152b7e678c716e Reviewed-on: https://gerrit.libreoffice.org/82392 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-10Fix typosAndrea Gelmini
Change-Id: Ibc1b7393a8e65bf23c78fdb9da78c6b73b544cf3 Reviewed-on: https://gerrit.libreoffice.org/78793 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-14Fix typoAndrea Gelmini
Change-Id: I6933975c919f32cfda38624fc65b59b1b0ef821e Reviewed-on: https://gerrit.libreoffice.org/74003 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-14Fix typoAndrea Gelmini
Change-Id: Id0f271e577732b8960228157d2e08fb04cdcae0a Reviewed-on: https://gerrit.libreoffice.org/74004 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-14Fix typoAndrea Gelmini
Change-Id: I7c6f8478b95fa3904b1cec0cf5dbfc6885fd2810 Reviewed-on: https://gerrit.libreoffice.org/74002 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-12Fix typoAndrea Gelmini
Change-Id: Ic079b52586850d3742a9db6755b2faa2862fd60b Reviewed-on: https://gerrit.libreoffice.org/73851 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-06-12Fix typoAndrea Gelmini
Change-Id: I8fec8ce31cd74c3322bc55bdbb2692e9f9941d45 Reviewed-on: https://gerrit.libreoffice.org/73850 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-09Fix typoAndrea Gelmini
Change-Id: I4c35be2f4261bca19ebd1f100846f650e2af905e Reviewed-on: https://gerrit.libreoffice.org/73730 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Remove java mouse/keyboard event testsSamuel Mehrbrodt
These tests has been implemented as a UITest in sw/qa/uitest/writer_tests5/xwindow.py Change-Id: I0c1ae6d086a5a7d6e15b89bb3e810b49434da01e Reviewed-on: https://gerrit.libreoffice.org/71950 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-10an uno -> a unoCaolán McNamara
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-02tdf#45904 Move XReplaceDescriptor Java tests to C++Jens Carl
Move XReplaceDescriptor Java tests to C++ for ScCellSearchObj. Change-Id: Ica5042ce8b5eac3663a0fb5f66ae0a2830c89d93 Reviewed-on: https://gerrit.libreoffice.org/71645 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-25tdf#45904 Move TableColumn Java tests to C++Jens Carl
Move TableColumn Java tests to C++ for ScTableColumnObj. Change-Id: I3f17fa1f25c2676124b56c384364e36736fac849 Reviewed-on: https://gerrit.libreoffice.org/71261 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03tdf#45904 Move XCellRange Java tests to C++Jens Carl
Move XCellRange Java tests to C++ for ScTableRowObj. Change-Id: I2735779cae777c5af4e622bc1b538df2d8bf70df Reviewed-on: https://gerrit.libreoffice.org/70163 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-02tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScAutoFormatObj. Change-Id: I01ad72f7f48b3626085203ceac4f49bca847cdab Reviewed-on: https://gerrit.libreoffice.org/70097 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-25new loplugin:unoqueryNoel Grandin
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-17tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScAutoFormatsObj. Change-Id: I2cbf6dd7f8dd77da51e20c5f60f19d300ecae62e Reviewed-on: https://gerrit.libreoffice.org/69350 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-15tdf#45904 Move XTableColumns Java tests to C++Jens Carl
Move XTableColumns Java tests to C++ for ScTableColumnsObj. Change-Id: Iead7ca3d7c07820086f75d86833b7bfc97978751 Reviewed-on: https://gerrit.libreoffice.org/69286 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-13tdf#45904 Move XNameReplace Java tests to C++Jens Carl
Move XNameReplace Java tests to C++ for ScStyleFamilyObj. Fixes i#23594 by creating a new "com.sun.star.style.CellStyle" rather then using an existing one. Change-Id: Ie42e627020aff475173af5bc014bc28d7a11ec56 Reviewed-on: https://gerrit.libreoffice.org/69140 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScDataPilotFieldObj. Change-Id: I9fa5d153cced1aae8892d2422025dfcdcda73c69 Reviewed-on: https://gerrit.libreoffice.org/68782 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-03tdf#45904 Move XTextRange Java tests to C++Jens Carl
Move XTextRange Java tests to C++ for ScAnnotationObj (also fixes i109517). Change-Id: Id7e45d9f1159b45fb267cb28dc875b62eae12e24 Reviewed-on: https://gerrit.libreoffice.org/68634 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-02-27CppunitTest_framework_dispatch: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: I2de32f700125fc8306c16fe4963ef76f87b0034c Reviewed-on: https://gerrit.libreoffice.org/68435 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-02tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScDataPilotFieldsObj. Change-Id: I4b8bf204ccf4229ee5c57c03caef9fa5459e28a8 Reviewed-on: https://gerrit.libreoffice.org/67269 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-30tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScSpreadsheetSettingsObj. Change-Id: I59da149983ee3b897c1cdeaf5f40962b917c91ba Reviewed-on: https://gerrit.libreoffice.org/67101 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScFilterDescriptorBase. Change-Id: I86a16f3c53a5aacea0ce88a54ec8b340d13dff4f Reviewed-on: https://gerrit.libreoffice.org/67038 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-25tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScSpreadsheetSettings. Change-Id: Id969a566fcb4e544c26a4097e0f49a01bc967ad7 Reviewed-on: https://gerrit.libreoffice.org/66926 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-25tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScTableValidationObj. Change-Id: If058f40ff73203d2705bf9841d0496d52ff93ed8 Reviewed-on: https://gerrit.libreoffice.org/66890 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-24tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScSheetLinksObj. Change-Id: Ibe4571cf75abf96edc4361d884c63be0a972cab2 Reviewed-on: https://gerrit.libreoffice.org/66819 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-23tdf#45904 Clean up _XDrawPageSummarizer Java testsJens Carl
The XDrawPageSummarizer interface is deprecated since commit d081c80877dc1ae413b9d65c206485b6821d0ef8 Change-Id: I041c5d5df11d1b5208b846c76ef82427c4df4585 Reviewed-on: https://gerrit.libreoffice.org/66757 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScDDELinksObj. Change-Id: I91d8ea1b51cde36996847371a03406b899e23d79 Reviewed-on: https://gerrit.libreoffice.org/66559 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-17tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableConditionalFormat. Change-Id: Ib2575920e05d56feed68c6f4c15b485ab7993600 Reviewed-on: https://gerrit.libreoffice.org/66488 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-16tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScStyleFamiliesObj. Change-Id: I0c21e35f1c303bb430010b51795285c0a2e7e283 Reviewed-on: https://gerrit.libreoffice.org/66347 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-14tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScDataPilotTablesObj. Change-Id: I43bd4ca0688e38792080710c288ca746f95460d9 Reviewed-on: https://gerrit.libreoffice.org/66273 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-13tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScDatabaseRangesObj. Change-Id: Id54f9bc1a9215a4524be4a1f52800049ce438c8a Reviewed-on: https://gerrit.libreoffice.org/66250 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-13tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScFunctionListObj. Change-Id: I2db954ed8801937271b946e814bb1773c089d9ab Reviewed-on: https://gerrit.libreoffice.org/66244 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScScenariosObj. Change-Id: I73dd65e672e1e98a6839cea03c30cfafb7da4ff4 Reviewed-on: https://gerrit.libreoffice.org/65313 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScCellFieldsObj. Change-Id: I09e7c6be401bb54e1314da95d6797790aedefbe1 Reviewed-on: https://gerrit.libreoffice.org/64795 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScCellFormatsObj. Change-Id: I5ef1e789a535af55705c3a39f07a9396666adbed Reviewed-on: https://gerrit.libreoffice.org/64648 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScDDELinkObj. Change-Id: I121d9fe6a66c549e402b0cf6fd54fea1201e443f Reviewed-on: https://gerrit.libreoffice.org/64511 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-03tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScLabelRangesObj. Change-Id: Icf49fb7e8c24b169e4fe33ffed8cc1412d21f9e8 Reviewed-on: https://gerrit.libreoffice.org/64432 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-02tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScAnnotationsObj. Change-Id: Ife8c2d51a3aae409fa008c5ad2515a8976481771 Reviewed-on: https://gerrit.libreoffice.org/64407 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java test to C++ for ScAreaLinksObj. Change-Id: I374b7301caf67c900b7a64920d2ac5b642a8c6fd Reviewed-on: https://gerrit.libreoffice.org/64376 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
generated by cgit (git 2.34.1) at 2024-06-18 04:23:51 +0000