summaryrefslogtreecommitdiff
path: root/framework/source/accelerators/moduleacceleratorconfiguration.cxx
AgeCommit message (Collapse)Author
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): frameworkStephan Bergmann
Change-Id: Ia6eef000a712c9f23f81eaf6d27f5a236da9b24d Reviewed-on: https://gerrit.libreoffice.org/76673 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-10an uno -> a unoCaolán McNamara
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-17loplugin:unusedfields in formula..registryNoel Grandin
Change-Id: I031654d8bb4f1788d364ef4f8d3bf7a05fadb148 Reviewed-on: https://gerrit.libreoffice.org/54454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: frameworkStephan Bergmann
Change-Id: Ib5eaab06ff0cc1b44db9e4057ab349a0990af14d
2017-03-03Fix typosAndrea Gelmini
Change-Id: Ieb35517ba57ca62526e84f6b6cee4c9129b4380a Reviewed-on: https://gerrit.libreoffice.org/34805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21Revert "Resolves: #i120029# Unregister on dispose."Maxim Monastirsky
This reverts commit 11f8e53d6c9942185702552445a751c6f542942d. At the time this commit was imported from AOO, we had the original problem fixed already with dd8fa7c25af9614dbee5a7795b95d8583093f65b ("fix more lifecycle problems"). Change-Id: Id8288d30c1cb908b68e5b9ef0279237412aae357
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-05loplugin:unnecessaryoverride (dtors) in frameworkStephan Bergmann
Change-Id: I52b12e390b97f15f9af07edd511fa36288f31fbd
2016-10-16tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorHieronymous
Change-Id: Id97c6698d9ecac07348d3bdd3e031dbbb8486ae7 Reviewed-on: https://gerrit.libreoffice.org/29824 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-14com::sun::star->css in frameworkNoel Grandin
Change-Id: If5a77db83fcbef5ed436f2043ddeb7c515a840dc Reviewed-on: https://gerrit.libreoffice.org/19356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-30Fix typosAndrea Gelmini
Change-Id: I051caee9ec6181074201ac4a8cb6fcec4fdf2293 Reviewed-on: https://gerrit.libreoffice.org/18951 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-08-14framework: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I6acff50f23bcbac58c689caf2a7f07dbd5404e57 Reviewed-on: https://gerrit.libreoffice.org/17734 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-14Related: tdf#63690 - remove rtl_logfileThorsten Behrens
This was unused since the earlier cleanup. Change-Id: Ia56641c4242037a0ce501e43939b8dc862499f0e
2014-12-18framework: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
2014-04-14typo: dependend -> dependentThomas Arnhold
2014-04-06Kill superfluous vertical whitespaceTor Lillqvist
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Use SolarMutexGuard directlyStephan Bergmann
Change-Id: I6ca88538be5400714fcbe880776ac30cca3d68ae
2014-03-17Consolidate framework::{Read,Write}GuardStephan Bergmann
...now that it is obvious that they both do the same Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115
2014-02-26Remove visual noise from frameworkAlexander Wilms
Conflicts: framework/inc/dispatch/oxt_handler.hxx framework/inc/services/layoutmanager.hxx framework/inc/tabwin/tabwindow.hxx framework/source/dispatch/menudispatcher.cxx framework/source/helper/dockingareadefaultacceptor.cxx framework/source/helper/ocomponentaccess.cxx framework/source/helper/ocomponentenumeration.cxx framework/source/helper/oframes.cxx framework/source/layoutmanager/toolbarlayoutmanager.hxx framework/source/recording/dispatchrecorder.cxx framework/source/services/desktop.cxx framework/source/services/frame.cxx framework/source/services/urltransformer.cxx Change-Id: Ibb04e3f6f0796e7f2be16dcce38542f8b90708d4 Reviewed-on: https://gerrit.libreoffice.org/8265 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-09Typo: I/internaly -> I/internallyJulien Nabet
Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-18fwk: Use constructor feature for ModuleAcceleratorConfiguration.Matúš Kukan
And avoid css::uno::XInitialization protocol. Change-Id: If4a7987778e2880502bdc7ef2c30792de9377364
2013-09-09Try to make the Gentoo tinderbox happy with explicit OUString() valuesTor Lillqvist
Change-Id: If73a84a09ad54072e1251ed2db8aacc307ff32d2
2013-09-09Bin some uses of the stupid DECLARE_ASCII macroTor Lillqvist
Change-Id: I076eef8069e848ec3cf9c69f1b489ad44586324e
2013-07-26fdo#46037: comphelper/configurationhelper partly not used in fmwk/acceleratorsJulien Nabet
Change-Id: I710b9155b6ce8f42f46d87c80cebf37414e91c70
2013-07-23fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFOJelle van der Waa
Change-Id: Ib0edc828691c6a8edbd1f45d3c0e2851c32c865f Reviewed-on: https://gerrit.libreoffice.org/5013 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-23convert more services in framework module to WeakImplHelperNoel Grandin
Change-Id: I417ae2ce644f39fce0e8eb9fbe6a3a3c783b6227
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-05-28fdo#46808, Convert some XMultiServiceFactory to XComponentContextNoel Grandin
Change-Id: I7223d8e2c962ca90eda08119ed73a034d334329d
2013-05-28fdo#46808, Convert ui:*AcceleratorConfiguration to new styleNoel Grandin
The services already existed, they just needed IDL files. API CHANGE: The return type of XUIConfigurationManager#getShortcutManager() is now XAcceleratorConfiguration instead of XInterface. This should not be a problem because XUIConfigurationManager is unpublished and the client code was relying on the service returning that type. Change-Id: I399fe35de3394b02a4166b75eb7ff93b28be8bef
2013-05-11Resolves: #i120029# Unregister on dispose.Andre Fischer
Patch by: zhang jianfang Review by: Andre Fischer (cherry picked from commit e0d5abb649958e48660357d3fa37ab6e9707b61f) Conflicts: framework/source/uielement/toolbarmanager.cxx Change-Id: I4c6a112b27396fc7e5d42f3feef11ac1fe81efcd
2013-04-15fdo#60724 informations -> informationThomas Arnhold
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-28use LanguageTag instead of comphelper::LocaleEike Rathke
Change-Id: I2c6d07bbdef62fa17e9c90ca87be6e742268c54f
2012-11-15re-base on ALv2 code. Includes:Michael Meeks
Patches contributed by: Armin Le Grand. #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task. http://svn.apache.org/viewvc?view=revision&revision=1195906 #118485# - Styles for OLEs are not saved. http://svn.apache.org/viewvc?view=revision&revision=1182166 #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles http://svn.apache.org/viewvc?view=revision&revision=1293316 #119337# Solves the wrong get/setPropertyValue calls in SvxShapeText (and thus in SvxOle2Shape) http://svn.apache.org/viewvc?view=revision&revision=1344156 Patches contributed by Mathias Bauer (and others) gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 cws mba34issues01: #i117717#: remove wrong assertion http://svn.apache.org/viewvc?view=revision&revision=1172349 Patch contributed by Herbert Duerr goodbye Registration and License dialogs, don't let the door hit you http://svn.apache.org/viewvc?view=revision&revision=1172613 help gcc 4.6.0 on 32bit ubuntu 11.10" http://svn.apache.org/viewvc?view=revision&revision=1245357 Do not add targets for junit tests when junit is disabled. Patch contributed by Andre Fischer http://svn.apache.org/viewvc?view=revision&revision=1241508 Revert "sb140: #i117082# avoid unncessary static class data members commit 21d97438e2944861e26e4984195f959a0cce1e41. remove obsolete FreeBSD visibility special case. retain consolidated BSD bridge code, remove OS/2 pieces.
2012-08-08reduce ascii noise and useless commentsThomas Arnhold
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
2012-08-08remove include comments and boxesThomas Arnhold
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
2012-06-02targeted string re-workNorbert Thiebaud
Change-Id: I3276836b76b69f04de38c2d36ae04b60c49d4873
2012-05-18removed unused const rtl::OUStringTakeshi Abe
Change-Id: If02be864f958de96ae1c54fe575b1828410390b1
2012-02-02Some cppcheck cleaningJulien Nabet
generated by cgit (git 2.34.1) at 2024-08-18 04:00:58 +0000