summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2015-06-25+= does not make any sense hereStephan Bergmann
...although it was like that ever since its inception in 4718eab5490fd470945890d90427f87894952d5f "INTEGRATION: CWS keyconfig01," but perhaps impl_st_normPath never actually gets called with a path with leading slash, anyway. Change-Id: Ia3cf4f4020b3a9ca7152777bfa0378c28948fb8f
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I63f1b54cc9ef49a83800b671a60ea25df7fc2121
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-19rendercontext: Fix crash with double-buffering in the Styles combo box.Jan Holesovsky
Decouple the actual window from rendercontext in UserDrawEvent. Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
2015-06-18coverity#1307696 Unchecked return valueCaolán McNamara
Change-Id: Id30efd398cc5ee3df0c31cae53028e1a1b6ea025
2015-06-18tdf#91953 Mixture of icon sizesPhilippe Jung
Now, whatever the size of toolbar icons, the toolbar context menu always shows small icons. Change-Id: Id17df15278d74ae75a3e82d54ecf7af310e0ceb4 Reviewed-on: https://gerrit.libreoffice.org/16361 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-18Rename some toolbarmanager related variablesPhilippe Jung
Renames some variable to ease the understanding of what does what Change-Id: Idd84eb89b7c1fb56dd43d66edfbbeafedc319095 Reviewed-on: https://gerrit.libreoffice.org/16360 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-18drop unused sequenceasvector.hxx (see sequence.hxx)Caolán McNamara
Change-Id: Ib6d91f1ee427d5f94eed75e478f0809346f38e05
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-13It's E_BEFORECLOSE not E_CLOSINGJulien Nabet
Change-Id: Ia53f9aa8bb3c7fd1dd5c0190624a667b65996ca2
2015-06-13Typo: E_HARDEXCETIONS->E_HARDEXCEPTIONSJulien Nabet
Change-Id: I482d8fdb549d2a9c79bb68bd910e761f61337fb6
2015-06-13Fix typosAndrea Gelmini
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac Reviewed-on: https://gerrit.libreoffice.org/16260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-12make it easier to find missing sidebar componentsMarkus Mohrhard
Change-Id: Id962fbc20d12db59818dfca421843c674755e36c Reviewed-on: https://gerrit.libreoffice.org/16101 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-06-11speed up Java unit tests by removing sleepsNoel Grandin
and replacing them with a call to XToolkitExperimental:: processEventsToIdle Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932 Reviewed-on: https://gerrit.libreoffice.org/16201 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I4a72a60d621c65e63310ef70b991f9c86f00494d
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-05Let JUnit take care of exceptionsNoel Grandin
Inspired by commit 4dd0ac62855c5b9382cac004c7eebb9bed983a2b Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960 Reviewed-on: https://gerrit.libreoffice.org/16094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04uno::Sequence provides now begin and endNoel Grandin
use begin() and end() when calling std::copy on an uno::Sequence Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2 "uno::Sequence provides now begin and end" Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b Reviewed-on: https://gerrit.libreoffice.org/16057 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-01loplugin:loopvartoosmallNoel Grandin
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-27Fix accidental mis-uses of VclPtr address-of operatorStephan Bergmann
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb
2015-05-26convert INVALIDATE constants to scoped enumNoel Grandin
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-25convert TOTOP constants to scoped enumNoel Grandin
Change-Id: I85ba631ba298f1034dc5b6a04a5ff3d509c41bcb
2015-05-25convert SHOW constants to scoped enumNoel Grandin
Change-Id: I2712a0901049885502cade31f9757f712048bb33
2015-05-22loplugin:constantfunctionNoel Grandin
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
2015-05-19remove the last of the OUString #defines in header filesNoel Grandin
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-18SAL_WARN_UNUSED LinkStephan Bergmann
Change-Id: I646677611e46a7e33e977a5afeea9bf831b28733
2015-05-15conver MENU_FLAG_ constants to scoped enumNoel Grandin
Change-Id: I969d99fa8881cc89601696a2d8621905a82b147b
2015-05-15convert POPUPMENU_ constants to scoped enumNoel Grandin
Change-Id: I4cdaf36581d1e1daa39929e621070d18a9996852
2015-05-14tdf#86138 Context menu should state the name of the toolbarPhilippe Jung
When Menu::SetText is called, it defines the title of the menu (reuse of an already defined & not used aTitleText) Popup-menu with a title defined paint it on top of the popup. Text is bold with a background slightly darker than the rest of the popup. Change-Id: Ifca1be60541400f76f562b03f6e3c40dc5fecb29 Reviewed-on: https://gerrit.libreoffice.org/15716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-13framework: remove pointless IGate interface and de-virtualizeMichael Stahl
Change-Id: I43080ab6a4d9530a5cd4e3b8fa7806df41467e51
2015-05-13ramework: remove confusing unused Gate::openGap()Michael Stahl
Change-Id: Ie8c6547da8210f394df261d8a189a9daba034b6e
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann
Change-Id: Ia1130431fa5206bd007b6ce05488e4a199323c5b
2015-05-10Use IMPL_[STATIC_]LINK_NOARG where applicableStephan Bergmann
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-09coverity#1297236 Uninitialized scalar fieldCaolán McNamara
Change-Id: I2c19d1a0f8ad31cdf384ab301f3dae99a6ea9933
2015-05-08Ensure progress bar LibreOfficeKit callbacks don't repeat the same percentageTor Lillqvist
Gets rid of superfluous sequential callbacks with the same percentage when loading large documents. This reverts commit cec72eff99d1d683f2236c8a86a2814b34ad861e. Change-Id: I70f43f7e3a650c76cbcbbc60ebb2d47efaca06a5
2015-05-08lopluign:staticmethods: Handle DECL_LINKStephan Bergmann
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-08convert SHOWDIALOG_ID constants to scoped enumNoel Grandin
Change-Id: I58fffa7345f6b5050b8a1b3ac1022c630e64dbb4 Reviewed-on: https://gerrit.libreoffice.org/15651 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-11 20:12:18 +0000