summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2015-08-05loplugin:unusedmethodsNoel Grandin
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04idl,framework,forms: inline some use-once typedefsNoel Grandin
Change-Id: Icb4908c274ec0778af7ed9fe2d935bf6723fedfb
2015-08-03inline some use-once typedefsNoel Grandin
Change-Id: I55cc82c8e180cce371c996690608090b1bfdfda4 Reviewed-on: https://gerrit.libreoffice.org/17494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03remove some unused definesNoel Grandin
Change-Id: I85a9a2bc12681e13fc482374165ff9bd6858dc93
2015-08-03remove some unused typedefsNoel Grandin
Change-Id: I98c1e7eaa66b7afb05255a017a3de54714637501 Reviewed-on: https://gerrit.libreoffice.org/17491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-01Whitespace.Jan Holesovsky
Change-Id: Ifcccd6376a6a44bf6761e9fa451b46933adb6ce9
2015-07-31framework: replace boost::function with std::functionMichael Stahl
Change-Id: I9342bbdaa626c88592d3a7bdf12f150cc2a605b1
2015-07-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-28SimplifyMaxim Monastirsky
Every button has a controller, so it should be enough to just iterate the controllers map. Change-Id: I9e3d269a00ddd9362164a45000a90d9dc6220cab
2015-07-27Fix image update of DROPDOWNONLY buttonsMaxim Monastirsky
Change-Id: I787878d6ac02d15286a405ccfcc1f09f04c39501
2015-07-27remove some unused definesNoel Grandin
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188 Reviewed-on: https://gerrit.libreoffice.org/17332 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24string: 'Remote File' -> 'Save Remote File...'Szymon Kłos
Change-Id: I30e664e6fa16cdcbdffa97c57905b73224d42636
2015-07-24Don't show open remote entry in the recent doc menuMaxim Monastirsky
We use the same menu controller for both the Open toolbar button and the Recent Documents menu. While it's reasonable to put the open remote file command under the open button, it has nothing to do with recent documents, so it shouldn't appear there. Also don't add the "No Document" entry in case the open remote entry is visible. The whole point of the "No Document" entry is that we can't leave the menu empty, but if there is another visible entry, it's not needed. Change-Id: Ibefbdc6dc7d1d49f555d8ee23f67b47eba19b445 Signed-off-by: Szymon Kłos <eszkadev@gmail.com>
2015-07-24convert WindowAlign to scoped enumNoel Grandin
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-07-22tdf#82744: fix WebDAV lock/unlock behaviour - part 2Giuseppe Castagno
Changes done to the code in framework, comphelper and unotools, in no particular order - add an interaction handler dedicated to WebDAV The stock interaction handler can be missing depending on the need of the framework performing its tasks, so a dedicated handler is provided, this one is always present. - force opening of a WebDAV file. A WebDAV file sould be open r/o even if explicitly requested to open as r/w. This is a limitation of current WebDAV implementation, not of the standard. This change is needed in order to reopen correctly a file as requested by a 'Edit Mode' GUI command. Change-Id: I5368fa2c0511f1630e6d6139c6a986d33aa19082 Reviewed-on: https://gerrit.libreoffice.org/17182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-22remove some unused constantsNoel Grandin
Change-Id: I8742db77a0cfd99257584d830162c1c7126da263 Reviewed-on: https://gerrit.libreoffice.org/17283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21tdf#36796 Status updates for custom shapes buttonsMaxim Monastirsky
We're dealing here with 2 bugs: 1. Single shape buttons (like rectangle, ellipse etc.) don't get the pressed state when active. The cause is that all commands of the same kind (Basic Shapes, Symbol Shapes etc.) are handled as one internally, allowing only one type of status updates. It used to transport the current active shape, but it was changed to a boolean value in the fix for i#41753, and since then used for the pressed state of the group buttons. 2. The pressed state of a group button shows always, even when a user activates a shape from a place other than the drop-down of that button. But in this case the image of the group button doesn't update with the current shape, thus confusing the user on what is currently active. The cause here is that we use (since i#41753) the XSubToolbarController interface to update the last selected function (instead of the old-style status based update), and ToolBarManager notifies a controller about a new selection only if it was made from a particular toolbar that the controller claimed to use in the getSubToolbarName method. Since 7352a7c17875e5adcc4226c45f4a03e11c44ff49 there is a similar regression for other group buttons in sd (like lines, 3D Objects and other), with the same cause. This is also fixed now. Change-Id: Ida074a001ff78bf5bd5bcb8151516daa6e27cbce
2015-07-21Miscellaneous typosAdolfo Jayme Barrientos
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-16Ignore string status updates completelyMaxim Monastirsky
See no benefit of it here, and also it has some unexpected results with some commands that have enum commands, and use a string item to update the currently selected item. Change-Id: Iae54c4e1fb7a3aa5a7c1a03904fb3629ed63c8f0
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: I1ad92d1496759007f770b86f9d24e322b3ae194b
2015-07-16loplugin:cstylecastStephan Bergmann
Change-Id: I365b43f0327219f5ccd74984ec907088a8769785
2015-07-16Working toolbar entry: Save As > Remote fileSzymon Kłos
Change-Id: I5601c7847f30a7d5fb7ede5f90b2a6a89f4c8693
2015-07-16'Save As' popup menu in the Writer's toolbarSzymon Kłos
Change-Id: I1b1cb7fcd2ae0e0f50e4d8e3900bc416435e60bf
2015-07-16open remote entry in the open drop down menuSzymon Kłos
Change-Id: Idebc8a926c6653c476c2507606d4a89b22e2eaaf
2015-07-15loplugin:unusedmethods frameworkNoel Grandin
Change-Id: Ibfeb0ef753a083f458c84f446f0729f05c73e2d6 Reviewed-on: https://gerrit.libreoffice.org/17060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15Remove pointless check for well-formed sal_Bool valueStephan Bergmann
Change-Id: I69cd54f6fddc93f0cdf87651401fedb60aeeb1f4
2015-07-14-fsanitize=functionStephan Bergmann
Change-Id: I0a57d590d9e82d368b00ef11426e512ba7bc4dd4
2015-07-14loplugin:unusedmethods svtoolsNoel Grandin
Change-Id: I04ad31055c04a247faddf4311943ca769051473c Reviewed-on: https://gerrit.libreoffice.org/17032 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-14sfx2: remove the global SidebarController::maSidebarControllerContainerMichael Stahl
This global was crashing on exit, unsurprising as it contains UNO services that reference VCL objects. It turns out that there is already a UNO singleton framework::ContextChangeEventMultiplexer that effectively contains this mapping already, so try to hook that up without creating a public API of it, which is made quite a bit harder by framework's inexplicable multitude of libraries. Change-Id: I4baf67b42c630191fa8879d650eeb62520c331a5
2015-07-13Introduce generic sub toolbar controllerMaxim Monastirsky
Currently many toolbar controllers are basically doing the same thing - show some docked toolbar. So the idea here is to have one generic controller that will handle all these cases in a unified way. It will get the name of the toolbar that it's supposed to show from the configuration, based on the command it was registered for. Right now it can handle both simple (i.e. with DROPDOWNONLY bits) and split (i.e. with DROPDOWN bits) scenarios, where for split kind it replaces the function (and the image) of the main part of the button, with the last selected function, for easy reusing. A button is considered to be a split one, if the name of the initial default command was passed along with the sub toolbar name, otherwise it will be a simple button. The core change is in framework/. Other parts are a usage example, in form of converting the custom shapes buttons to this new controller. Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d Reviewed-on: https://gerrit.libreoffice.org/16967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-12allow also to use non-frame modules for sidebarMarkus Mohrhard
One more step away from using the frame as key and moving to the controller. Change-Id: I438b7eea2161d49a6f2cbf649bf01b8a2e233ebd
2015-07-10do not include boost/utility.hppMichael Stahl
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-09comphelper: remove boost::bind from headersMichael Stahl
Change-Id: I40c504d086c8ae1fd825acdafaada283ad9db8d0
2015-07-08Fix typosAndrea Gelmini
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-06Set button size before updating the imagesMaxim Monastirsky
So that the sub-toolbar controller will pick the right image size. Change-Id: I70b642ac84377b461a001ef11f551a5e1448c0f1
2015-07-06ToolBarManager: Let XSubToolbarController update itselfMaxim Monastirsky
The doc for XSubToolbarController::updateImage says: "gets called to notify a controller that it should set an image which represents the current selected function. Only the controller instance is able to set the correct image for the current function. A toolbar implementation will ask sub-toolbar controllers to update their image whenever it has to update the images of all its buttons." However, it didn't work that way until now. Steps to reproduce: 1. Open one of the custom shapes dropdowns, and choose a shape other than the default. Note that the button is now updated with the last selection. 2. Change the icon theme. Note that the button shows now the default shape, despite the fact that a future activation of that button, will still draw the last used shape. Change-Id: I9345c9faa17dc82a5f590b242b60751ce5d8e648 Reviewed-on: https://gerrit.libreoffice.org/16781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-06loplugin:unusedmethods svlNoel Grandin
Change-Id: Ic136cce6abef44291b7236a6d709f0eee391f311 Reviewed-on: https://gerrit.libreoffice.org/16784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-03Fix typosAndrea Gelmini
Change-Id: Id884946cae0687d0b71c967e236e58df17567884 Reviewed-on: https://gerrit.libreoffice.org/16707 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03typo: therfore -> thereforeAndras Timar
Change-Id: I9dcc0ce882dfd533d98a4f71625bb85e44084283
2015-07-01systools/win32/snprintf.h already included via sal/config.hStephan Bergmann
Change-Id: I74c683cf1ca821733717348a7840feeb7fbff3e9
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-29coverity#1308429 Unchecked return valueCaolán McNamara
Change-Id: I1d7db630eb6d0c12c5eb8b507be114693689e4e1
2015-06-29coverity#1308590 Uncaught exceptionCaolán McNamara
Change-Id: Ic92709acff10386f22b633e9cd4c3ad6cd1fbc9b
2015-06-29coverity#1308570 Uncaught exceptionCaolán McNamara
Change-Id: I9009a96e09943b5339c6ef6995d9a28c3e4b596c
2015-06-28coverity#1308527 Uncaught exceptionCaolán McNamara
Change-Id: I7ddc62f0ee005652dba62adc359959e1eb09a41e
2015-06-28coverity#1308516 Uncaught exceptionCaolán McNamara
Change-Id: If5dcf42448f87888e9f6bab2209bc1f9dd1d525c
2015-06-28Fix typosAndrea Gelmini
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28Fix typosAndrea Gelmini
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann
Change-Id: Ie17c1d6c7664b3d3ad0255094b26ba433c2c1921
generated by cgit (git 2.34.1) at 2024-07-13 21:07:11 +0000