summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove some old MSVC workaroundsNoel Grandin
Change-Id: I6abd8aaffb27b3c85df7c0518f7f576be4e32222 Reviewed-on: https://gerrit.libreoffice.org/36660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20convert EDynamicMenuType to scoped enumNoel Grandin
and drop unused E_HELPBOOKMARKS Change-Id: I5756ea326bdc1a99f7d6f1ba43baf6aca9f7f2fc Reviewed-on: https://gerrit.libreoffice.org/36728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19clang-tidy readability-simplify-boolean-expr in dbaccess..frameworkNoel Grandin
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99 Reviewed-on: https://gerrit.libreoffice.org/36678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19remove freshly unused menu support from src filesCaolán McNamara
Change-Id: I038711a0c4d440d452d5b2ae1bfcba5c9305815b Reviewed-on: https://gerrit.libreoffice.org/36646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-19convert over weird hidden RID_FMSHELL_CONVERSIONMENU use to new .uiCaolán McNamara
Change-Id: I61691a4148c1ff38703bb0d6ad9169242eb09871
2017-04-15Fix typosAndrea Gelmini
Change-Id: I0238202c0dc0380b0e33a9c4567a9513c0afbe91 Reviewed-on: https://gerrit.libreoffice.org/36556 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-14rework POPUPMENU_TOOLBAR_QUICKCUSTOMIZATIONCaolán McNamara
don't create a menu in order to copy certain entries under certain conditions to another menu, just insert the specific entries from more elemental parts Change-Id: I2254753fdc374742422afdb40fed7e78ae5dfbb2
2017-04-13Removed duplicated includesAndrea Gelmini
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-12update test to pass now that .ui files are foundCaolán McNamara
with 506cab1a01b0481d0831a7a692a26dc5a5b55e91 "take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR" in place .ui files are found and the count here changes, reverting the above makes it pass, but also reverting 08cf2fd01064306eef7fdbb5b62320947c4d1089 (framework: last dispatchInterceptor gets asked first, 2016-05-20) that this test wants to test also passes Change-Id: I01f5b77065e9562619412824bf69494b7b672b68
2017-04-04make UNO enums scoped for internal LO codeNoel Grandin
this modifies codemaker so that, for an UNO enum, we generate code that effectively looks like: #ifdef LIBO_INTERNAL_ONLY && HAVE_CX11_CONSTEXPR enum class XXX { ONE = 1 }; constexpr auto ONE = XXX_ONE; #else ...the old normal way.. #endif which means that for LO internal code, the enums are scoped. The "constexpr auto" trick acts like an alias so we don't have to use scoped naming everywhere. Change-Id: I3054ecb230e8666ce98b4a9cb87b384df5f64fb4 Reviewed-on: https://gerrit.libreoffice.org/34546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-01Replace OSL_FAIL by SAL_WARN_IFJulien Nabet
+ simplify message and code to create it Change-Id: I40cc0c1bf62a974ad5a5c5f27c4ed78c822390fa Reviewed-on: https://gerrit.libreoffice.org/35984 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-31spelling in comments: minmal -> minimalJustin Luth
Change-Id: Ie1947782cd7679c0c979d01ee7776176d771fc04 Reviewed-on: https://gerrit.libreoffice.org/35925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-03-30remove type decorations on char literalsJochen Nitschke
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in dbaccess/, forms/, fpicker/, framework/, and idl/ Change-Id: I08b3db9492f16fc1c457e8f5eff838c13561c945 Reviewed-on: https://gerrit.libreoffice.org/35888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-26Fix sub-toolbar tearoff for .uno:ChooseControlsMaxim Monastirsky
Regression of 81d4fbc0daa54889ccb09e6a3fadff9c70d99448 ("tdf#42029 Use a floating toolbar to show clipped items"). Change-Id: Id32a49109477745122d78354a5d3bd94cb126310
2017-03-25Fix typosAndrea Gelmini
Change-Id: I63ae7dbd7edf66aa5542f7d41f1bfd8ac04fc5e8 Reviewed-on: https://gerrit.libreoffice.org/35631 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22loplugin:redundantcast find redundant c-style enum castsNoel Grandin
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349 Reviewed-on: https://gerrit.libreoffice.org/35467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19TyposJulien Nabet
Change-Id: Id1b96b56b16ebf2d8a99dd6fb64c73906dfd598f Reviewed-on: https://gerrit.libreoffice.org/35435 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19TyposJulien Nabet
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c Reviewed-on: https://gerrit.libreoffice.org/35436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-17remove unused defines from HRC files in variousNoel Grandin
Change-Id: Ia1ba313d2438f04a84bcfcbbbcf6fffea5c1921d Reviewed-on: https://gerrit.libreoffice.org/35310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13More ToolBox sal_uInt16 -> ImplToolItems::size_type clean-upStephan Bergmann
Change-Id: I6ec50033a452493852729dc8efe78da2708cbd96
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-11Fix typosAndrea Gelmini
Change-Id: I19d30a1ef4236dbe0a0053dad67a5ba7b1586fc8 Reviewed-on: https://gerrit.libreoffice.org/35054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Johnny_M <klasse@partyheld.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06tdf#106224 Support extra large savemodified iconMaxim Monastirsky
For now just duplicated the large icon in Galaxy, to satisfy the resource compiler. Change-Id: Icf31df0185a1ec7f080d9600b2536bcaa5d0783e
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03Fix typosAndrea Gelmini
Change-Id: Ieb35517ba57ca62526e84f6b6cee4c9129b4380a Reviewed-on: https://gerrit.libreoffice.org/34805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-27Use WeakImplHelper to implement MenuBarManagerStephan Bergmann
Change-Id: I3a30bc86796a7ad24616cb11ae10b6886e09c1e9
2017-02-27loplugin:loopvartoosmallStephan Bergmann
Change-Id: I05874c22883a98f09c9231c0e0ff0dff93e2d643
2017-02-24Make ToolbarMode's "IsExperimental" property non-nillableSzymon Kłos
Change-Id: Ia83776d7ee23fa56c0fc541c228c68b1832c3d11 Reviewed-on: https://gerrit.libreoffice.org/34585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-23change intervall -> intervalDavid Tardon
Change-Id: Ib211619428f16304603d9c0a9fce0b22dde2a617
2017-02-22tdf#103323 Single Toolbar without experimental modeSzymon Kłos
Only Notebookbar mode should be marked as experimental. This patch allows to enable Single Toolbar or Sidebar mode without experimental mode activation. Change-Id: I9dcf1602b2f560aaa9ea29c07c4a7ed473be0352 Reviewed-on: https://gerrit.libreoffice.org/34431 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-21Fix typos/translations, following 04644956e53dAndrea Gelmini
No automatic tools Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428 Reviewed-on: https://gerrit.libreoffice.org/30874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21loplugin:subtlezeroinit: frameworkStephan Bergmann
Change-Id: I88871abd4b57debeb8002a25ef5f59f57e065803
2017-02-21Use module name when getting labelsMaxim Monastirsky
Change-Id: I1d5196e1ca888dfb11d5bd6ef4676937dce49fdc
2017-02-21Single GlobalAcceleratorConfiguration should be enoughMaxim Monastirsky
avoid reading the configuration again and again. Change-Id: I4179da53114990e5ee68b47125ccef356ca00d53
2017-02-21Revert "Resolves: #i120029# Unregister on dispose."Maxim Monastirsky
This reverts commit 11f8e53d6c9942185702552445a751c6f542942d. At the time this commit was imported from AOO, we had the original problem fixed already with dd8fa7c25af9614dbee5a7795b95d8583093f65b ("fix more lifecycle problems"). Change-Id: Id8288d30c1cb908b68e5b9ef0279237412aae357
2017-02-21tdf#95844 Refactor CommandInfoProviderRohan Kumar
Instead of a singleton, CommandInfoProvider should just be a set of static methods. Change-Id: I16d4406e361a72f013d78f18d6bd0ae20c0cc5e9
2017-02-16drop unused Private from EProtocol enumNoel Grandin
Change-Id: Ic3f64eb211e520dbafed4ef98344ab5cb0811599
2017-02-16drop enum framework::GlobalSettings::UIElementTypeNoel Grandin
since we only ever use the one enumerator. Consequently renaming some methods Change-Id: Ia8c022135df6661b8f300e037ea3e7cf610b63ac
2017-02-16convert LoadEnv::EFeature to o3tl::typed_flagsNoel Grandin
Change-Id: I4c16b68c820783e9bd27fa273f2017b5088f4b85
2017-02-16drop unused enumerators from TargetHelper::ESpecialTargetNoel Grandin
Change-Id: Ieda0b6f09b0e4cb463de32309a2617018bb7cee5
2017-02-16tdf#100726 Improved readability of OUString concatenationsFakabbir Amin
Cleanup in filter, framework and svtools directory. Change-Id: Icf4f04cff1207e58ce55ea3dc8c21b0635c3b6ec Reviewed-on: https://gerrit.libreoffice.org/34298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>