summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I4a72a60d621c65e63310ef70b991f9c86f00494d
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-05Let JUnit take care of exceptionsNoel Grandin
Inspired by commit 4dd0ac62855c5b9382cac004c7eebb9bed983a2b Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960 Reviewed-on: https://gerrit.libreoffice.org/16094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04uno::Sequence provides now begin and endNoel Grandin
use begin() and end() when calling std::copy on an uno::Sequence Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2 "uno::Sequence provides now begin and end" Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b Reviewed-on: https://gerrit.libreoffice.org/16057 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-01loplugin:loopvartoosmallNoel Grandin
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-27Fix accidental mis-uses of VclPtr address-of operatorStephan Bergmann
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb
2015-05-26convert INVALIDATE constants to scoped enumNoel Grandin
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-25convert TOTOP constants to scoped enumNoel Grandin
Change-Id: I85ba631ba298f1034dc5b6a04a5ff3d509c41bcb
2015-05-25convert SHOW constants to scoped enumNoel Grandin
Change-Id: I2712a0901049885502cade31f9757f712048bb33
2015-05-22loplugin:constantfunctionNoel Grandin
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
2015-05-19remove the last of the OUString #defines in header filesNoel Grandin
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-18SAL_WARN_UNUSED LinkStephan Bergmann
Change-Id: I646677611e46a7e33e977a5afeea9bf831b28733
2015-05-15conver MENU_FLAG_ constants to scoped enumNoel Grandin
Change-Id: I969d99fa8881cc89601696a2d8621905a82b147b
2015-05-15convert POPUPMENU_ constants to scoped enumNoel Grandin
Change-Id: I4cdaf36581d1e1daa39929e621070d18a9996852
2015-05-14tdf#86138 Context menu should state the name of the toolbarPhilippe Jung
When Menu::SetText is called, it defines the title of the menu (reuse of an already defined & not used aTitleText) Popup-menu with a title defined paint it on top of the popup. Text is bold with a background slightly darker than the rest of the popup. Change-Id: Ifca1be60541400f76f562b03f6e3c40dc5fecb29 Reviewed-on: https://gerrit.libreoffice.org/15716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-13framework: remove pointless IGate interface and de-virtualizeMichael Stahl
Change-Id: I43080ab6a4d9530a5cd4e3b8fa7806df41467e51
2015-05-13ramework: remove confusing unused Gate::openGap()Michael Stahl
Change-Id: Ie8c6547da8210f394df261d8a189a9daba034b6e
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann
Change-Id: Ia1130431fa5206bd007b6ce05488e4a199323c5b
2015-05-10Use IMPL_[STATIC_]LINK_NOARG where applicableStephan Bergmann
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-09coverity#1297236 Uninitialized scalar fieldCaolán McNamara
Change-Id: I2c19d1a0f8ad31cdf384ab301f3dae99a6ea9933
2015-05-08Ensure progress bar LibreOfficeKit callbacks don't repeat the same percentageTor Lillqvist
Gets rid of superfluous sequential callbacks with the same percentage when loading large documents. This reverts commit cec72eff99d1d683f2236c8a86a2814b34ad861e. Change-Id: I70f43f7e3a650c76cbcbbc60ebb2d47efaca06a5
2015-05-08lopluign:staticmethods: Handle DECL_LINKStephan Bergmann
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-08convert SHOWDIALOG_ID constants to scoped enumNoel Grandin
Change-Id: I58fffa7345f6b5050b8a1b3ac1022c630e64dbb4 Reviewed-on: https://gerrit.libreoffice.org/15651 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-08Use typed Menu::Set[De]actuivateHdl LinksStephan Bergmann
Change-Id: I6736383ad0ec5c9f2ea2281bfdcfa280cd712032
2015-05-08Use typed Menu::SetHighlightHdl LinkStephan Bergmann
Change-Id: I47a35813fddcb90497b621a96bafe74969dc90d0
2015-05-06Don't bother ensuring progress bar LibreOfficeKit callbacks are monotonicalTor Lillqvist
It can well be that the StatusIndicator code is called for multiple independent sections while loading some document format, and that the first progress is not the one that actually takes much time at all, so following just the progress of that would be misleading, the progress would be "stuck" at the highest value set by the first progress (forever, if it has gone up to 100%). For example, when loading the odk/examples/java/DocumentHandling/ test/test1.odt sample document, the code first calls the StatusIndicator while parsing the styles.xml, going from 0% to 100%. But the styles.xml is typically rather small. Then the code calls the StatusIndicator *again* while parsing the much more relevant concent.xml. For that particular document, this time the progress goes from 0% to 27% only, for some reason. Oh well, GIGO. Change-Id: I87bfc586a53efcbeb94924f21dd365ca63da88d7
2015-05-06We don't use <config_features.h> any more hereTor Lillqvist
Change-Id: I06a382917717906a0e5fdee57e296bab407c5348
2015-05-06Add support for progress bar callbacks to LibreOfficeKit clientsTor Lillqvist
The framework bits. Change-Id: I9cbd649c7766284bfcf8846d2b5e129dd2731ee8
2015-05-06Use typed ToolBox::SetMenuButtonHdl LinkStephan Bergmann
Change-Id: I00cd35374294ccdcc0ac3223ae81ba8129b9a5d7
2015-05-06Use typed ToolBox::SetDataChangedHdl LinkStephan Bergmann
Change-Id: Ia4fe932e765651653e6c534e755a8fc32875ffc3
2015-05-06Use typed ToolBox::SetStateChangedHdl LinkStephan Bergmann
Change-Id: I9b574f652e5d999086e32e9c7ede7c68fe5cc99a
2015-05-06Use typed ToolBox::SetCommandHdl LinkStephan Bergmann
Change-Id: Ieee142ddebb288037647fb77bac6f11b9827c4a8
2015-05-06convert BMP_SCALE constant to scoped enumNoel Grandin
Change-Id: Ibc9f88d2588c028cd71aa86c26d970a73025ef22
2015-05-06convert CONFIG_MODE constants to scoped enumNoel Grandin
Change-Id: I1b0fb976e7bf8d7de06da0c30012e8bba1320498
2015-05-06Use typed ToolBox::SetDeactivateHdl LinkStephan Bergmann
Change-Id: Ia2521b000e962a0cc461a54f73b5c97bbe34a602
2015-05-06Use typed ToolBox::SetActivateHdl LinkStephan Bergmann
Change-Id: I15044bd9ea94562c1d4727f64aa0b32543e0cc0a
2015-05-06Use various typed ToolBox::Set*Hdl LinksStephan Bergmann
Change-Id: Iddfd36ae0de86fdd2d4febb2c05d1fe0c02801f0
2015-05-05vcl: rename other members of StateChangedType for consistencyMichael Stahl
Change-Id: Ifd3339813e5d3dfb54566fd226aaf2d2a199d59a
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-04Use typed TabControl::SetDeactivatePageHdl LinkStephan Bergmann
Change-Id: I487aad5217cb685ece971717445a68b4fb3d2b3a
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Get rid of the initial :: for the vcl namespaceTor Lillqvist
We used it all over the place without leading :: already anyway, even in many files in include. So let's be consistent. In the majority of cases, prefer the easier-on-the-eyes choice, not the "safe" one. In those files in include where *all* existing uses of ::vcl:: indeed used the :: prefix, there let's keep it for consistency. Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29error C2666: 'operator ==' : 2 overloads have similar conversionsDavid Tardon
Change-Id: I2813d08f5f903d4d5115f04f58598b3841facfd0
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28Rephrase comparisons between bool and sal_BoolStephan Bergmann
...to cater for forthcoming loplugin:implicitboolconversion improvements Change-Id: I801b6b73648715448198d582a087cc834f6e20c8