summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17coverity#1247630 Uncaught exceptionCaolán McNamara
Change-Id: Ic15d712a26bdb6565b78efc4e9cab1bb09fd1cf4
2014-10-17java: final fields that can be staticNoel Grandin
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10cid#1244948 Uncaught exceptionNoel Grandin
Change-Id: I421f245fd3be90f0e1d08ad92b0723a64121ae12
2014-10-10cid#1244950 Uncaught exceptionNoel Grandin
Change-Id: I1aa4d437838dac42ac1fc803a2ba2a437fa3addb
2014-10-10cid#1244951 Uncaught exceptionNoel Grandin
Change-Id: I3bb5dc5932f4239507920cb9cafa66caab9ff7e0
2014-10-10cid#1244952 Uncaught exceptionNoel Grandin
Change-Id: Ied23e7df1d8ebda9976e63d03c122c058addf274
2014-10-08spelling: instanciated -> instantiatedNoel Grandin
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-07java: remove some unnecessary intermediary object creationNoel Grandin
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
2014-10-03coverity#1078526 Logically dead codeCaolán McNamara
Change-Id: I203511fcb1e740d7d371821d49a7c13a72e6fc3b
2014-10-02coverity#1242768 Unused valueCaolán McNamara
Change-Id: Ida66a4a4d00caa49e993938f86e357e4351a60c5
2014-10-02coverity#1242970 Result is not floating-pointCaolán McNamara
Change-Id: Icd0b04a2b8d9250418dfec95668fa6c496e45e5e
2014-10-02fix for older compiler, doesn't like <::Noel Grandin
Change-Id: I8113125b7eb9d919aaf84a1dcde3e58e41e978f4
2014-10-02loplugin: cstylecastNoel Grandin
Change-Id: I4a8786f335b5f9a14116c546d32f1ff6cff99930
2014-10-01loplugin: cstylecastNoel Grandin
Change-Id: Idac41288539ff171e1c9fb0e12b172a311878ed6
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30framework: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I6ef5e9018d1e33c205eae934c404d3391a4693f2
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-24fdo#83558 Don't change toolbar tooltip on state changeSamuel Mehrbrodt
Also removed EraseAllMnemonicChars since that method is called later by SetItemText Change-Id: I10139d437290ccfed6a8a15e8e5ce501e15c2560 Reviewed-on: https://gerrit.libreoffice.org/11306 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22Always add the keyboard shortcut to the toolbar tooltipsSamuel Mehrbrodt
Change-Id: I6f6e385cf6d09b0a3f18b708daeff2df9aba83c6 Reviewed-on: https://gerrit.libreoffice.org/11595 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-22Revert "Related fdo#81475 Improve toolbar tooltips in Writer standard toolbar"Jan Holesovsky
Unfortunately this breaks the Edit menu - it is now crowded with long texts; so while it may improve the toolbar, it definitely breaks the menu. This reverts commit b59c5ace4b7213ffd62495d0c0e5b6411f5071be.
2014-09-22Related fdo#77813: $(workdirurl) was always emptyStephan Bergmann
Regression introduced with cb021fcafba06ccf973f2abe229a4761c0a002de "fdo#46037: remove 1 comphelper/configurationhelper in framework." Change-Id: I07727d93315e0d3d87004ce71708271e90a173a3
2014-09-22Unwind one level of cluttering indirectionStephan Bergmann
Change-Id: Iceaed0e5490b6002c1421d74dfb8f2d0ba38cbf5
2014-09-22vcl: Allow creation of button content from action name (.uno: commands).Jan Holesovsky
Change-Id: If4b2aef59d45a848fb77de9e1b7bf80d49548a75
2014-09-21Related fdo#81475 Improve toolbar tooltips in Writer standard toolbarSamuel Mehrbrodt
and show the shortcut in the tooltip also when there is a custom tooltip Change-Id: Ia3f5d17df3769479f7aacf63a83507ccb8593103 Reviewed-on: https://gerrit.libreoffice.org/11303 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-21fdo#81237: OpenGL window is not resized by view changeZolnai Tamás
Reproduce: - Create a 2D OpenGL chart - Step out from edit mode - Zoom in / zoom out Behavior - Chart window is not resized, it has a constant size. When we step out from chart edit mode the chart becomes an inplace active object (instead of UI active) which means the m_xDockingAreaAcceptor is removed. On the other hand it seems we don't actually use this m_xDockingAreaAcceptor here, so don't need to check whether it exists. Change-Id: I056109b6e5cac28cdd2aeb8fabd9190413a16ed5
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-12framework: sal_Bool -> boolStephan Bergmann
Change-Id: Ie56d3fe674af048d7aea32f141c5825e4c2aa98b
2014-09-12vcl: It's a close button, there is no such a thing as a 'closer'.Jan Holesovsky
Clean up at least vcl + what depends on that, but unfortunately there are still some "Closer"'s left elsewhere... Change-Id: I019c863d07ee62d701ff01c8d871334012c105f1
2014-09-10Typo: (N|n)ormaly->(N|n)ormallyJulien Nabet
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-09-09Fix indentation.Jan Holesovsky
Change-Id: I0fb904353bc79199d7df957cf756883e425c97eb
2014-08-25set names on a bunch more threads...Michael Stahl
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-22Open the right tab for the More... commandMaxim Monastirsky
Partially fixed by Caolán in 3ac80237f310366afef0f7b6c427889d652bd369. Remaining issues are the paragraph submenu, and the top menu for both selection and paragraph. Also fixed for the drawing text and annotations shells (including the regression created by the above commit, that the dialog didn't show at all). Change-Id: I1ba4c825ad48af23ad5c07c8c5f25380952c0be1
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20java: remove modifiers implied by the contextNoel Grandin
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20java: Avoid naming non-fields with the prefix m_Noel Grandin
found by PMD Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-19fdo#529470: I can't remove a path in AutoText dialogTor Lillqvist
This is, not surprisingly, somewhat weird code, but I think this patch does what is necessary, it does fix the bug. Change-Id: Ie1947b311f1455ba48a904f5ef42ad92899fac31
2014-08-19java: no need to instantiate String objects directlyNoel Grandin
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19java: use 'Short.valueOf' instead of 'new Short'Noel Grandin
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19java: use 'Long.valueOf' instead of 'new Long'Noel Grandin
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19java: remove unused methodsNoel Grandin
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-18document the swap-on-free idiom usageNoel Grandin
Effective C++, item 17 Change-Id: I5c6f20c9631f1ca86b481a56ef08d578a7addbad
generated by cgit (git 2.34.1) at 2024-08-20 05:23:30 +0000