summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2021-12-17Fix typosAndrea Gelmini
Change-Id: I7f1636226c4fbe29d9d2ef850318a9d57f1b5450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127009 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-16tdf#146219: don't try to detect if a recent file is a directoryMike Kaganski
This avoids accessing (possibly unavailable) remote URLs, when we already know that MRU items are files. Change-Id: I97e07f007d4129b93b4939311c67cf95de6ff836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126943 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-15Recheck include/[a-d]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I42475b8e75951d5dcae2fe6b0ad0bca64441e7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-14prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: I23310b8b5adbe7c84d0b9d30a227619c1e9a6960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: I486e24b0b85357b43213443c1a9b71206b8f441a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13only use css::awt::XPopupMenu methodsCaolán McNamara
Change-Id: Icab3bc855e92c5f6389ee8129bcaaa1308619ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ibb5984a588e21f9b761b6f56933394874c09dd88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126709 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: I81c892d946965f779d982194efd6b32d6493143e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126708 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ib52e4091d6a4e0d01aece3eb5f541cd29187a983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126707 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13only use css::awt::XPopupMenu methodsCaolán McNamara
Change-Id: Ib8e14af038fccd43e79f12b6a5f9371be6a29c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126706 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ibf34e33715a86a09ec49495b1049a60e1403a6af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13use XMenu::enableAutoMnemonics instead of Menu::SetMenuFlagsCaolán McNamara
Change-Id: I4d3d8234bb2e643067bed68595a4b22198e38fb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12these aSolarMutexGuard calls are redundant nowCaolán McNamara
Change-Id: Ic167b8d40c1c93f5e6f4408d260c4e70b4017fd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126693 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12prefer more css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ib008281d63071ea79935af83cbe434be66155455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12prefer css::awt::XPopupMenu apiCaolán McNamara
and using GetXGraphic will return a vcl unographic::XGraphic which also supports XBitmap as well as XGraphic so we can check if the XBitmap we're passing around supports XGraphic and use that if it does and drop the imagewrapper in favor of doing that Change-Id: I3bd7963b53c3f715fca4b5cfb2ddad650ca92e1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-11Fix typosAndrea Gelmini
Change-Id: I8e6db5dfb5285e45f862fadf09ecb4142be6e075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126659 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-12-10Generally determine Rdb content from gb_*_set_componentfile callsStephan Bergmann
...instead of by listing the content somewhat redundantly in the Rdb_*.mk files, to avoid duplication of logic for components that are only built conditionally (and thus should only be included conditionally in the corresponding Rdb). To achieve that, add an "rdb" parameter to gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros that internally call gb_ComponentTarget_ComponentTarget), which is used to make the appropriate gb_Rdb_add_component call internally from within gb_ComponentTarget_ComponentTarget. (As a special case, gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that has already been done by the corresponding gb_Library_set_componentfile call, so allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to support that special case.) Most Rdb_*.mk files are thus mostly empty now. One exception is i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as needed during the build in CustomTarget_i18npool/localedata. 1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built components" had already tried to do something similar (in addition to other things) under a new --enable-services-rdb-from-build option. However, that approach had four drawbacks that this approach here addresses (and which thus partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b): 1 Rdb_services shall not contain the component files of all libraries that are built. While that commit filtered out the component files that go into Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files that go into others like Rdb_postgresql-sdbc (connectivity/Rdb_postgresql-sdbc.mk). 2 The code added by that commit to Makefile.gbuild codified the knowledge that there is an Rdb_services, which is brittle. 3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle. 4 Introducing an --enable-services-rdb-from-build option needlessly provided two different ways how the content of Rdb_services is assembled. The changes done here would leave --enable-services-rdb-from-build as a misnomer, as it no longer controls how Rdb_services is assembled. I thus renamed it to --enable-customtarget-components, as that is apparently what it still does now. Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-07loplugin:unusedfieldsNoel Grandin
Change-Id: Id39c3f484a364fb5163444febe99aee79daf1a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03use OMultiTypeInterfaceContainerHelperVar3 in frameworkNoel Grandin
Change-Id: Ia2f59322511ed85492708262f90de26b33275105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126197 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-30use more XPopupMenu methods over PopupMenu onesCaolán McNamara
Change-Id: Ib60ae5db7097cd92cc7971fd8227b8753391da26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126073 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-30drop unneeded includeCaolán McNamara
Change-Id: Iea28a59086d23c4edd91d0c531bf3a1337b5da78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-30remove out of date commentsCaolán McNamara
Change-Id: If1fb6c86b04d559eabb5b35fa35f09408a90522f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-30drop unneeded includeCaolán McNamara
Change-Id: I3eba0020edefcc92bc612eea1f388f17b9a45022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29use more XPopupMenu methods over PopupMenu onesCaolán McNamara
Change-Id: I54acdcb82b90d363e48543de99c75adea8fceb2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126047 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29nothing consumes this value set with SetUserValueCaolán McNamara
the GetUserValue was removed in... commit b90296a32bc97bd5038ee2dd262c1d1ee63f3c96 Date: Mon Jun 19 10:42:18 2006 +0000 INTEGRATION: CWS warnings01 (1.13.32); FILE MERGED 2006/05/29 07:55:08 sb 1.13.32.5: #i53898# Made code warning-free and/or compile at all after resync to SRC680m170. 2006/05/23 16:14:01 sb 1.13.32.4: RESYNC: (1.14-1.15); FILE MERGED 2006/01/25 17:36:29 sb 1.13.32.3: RESYNC: (1.13-1.14); FILE MERGED 2005/11/16 15:20:46 pl 1.13.32.2: #i55991# removed warnings 2005/10/28 14:48:46 cd 1.13.32.1: #i55991# Warning free code changes for gcc Change-Id: If2519a7826ab5fa9dd605218a51b2f7622231d1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126046 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29use css::awt::XPopupMenu::setItemImage instead of PopupMenu::SetItemImageCaolán McNamara
Change-Id: I414a98a2d8a9e9a2995811e95b2db1f66ac87d5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126043 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29can use css::awt::XPopupMenu::setCommandCaolán McNamara
instead of PopupMenu::SetItemCommand since... commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56 Date: Wed Feb 25 16:57:46 2004 +0000 INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED 2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL Change-Id: I0cf0beaa300331c2d221a60b91a855b1bd47c7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126041 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29can use css::awt::XPopupMenu::setCommandCaolán McNamara
instead of PopupMenu::SetItemCommand since... commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56 Date: Wed Feb 25 16:57:46 2004 +0000 INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED 2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL Change-Id: I4e78ad66771562ab80b8aad91347c1b99dccb1a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126040 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29can use css::awt::XPopupMenu::setCommandCaolán McNamara
instead of PopupMenu::SetItemCommand since... commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56 Date: Wed Feb 25 16:57:46 2004 +0000 INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED 2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL Change-Id: I3ec9126aa601a30bf6376a18659c81198b78c4d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126039 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29can use css::awt::XPopupMenu::setCommandCaolán McNamara
instead of PopupMenu::SetItemCommand since... commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56 Date: Wed Feb 25 16:57:46 2004 +0000 INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED 2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL Change-Id: I527d2ad2a12f7933d5e2cd892b26e96e284a0631 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126038 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29use css::awt::XPopupMenu api instead of PopupMenuCaolán McNamara
Change-Id: Iedd1e2a7db826bdf876f4b6ed0535882b9460c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126037 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29can use css::awt::XPopupMenu::setCommandCaolán McNamara
instead of PopupMenu::SetItemCommand since... commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56 Date: Wed Feb 25 16:57:46 2004 +0000 INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED 2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL Change-Id: I11fde1ec8928e7a331200be9182e465798a75965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126036 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29use VCLXPopupMenu directly, don't extract underlying PopupMenu*Caolán McNamara
Change-Id: I7fb25ca34e6439020b00d0266453668df38efe6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29pAry is always FontList::GetStdSizeAry()Caolán McNamara
so the other branch is bogus, this is (more obvious) since... commit f5a81a119cb63152c2c2e2473a1ea183a30c8db9 Date: Tue Sep 21 07:19:15 2021 +1000 vcl: remove OutputDevice's GetDevFontSizeCount() and GetDevFontSize() Change-Id: I587f4b0ee33129b611ff00265a835071a8332b8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126034 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29m_pHeightArray can be a std::vectorCaolán McNamara
Change-Id: I406aadb0a907fc2ac554c88ce8dc60c4d444a1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126033 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29can use css::awt::XPopupMenu::setCommandCaolán McNamara
instead of PopupMenu::SetItemCommand since... commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56 Date: Wed Feb 25 16:57:46 2004 +0000 INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED 2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL Change-Id: Icef85cc5583f2c2677dd8b7ad8dc095f5d604272 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29use VCLXPopupMenu directly, don't extract underlying PopupMenu*Caolán McNamara
Change-Id: If26c7e61e4c7203d2d4266f49149ebaf053dfdf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126030 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29use css::awt::XPopupMenu api, don't need to tunnel to get VCLXPopupMenu*Caolán McNamara
Change-Id: I6b6b09ded063a5c1f2e561fffcb8fb2214d35a56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126028 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29can use css::awt::XPopupMenu::setCommandCaolán McNamara
instead of PopupMenu::SetItemCommand since... commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56 Date: Wed Feb 25 16:57:46 2004 +0000 INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED 2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL Change-Id: I2bf9aa64b8c1dcd3bc7356adbfaf5592910eb851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126029 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29move PopupMenu::IsInExecute out of vcl/include/menu.hxxCaolán McNamara
Change-Id: I01af38dd57a645ea0afeaff033ce6d07dfe09535 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126026 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29use VCLXPopupMenu directly, don't extract underlying PopupMenu*Caolán McNamara
Change-Id: Ide78849af0731c68bfff1a8faba3d81100644eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-27use more OInterfaceContainerHelper3 in UndoManagerHelper_ImplNoel Grandin
Change-Id: I9076f35366de690cca84361695d45ad3ffc31089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125917 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26cid#1494445 silence Data race conditionCaolán McNamara
Change-Id: If1037293058812d6800646a2a0399a59f356d098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125865 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26remove unused definesNoel Grandin
Change-Id: I299486e00e027299b571fdeb3846a74830511ce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125861 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26loplugin:stringliteraldefine in frameworkNoel Grandin
Change-Id: I8bdda62c232b8f20aa6bb1e5e7ad303d6ffa47ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-23O[U]String::replaceAt overloads that take string_viewNoel Grandin
which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-22osl::Mutex->std::mutex in WindowCommandDispatchNoel Grandin
Change-Id: Ia89f4a7b1f444a031e8f58f644ba9129f8c48942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125622 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-22osl::Mutex->std::mutex in XFrameImpl::windowShownNoel Grandin
Change-Id: I1e56d0931a6e814cb9a4faa6a06e70b3740cb728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-22osl::Mutex->std::mutex in GlobalSettings_AccessNoel Grandin
Change-Id: I5162a157fd07870bf768947b32e8afe8f1fb0a02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125629 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-21osl::Mutex->std::mutex in ActionLockGuardNoel Grandin
Change-Id: I8081d017f8a03be94b60011fcd4eb34eba786aa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125623 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-15 21:40:38 +0000