summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)Author
2022-01-17Recheck modules [e-f]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I49a3ce10dee4b03f99156f5b641f69448e1d5617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128479 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-15include memory for std::unique_ptrCaolán McNamara
Change-Id: I15f78ecfc53e75403bb8edbcd6e5400e8ecaaa44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15tdf#146754: consider xyz:123 as host:port when parsing URLs smartMike Kaganski
... rather than scheme: and path. Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-14make comphelper::OInterfaceContainerHelper4 more threadsafeNoel Grandin
(*) make all the methods that require an external mutex take a std::unique_lock as a parameter, so that call sites cannot forget (*) make the forEach method drop the lock when firing listener methods, to reduce the odds of deadlock Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-11OReadStatusBarDocumentHandler doesnt need SolarMutexNoel Grandin
it is only ever used from a single thread. This was there since the beginning. Change-Id: Ib001db94c7a5b2520d9a6435e21c27dca60d1dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128271 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-11OWriteToolBoxDocumentHandler doesnt need SolarMutexNoel Grandin
it is only ever used from a single thread. This was there since the beginning. Change-Id: I580cf86457b2983cd7729bce32cbc0ccca601005 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-11OWriteImagesDocumentHandler doesnt need SolarMutexNoel Grandin
it is only ever used from a single thread. This was there since the beginning. Change-Id: If6c2929677ea1231cbf3326974451c3c6d51486f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-11OReadImagesDocumentHandler doesn't need SolarMutexNoel Grandin
it is only ever used from a single thread. This was there since the beginning. Change-Id: I7a2629071a3b2f3d4ddb6c7758a24515cfd5cebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128268 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-08move UserData bodge into VCLXMenuCaolán McNamara
Change-Id: I20c303788e576a29574a696cb20c9e8a235233b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126804 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-27use comphelper::WeakComponentImplHelper in WindowContentFactoryManagerNoel Grandin
Change-Id: I0918d7d1ff84b4d5e41191b554d08474abce1f93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27use comphelper::WeakComponentImplHelper in UIElementFactoryManagerNoel Grandin
Change-Id: I048e5671df230c498a2425d60f64208089fd044b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127489 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27use comphelper::WeakComponentImplHelper in UIControllerFactoryNoel Grandin
Change-Id: I4b583d72a1ece5af86f43be2f2add3da2779502a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127488 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-26use comphelper::WeakComponentImplHelper in StatusbarItemNoel Grandin
Change-Id: I2c278547d16c5ad0530188f1e465cb784d345746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-26use comphelper::WeakComponentImplHelper in UICommandDescriptionNoel Grandin
Change-Id: I042c9761c60d3b1c39950cfede80958edf2d84c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-26use comphelper::WeakComponentImplHelper in SubstitutePathVariablesNoel Grandin
Change-Id: I1b41ae57b65b42ef63d2d2c026cf78a00b5b937d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127462 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-26use comphelper::WeakComponentImplHelper in TaskCreatorServiceNoel Grandin
Change-Id: I2414ef01bc0990c68bb6fa02a897bfa19d7982a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-26use comphelper::WeakComponentImplHelper in WindowStateConfigurationNoel Grandin
Change-Id: Iada515ab1926aa1e0b7a3f39690d7c6eebf28aea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127465 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-25use comphelper::WeakComponentImplHelper in MenuBarManagerNoel Grandin
Change-Id: I687f71c5af810618b3ab27b004bf765b53d7b8e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-25use comphelper::WeakComponentImplHelper in ContextChangeEventMultiplexerNoel Grandin
Change-Id: I6f8c2be817695e44b25f209a5a56e021cd3e94d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127487 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-25use comphelper::WeakComponentImplHelper in ModuleUIConfigurationManagerSupplierNoel Grandin
Change-Id: I22164080dd87ab3c3a93b50d06cba8574e00c189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127464 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-22cleanup AcceleratorCacheNoel Grandin
(1) reduce visibility of stuff nothing is using outside the class (2) remove noise comments Change-Id: Icea829ef92d6121b957ad47a992ef7ac04656af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21Fix typoAndrea Gelmini
Change-Id: I0b441f47062a45395777b609d71ea0fa978bffc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127279 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-21loplugin:flatten in filter..frameworkNoel Grandin
Change-Id: I15a577b3c6da03001bbbf2c2b43b29b41c4007c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in GlobalImageListNoel Grandin
Change-Id: I12b3074e77e67bfd0914f74d71ad2dace8d1ac21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127107 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in ModuleUIConfigurationManagerNoel Grandin
Change-Id: I012ba8ab049fd19832e9f1df643957e57c05b69c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in ImageManagerImplNoel Grandin
Change-Id: I2feae13f2d8fe90d1f3b072156f3e384fd71db82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in UndoManagerHelper_ImplNoel Grandin
Change-Id: I4d279e2175f22422bec242ef8a15166cf67ef59f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in Oxt_HandlerNoel Grandin
Change-Id: Iaa7120a5373c09a1515dc76e5a5ba19b16cf1554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in WakeUpThreadNoel Grandin
Change-Id: I469fa855eb373829f23232875669f607dcb0c6a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in UIConfigurationManagerNoel Grandin
Change-Id: Idbad742b51c1ee8b8ba7104bc7520772ad947ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in HelpOnStartupNoel Grandin
Change-Id: I3133ab5e0f0af40c7570856c216f3921576818af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-20osl::Mutex->std::mutex in StorageHolderNoel Grandin
Change-Id: Ie0ababcea79b445ac73ffd4e69d260a7641af663 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-17Fix typosAndrea Gelmini
Change-Id: I7f1636226c4fbe29d9d2ef850318a9d57f1b5450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127009 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-16tdf#146219: don't try to detect if a recent file is a directoryMike Kaganski
This avoids accessing (possibly unavailable) remote URLs, when we already know that MRU items are files. Change-Id: I97e07f007d4129b93b4939311c67cf95de6ff836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126943 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-15Recheck include/[a-d]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I42475b8e75951d5dcae2fe6b0ad0bca64441e7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-14prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: I23310b8b5adbe7c84d0b9d30a227619c1e9a6960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: I486e24b0b85357b43213443c1a9b71206b8f441a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13only use css::awt::XPopupMenu methodsCaolán McNamara
Change-Id: Icab3bc855e92c5f6389ee8129bcaaa1308619ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ibb5984a588e21f9b761b6f56933394874c09dd88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126709 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: I81c892d946965f779d982194efd6b32d6493143e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126708 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ib52e4091d6a4e0d01aece3eb5f541cd29187a983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126707 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13only use css::awt::XPopupMenu methodsCaolán McNamara
Change-Id: Ib8e14af038fccd43e79f12b6a5f9371be6a29c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126706 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13prefer css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ibf34e33715a86a09ec49495b1049a60e1403a6af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-13use XMenu::enableAutoMnemonics instead of Menu::SetMenuFlagsCaolán McNamara
Change-Id: I4d3d8234bb2e643067bed68595a4b22198e38fb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12these aSolarMutexGuard calls are redundant nowCaolán McNamara
Change-Id: Ic167b8d40c1c93f5e6f4408d260c4e70b4017fd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126693 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12prefer more css::awt::XPopupMenu apiCaolán McNamara
Change-Id: Ib008281d63071ea79935af83cbe434be66155455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-12prefer css::awt::XPopupMenu apiCaolán McNamara
and using GetXGraphic will return a vcl unographic::XGraphic which also supports XBitmap as well as XGraphic so we can check if the XBitmap we're passing around supports XGraphic and use that if it does and drop the imagewrapper in favor of doing that Change-Id: I3bd7963b53c3f715fca4b5cfb2ddad650ca92e1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-11Fix typosAndrea Gelmini
Change-Id: I8e6db5dfb5285e45f862fadf09ecb4142be6e075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126659 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-12-10Generally determine Rdb content from gb_*_set_componentfile callsStephan Bergmann
...instead of by listing the content somewhat redundantly in the Rdb_*.mk files, to avoid duplication of logic for components that are only built conditionally (and thus should only be included conditionally in the corresponding Rdb). To achieve that, add an "rdb" parameter to gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros that internally call gb_ComponentTarget_ComponentTarget), which is used to make the appropriate gb_Rdb_add_component call internally from within gb_ComponentTarget_ComponentTarget. (As a special case, gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that has already been done by the corresponding gb_Library_set_componentfile call, so allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to support that special case.) Most Rdb_*.mk files are thus mostly empty now. One exception is i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as needed during the build in CustomTarget_i18npool/localedata. 1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built components" had already tried to do something similar (in addition to other things) under a new --enable-services-rdb-from-build option. However, that approach had four drawbacks that this approach here addresses (and which thus partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b): 1 Rdb_services shall not contain the component files of all libraries that are built. While that commit filtered out the component files that go into Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files that go into others like Rdb_postgresql-sdbc (connectivity/Rdb_postgresql-sdbc.mk). 2 The code added by that commit to Makefile.gbuild codified the knowledge that there is an Rdb_services, which is brittle. 3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle. 4 Introducing an --enable-services-rdb-from-build option needlessly provided two different ways how the content of Rdb_services is assembled. The changes done here would leave --enable-services-rdb-from-build as a misnomer, as it no longer controls how Rdb_services is assembled. I thus renamed it to --enable-customtarget-components, as that is apparently what it still does now. Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-07loplugin:unusedfieldsNoel Grandin
Change-Id: Id39c3f484a364fb5163444febe99aee79daf1a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-26 20:53:07 +0000